[INFO] cloning repository https://github.com/andev0/perfect_code [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andev0/perfect_code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandev0%2Fperfect_code", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandev0%2Fperfect_code'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7cd28b9962801c350c3f475d2a0242101825195 [INFO] linting andev0/perfect_code against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandev0%2Fperfect_code" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/andev0/perfect_code [INFO] finished tweaking git repo https://github.com/andev0/perfect_code [INFO] tweaked toml for git repo https://github.com/andev0/perfect_code written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/andev0/perfect_code on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/andev0/perfect_code already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 876bbeb50b4b196e6614b2c81903fb2bd8ebf24827e6e8b1ad3c9a8ce2211a38 [INFO] running `Command { std: "docker" "start" "-a" "876bbeb50b4b196e6614b2c81903fb2bd8ebf24827e6e8b1ad3c9a8ce2211a38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "876bbeb50b4b196e6614b2c81903fb2bd8ebf24827e6e8b1ad3c9a8ce2211a38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "876bbeb50b4b196e6614b2c81903fb2bd8ebf24827e6e8b1ad3c9a8ce2211a38", kill_on_drop: false }` [INFO] [stdout] 876bbeb50b4b196e6614b2c81903fb2bd8ebf24827e6e8b1ad3c9a8ce2211a38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac9c505bef2bc0f53d2cbb1a2780adaee0f6f19538dd6437efb93872408ce209 [INFO] running `Command { std: "docker" "start" "-a" "ac9c505bef2bc0f53d2cbb1a2780adaee0f6f19538dd6437efb93872408ce209", kill_on_drop: false }` [INFO] [stderr] Checking perfect_code v777.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::path::Display` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::Display; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Display` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::Display; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | .for_each(|(f, &f12)| println!("FizzBuzz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | .for_each(|(f, &f12)| println!("FizzBuzz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:90:19 [INFO] [stdout] | [INFO] [stdout] 90 | .filter(|(o1, &o2)| { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | .for_each(|(f, &f12)| println!("Buzz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:86:25 [INFO] [stdout] | [INFO] [stdout] 86 | .for_each(|(f, &f12)| println!("Buzz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:81:21 [INFO] [stdout] | [INFO] [stdout] 81 | .for_each(|(f, &f12)| println!("Fizz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | .for_each(|(f, &f12)| println!("Fizz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | .for_each(|(f, &f12)| println!("{}", f12)); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | .filter(|(o1, &o2)| o2 % 3 != 0 && o2 % 5 != 0) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let a = 5; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let b: u8; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `rth` is never read [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | rth -= 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `reasonA` and `reason3` are never read [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Mvce { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 5 | reasonA: i32, // reason a [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | reason3: (), // reason 3 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mvce` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:28 [INFO] [stdout] | [INFO] [stdout] 103 | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 103 - if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 103 + if !(!is_probably_fizz() || i % 3 != 0 || i % 5 == 0) { [INFO] [stdout] | [INFO] [stdout] 103 - if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 103 + if is_probably_fizz() && i % 3 == 0 && i % 5 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 105 + } else if !(is_probably_fizz() || i % 5 != 0 || i % 3 == 0) { [INFO] [stdout] | [INFO] [stdout] 105 - } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 105 + } else if !is_probably_fizz() && i % 5 == 0 && i % 3 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:32 [INFO] [stdout] | [INFO] [stdout] 110 | ... && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !(i % 3 == 0 && i % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && i % 3 != 0 || i % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 110 | ... && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !!(i % 3 != 0 || i % 5 == 0) [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !i % 3 == 0 && i % 5 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:32 [INFO] [stdout] | [INFO] [stdout] 111 | ... && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !(i % 5 == 0 && i % 3 != 0) [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && i % 5 != 0 || i % 3 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | ... && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !!(i % 5 != 0 || i % 3 == 0) [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !i % 5 == 0 && i % 3 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 80 | .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 80 - .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 80 + .filter(|(o1, &o2)| !(o2 % 3 != 0 || o2 % 5 == 0)) [INFO] [stdout] | [INFO] [stdout] 80 - .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 80 + .filter(|(o1, &o2)| o2 % 3 == 0 && o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 85 + .filter(|(o1, &o2)| !(o2 % 5 != 0 || o2 % 3 == 0)) [INFO] [stdout] | [INFO] [stdout] 85 - .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 85 + .filter(|(o1, &o2)| o2 % 5 == 0 && o2 % 3 != 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | / o2 % 3 == 0 [INFO] [stdout] 92 | | && o2 % 5 == 0 [INFO] [stdout] 93 | | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 - o2 % 3 == 0 [INFO] [stdout] 92 - && o2 % 5 == 0 [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 91 + !(o2 % 3 != 0 || o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 91 - o2 % 3 == 0 [INFO] [stdout] 92 - && o2 % 5 == 0 [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 91 + o2 % 3 == 0 && o2 % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !(o2 % 3 == 0 && o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && o2 % 3 != 0 || o2 % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !!(o2 % 3 != 0 || o2 % 5 == 0) [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !o2 % 3 == 0 && o2 % 5 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !(o2 % 5 == 0 && o2 % 3 != 0) [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && o2 % 5 != 0 || o2 % 3 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !!(o2 % 5 != 0 || o2 % 3 == 0) [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !o2 % 5 == 0 && o2 % 3 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if i > 5 { [INFO] [stdout] 100 | | if i > 20 { [INFO] [stdout] 101 | | if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if i > 5 [INFO] [stdout] 100 ~ && i > 20 { [INFO] [stdout] 101 | if i < 100 { [INFO] [stdout] ... [INFO] [stdout] 116 | } [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / if i > 20 { [INFO] [stdout] 101 | | if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] 103 | | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if i > 20 [INFO] [stdout] 101 ~ && i < 100 { [INFO] [stdout] 102 | if i < 51 { [INFO] [stdout] ... [INFO] [stdout] 115 | } [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | / if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] 103 | | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 104 | | println!("Fizz"); [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ if i < 100 [INFO] [stdout] 102 ~ && i < 51 { [INFO] [stdout] 103 | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] ... [INFO] [stdout] 114 | } [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `reasonA` should have a snake case name [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | reasonA: i32, // reason a [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `reason_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | .for_each(|(f, &f12)| println!("FizzBuzz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | .for_each(|(f, &f12)| println!("FizzBuzz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:90:19 [INFO] [stdout] | [INFO] [stdout] 90 | .filter(|(o1, &o2)| { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | .for_each(|(f, &f12)| println!("Buzz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:86:25 [INFO] [stdout] | [INFO] [stdout] 86 | .for_each(|(f, &f12)| println!("Buzz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:81:21 [INFO] [stdout] | [INFO] [stdout] 81 | .for_each(|(f, &f12)| println!("Fizz")); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f12` [INFO] [stdout] --> src/main.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | .for_each(|(f, &f12)| println!("Fizz")); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_f12` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/main.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | .for_each(|(f, &f12)| println!("{}", f12)); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `o1` [INFO] [stdout] --> src/main.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | .filter(|(o1, &o2)| o2 % 3 != 0 && o2 % 5 != 0) [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_o1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let a = 5; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let b: u8; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `rth` is never read [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | rth -= 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `reasonA` and `reason3` are never read [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Mvce { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 5 | reasonA: i32, // reason a [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | reason3: (), // reason 3 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mvce` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:28 [INFO] [stdout] | [INFO] [stdout] 103 | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 103 - if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 103 + if !(!is_probably_fizz() || i % 3 != 0 || i % 5 == 0) { [INFO] [stdout] | [INFO] [stdout] 103 - if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 103 + if is_probably_fizz() && i % 3 == 0 && i % 5 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 - } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 105 + } else if !(is_probably_fizz() || i % 5 != 0 || i % 3 == 0) { [INFO] [stdout] | [INFO] [stdout] 105 - } else if !is_probably_fizz() && i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 105 + } else if !is_probably_fizz() && i % 5 == 0 && i % 3 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:32 [INFO] [stdout] | [INFO] [stdout] 110 | ... && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !(i % 3 == 0 && i % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && i % 3 != 0 || i % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 110 | ... && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !!(i % 3 != 0 || i % 5 == 0) [INFO] [stdout] | [INFO] [stdout] 110 - && !(i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 110 + && !i % 3 == 0 && i % 5 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:32 [INFO] [stdout] | [INFO] [stdout] 111 | ... && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !(i % 5 == 0 && i % 3 != 0) [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && i % 5 != 0 || i % 3 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | ... && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !!(i % 5 != 0 || i % 3 == 0) [INFO] [stdout] | [INFO] [stdout] 111 - && !(i % 5 == 0 && !(i % 3 == 0 && i % 5 == 0)) [INFO] [stdout] 111 + && !i % 5 == 0 && i % 3 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 80 | .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 80 - .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 80 + .filter(|(o1, &o2)| !(o2 % 3 != 0 || o2 % 5 == 0)) [INFO] [stdout] | [INFO] [stdout] 80 - .filter(|(o1, &o2)| o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 80 + .filter(|(o1, &o2)| o2 % 3 == 0 && o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 85 + .filter(|(o1, &o2)| !(o2 % 5 != 0 || o2 % 3 == 0)) [INFO] [stdout] | [INFO] [stdout] 85 - .filter(|(o1, &o2)| o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 85 + .filter(|(o1, &o2)| o2 % 5 == 0 && o2 % 3 != 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | / o2 % 3 == 0 [INFO] [stdout] 92 | | && o2 % 5 == 0 [INFO] [stdout] 93 | | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 - o2 % 3 == 0 [INFO] [stdout] 92 - && o2 % 5 == 0 [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 91 + !(o2 % 3 != 0 || o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 91 - o2 % 3 == 0 [INFO] [stdout] 92 - && o2 % 5 == 0 [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 91 + o2 % 3 == 0 && o2 % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !(o2 % 3 == 0 && o2 % 5 != 0) [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && o2 % 3 != 0 || o2 % 5 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !!(o2 % 3 != 0 || o2 % 5 == 0) [INFO] [stdout] | [INFO] [stdout] 93 - && !(o2 % 3 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 93 + && !o2 % 3 == 0 && o2 % 5 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !(o2 % 5 == 0 && o2 % 3 != 0) [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && o2 % 5 != 0 || o2 % 3 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !!(o2 % 5 != 0 || o2 % 3 == 0) [INFO] [stdout] | [INFO] [stdout] 94 - && !(o2 % 5 == 0 && !(o2 % 3 == 0 && o2 % 5 == 0)) [INFO] [stdout] 94 + && !o2 % 5 == 0 && o2 % 3 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if i > 5 { [INFO] [stdout] 100 | | if i > 20 { [INFO] [stdout] 101 | | if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if i > 5 [INFO] [stdout] 100 ~ && i > 20 { [INFO] [stdout] 101 | if i < 100 { [INFO] [stdout] ... [INFO] [stdout] 116 | } [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / if i > 20 { [INFO] [stdout] 101 | | if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] 103 | | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if i > 20 [INFO] [stdout] 101 ~ && i < 100 { [INFO] [stdout] 102 | if i < 51 { [INFO] [stdout] ... [INFO] [stdout] 115 | } [INFO] [stdout] 116 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | / if i < 100 { [INFO] [stdout] 102 | | if i < 51 { [INFO] [stdout] 103 | | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] 104 | | println!("Fizz"); [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ if i < 100 [INFO] [stdout] 102 ~ && i < 51 { [INFO] [stdout] 103 | if is_probably_fizz() && i % 3 == 0 && !(i % 3 == 0 && i % 5 == 0) { [INFO] [stdout] ... [INFO] [stdout] 114 | } [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `reasonA` should have a snake case name [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | reasonA: i32, // reason a [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `reason_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "ac9c505bef2bc0f53d2cbb1a2780adaee0f6f19538dd6437efb93872408ce209", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac9c505bef2bc0f53d2cbb1a2780adaee0f6f19538dd6437efb93872408ce209", kill_on_drop: false }` [INFO] [stdout] ac9c505bef2bc0f53d2cbb1a2780adaee0f6f19538dd6437efb93872408ce209