[INFO] cloning repository https://github.com/andOrlando/save-manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andOrlando/save-manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FandOrlando%2Fsave-manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FandOrlando%2Fsave-manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 42f6b8d1a069c5a4eaed56b1c7f30fbdff25b8f7 [INFO] linting andOrlando/save-manager against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FandOrlando%2Fsave-manager" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/andOrlando/save-manager [INFO] finished tweaking git repo https://github.com/andOrlando/save-manager [INFO] tweaked toml for git repo https://github.com/andOrlando/save-manager written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/andOrlando/save-manager on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/andOrlando/save-manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded walkdir v0.1.8 [INFO] [stderr] Downloaded copy_dir v0.1.2 [INFO] [stderr] Downloaded clap v4.3.10 [INFO] [stderr] Downloaded clap_builder v4.3.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c0191bee42773aad746ba986ffd3b2327eefc933c171013c944428605009d9a [INFO] running `Command { std: "docker" "start" "-a" "1c0191bee42773aad746ba986ffd3b2327eefc933c171013c944428605009d9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c0191bee42773aad746ba986ffd3b2327eefc933c171013c944428605009d9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c0191bee42773aad746ba986ffd3b2327eefc933c171013c944428605009d9a", kill_on_drop: false }` [INFO] [stdout] 1c0191bee42773aad746ba986ffd3b2327eefc933c171013c944428605009d9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 033a93d282ffa3f7a4e97a7c5100647f82785476e75e28d0d26ad01685ae38b4 [INFO] running `Command { std: "docker" "start" "-a" "033a93d282ffa3f7a4e97a7c5100647f82785476e75e28d0d26ad01685ae38b4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling rustix v0.38.1 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.99 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking walkdir v0.1.8 [INFO] [stderr] Checking copy_dir v0.1.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.10 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.10 [INFO] [stderr] Checking serde v1.0.164 [INFO] [stderr] Checking save-manager v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn create(name: &String, paths: &Vec) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 ~ pub fn create(name: &str, paths: &Vec) -> AppError { [INFO] [stdout] 15 | [INFO] [stdout] ... [INFO] [stdout] 26 | app.categories.push(Category { [INFO] [stdout] 27 ~ name: name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn update_name(name: &String) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 ~ pub fn update_name(name: &str) -> AppError { [INFO] [stdout] 88 | [INFO] [stdout] ... [INFO] [stdout] 103 | //update category and current [INFO] [stdout] 104 ~ category.name = name.to_owned(); [INFO] [stdout] 105 | [INFO] [stdout] ... [INFO] [stdout] 123 | //rename current [INFO] [stdout] 124 ~ app.current = Some(name.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn switch(name: &String) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 ~ pub fn switch(name: &str) -> AppError { [INFO] [stdout] 134 | [INFO] [stdout] ... [INFO] [stdout] 137 | app.get_category(name)?; //ensure category exists [INFO] [stdout] 138 ~ app.current = Some(name.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/functions.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/functions.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:257:16 [INFO] [stdout] | [INFO] [stdout] 257 | rename(&source, &auto).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:258:26 [INFO] [stdout] | [INFO] [stdout] 258 | copy_dir(&local, &source).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:273:40 [INFO] [stdout] | [INFO] [stdout] 273 | let autos = current.get_auto_paths(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | rename(&source, &auto).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 281 | rename(&_auto, &source).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:317:37 [INFO] [stdout] | [INFO] [stdout] 317 | } else { current.get_save_index(&name)? }; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn create(name: &String, paths: &Vec) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 ~ pub fn create(name: &str, paths: &Vec) -> AppError { [INFO] [stdout] 15 | [INFO] [stdout] ... [INFO] [stdout] 26 | app.categories.push(Category { [INFO] [stdout] 27 ~ name: name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 330 | copy_dir(&source, &local).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:356:41 [INFO] [stdout] | [INFO] [stdout] 356 | } else { current.get_save_index(&name)? }; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn update_name(name: &String) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 ~ pub fn update_name(name: &str) -> AppError { [INFO] [stdout] 88 | [INFO] [stdout] ... [INFO] [stdout] 103 | //update category and current [INFO] [stdout] 104 ~ category.name = name.to_owned(); [INFO] [stdout] 105 | [INFO] [stdout] ... [INFO] [stdout] 123 | //rename current [INFO] [stdout] 124 ~ app.current = Some(name.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn switch(name: &String) -> AppError { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 ~ pub fn switch(name: &str) -> AppError { [INFO] [stdout] 134 | [INFO] [stdout] ... [INFO] [stdout] 137 | app.get_category(name)?; //ensure category exists [INFO] [stdout] 138 ~ app.current = Some(name.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/functions.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/functions.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 171 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(self.get_category(self.current.as_ref().unwrap())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 15 - Ok(self.get_category(self.current.as_ref().unwrap())?) [INFO] [stdout] 15 + self.get_category(self.current.as_ref().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/types.rs:24:56 [INFO] [stdout] | [INFO] [stdout] 24 | let category = self.categories.iter().find(|a| &a.name == name); [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/types.rs:29:57 [INFO] [stdout] | [INFO] [stdout] 29 | let index = self.categories.iter().position(|a| &a.name == name); [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:257:16 [INFO] [stdout] | [INFO] [stdout] 257 | rename(&source, &auto).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:258:26 [INFO] [stdout] | [INFO] [stdout] 258 | copy_dir(&local, &source).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:273:40 [INFO] [stdout] | [INFO] [stdout] 273 | let autos = current.get_auto_paths(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | rename(&source, &auto).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 281 | rename(&_auto, &source).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:317:37 [INFO] [stdout] | [INFO] [stdout] 317 | } else { current.get_save_index(&name)? }; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/functions.rs:330:18 [INFO] [stdout] | [INFO] [stdout] 330 | copy_dir(&source, &local).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:356:41 [INFO] [stdout] | [INFO] [stdout] 356 | } else { current.get_save_index(&name)? }; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !metadata(&data_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(&data_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/data.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(self.get_category(self.current.as_ref().unwrap())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 15 - Ok(self.get_category(self.current.as_ref().unwrap())?) [INFO] [stdout] 15 + self.get_category(self.current.as_ref().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/types.rs:24:56 [INFO] [stdout] | [INFO] [stdout] 24 | let category = self.categories.iter().find(|a| &a.name == name); [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/types.rs:29:57 [INFO] [stdout] | [INFO] [stdout] 29 | let index = self.categories.iter().position(|a| &a.name == name); [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `a.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !metadata(&data_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(&data_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/data.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.06s [INFO] running `Command { std: "docker" "inspect" "033a93d282ffa3f7a4e97a7c5100647f82785476e75e28d0d26ad01685ae38b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "033a93d282ffa3f7a4e97a7c5100647f82785476e75e28d0d26ad01685ae38b4", kill_on_drop: false }` [INFO] [stdout] 033a93d282ffa3f7a4e97a7c5100647f82785476e75e28d0d26ad01685ae38b4