[INFO] cloning repository https://github.com/an0nn30/rusty_conch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/an0nn30/rusty_conch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan0nn30%2Frusty_conch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan0nn30%2Frusty_conch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 901794c51fead9cf3f653c2fb9578a87fc2ccd6d [INFO] linting an0nn30/rusty_conch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan0nn30%2Frusty_conch" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/an0nn30/rusty_conch [INFO] finished tweaking git repo https://github.com/an0nn30/rusty_conch [INFO] tweaked toml for git repo https://github.com/an0nn30/rusty_conch written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/an0nn30/rusty_conch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/an0nn30/rusty_conch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ssh-encoding v0.2.0 [INFO] [stderr] Downloaded bcrypt-pbkdf v0.10.0 [INFO] [stderr] Downloaded russh-cryptovec v0.48.0 [INFO] [stderr] Downloaded pkcs5 v0.7.1 [INFO] [stderr] Downloaded which v7.0.3 [INFO] [stderr] Downloaded miow v0.6.1 [INFO] [stderr] Downloaded p521 v0.13.3 [INFO] [stderr] Downloaded mlua-sys v0.6.8 [INFO] [stderr] Downloaded pathfinder_simd v0.5.5 [INFO] [stderr] Downloaded toml_edit v0.25.3+spec-1.1.0 [INFO] [stderr] Downloaded font-kit v0.14.3 [INFO] [stderr] Downloaded ssh-key v0.6.7 [INFO] [stderr] Downloaded rfd v0.17.2 [INFO] [stderr] Downloaded mlua v0.10.5 [INFO] [stderr] Downloaded flurry v0.5.2 [INFO] [stderr] Downloaded vte v0.15.0 [INFO] [stderr] Downloaded russh-keys v0.48.1 [INFO] [stderr] Downloaded des v0.8.1 [INFO] [stderr] Downloaded delegate v0.13.5 [INFO] [stderr] Downloaded pageant v0.0.1 [INFO] [stderr] Downloaded russh-util v0.48.0 [INFO] [stderr] Downloaded rustix-openpty v0.2.0 [INFO] [stderr] Downloaded java-locator v0.1.9 [INFO] [stderr] Downloaded russh v0.48.2 [INFO] [stderr] Downloaded dwrote v0.11.5 [INFO] [stderr] Downloaded russh-sftp v2.1.1 [INFO] [stderr] Downloaded seize v0.3.3 [INFO] [stderr] Downloaded ssh-cipher v0.2.0 [INFO] [stderr] Downloaded alacritty_terminal v0.25.1 [INFO] [stderr] Downloaded luajit-src v210.5.12+a4f56a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31829302b092e449a4bf74517f1a79057f56ec5ce5a42c04b3dd7252e0d06793 [INFO] running `Command { std: "docker" "start" "-a" "31829302b092e449a4bf74517f1a79057f56ec5ce5a42c04b3dd7252e0d06793", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31829302b092e449a4bf74517f1a79057f56ec5ce5a42c04b3dd7252e0d06793", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31829302b092e449a4bf74517f1a79057f56ec5ce5a42c04b3dd7252e0d06793", kill_on_drop: false }` [INFO] [stdout] 31829302b092e449a4bf74517f1a79057f56ec5ce5a42c04b3dd7252e0d06793 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3339bf43dc6bfb79b1bcdb8baecabf924962355ee17e9bf4e73cd290892c63e8 [INFO] running `Command { std: "docker" "start" "-a" "3339bf43dc6bfb79b1bcdb8baecabf924962355ee17e9bf4e73cd290892c63e8", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking dlib v0.5.3 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking piper v0.2.5 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Compiling toml_edit v0.25.3+spec-1.1.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking memmap2 v0.9.10 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Compiling env_home v0.1.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling proc-macro-crate v3.5.0 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking immutable-chunkmap v2.1.2 [INFO] [stderr] Compiling lua-src v547.0.0 [INFO] [stderr] Compiling winit v0.30.13 [INFO] [stderr] Compiling num-bigint-dig v0.8.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking epaint_default_fonts v0.31.1 [INFO] [stderr] Checking pxfm v0.1.28 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling freetype-sys v0.20.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Compiling pathfinder_simd v0.5.5 [INFO] [stderr] Compiling which v7.0.3 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v6.0.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Compiling luajit-src v210.5.12+a4f56a4 [INFO] [stderr] Checking java-locator v0.1.9 [INFO] [stderr] Checking rsa v0.9.10 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling mlua-sys v0.6.8 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking rustix-openpty v0.2.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Compiling conch_plugin v1.0.1 (/opt/rustwide/workdir/crates/conch_plugin) [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking seize v0.3.3 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] warning: conch_plugin@1.0.1: Java SDK JAR not found at /opt/rustwide/workdir/crates/conch_plugin/../../java-sdk/build/conch-plugin-sdk.jar. JVM plugin support will be disabled. Build it with: make -C java-sdk build [INFO] [stderr] Checking flurry v0.5.2 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking russh-cryptovec v0.48.0 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling rfd v0.17.2 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Compiling font-kit v0.14.3 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking notify-types v1.0.1 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Compiling conch_app v1.0.1 (/opt/rustwide/workdir/crates/conch_app) [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking calloop v0.14.4 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking emath v0.31.1 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking ecolor v0.31.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking epaint v0.31.1 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking jni v0.21.1 [INFO] [stderr] Compiling delegate v0.13.5 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking notify v7.0.0 [INFO] [stderr] Checking egui v0.31.1 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking conch_plugin_sdk v1.0.1 (/opt/rustwide/workdir/crates/conch_plugin_sdk) [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking vte v0.15.0 [INFO] [stderr] Checking ssh-key v0.6.7 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking alacritty_terminal v0.25.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking webbrowser v1.1.0 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking test-echo-session v1.0.1 (/opt/rustwide/workdir/plugins/test-echo-session) [INFO] [stderr] Checking conch-files v1.0.1 (/opt/rustwide/workdir/plugins/conch-files) [INFO] [stderr] Checking test-panel v1.0.1 (/opt/rustwide/workdir/plugins/test-panel) [INFO] [stderr] Checking test-panel-2 v1.0.1 (/opt/rustwide/workdir/plugins/test-panel-2) [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel-2/src/lib.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | / if id == "toggle" { [INFO] [stdout] 44 | | self.checked = checked; [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ PluginEvent::Widget(WidgetEvent::CheckboxChanged { id, checked }) [INFO] [stdout] 43 ~ if id == "toggle" => { [INFO] [stdout] 44 | self.checked = checked; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel/src/lib.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / if id == "input" { [INFO] [stdout] 60 | | self.text_value = value; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ PluginEvent::Widget(WidgetEvent::TextInputChanged { id, value }) [INFO] [stdout] 59 ~ if id == "input" => { [INFO] [stdout] 60 | self.text_value = value; [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel/src/lib.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | / if id == "input" { [INFO] [stdout] 65 | | let msg = CString::new(format!("Input submitted: {value}")).unwrap(); [INFO] [stdout] 66 | | (self.api.log)(2, msg.as_ptr()); [INFO] [stdout] 67 | | self.text_value.clear(); [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ PluginEvent::Widget(WidgetEvent::TextInputSubmit { id, value }) [INFO] [stdout] 64 ~ if id == "input" => { [INFO] [stdout] 65 | let msg = CString::new(format!("Input submitted: {value}")).unwrap(); [INFO] [stdout] 66 | (self.api.log)(2, msg.as_ptr()); [INFO] [stdout] 67 | self.text_value.clear(); [INFO] [stdout] 68 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel-2/src/lib.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | / if id == "toggle" { [INFO] [stdout] 44 | | self.checked = checked; [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ PluginEvent::Widget(WidgetEvent::CheckboxChanged { id, checked }) [INFO] [stdout] 43 ~ if id == "toggle" => { [INFO] [stdout] 44 | self.checked = checked; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `output_cb` and `output_ctx` are never read [INFO] [stdout] --> plugins/test-echo-session/src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct EchoSession { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 19 | handle: SessionHandle, [INFO] [stdout] 20 | output_cb: OutputCallback, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 21 | output_ctx: *mut c_void, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `output_cb` and `output_ctx` are never read [INFO] [stdout] --> plugins/test-echo-session/src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct EchoSession { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 19 | handle: SessionHandle, [INFO] [stdout] 20 | output_cb: OutputCallback, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 21 | output_ctx: *mut c_void, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking toml v0.8.23 [INFO] [stdout] warning: unused import: `ColumnVisibility` [INFO] [stdout] --> plugins/conch-files/src/lib.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use pane::{ColumnVisibility, Pane, PaneMode}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ColumnVisibility` [INFO] [stdout] --> plugins/conch-files/src/lib.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use pane::{ColumnVisibility, Pane, PaneMode}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel/src/lib.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / if id == "input" { [INFO] [stdout] 60 | | self.text_value = value; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ PluginEvent::Widget(WidgetEvent::TextInputChanged { id, value }) [INFO] [stdout] 59 ~ if id == "input" => { [INFO] [stdout] 60 | self.text_value = value; [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/test-panel/src/lib.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | / if id == "input" { [INFO] [stdout] 65 | | let msg = CString::new(format!("Input submitted: {value}")).unwrap(); [INFO] [stdout] 66 | | (self.api.log)(2, msg.as_ptr()); [INFO] [stdout] 67 | | self.text_value.clear(); [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ PluginEvent::Widget(WidgetEvent::TextInputSubmit { id, value }) [INFO] [stdout] 64 ~ if id == "input" => { [INFO] [stdout] 65 | let msg = CString::new(format!("Input submitted: {value}")).unwrap(); [INFO] [stdout] 66 | (self.api.log)(2, msg.as_ptr()); [INFO] [stdout] 67 | self.text_value.clear(); [INFO] [stdout] 68 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking russh-util v0.48.0 [INFO] [stderr] Checking conch_pty v1.0.1 (/opt/rustwide/workdir/crates/conch_pty) [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/conch-files/src/pane.rs:281:17 [INFO] [stdout] | [INFO] [stdout] 281 | / if strip_prefix(id, &self.prefix) == "path" { [INFO] [stdout] 282 | | self.navigate_to(value, api); [INFO] [stdout] 283 | | true [INFO] [stdout] 284 | | } else { [INFO] [stdout] 285 | | false [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 280 ~ WidgetEvent::ToolbarInputSubmit { id, value } [INFO] [stdout] 281 ~ if strip_prefix(id, &self.prefix) == "path" => { [INFO] [stdout] 282 | self.navigate_to(value, api); [INFO] [stdout] 283 | true [INFO] [stdout] 284 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/conch-files/src/pane.rs:290:17 [INFO] [stdout] | [INFO] [stdout] 290 | / if strip_prefix(id, &self.prefix) == "path" { [INFO] [stdout] 291 | | self.navigate_to(value, api); [INFO] [stdout] 292 | | true [INFO] [stdout] 293 | | } else { [INFO] [stdout] 294 | | false [INFO] [stdout] 295 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 289 ~ WidgetEvent::TextInputSubmit { id, value } [INFO] [stdout] 290 ~ if strip_prefix(id, &self.prefix) == "path" => { [INFO] [stdout] 291 | self.navigate_to(value, api); [INFO] [stdout] 292 | true [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/pane.rs:302:17 [INFO] [stdout] | [INFO] [stdout] 302 | / if let Some(entry) = self.entries.iter().find(|e| e.name == *row_id) { [INFO] [stdout] 303 | | if entry.is_dir { [INFO] [stdout] 304 | | let new_path = if self.current_path.ends_with('/') || self.current_path == "." { [INFO] [stdout] 305 | | if self.current_path == "." { [INFO] [stdout] ... | [INFO] [stdout] 315 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ if let Some(entry) = self.entries.iter().find(|e| e.name == *row_id) [INFO] [stdout] 303 ~ && entry.is_dir { [INFO] [stdout] 304 | let new_path = if self.current_path.ends_with('/') || self.current_path == "." { [INFO] [stdout] ... [INFO] [stdout] 313 | self.navigate_to(&new_path, api); [INFO] [stdout] 314 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> plugins/conch-files/src/pane.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | / self.selected_row.as_ref().map_or(false, |name| { [INFO] [stdout] 495 | | self.entries.iter().any(|e| e.name == *name && e.is_dir) [INFO] [stdout] 496 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 494 - self.selected_row.as_ref().map_or(false, |name| { [INFO] [stdout] 494 + self.selected_row.as_ref().is_some_and(|name| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> plugins/conch-files/src/pane.rs:557:53 [INFO] [stdout] | [INFO] [stdout] 557 | label: Some(if self.show_hidden { ".*" } else { ".*" }.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> plugins/conch-files/src/pane.rs:557:67 [INFO] [stdout] | [INFO] [stdout] 557 | label: Some(if self.show_hidden { ".*" } else { ".*" }.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/conch-files/src/pane.rs:281:17 [INFO] [stdout] | [INFO] [stdout] 281 | / if strip_prefix(id, &self.prefix) == "path" { [INFO] [stdout] 282 | | self.navigate_to(value, api); [INFO] [stdout] 283 | | true [INFO] [stdout] 284 | | } else { [INFO] [stdout] 285 | | false [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 280 ~ WidgetEvent::ToolbarInputSubmit { id, value } [INFO] [stdout] 281 ~ if strip_prefix(id, &self.prefix) == "path" => { [INFO] [stdout] 282 | self.navigate_to(value, api); [INFO] [stdout] 283 | true [INFO] [stdout] 284 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> plugins/conch-files/src/pane.rs:290:17 [INFO] [stdout] | [INFO] [stdout] 290 | / if strip_prefix(id, &self.prefix) == "path" { [INFO] [stdout] 291 | | self.navigate_to(value, api); [INFO] [stdout] 292 | | true [INFO] [stdout] 293 | | } else { [INFO] [stdout] 294 | | false [INFO] [stdout] 295 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 289 ~ WidgetEvent::TextInputSubmit { id, value } [INFO] [stdout] 290 ~ if strip_prefix(id, &self.prefix) == "path" => { [INFO] [stdout] 291 | self.navigate_to(value, api); [INFO] [stdout] 292 | true [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/pane.rs:302:17 [INFO] [stdout] | [INFO] [stdout] 302 | / if let Some(entry) = self.entries.iter().find(|e| e.name == *row_id) { [INFO] [stdout] 303 | | if entry.is_dir { [INFO] [stdout] 304 | | let new_path = if self.current_path.ends_with('/') || self.current_path == "." { [INFO] [stdout] 305 | | if self.current_path == "." { [INFO] [stdout] ... | [INFO] [stdout] 315 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ if let Some(entry) = self.entries.iter().find(|e| e.name == *row_id) [INFO] [stdout] 303 ~ && entry.is_dir { [INFO] [stdout] 304 | let new_path = if self.current_path.ends_with('/') || self.current_path == "." { [INFO] [stdout] ... [INFO] [stdout] 313 | self.navigate_to(&new_path, api); [INFO] [stdout] 314 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Ok(json) = serde_json::to_string(vis) { [INFO] [stdout] 37 | | if let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Ok(json) = serde_json::to_string(vis) [INFO] [stdout] 37 ~ && let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Ok(key) = CString::new("columns") [INFO] [stdout] 38 ~ && let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if let Some(sid) = session_id { [INFO] [stdout] 316 | | if let Some(info) = self.ssh_sessions.get(&sid) { [INFO] [stdout] 317 | | let host = info.host.clone(); [INFO] [stdout] 318 | | let user = info.user.clone(); [INFO] [stdout] ... | [INFO] [stdout] 329 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if let Some(sid) = session_id [INFO] [stdout] 316 ~ && let Some(info) = self.ssh_sessions.get(&sid) { [INFO] [stdout] 317 | let host = info.host.clone(); [INFO] [stdout] ... [INFO] [stdout] 327 | } [INFO] [stdout] 328 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> plugins/conch-files/src/pane.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | / self.selected_row.as_ref().map_or(false, |name| { [INFO] [stdout] 495 | | self.entries.iter().any(|e| e.name == *name && e.is_dir) [INFO] [stdout] 496 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 494 - self.selected_row.as_ref().map_or(false, |name| { [INFO] [stdout] 494 + self.selected_row.as_ref().is_some_and(|name| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> plugins/conch-files/src/pane.rs:557:53 [INFO] [stdout] | [INFO] [stdout] 557 | label: Some(if self.show_hidden { ".*" } else { ".*" }.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> plugins/conch-files/src/pane.rs:557:67 [INFO] [stdout] | [INFO] [stdout] 557 | label: Some(if self.show_hidden { ".*" } else { ".*" }.into()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-files/src/lib.rs:855:1 [INFO] [stdout] | [INFO] [stdout] 855 | / fn download_dir_inner( [INFO] [stdout] 856 | | api: &HostApi, [INFO] [stdout] 857 | | session_id: u64, [INFO] [stdout] 858 | | remote_dir: &str, [INFO] [stdout] ... | [INFO] [stdout] 863 | | sftp: Option<&sftp_direct::SftpAccess>, [INFO] [stdout] 864 | | ) -> Result<(), String> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Ok(json) = serde_json::to_string(vis) { [INFO] [stdout] 37 | | if let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Ok(json) = serde_json::to_string(vis) [INFO] [stdout] 37 ~ && let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Ok(key) = CString::new("columns") { [INFO] [stdout] 38 | | if let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Ok(key) = CString::new("columns") [INFO] [stdout] 38 ~ && let Ok(val) = CString::new(json) { [INFO] [stdout] 39 | (api.set_config)(key.as_ptr(), val.as_ptr()); [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-files/src/lib.rs:946:1 [INFO] [stdout] | [INFO] [stdout] 946 | / fn upload_dir_inner( [INFO] [stdout] 947 | | api: &HostApi, [INFO] [stdout] 948 | | session_id: u64, [INFO] [stdout] 949 | | local_dir: &str, [INFO] [stdout] ... | [INFO] [stdout] 954 | | sftp: Option<&sftp_direct::SftpAccess>, [INFO] [stdout] 955 | | ) -> Result<(), String> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_pty/src/pty.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn new( [INFO] [stdout] 116 | | cols: u16, [INFO] [stdout] 117 | | rows: u16, [INFO] [stdout] 118 | | cell_width: u16, [INFO] [stdout] ... | [INFO] [stdout] 123 | | working_directory: Option, [INFO] [stdout] 124 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_pty/src/pty.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn new( [INFO] [stdout] 116 | | cols: u16, [INFO] [stdout] 117 | | rows: u16, [INFO] [stdout] 118 | | cell_width: u16, [INFO] [stdout] ... | [INFO] [stdout] 123 | | working_directory: Option, [INFO] [stdout] 124 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-files/src/lib.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if let Some(sid) = session_id { [INFO] [stdout] 316 | | if let Some(info) = self.ssh_sessions.get(&sid) { [INFO] [stdout] 317 | | let host = info.host.clone(); [INFO] [stdout] 318 | | let user = info.user.clone(); [INFO] [stdout] ... | [INFO] [stdout] 329 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if let Some(sid) = session_id [INFO] [stdout] 316 ~ && let Some(info) = self.ssh_sessions.get(&sid) { [INFO] [stdout] 317 | let host = info.host.clone(); [INFO] [stdout] ... [INFO] [stdout] 327 | } [INFO] [stdout] 328 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking conch_core v1.0.1 (/opt/rustwide/workdir/crates/conch_core) [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-files/src/lib.rs:855:1 [INFO] [stdout] | [INFO] [stdout] 855 | / fn download_dir_inner( [INFO] [stdout] 856 | | api: &HostApi, [INFO] [stdout] 857 | | session_id: u64, [INFO] [stdout] 858 | | remote_dir: &str, [INFO] [stdout] ... | [INFO] [stdout] 863 | | sftp: Option<&sftp_direct::SftpAccess>, [INFO] [stdout] 864 | | ) -> Result<(), String> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-files/src/lib.rs:946:1 [INFO] [stdout] | [INFO] [stdout] 946 | / fn upload_dir_inner( [INFO] [stdout] 947 | | api: &HostApi, [INFO] [stdout] 948 | | session_id: u64, [INFO] [stdout] 949 | | local_dir: &str, [INFO] [stdout] ... | [INFO] [stdout] 954 | | sftp: Option<&sftp_direct::SftpAccess>, [INFO] [stdout] 955 | | ) -> Result<(), String> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking russh-sftp v2.1.1 [INFO] [stderr] Checking egui_glow v0.31.1 [INFO] [stderr] Checking zbus-lockstep v0.4.4 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_core/src/color_scheme.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / if path.extension().is_some_and(|ext| ext == "toml") { [INFO] [stdout] 147 | | if let Some(stem) = path.file_stem() { [INFO] [stdout] 148 | | themes.insert(stem.to_string_lossy().into_owned(), path); [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ if path.extension().is_some_and(|ext| ext == "toml") [INFO] [stdout] 147 ~ && let Some(stem) = path.file_stem() { [INFO] [stdout] 148 | themes.insert(stem.to_string_lossy().into_owned(), path); [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/colors.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for AppearanceMode { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self::Dark [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub enum AppearanceMode { [INFO] [stdout] 9 ~ #[default] [INFO] [stdout] 10 ~ Dark, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/conch.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ConchConfig { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | keyboard: KeyboardConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub struct ConchConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/persistent.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for PersistentState { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | layout: LayoutConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub struct PersistentState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/terminal.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / impl Default for TerminalShell { [INFO] [stdout] 39 | | fn default() -> Self { [INFO] [stdout] 40 | | Self { [INFO] [stdout] 41 | | program: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub struct TerminalShell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/terminal.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | / impl Default for CursorConfig { [INFO] [stdout] 55 | | fn default() -> Self { [INFO] [stdout] 56 | | Self { [INFO] [stdout] 57 | | style: CursorStyleConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 49 + #[derive(Default)] [INFO] [stdout] 50 | pub struct CursorConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/window.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for WindowConfig { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | Self { [INFO] [stdout] 54 | | dimensions: WindowDimensions::default(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 46 + #[derive(Default)] [INFO] [stdout] 47 | pub struct WindowConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / impl Default for UserConfig { [INFO] [stdout] 63 | | fn default() -> Self { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | window: WindowConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 39 + #[derive(Default)] [INFO] [stdout] 40 | pub struct UserConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking russh-keys v0.48.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_core/src/color_scheme.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / if path.extension().is_some_and(|ext| ext == "toml") { [INFO] [stdout] 147 | | if let Some(stem) = path.file_stem() { [INFO] [stdout] 148 | | themes.insert(stem.to_string_lossy().into_owned(), path); [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ if path.extension().is_some_and(|ext| ext == "toml") [INFO] [stdout] 147 ~ && let Some(stem) = path.file_stem() { [INFO] [stdout] 148 | themes.insert(stem.to_string_lossy().into_owned(), path); [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/colors.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for AppearanceMode { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self::Dark [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub enum AppearanceMode { [INFO] [stdout] 9 ~ #[default] [INFO] [stdout] 10 ~ Dark, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/conch.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for ConchConfig { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | keyboard: KeyboardConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub struct ConchConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/persistent.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for PersistentState { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | layout: LayoutConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | pub struct PersistentState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/terminal.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / impl Default for TerminalShell { [INFO] [stdout] 39 | | fn default() -> Self { [INFO] [stdout] 40 | | Self { [INFO] [stdout] 41 | | program: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub struct TerminalShell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/terminal.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | / impl Default for CursorConfig { [INFO] [stdout] 55 | | fn default() -> Self { [INFO] [stdout] 56 | | Self { [INFO] [stdout] 57 | | style: CursorStyleConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 49 + #[derive(Default)] [INFO] [stdout] 50 | pub struct CursorConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/window.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for WindowConfig { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | Self { [INFO] [stdout] 54 | | dimensions: WindowDimensions::default(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 46 + #[derive(Default)] [INFO] [stdout] 47 | pub struct WindowConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_core/src/config/mod.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | / impl Default for UserConfig { [INFO] [stdout] 63 | | fn default() -> Self { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | window: WindowConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 39 + #[derive(Default)] [INFO] [stdout] 40 | pub struct UserConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking russh v0.48.2 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking mlua v0.10.5 [INFO] [stderr] Checking conch-ssh v1.0.1 (/opt/rustwide/workdir/plugins/conch-ssh) [INFO] [stdout] warning: unused import: `first_matching_server_id` [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:43:45 [INFO] [stdout] | [INFO] [stdout] 43 | use crate::server_tree::{build_server_tree, first_matching_server_id}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `first_matching_server_id` [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:43:45 [INFO] [stdout] | [INFO] [stdout] 43 | use crate::server_tree::{build_server_tree, first_matching_server_id}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_folder`, `update_tunnel`, and `tunnels_for_server` are never used [INFO] [stdout] --> plugins/conch-ssh/src/config.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl SshConfig { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 97 | pub fn is_folder(&self, id: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn update_tunnel(&mut self, tunnel: SavedTunnel) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | pub fn tunnels_for_server(&self, session_key: &str) -> Vec<&SavedTunnel> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `first_matching_server_id` is never used [INFO] [stdout] --> plugins/conch-ssh/src/server_tree.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn first_matching_server_id( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `description` is never used [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl SavedTunnel { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] 43 | pub fn description(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_error`, `clear_status`, `is_active`, and `active_ids` are never used [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 208 | impl TunnelManager { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 224 | pub async fn set_error(&self, id: &Uuid, msg: String) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 231 | pub async fn clear_status(&self, id: &Uuid) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 359 | pub async fn is_active(&self, id: &Uuid) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 378 | pub async fn active_ids(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-ssh/src/session_backend.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn activate( [INFO] [stdout] 76 | | &mut self, [INFO] [stdout] 77 | | channel: russh::Channel, [INFO] [stdout] 78 | | ssh_handle: russh::client::Handle, [INFO] [stdout] ... | [INFO] [stdout] 83 | | close_session: CloseSessionFn, [INFO] [stdout] 84 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:520:32 [INFO] [stdout] | [INFO] [stdout] 520 | drop(Box::from_raw(std::slice::from_raw_parts_mut(ptr, len))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(ptr, len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:537:40 [INFO] [stdout] | [INFO] [stdout] 537 | drop(Box::from_raw(std::slice::from_raw_parts_mut( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 538 | | entry.name, [INFO] [stdout] 539 | | entry.name_len, [INFO] [stdout] 540 | | ))); [INFO] [stdout] | |_____________________^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(entry.name, entry.name_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:553:32 [INFO] [stdout] | [INFO] [stdout] 553 | drop(Box::from_raw(std::slice::from_raw_parts_mut( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 554 | | r.error, [INFO] [stdout] 555 | | r.error_len, [INFO] [stdout] 556 | | ))); [INFO] [stdout] | |_____________^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(r.error, r.error_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Some(entry) = current.take() { [INFO] [stdout] 40 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 41 | | entries.push(se); [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Some(entry) = current.take() [INFO] [stdout] 40 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 41 | entries.push(se); [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Some(entry) = current.take() { [INFO] [stdout] 91 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 92 | | entries.push(se); [INFO] [stdout] 93 | | } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Some(entry) = current.take() [INFO] [stdout] 91 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 92 | entries.push(se); [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / if let Some(entry) = current.take() { [INFO] [stdout] 102 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 103 | | entries.push(se); [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ if let Some(entry) = current.take() [INFO] [stdout] 102 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 103 | entries.push(se); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | / if accepted { [INFO] [stdout] 163 | | if let Err(e) = known_hosts::add_known_host(&self.host, self.port, server_public_key) { [INFO] [stdout] 164 | | log::warn!("tunnel ssh: failed to save host key: {e}"); [INFO] [stdout] 165 | | } [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 162 ~ if accepted [INFO] [stdout] 163 ~ && let Err(e) = known_hosts::add_known_host(&self.host, self.port, server_public_key) { [INFO] [stdout] 164 | log::warn!("tunnel ssh: failed to save host key: {e}"); [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Some(state) = tunnels.get(id) { [INFO] [stdout] 235 | | if !matches!(state.status, TunnelStatus::Active) { [INFO] [stdout] 236 | | tunnels.remove(id); [INFO] [stdout] 237 | | } [INFO] [stdout] 238 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 234 ~ if let Some(state) = tunnels.get(id) [INFO] [stdout] 235 ~ && !matches!(state.status, TunnelStatus::Active) { [INFO] [stdout] 236 | tunnels.remove(id); [INFO] [stdout] 237 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:345:9 [INFO] [stdout] | [INFO] [stdout] 345 | / if let Some(state) = self.tunnels.lock().await.remove(id) { [INFO] [stdout] 346 | | if let Some(handle) = state.abort_handle { [INFO] [stdout] 347 | | log::info!("tunnel[{id}]: stopping"); [INFO] [stdout] 348 | | handle.abort(); [INFO] [stdout] 349 | | } [INFO] [stdout] 350 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 345 ~ if let Some(state) = self.tunnels.lock().await.remove(id) [INFO] [stdout] 346 ~ && let Some(handle) = state.abort_handle { [INFO] [stdout] 347 | log::info!("tunnel[{id}]: stopping"); [INFO] [stdout] 348 | handle.abort(); [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if path == "~" || path.starts_with("~/") { [INFO] [stdout] 26 | | if let Some(home) = dirs::home_dir() { [INFO] [stdout] 27 | | return home.join(&path[2..]); // skip "~/" [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if (path == "~" || path.starts_with("~/")) { [INFO] [stdout] 26 ~ && let Some(home) = dirs::home_dir() { [INFO] [stdout] 27 | return home.join(&path[2..]); // skip "~/" [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | let msg = CString::new(format!("{e}")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:631:38 [INFO] [stdout] | [INFO] [stdout] 631 | } else if key_path.is_some() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 632 | | "key".to_string() [INFO] [stdout] 633 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:633:16 [INFO] [stdout] | [INFO] [stdout] 633 | } else { [INFO] [stdout] | ________________^ [INFO] [stdout] 634 | | "key".to_string() [INFO] [stdout] 635 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:845:17 [INFO] [stdout] | [INFO] [stdout] 845 | "close" | _ => return, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_folder`, `update_tunnel`, and `tunnels_for_server` are never used [INFO] [stdout] --> plugins/conch-ssh/src/config.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl SshConfig { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 97 | pub fn is_folder(&self, id: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 128 | pub fn update_tunnel(&mut self, tunnel: SavedTunnel) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | pub fn tunnels_for_server(&self, session_key: &str) -> Vec<&SavedTunnel> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `first_matching_server_id` is never used [INFO] [stdout] --> plugins/conch-ssh/src/server_tree.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn first_matching_server_id( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> crates/conch_plugin/src/jvm_stub.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> crates/conch_plugin/src/jvm_stub.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> plugins/conch-ssh/src/session_backend.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn activate( [INFO] [stdout] 76 | | &mut self, [INFO] [stdout] 77 | | channel: russh::Channel, [INFO] [stdout] 78 | | ssh_handle: russh::client::Handle, [INFO] [stdout] ... | [INFO] [stdout] 83 | | close_session: CloseSessionFn, [INFO] [stdout] 84 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:520:32 [INFO] [stdout] | [INFO] [stdout] 520 | drop(Box::from_raw(std::slice::from_raw_parts_mut(ptr, len))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(ptr, len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:537:40 [INFO] [stdout] | [INFO] [stdout] 537 | drop(Box::from_raw(std::slice::from_raw_parts_mut( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 538 | | entry.name, [INFO] [stdout] 539 | | entry.name_len, [INFO] [stdout] 540 | | ))); [INFO] [stdout] | |_____________________^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(entry.name, entry.name_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly casting the result of `from_raw_parts_mut` to `*mut [u8]` [INFO] [stdout] --> plugins/conch-ssh/src/sftp_vtable.rs:553:32 [INFO] [stdout] | [INFO] [stdout] 553 | drop(Box::from_raw(std::slice::from_raw_parts_mut( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 554 | | r.error, [INFO] [stdout] 555 | | r.error_len, [INFO] [stdout] 556 | | ))); [INFO] [stdout] | |_____________^ help: replace_with: `std::ptr::slice_from_raw_parts_mut(r.error, r.error_len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Some(entry) = current.take() { [INFO] [stdout] 40 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 41 | | entries.push(se); [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Some(entry) = current.take() [INFO] [stdout] 40 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 41 | entries.push(se); [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Some(entry) = current.take() { [INFO] [stdout] 91 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 92 | | entries.push(se); [INFO] [stdout] 93 | | } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Some(entry) = current.take() [INFO] [stdout] 91 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 92 | entries.push(se); [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/ssh_config_parser.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / if let Some(entry) = current.take() { [INFO] [stdout] 102 | | if let Some(se) = entry.into_server_entry() { [INFO] [stdout] 103 | | entries.push(se); [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 101 ~ if let Some(entry) = current.take() [INFO] [stdout] 102 ~ && let Some(se) = entry.into_server_entry() { [INFO] [stdout] 103 | entries.push(se); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | / if accepted { [INFO] [stdout] 163 | | if let Err(e) = known_hosts::add_known_host(&self.host, self.port, server_public_key) { [INFO] [stdout] 164 | | log::warn!("tunnel ssh: failed to save host key: {e}"); [INFO] [stdout] 165 | | } [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 162 ~ if accepted [INFO] [stdout] 163 ~ && let Err(e) = known_hosts::add_known_host(&self.host, self.port, server_public_key) { [INFO] [stdout] 164 | log::warn!("tunnel ssh: failed to save host key: {e}"); [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Some(state) = tunnels.get(id) { [INFO] [stdout] 235 | | if !matches!(state.status, TunnelStatus::Active) { [INFO] [stdout] 236 | | tunnels.remove(id); [INFO] [stdout] 237 | | } [INFO] [stdout] 238 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 234 ~ if let Some(state) = tunnels.get(id) [INFO] [stdout] 235 ~ && !matches!(state.status, TunnelStatus::Active) { [INFO] [stdout] 236 | tunnels.remove(id); [INFO] [stdout] 237 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/tunnel.rs:345:9 [INFO] [stdout] | [INFO] [stdout] 345 | / if let Some(state) = self.tunnels.lock().await.remove(id) { [INFO] [stdout] 346 | | if let Some(handle) = state.abort_handle { [INFO] [stdout] 347 | | log::info!("tunnel[{id}]: stopping"); [INFO] [stdout] 348 | | handle.abort(); [INFO] [stdout] 349 | | } [INFO] [stdout] 350 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 345 ~ if let Some(state) = self.tunnels.lock().await.remove(id) [INFO] [stdout] 346 ~ && let Some(handle) = state.abort_handle { [INFO] [stdout] 347 | log::info!("tunnel[{id}]: stopping"); [INFO] [stdout] 348 | handle.abort(); [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if path == "~" || path.starts_with("~/") { [INFO] [stdout] 26 | | if let Some(home) = dirs::home_dir() { [INFO] [stdout] 27 | | return home.join(&path[2..]); // skip "~/" [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if (path == "~" || path.starts_with("~/")) { [INFO] [stdout] 26 ~ && let Some(home) = dirs::home_dir() { [INFO] [stdout] 27 | return home.join(&path[2..]); // skip "~/" [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | let msg = CString::new(format!("{e}")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:631:38 [INFO] [stdout] | [INFO] [stdout] 631 | } else if key_path.is_some() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 632 | | "key".to_string() [INFO] [stdout] 633 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:633:16 [INFO] [stdout] | [INFO] [stdout] 633 | } else { [INFO] [stdout] | ________________^ [INFO] [stdout] 634 | | "key".to_string() [INFO] [stdout] 635 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> plugins/conch-ssh/src/lib.rs:845:17 [INFO] [stdout] | [INFO] [stdout] 845 | "close" | _ => return, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PluginBus` [INFO] [stdout] --> crates/conch_plugin/src/bus.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / pub fn new() -> Self { [INFO] [stdout] 125 | | Self { [INFO] [stdout] 126 | | plugin_senders: RwLock::new(HashMap::new()), [INFO] [stdout] 127 | | subscriptions: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 123 + impl Default for PluginBus { [INFO] [stdout] 124 + fn default() -> Self { [INFO] [stdout] 125 + Self::new() [INFO] [stdout] 126 + } [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WidgetAccumulator` [INFO] [stdout] --> crates/conch_plugin/src/lua/api.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | Self { [INFO] [stdout] 29 | | stack: vec![vec![]], [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 26 + impl Default for WidgetAccumulator { [INFO] [stdout] 27 + fn default() -> Self { [INFO] [stdout] 28 + Self::new() [INFO] [stdout] 29 + } [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PluginBus` [INFO] [stdout] --> crates/conch_plugin/src/bus.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / pub fn new() -> Self { [INFO] [stdout] 125 | | Self { [INFO] [stdout] 126 | | plugin_senders: RwLock::new(HashMap::new()), [INFO] [stdout] 127 | | subscriptions: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 123 + impl Default for PluginBus { [INFO] [stdout] 124 + fn default() -> Self { [INFO] [stdout] 125 + Self::new() [INFO] [stdout] 126 + } [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WidgetAccumulator` [INFO] [stdout] --> crates/conch_plugin/src/lua/api.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | Self { [INFO] [stdout] 29 | | stack: vec![vec![]], [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 26 + impl Default for WidgetAccumulator { [INFO] [stdout] 27 + fn default() -> Self { [INFO] [stdout] 28 + Self::new() [INFO] [stdout] 29 + } [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/api.rs:1214:13 [INFO] [stdout] | [INFO] [stdout] 1214 | / if let Ok(v) = field.get::(key.to_string()) { [INFO] [stdout] 1215 | | if !matches!(v, LuaValue::Nil) { [INFO] [stdout] 1216 | | obj.insert(key.to_string(), lua_value_to_json(v)?); [INFO] [stdout] 1217 | | } [INFO] [stdout] 1218 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if let Ok(v) = field.get::(key.to_string()) [INFO] [stdout] 1215 ~ && !matches!(v, LuaValue::Nil) { [INFO] [stdout] 1216 | obj.insert(key.to_string(), lua_value_to_json(v)?); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/metadata.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | } else if let Some(value) = comment.strip_prefix("plugin-keybind:") { [INFO] [stdout] | ________________^ [INFO] [stdout] 96 | | if let Some(keybind) = parse_keybind(value) { [INFO] [stdout] 97 | | meta.keybinds.push(keybind); [INFO] [stdout] 98 | | } [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ } else if let Some(value) = comment.strip_prefix("plugin-keybind:") [INFO] [stdout] 96 ~ && let Some(keybind) = parse_keybind(value) { [INFO] [stdout] 97 | meta.keybinds.push(keybind); [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/metadata.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / if path.extension().is_some_and(|ext| ext == "lua") { [INFO] [stdout] 133 | | if let Ok(source) = std::fs::read_to_string(&path) { [INFO] [stdout] 134 | | plugins.push((path, source)); [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if path.extension().is_some_and(|ext| ext == "lua") [INFO] [stdout] 133 ~ && let Ok(source) = std::fs::read_to_string(&path) { [INFO] [stdout] 134 | plugins.push((path, source)); [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/api.rs:1214:13 [INFO] [stdout] | [INFO] [stdout] 1214 | / if let Ok(v) = field.get::(key.to_string()) { [INFO] [stdout] 1215 | | if !matches!(v, LuaValue::Nil) { [INFO] [stdout] 1216 | | obj.insert(key.to_string(), lua_value_to_json(v)?); [INFO] [stdout] 1217 | | } [INFO] [stdout] 1218 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if let Ok(v) = field.get::(key.to_string()) [INFO] [stdout] 1215 ~ && !matches!(v, LuaValue::Nil) { [INFO] [stdout] 1216 | obj.insert(key.to_string(), lua_value_to_json(v)?); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / let lua = match Lua::new() { [INFO] [stdout] 89 | | lua => lua, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 88 ~ let lua = Lua::new(); [INFO] [stdout] 89 + let lua = lua; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / if let Ok(setup_fn) = lua.globals().get::("setup") { [INFO] [stdout] 111 | | if let Err(e) = setup_fn.call::<()>(()) { [INFO] [stdout] 112 | | log::error!("Lua plugin setup() failed: {e}"); [INFO] [stdout] 113 | | return; [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 110 ~ if let Ok(setup_fn) = lua.globals().get::("setup") [INFO] [stdout] 111 ~ && let Err(e) = setup_fn.call::<()>(()) { [INFO] [stdout] 112 | log::error!("Lua plugin setup() failed: {e}"); [INFO] [stdout] 113 | return; [INFO] [stdout] 114 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/metadata.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | } else if let Some(value) = comment.strip_prefix("plugin-keybind:") { [INFO] [stdout] | ________________^ [INFO] [stdout] 96 | | if let Some(keybind) = parse_keybind(value) { [INFO] [stdout] 97 | | meta.keybinds.push(keybind); [INFO] [stdout] 98 | | } [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 95 ~ } else if let Some(value) = comment.strip_prefix("plugin-keybind:") [INFO] [stdout] 96 ~ && let Some(keybind) = parse_keybind(value) { [INFO] [stdout] 97 | meta.keybinds.push(keybind); [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/metadata.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / if path.extension().is_some_and(|ext| ext == "lua") { [INFO] [stdout] 133 | | if let Ok(source) = std::fs::read_to_string(&path) { [INFO] [stdout] 134 | | plugins.push((path, source)); [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if path.extension().is_some_and(|ext| ext == "lua") [INFO] [stdout] 133 ~ && let Ok(source) = std::fs::read_to_string(&path) { [INFO] [stdout] 134 | plugins.push((path, source)); [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Ok(teardown_fn) = lua.globals().get::("teardown") { [INFO] [stdout] 167 | | if let Err(e) = teardown_fn.call::<()>(()) { [INFO] [stdout] 168 | | log::warn!("Lua plugin teardown() error: {e}"); [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if let Ok(teardown_fn) = lua.globals().get::("teardown") [INFO] [stdout] 167 ~ && let Err(e) = teardown_fn.call::<()>(()) { [INFO] [stdout] 168 | log::warn!("Lua plugin teardown() error: {e}"); [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:201:28 [INFO] [stdout] | [INFO] [stdout] 201 | let Ok(tbl) = lua.load(&format!("return {}", lua_literal)).eval::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("return {}", lua_literal)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / let lua = match Lua::new() { [INFO] [stdout] 89 | | lua => lua, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 88 ~ let lua = Lua::new(); [INFO] [stdout] 89 + let lua = lua; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | / if let Ok(render_fn) = lua.globals().get::("render") { [INFO] [stdout] 222 | | if let Err(e) = render_fn.call::<()>(()) { [INFO] [stdout] 223 | | log::error!("Lua render() error: {e}"); [INFO] [stdout] 224 | | return vec![]; [INFO] [stdout] 225 | | } [INFO] [stdout] 226 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 221 ~ if let Ok(render_fn) = lua.globals().get::("render") [INFO] [stdout] 222 ~ && let Err(e) = render_fn.call::<()>(()) { [INFO] [stdout] 223 | log::error!("Lua render() error: {e}"); [INFO] [stdout] 224 | return vec![]; [INFO] [stdout] 225 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / if let Ok(setup_fn) = lua.globals().get::("setup") { [INFO] [stdout] 111 | | if let Err(e) = setup_fn.call::<()>(()) { [INFO] [stdout] 112 | | log::error!("Lua plugin setup() failed: {e}"); [INFO] [stdout] 113 | | return; [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 110 ~ if let Ok(setup_fn) = lua.globals().get::("setup") [INFO] [stdout] 111 ~ && let Err(e) = setup_fn.call::<()>(()) { [INFO] [stdout] 112 | log::error!("Lua plugin setup() failed: {e}"); [INFO] [stdout] 113 | return; [INFO] [stdout] 114 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:248:26 [INFO] [stdout] | [INFO] [stdout] 248 | Err(_) => return format!("{{}}"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Ok(teardown_fn) = lua.globals().get::("teardown") { [INFO] [stdout] 167 | | if let Err(e) = teardown_fn.call::<()>(()) { [INFO] [stdout] 168 | | log::warn!("Lua plugin teardown() error: {e}"); [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if let Ok(teardown_fn) = lua.globals().get::("teardown") [INFO] [stdout] 167 ~ && let Err(e) = teardown_fn.call::<()>(()) { [INFO] [stdout] 168 | log::warn!("Lua plugin teardown() error: {e}"); [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:201:28 [INFO] [stdout] | [INFO] [stdout] 201 | let Ok(tbl) = lua.load(&format!("return {}", lua_literal)).eval::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("return {}", lua_literal)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | / if let Ok(render_fn) = lua.globals().get::("render") { [INFO] [stdout] 222 | | if let Err(e) = render_fn.call::<()>(()) { [INFO] [stdout] 223 | | log::error!("Lua render() error: {e}"); [INFO] [stdout] 224 | | return vec![]; [INFO] [stdout] 225 | | } [INFO] [stdout] 226 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 221 ~ if let Ok(render_fn) = lua.globals().get::("render") [INFO] [stdout] 222 ~ && let Err(e) = render_fn.call::<()>(()) { [INFO] [stdout] 223 | log::error!("Lua render() error: {e}"); [INFO] [stdout] 224 | return vec![]; [INFO] [stdout] 225 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> crates/conch_plugin/src/lua/runner.rs:248:26 [INFO] [stdout] | [INFO] [stdout] 248 | Err(_) => return format!("{{}}"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/native/lifecycle.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / if let Some(handle) = self.thread_handle.take() { [INFO] [stdout] 31 | | if let Err(e) = handle.join() { [INFO] [stdout] 32 | | log::error!("plugin thread for {:?} panicked: {:?}", self.meta.name, e); [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(handle) = self.thread_handle.take() [INFO] [stdout] 31 ~ && let Err(e) = handle.join() { [INFO] [stdout] 32 | log::error!("plugin thread for {:?} panicked: {:?}", self.meta.name, e); [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_plugin/src/native/lifecycle.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / if let Some(handle) = self.thread_handle.take() { [INFO] [stdout] 31 | | if let Err(e) = handle.join() { [INFO] [stdout] 32 | | log::error!("plugin thread for {:?} panicked: {:?}", self.meta.name, e); [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(handle) = self.thread_handle.take() [INFO] [stdout] 31 ~ && let Err(e) = handle.join() { [INFO] [stdout] 32 | log::error!("plugin thread for {:?} panicked: {:?}", self.meta.name, e); [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/conch_plugin/src/native/manager.rs:154:22 [INFO] [stdout] | [INFO] [stdout] 154 | .map_err(|e| LoadError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `LoadError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/conch_plugin/src/native/manager.rs:154:22 [INFO] [stdout] | [INFO] [stdout] 154 | .map_err(|e| LoadError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `LoadError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.31.1 [INFO] [stderr] Checking eframe v0.31.1 [INFO] [stdout] warning: unused import: `RunningLuaPlugin` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:8:54 [INFO] [stdout] | [INFO] [stdout] 8 | use conch_plugin::lua::runner::{DiscoveredLuaPlugin, RunningLuaPlugin}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `conch_plugin_sdk::PanelLocation` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use conch_plugin_sdk::PanelLocation; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::host::bridge` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::host::bridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RunningLuaPlugin` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:8:54 [INFO] [stdout] | [INFO] [stdout] 8 | use conch_plugin::lua::runner::{DiscoveredLuaPlugin, RunningLuaPlugin}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `conch_plugin_sdk::PanelLocation` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use conch_plugin_sdk::PanelLocation; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::host::bridge` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::host::bridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> crates/conch_app/src/app.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | let mut win = w.lock(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `should_close` is never read [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:312:32 [INFO] [stdout] | [INFO] [stdout] 312 | let mut should_close = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:603:13 [INFO] [stdout] | [INFO] [stdout] 603 | id, [INFO] [stdout] | ^^ help: try ignoring the field: `id: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> crates/conch_app/src/app.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | let mut win = w.lock(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fg` [INFO] [stdout] --> crates/conch_app/src/ui_theme.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let fg = to_color32(colors.foreground); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_fg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `should_close` is never read [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:312:32 [INFO] [stdout] | [INFO] [stdout] 312 | let mut should_close = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rt` is never read [INFO] [stdout] --> crates/conch_app/src/app.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct ConchApp { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | pub(crate) rt: Arc, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | pub struct PendingSession { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 123 | pub handle: SessionHandle, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_menu_items_for_plugin` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | pub fn remove_menu_items_for_plugin(plugin_name: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ActiveSessionInfo` is never constructed [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | pub struct ActiveSessionInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `ACTIVE_SESSION` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:322:8 [INFO] [stdout] | [INFO] [stdout] 322 | static ACTIVE_SESSION: parking_lot::Mutex> = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `set_active_session` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 326 | pub fn set_active_session(info: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_active_session` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:331:8 [INFO] [stdout] | [INFO] [stdout] 331 | pub fn get_active_session() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deregister_sftp` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:1087:8 [INFO] [stdout] | [INFO] [stdout] 1087 | pub fn deregister_sftp(session_id: u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `form_values_to_json` is never used [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:478:4 [INFO] [stdout] | [INFO] [stdout] 478 | fn form_values_to_json(values: &HashMap) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `panel_location` is never read [INFO] [stdout] --> crates/conch_app/src/host/plugin_manager_ui.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct PluginEntry { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub panel_location: PanelLocation, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PluginEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEFAULT_SIDE_WIDTH` is never used [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | const DEFAULT_SIDE_WIDTH: f32 = 300.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEFAULT_BOTTOM_HEIGHT` is never used [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:53:7 [INFO] [stdout] | [INFO] [stdout] 53 | const DEFAULT_BOTTOM_HEIGHT: f32 = 180.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `resize` is never used [INFO] [stdout] --> crates/conch_app/src/host/session_bridge.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 90 | impl PluginSessionBridge { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 133 | pub fn resize(&mut self, cols: u16, rows: u16) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `image`, `texture_id`, and `texture_handle` are never used [INFO] [stdout] --> crates/conch_app/src/icons.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl IconCache { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 277 | pub fn image(&self, icon: Icon) -> Option> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | pub fn texture_id(&self, icon: Icon) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 310 | fn texture_handle(&self, icon: Icon) -> Option<&TextureHandle> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `bg_with_alpha` is never used [INFO] [stdout] --> crates/conch_app/src/ui_theme.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 67 | impl UiTheme { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 246 | pub fn bg_with_alpha(&self, alpha: u8) -> Color32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> crates/conch_app/src/watcher.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) struct FileChange { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | pub kind: FileChangeKind, [INFO] [stdout] 17 | pub path: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WindowClosed` and `PublishTabChanged` are never constructed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) enum WindowAction { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 110 | WindowClosed(egui::ViewportId), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | PublishTabChanged { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `active_session_mut` is never used [INFO] [stdout] --> crates/conch_app/src/window_state.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl WindowState { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 248 | pub fn active_session_mut(&mut self) -> Option<&mut Session> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:603:13 [INFO] [stdout] | [INFO] [stdout] 603 | id, [INFO] [stdout] | ^^ help: try ignoring the field: `id: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | / if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend { [INFO] [stdout] 298 | | if bridge.handle == handle { return Some(*sid); } [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 297 ~ if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend [INFO] [stdout] 298 ~ && bridge.handle == handle { return Some(*sid); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend { [INFO] [stdout] 331 | | if bridge.handle == update.handle { return Some(*sid); } [INFO] [stdout] 332 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend [INFO] [stdout] 331 ~ && bridge.handle == update.handle { return Some(*sid); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:441:13 [INFO] [stdout] | [INFO] [stdout] 441 | / if let Some(bytes) = tab_bytes { [INFO] [stdout] 442 | | if let Some(session) = win.active_session() { [INFO] [stdout] 443 | | session.write(&bytes); [INFO] [stdout] 444 | | } [INFO] [stdout] 445 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 441 ~ if let Some(bytes) = tab_bytes [INFO] [stdout] 442 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 443 | session.write(&bytes); [INFO] [stdout] 444 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/conch_app/src/app.rs:604:13 [INFO] [stdout] | [INFO] [stdout] 604 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 603 - ctx.send_viewport_cmd(ViewportCommand::Close); [INFO] [stdout] 604 - return; [INFO] [stdout] 603 + ctx.send_viewport_cmd(ViewportCommand::Close); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> crates/conch_app/src/app.rs:600:41 [INFO] [stdout] | [INFO] [stdout] 600 | for (_, session) in &win.sessions { session.shutdown(); } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 600 - for (_, session) in &win.sessions { session.shutdown(); } [INFO] [stdout] 600 + for session in win.sessions.values() { session.shutdown(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:1089:5 [INFO] [stdout] | [INFO] [stdout] 1089 | / if let Some(map) = guard.as_mut() { [INFO] [stdout] 1090 | | if let Some(entry) = map.remove(&session_id) { [INFO] [stdout] 1091 | | unsafe { ((*entry.vtable).release)(entry.ctx) }; [INFO] [stdout] 1092 | | log::info!("deregister_sftp: removed SFTP for session {session_id}"); [INFO] [stdout] 1093 | | } [INFO] [stdout] 1094 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1089 ~ if let Some(map) = guard.as_mut() [INFO] [stdout] 1090 ~ && let Some(entry) = map.remove(&session_id) { [INFO] [stdout] 1091 | unsafe { ((*entry.vtable).release)(entry.ctx) }; [INFO] [stdout] 1092 | log::info!("deregister_sftp: removed SFTP for session {session_id}"); [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | / if !self.active.contains_key(&viewport_id) { [INFO] [stdout] 296 | | if let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | | if !queue.is_empty() { [INFO] [stdout] 298 | | let request = queue.remove(0); [INFO] [stdout] ... | [INFO] [stdout] 306 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ if !self.active.contains_key(&viewport_id) [INFO] [stdout] 296 ~ && let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | if !queue.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 304 | } [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | / if let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | | if !queue.is_empty() { [INFO] [stdout] 298 | | let request = queue.remove(0); [INFO] [stdout] 299 | | log::info!( [INFO] [stdout] ... | [INFO] [stdout] 305 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 296 ~ if let Some(queue) = self.pending.get_mut(&viewport_id) [INFO] [stdout] 297 ~ && !queue.is_empty() { [INFO] [stdout] 298 | let request = queue.remove(0); [INFO] [stdout] ... [INFO] [stdout] 303 | self.active.insert(viewport_id, activate_request(request)); [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / if should_close { [INFO] [stdout] 347 | | if let Some(dialog) = self.active.remove(&viewport_id) { [INFO] [stdout] 348 | | send_dialog_result(dialog); [INFO] [stdout] 349 | | } [INFO] [stdout] 350 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 346 ~ if should_close [INFO] [stdout] 347 ~ && let Some(dialog) = self.active.remove(&viewport_id) { [INFO] [stdout] 348 | send_dialog_result(dialog); [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:770:45 [INFO] [stdout] | [INFO] [stdout] 770 | / ... if resp.clicked() { [INFO] [stdout] 771 | | ... if let Some(FormValue::Text(val)) = [INFO] [stdout] 772 | | ... values.get_mut(id) [INFO] [stdout] ... | [INFO] [stdout] 776 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 770 ~ if resp.clicked() [INFO] [stdout] 771 ~ && let Some(FormValue::Text(val)) = [INFO] [stdout] 772 | values.get_mut(id) [INFO] [stdout] 773 | { [INFO] [stdout] 774 | *val = row_data.id.clone(); [INFO] [stdout] 775 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:876:39 [INFO] [stdout] | [INFO] [stdout] 876 | ... .join(&dir[2..]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:873:40 [INFO] [stdout] | [INFO] [stdout] 873 | let expanded = if dir.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 873 ~ let expanded = if let Some() = dir.strip_prefix("~/") { [INFO] [stdout] 874 | dirs::home_dir() [INFO] [stdout] 875 | .unwrap_or_default() [INFO] [stdout] 876 ~ .join() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:1076:9 [INFO] [stdout] | [INFO] [stdout] 1076 | / if let Some(rect) = area_rect { [INFO] [stdout] 1077 | | if !rect.contains(ctx.input(|i| i.pointer.hover_pos().unwrap_or_default())) { [INFO] [stdout] 1078 | | close = true; [INFO] [stdout] 1079 | | } [INFO] [stdout] 1080 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1076 ~ if let Some(rect) = area_rect [INFO] [stdout] 1077 ~ && !rect.contains(ctx.input(|i| i.pointer.hover_pos().unwrap_or_default())) { [INFO] [stdout] 1078 | close = true; [INFO] [stdout] 1079 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:431:25 [INFO] [stdout] | [INFO] [stdout] 431 | / if let Some(ic) = icon_cache { [INFO] [stdout] 432 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | | if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] ... | [INFO] [stdout] 437 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 431 ~ if let Some(ic) = icon_cache [INFO] [stdout] 432 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 | } [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:432:29 [INFO] [stdout] | [INFO] [stdout] 432 | / ... if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | | ... if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | | ... events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 | | ... } [INFO] [stdout] 436 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 432 ~ if let Some(img) = ic.image_by_name(icon_name, dark_mode) [INFO] [stdout] 433 ~ && ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:443:29 [INFO] [stdout] | [INFO] [stdout] 443 | / ... if let Some(ic) = icon_cache { [INFO] [stdout] 444 | | ... if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 445 | | ... ui.add(img); [INFO] [stdout] 446 | | ... } [INFO] [stdout] 447 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ if let Some(ic) = icon_cache [INFO] [stdout] 444 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 445 | ui.add(img); [INFO] [stdout] 446 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fg` [INFO] [stdout] --> crates/conch_app/src/ui_theme.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let fg = to_color32(colors.foreground); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_fg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:850:1 [INFO] [stdout] | [INFO] [stdout] 850 | / fn render_tree_node( [INFO] [stdout] 851 | | ui: &mut egui::Ui, [INFO] [stdout] 852 | | tree_id: &str, [INFO] [stdout] 853 | | node: &conch_plugin_sdk::widgets::TreeNode, [INFO] [stdout] ... | [INFO] [stdout] 859 | | icon_cache: Option<&IconCache>, [INFO] [stdout] 860 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:882:17 [INFO] [stdout] | [INFO] [stdout] 882 | / if let Some(ic) = icon_cache { [INFO] [stdout] 883 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 884 | | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] 885 | | Some("blue") => Some(theme.accent), [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 882 ~ if let Some(ic) = icon_cache [INFO] [stdout] 883 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 884 | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] ... [INFO] [stdout] 894 | ui.add(img); [INFO] [stdout] 895 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if let Some(ic) = icon_cache { [INFO] [stdout] 968 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 969 | | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] 970 | | Some("blue") => Some(theme.accent), [INFO] [stdout] ... | [INFO] [stdout] 981 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 967 ~ if let Some(ic) = icon_cache [INFO] [stdout] 968 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 969 | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] ... [INFO] [stdout] 979 | ui.add(img); [INFO] [stdout] 980 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:855:5 [INFO] [stdout] | [INFO] [stdout] 855 | depth: usize, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:950:25 [INFO] [stdout] | [INFO] [stdout] 950 | depth + 1, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:857:5 [INFO] [stdout] | [INFO] [stdout] 857 | text_input_state: &mut HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_text_input_state` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:952:25 [INFO] [stdout] | [INFO] [stdout] 952 | text_input_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1053:21 [INFO] [stdout] | [INFO] [stdout] 1053 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1054 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1055 | | ui.add(img); [INFO] [stdout] 1056 | | } [INFO] [stdout] 1057 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1053 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1054 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1055 | ui.add(img); [INFO] [stdout] 1056 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1108:17 [INFO] [stdout] | [INFO] [stdout] 1108 | / if let Some(icon_name) = icon { [INFO] [stdout] 1109 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1110 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | | let resp = ui [INFO] [stdout] ... | [INFO] [stdout] 1121 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1108 ~ if let Some(icon_name) = icon [INFO] [stdout] 1109 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1110 | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] ... [INFO] [stdout] 1119 | } [INFO] [stdout] 1120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1109:21 [INFO] [stdout] | [INFO] [stdout] 1109 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1110 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | | let resp = ui [INFO] [stdout] 1112 | | .add_enabled(is_enabled, egui::ImageButton::new(img).frame(false)); [INFO] [stdout] ... | [INFO] [stdout] 1120 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1109 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1110 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | let resp = ui [INFO] [stdout] ... [INFO] [stdout] 1118 | } [INFO] [stdout] 1119 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1125:17 [INFO] [stdout] | [INFO] [stdout] 1125 | / if let Some(icon_name) = icon { [INFO] [stdout] 1126 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1127 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | | ui.add(img); [INFO] [stdout] ... | [INFO] [stdout] 1131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1125 ~ if let Some(icon_name) = icon [INFO] [stdout] 1126 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1127 | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | ui.add(img); [INFO] [stdout] 1129 | } [INFO] [stdout] 1130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1126:21 [INFO] [stdout] | [INFO] [stdout] 1126 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1127 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | | ui.add(img); [INFO] [stdout] 1129 | | } [INFO] [stdout] 1130 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1126 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1127 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | ui.add(img); [INFO] [stdout] 1129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1239:1 [INFO] [stdout] | [INFO] [stdout] 1239 | / fn render_table( [INFO] [stdout] 1240 | | ui: &mut egui::Ui, [INFO] [stdout] 1241 | | table_id: &str, [INFO] [stdout] 1242 | | columns: &[TableColumn], [INFO] [stdout] ... | [INFO] [stdout] 1249 | | icon_cache: Option<&IconCache>, [INFO] [stdout] 1250 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1440:25 [INFO] [stdout] | [INFO] [stdout] 1440 | / if let Some(name) = icon_name { [INFO] [stdout] 1441 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1442 | | if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | | let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] ... | [INFO] [stdout] 1451 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1440 ~ if let Some(name) = icon_name [INFO] [stdout] 1441 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1442 | if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] ... [INFO] [stdout] 1449 | } [INFO] [stdout] 1450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1441:29 [INFO] [stdout] | [INFO] [stdout] 1441 | / ... if let Some(ic) = icon_cache { [INFO] [stdout] 1442 | | ... if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | | ... let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] 1444 | | ... egui::pos2(text_x, cell_rect.center().y - icon_size / 2.0), [INFO] [stdout] ... | [INFO] [stdout] 1450 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1441 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1442 ~ && let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] ... [INFO] [stdout] 1448 | text_x += icon_size + 4.0; [INFO] [stdout] 1449 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Ok(exe) = std::env::current_exe() { [INFO] [stdout] 34 | | if let Some(exe_dir) = exe.parent() { [INFO] [stdout] 35 | | // Same directory as the binary (Windows, portable builds). [INFO] [stdout] 36 | | dirs.push(exe_dir.to_path_buf()); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Ok(exe) = std::env::current_exe() [INFO] [stdout] 34 ~ && let Some(exe_dir) = exe.parent() { [INFO] [stdout] 35 | // Same directory as the binary (Windows, portable builds). [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | / if plugins_cfg.native { [INFO] [stdout] 83 | | if let Ok(paths) = conch_plugin::native::library::discover_library_paths(dir) { [INFO] [stdout] 84 | | for path in paths { [INFO] [stdout] 85 | | match unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ if plugins_cfg.native [INFO] [stdout] 83 ~ && let Ok(paths) = conch_plugin::native::library::discover_library_paths(dir) { [INFO] [stdout] 84 | for path in paths { [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | / match unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] 86 | | Ok(lib) => { [INFO] [stdout] 87 | | let meta = unsafe { lib.read_info() }; [INFO] [stdout] 88 | | entries.push(PluginEntry { [INFO] [stdout] ... | [INFO] [stdout] 98 | | Err(_) => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Ok(lib) = unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] 86 + let meta = unsafe { lib.read_info() }; [INFO] [stdout] 87 + entries.push(PluginEntry { [INFO] [stdout] 88 + name: meta.name, [INFO] [stdout] 89 + description: meta.description, [INFO] [stdout] 90 + version: meta.version, [INFO] [stdout] 91 + plugin_type: meta.plugin_type, [INFO] [stdout] 92 + panel_location: meta.panel_location, [INFO] [stdout] 93 + source: PluginSource::Native, [INFO] [stdout] 94 + path, [INFO] [stdout] 95 + }); [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / if plugins_cfg.java { [INFO] [stdout] 106 | | if let Some(mgr) = &mut self.java_plugin_mgr { [INFO] [stdout] 107 | | for (path, meta) in mgr.discover(dir) { [INFO] [stdout] 108 | | entries.push(PluginEntry { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if plugins_cfg.java [INFO] [stdout] 106 ~ && let Some(mgr) = &mut self.java_plugin_mgr { [INFO] [stdout] 107 | for (path, meta) in mgr.discover(dir) { [INFO] [stdout] ... [INFO] [stdout] 117 | } [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:278:28 [INFO] [stdout] | [INFO] [stdout] 278 | if self.java_plugin_mgr.as_ref().map_or(false, |m| m.is_loaded(&name)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 278 - if self.java_plugin_mgr.as_ref().map_or(false, |m| m.is_loaded(&name)) { [INFO] [stdout] 278 + if self.java_plugin_mgr.as_ref().is_some_and(|m| m.is_loaded(&name)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / if !force_set.contains(&plugin_name) { [INFO] [stdout] 403 | | if let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 402 ~ if !force_set.contains(&plugin_name) [INFO] [stdout] 403 ~ && let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | continue; [INFO] [stdout] 406 | } [INFO] [stdout] 407 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | / if let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | | continue; [INFO] [stdout] 406 | | } [INFO] [stdout] 407 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 403 ~ if let Some(last) = self.render_last_request.get(&plugin_name) [INFO] [stdout] 404 ~ && now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | continue; [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/host/plugin_manager_ui.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | / impl Default for PluginManagerState { [INFO] [stdout] 66 | | fn default() -> Self { [INFO] [stdout] 67 | | Self { [INFO] [stdout] 68 | | plugins: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 45 + #[derive(Default)] [INFO] [stdout] 46 | pub struct PluginManagerState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rt` is never read [INFO] [stdout] --> crates/conch_app/src/app.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct ConchApp { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | pub(crate) rt: Arc, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | pub struct PendingSession { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 123 | pub handle: SessionHandle, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_menu_items_for_plugin` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | pub fn remove_menu_items_for_plugin(plugin_name: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ActiveSessionInfo` is never constructed [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | pub struct ActiveSessionInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `ACTIVE_SESSION` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:322:8 [INFO] [stdout] | [INFO] [stdout] 322 | static ACTIVE_SESSION: parking_lot::Mutex> = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `set_active_session` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 326 | pub fn set_active_session(info: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | / pub(crate) fn render_plugin_panels_for_ctx( [INFO] [stdout] 74 | | ctx: &egui::Context, [INFO] [stdout] 75 | | panel_registry: &Arc>, [INFO] [stdout] 76 | | plugin_bus: &Arc, [INFO] [stdout] ... | [INFO] [stdout] 88 | | viewport_id: egui::ViewportId, [INFO] [stdout] 89 | | ) -> PanelSizes { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_active_session` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:331:8 [INFO] [stdout] | [INFO] [stdout] 331 | pub fn get_active_session() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deregister_sftp` is never used [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:1087:8 [INFO] [stdout] | [INFO] [stdout] 1087 | pub fn deregister_sftp(session_id: u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `panel_location` is never read [INFO] [stdout] --> crates/conch_app/src/host/plugin_manager_ui.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct PluginEntry { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub panel_location: PanelLocation, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PluginEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEFAULT_SIDE_WIDTH` is never used [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | const DEFAULT_SIDE_WIDTH: f32 = 300.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEFAULT_BOTTOM_HEIGHT` is never used [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:53:7 [INFO] [stdout] | [INFO] [stdout] 53 | const DEFAULT_BOTTOM_HEIGHT: f32 = 180.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `image`, `texture_id`, and `texture_handle` are never used [INFO] [stdout] --> crates/conch_app/src/icons.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 250 | impl IconCache { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 277 | pub fn image(&self, icon: Icon) -> Option> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | pub fn texture_id(&self, icon: Icon) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 310 | fn texture_handle(&self, icon: Icon) -> Option<&TextureHandle> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> crates/conch_app/src/watcher.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) struct FileChange { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | pub kind: FileChangeKind, [INFO] [stdout] 17 | pub path: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `WindowClosed` and `PublishTabChanged` are never constructed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) enum WindowAction { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 110 | WindowClosed(egui::ViewportId), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | PublishTabChanged { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `active_session_mut` is never used [INFO] [stdout] --> crates/conch_app/src/window_state.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 185 | impl WindowState { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 248 | pub fn active_session_mut(&mut self) -> Option<&mut Session> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:368:5 [INFO] [stdout] | [INFO] [stdout] 368 | / if let Some(ref e) = entry { [INFO] [stdout] 369 | | if (e.level == 0 || e.level == 3) [INFO] [stdout] 370 | | && e.progress < 0.0 [INFO] [stdout] 371 | | && e.timestamp.elapsed().as_secs() > 10 [INFO] [stdout] ... | [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 368 ~ if let Some(ref e) = entry [INFO] [stdout] 369 ~ && (e.level == 0 || e.level == 3) [INFO] [stdout] 370 | && e.progress < 0.0 [INFO] [stdout] ... [INFO] [stdout] 374 | entry = None; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | / if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend { [INFO] [stdout] 298 | | if bridge.handle == handle { return Some(*sid); } [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 297 ~ if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend [INFO] [stdout] 298 ~ && bridge.handle == handle { return Some(*sid); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend { [INFO] [stdout] 331 | | if bridge.handle == update.handle { return Some(*sid); } [INFO] [stdout] 332 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if let crate::state::SessionBackend::Plugin { bridge, .. } = &s.backend [INFO] [stdout] 331 ~ && bridge.handle == update.handle { return Some(*sid); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/app.rs:441:13 [INFO] [stdout] | [INFO] [stdout] 441 | / if let Some(bytes) = tab_bytes { [INFO] [stdout] 442 | | if let Some(session) = win.active_session() { [INFO] [stdout] 443 | | session.write(&bytes); [INFO] [stdout] 444 | | } [INFO] [stdout] 445 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 441 ~ if let Some(bytes) = tab_bytes [INFO] [stdout] 442 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 443 | session.write(&bytes); [INFO] [stdout] 444 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/conch_app/src/app.rs:604:13 [INFO] [stdout] | [INFO] [stdout] 604 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 603 - ctx.send_viewport_cmd(ViewportCommand::Close); [INFO] [stdout] 604 - return; [INFO] [stdout] 603 + ctx.send_viewport_cmd(ViewportCommand::Close); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/input.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | / if modifiers.ctrl { [INFO] [stdout] 138 | | if let Some(ch) = key_to_char(key) { [INFO] [stdout] 139 | | if ch.is_ascii_lowercase() { [INFO] [stdout] 140 | | return Some(vec![ch as u8 - b'a' + 1]); [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 137 ~ if modifiers.ctrl [INFO] [stdout] 138 ~ && let Some(ch) = key_to_char(key) { [INFO] [stdout] 139 | if ch.is_ascii_lowercase() { [INFO] [stdout] ... [INFO] [stdout] 149 | }; [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/input.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | / if let Some(txt) = text { [INFO] [stdout] 191 | | if !txt.is_empty() && !modifiers.ctrl { [INFO] [stdout] 192 | | if modifiers.alt { [INFO] [stdout] 193 | | let mut bytes = vec![0x1b]; [INFO] [stdout] ... | [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 190 ~ if let Some(txt) = text [INFO] [stdout] 191 ~ && !txt.is_empty() && !modifiers.ctrl { [INFO] [stdout] 192 | if modifiers.alt { [INFO] [stdout] ... [INFO] [stdout] 197 | return Some(txt.as_bytes().to_vec()); [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> crates/conch_app/src/app.rs:600:41 [INFO] [stdout] | [INFO] [stdout] 600 | for (_, session) in &win.sessions { session.shutdown(); } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 600 - for (_, session) in &win.sessions { session.shutdown(); } [INFO] [stdout] 600 + for session in win.sessions.values() { session.shutdown(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/menu_bar/egui_menu.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / if let Some(items) = items { [INFO] [stdout] 145 | | if !items.is_empty() { [INFO] [stdout] 146 | | ui.separator(); [INFO] [stdout] 147 | | for item in items { [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ if let Some(items) = items [INFO] [stdout] 145 ~ && !items.is_empty() { [INFO] [stdout] 146 | ui.separator(); [INFO] [stdout] ... [INFO] [stdout] 155 | } [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(col as u8).saturating_add(33)` is never greater than `255` and has therefore no effect [INFO] [stdout] --> crates/conch_app/src/mouse.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | let cx = (col as u8).saturating_add(33).min(255); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(col as u8).saturating_add(33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(row as u8).saturating_add(33)` is never greater than `255` and has therefore no effect [INFO] [stdout] --> crates/conch_app/src/mouse.rs:93:18 [INFO] [stdout] | [INFO] [stdout] 93 | let cy = (row as u8).saturating_add(33).min(255); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(row as u8).saturating_add(33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_app/src/mouse.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / pub fn handle_terminal_mouse( [INFO] [stdout] 108 | | ctx: &egui::Context, [INFO] [stdout] 109 | | response: &egui::Response, [INFO] [stdout] 110 | | size_info: &SizeInfo, [INFO] [stdout] ... | [INFO] [stdout] 115 | | scroll_sensitivity: f32, [INFO] [stdout] 116 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if mouse_mode { [INFO] [stdout] 164 | | if let Some(pos) = ctx.input(|i| i.pointer.hover_pos()) { [INFO] [stdout] 165 | | let (col, row) = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... | [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if mouse_mode [INFO] [stdout] 164 ~ && let Some(pos) = ctx.input(|i| i.pointer.hover_pos()) { [INFO] [stdout] 165 | let (col, row) = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 169 | write_fn(&bytes); [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(pos) = hover_pos { [INFO] [stdout] 221 | | if rect.contains(pos) { [INFO] [stdout] 222 | | let (col, row) = pixel_to_cell(pos, rect.min, size_info); [INFO] [stdout] ... | [INFO] [stdout] 272 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(pos) = hover_pos [INFO] [stdout] 221 ~ && rect.contains(pos) { [INFO] [stdout] 222 | let (col, row) = pixel_to_cell(pos, rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 270 | } [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | / if let Some(btn) = motion_button { [INFO] [stdout] 265 | | if response.dragged() { [INFO] [stdout] 266 | | let bytes = encode_mouse(btn, col, row, sgr, true); [INFO] [stdout] 267 | | write_fn(&bytes); [INFO] [stdout] 268 | | } [INFO] [stdout] 269 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if let Some(btn) = motion_button [INFO] [stdout] 265 ~ && response.dragged() { [INFO] [stdout] 266 | let bytes = encode_mouse(btn, col, row, sgr, true); [INFO] [stdout] 267 | write_fn(&bytes); [INFO] [stdout] 268 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | / if response.drag_started() { [INFO] [stdout] 276 | | if let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 277 | | let cell = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] 278 | | let click_count = selection.register_click(cell); [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 275 ~ if response.drag_started() [INFO] [stdout] 276 ~ && let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 277 | let cell = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 300 | } [INFO] [stdout] 301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | / if response.dragged() && selection.active { [INFO] [stdout] 304 | | if let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 305 | | selection.end = Some(pixel_to_cell(pos, response.rect.min, size_info)); [INFO] [stdout] 306 | | } [INFO] [stdout] 307 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if response.dragged() && selection.active [INFO] [stdout] 304 ~ && let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 305 | selection.end = Some(pixel_to_cell(pos, response.rect.min, size_info)); [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/notifications.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / if let Phase::Visible { until: Some(deadline) } = self.phase { [INFO] [stdout] 106 | | if Instant::now() >= deadline { [INFO] [stdout] 107 | | self.phase = Phase::Done; [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if let Phase::Visible { until: Some(deadline) } = self.phase [INFO] [stdout] 106 ~ && Instant::now() >= deadline { [INFO] [stdout] 107 | self.phase = Phase::Done; [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/sessions.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | tc.default_cursor_style = parse_style(&cfg.style); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `alacritty_terminal::term::Config { default_cursor_style: parse_style(&cfg.style), vi_mode_cursor_style: cfg.vi_mode_style.as_ref().map(parse_style), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/sessions.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | let mut tc = alacritty_terminal::term::Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/tab_bar.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / impl Default for TabBarState { [INFO] [stdout] 36 | | fn default() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | closing: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Default)] [INFO] [stdout] 30 | pub struct TabBarState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/bridge.rs:1089:5 [INFO] [stdout] | [INFO] [stdout] 1089 | / if let Some(map) = guard.as_mut() { [INFO] [stdout] 1090 | | if let Some(entry) = map.remove(&session_id) { [INFO] [stdout] 1091 | | unsafe { ((*entry.vtable).release)(entry.ctx) }; [INFO] [stdout] 1092 | | log::info!("deregister_sftp: removed SFTP for session {session_id}"); [INFO] [stdout] 1093 | | } [INFO] [stdout] 1094 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1089 ~ if let Some(map) = guard.as_mut() [INFO] [stdout] 1090 ~ && let Some(entry) = map.remove(&session_id) { [INFO] [stdout] 1091 | unsafe { ((*entry.vtable).release)(entry.ctx) }; [INFO] [stdout] 1092 | log::info!("deregister_sftp: removed SFTP for session {session_id}"); [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:112:1 [INFO] [stdout] | [INFO] [stdout] 112 | / impl Default for TerminalFrameCache { [INFO] [stdout] 113 | | fn default() -> Self { [INFO] [stdout] 114 | | Self { [INFO] [stdout] 115 | | cells: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 103 + #[derive(Default)] [INFO] [stdout] 104 | pub struct TerminalFrameCache { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn show_terminal( [INFO] [stdout] 127 | | ui: &mut egui::Ui, [INFO] [stdout] 128 | | term: &Arc>>, [INFO] [stdout] 129 | | cell_width: f32, [INFO] [stdout] ... | [INFO] [stdout] 135 | | frame_cache: &mut TerminalFrameCache, [INFO] [stdout] 136 | | ) -> (egui::Response, SizeInfo) { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Some((sel_start, sel_end)) = selection { [INFO] [stdout] 192 | | if is_in_selection(col, row, sel_start, sel_end) { [INFO] [stdout] 193 | | if let (Some(sel_bg), Some(sel_fg)) = (colors.selection_bg, colors.selection_text) { [INFO] [stdout] 194 | | bg = sel_bg; [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if let Some((sel_start, sel_end)) = selection [INFO] [stdout] 192 ~ && is_in_selection(col, row, sel_start, sel_end) { [INFO] [stdout] 193 | if let (Some(sel_bg), Some(sel_fg)) = (colors.selection_bg, colors.selection_text) { [INFO] [stdout] ... [INFO] [stdout] 198 | } [INFO] [stdout] 199 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:273:1 [INFO] [stdout] | [INFO] [stdout] 273 | / fn paint_cells_cached( [INFO] [stdout] 274 | | painter: &Painter, [INFO] [stdout] 275 | | cells: &[CellInfo], [INFO] [stdout] 276 | | cursor_pos: Option<(usize, usize, alacritty_terminal::vte::ansi::CursorShape)>, [INFO] [stdout] ... | [INFO] [stdout] 283 | | out_shapes: &mut Vec, [INFO] [stdout] 284 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:371:1 [INFO] [stdout] | [INFO] [stdout] 371 | / fn paint_char_cached( [INFO] [stdout] 372 | | painter: &Painter, [INFO] [stdout] 373 | | c: char, [INFO] [stdout] 374 | | pos: Pos2, [INFO] [stdout] ... | [INFO] [stdout] 381 | | out_shapes: &mut Vec, [INFO] [stdout] 382 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:404:1 [INFO] [stdout] | [INFO] [stdout] 404 | / fn draw_underline_cached( [INFO] [stdout] 405 | | painter: &Painter, [INFO] [stdout] 406 | | style: UnderlineStyle, [INFO] [stdout] 407 | | x_start: f32, [INFO] [stdout] ... | [INFO] [stdout] 412 | | out_shapes: &mut Vec, [INFO] [stdout] 413 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | / if let Some(prev_row) = last_row { [INFO] [stdout] 544 | | if row > prev_row { [INFO] [stdout] 545 | | result.push('\n'); [INFO] [stdout] 546 | | } [INFO] [stdout] 547 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Some(prev_row) = last_row [INFO] [stdout] 544 ~ && row > prev_row { [INFO] [stdout] 545 | result.push('\n'); [INFO] [stdout] 546 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/conch_app/src/window_state.rs:468:21 [INFO] [stdout] | [INFO] [stdout] 468 | / if session.custom_title.is_none() { [INFO] [stdout] 469 | | session.title = t; [INFO] [stdout] 470 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 467 ~ alacritty_terminal::event::Event::Title(t) [INFO] [stdout] 468 ~ if session.custom_title.is_none() => { [INFO] [stdout] 469 | session.title = t; [INFO] [stdout] 470 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> crates/conch_app/src/window_state.rs:502:29 [INFO] [stdout] | [INFO] [stdout] 502 | for (_, session) in &win.sessions { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 502 - for (_, session) in &win.sessions { [INFO] [stdout] 502 + for session in win.sessions.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:545:5 [INFO] [stdout] | [INFO] [stdout] 545 | / if let Some(text) = paste_text { [INFO] [stdout] 546 | | if !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | | session.write(text.as_bytes()); [INFO] [stdout] ... | [INFO] [stdout] 551 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 545 ~ if let Some(text) = paste_text [INFO] [stdout] 546 ~ && !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | session.write(text.as_bytes()); [INFO] [stdout] 549 | } [INFO] [stdout] 550 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | / if !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | | session.write(text.as_bytes()); [INFO] [stdout] 549 | | } [INFO] [stdout] 550 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ if !dialog_active && !any_widget_focused [INFO] [stdout] 547 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 548 | session.write(text.as_bytes()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:556:5 [INFO] [stdout] | [INFO] [stdout] 556 | / if !dropped.is_empty() && !dialog_active && !any_widget_focused { [INFO] [stdout] 557 | | if let Some(session) = win.active_session() { [INFO] [stdout] 558 | | let paths: Vec = dropped [INFO] [stdout] 559 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 568 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 556 ~ if !dropped.is_empty() && !dialog_active && !any_widget_focused [INFO] [stdout] 557 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 558 | let paths: Vec = dropped [INFO] [stdout] ... [INFO] [stdout] 566 | } [INFO] [stdout] 567 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:626:5 [INFO] [stdout] | [INFO] [stdout] 626 | / if win.has_focus && !show_in_window_menu { [INFO] [stdout] 627 | | if let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] 628 | | handle_menu_action(action, ctx, win, &cfg, shared); [INFO] [stdout] 629 | | } [INFO] [stdout] 630 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 626 ~ if win.has_focus && !show_in_window_menu [INFO] [stdout] 627 ~ && let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] 628 | handle_menu_action(action, ctx, win, &cfg, shared); [INFO] [stdout] 629 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/conch_app/src/window_state.rs:627:58 [INFO] [stdout] | [INFO] [stdout] 627 | if let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut shared.menu_bar_state.lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/conch_app/src/window_state.rs:637:13 [INFO] [stdout] | [INFO] [stdout] 637 | &mut *shared.plugin_manager.lock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut shared.plugin_manager.lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:766:33 [INFO] [stdout] | [INFO] [stdout] 766 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 767 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 768 | | ... let _ = reply.send(Some("true".to_string())); [INFO] [stdout] 769 | | ... } [INFO] [stdout] 770 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 766 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 767 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 768 | let _ = reply.send(Some("true".to_string())); [INFO] [stdout] 769 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:773:33 [INFO] [stdout] | [INFO] [stdout] 773 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 774 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 775 | | ... let _ = reply.send(None); [INFO] [stdout] 776 | | ... } [INFO] [stdout] 777 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 773 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 774 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 775 | let _ = reply.send(None); [INFO] [stdout] 776 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:780:33 [INFO] [stdout] | [INFO] [stdout] 780 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 781 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 782 | | ... let _ = reply.send(Some(pw)); [INFO] [stdout] 783 | | ... } [INFO] [stdout] 784 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 780 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 781 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 782 | let _ = reply.send(Some(pw)); [INFO] [stdout] 783 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:850:5 [INFO] [stdout] | [INFO] [stdout] 850 | / if close_tab_requested { [INFO] [stdout] 851 | | if let Some(id) = win.active_tab { [INFO] [stdout] 852 | | win.remove_session(id); [INFO] [stdout] 853 | | } [INFO] [stdout] 854 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 850 ~ if close_tab_requested [INFO] [stdout] 851 ~ && let Some(id) = win.active_tab { [INFO] [stdout] 852 | win.remove_session(id); [INFO] [stdout] 853 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:935:13 [INFO] [stdout] | [INFO] [stdout] 935 | / if let Some((start, end)) = win.selection.normalized() { [INFO] [stdout] 936 | | if let Some(session) = win.active_session() { [INFO] [stdout] 937 | | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] 938 | | if !text.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 942 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 935 ~ if let Some((start, end)) = win.selection.normalized() [INFO] [stdout] 936 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 937 | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] ... [INFO] [stdout] 940 | } [INFO] [stdout] 941 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1039:12 [INFO] [stdout] | [INFO] [stdout] 1039 | && win.active_session().map_or(false, |s| { [INFO] [stdout] | ____________^ [INFO] [stdout] 1040 | | s.term() [INFO] [stdout] 1041 | | .try_lock_unfair() [INFO] [stdout] 1042 | | .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] 1043 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1039 - && win.active_session().map_or(false, |s| { [INFO] [stdout] 1039 + && win.active_session().is_some_and(|s| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1040:13 [INFO] [stdout] | [INFO] [stdout] 1040 | / s.term() [INFO] [stdout] 1041 | | .try_lock_unfair() [INFO] [stdout] 1042 | | .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1042 - .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] 1042 + .is_some_and(|term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1254:17 [INFO] [stdout] | [INFO] [stdout] 1254 | / if !text_widget_focused { [INFO] [stdout] 1255 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1256 | | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] 1257 | | term.scroll_display(alacritty_terminal::grid::Scroll::Bottom); [INFO] [stdout] ... | [INFO] [stdout] 1261 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1253 ~ egui::Event::Text(text) [INFO] [stdout] 1254 ~ if !text_widget_focused => { [INFO] [stdout] 1255 | if let Some(session) = win.active_session() { [INFO] [stdout] ... [INFO] [stdout] 1260 | } [INFO] [stdout] 1261 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1102:21 [INFO] [stdout] | [INFO] [stdout] 1102 | / if let Some(idx) = tab_num { [INFO] [stdout] 1103 | | if let Some(&id) = win.tab_order.get(idx) { [INFO] [stdout] 1104 | | win.active_tab = Some(id); [INFO] [stdout] 1105 | | continue; [INFO] [stdout] 1106 | | } [INFO] [stdout] 1107 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1102 ~ if let Some(idx) = tab_num [INFO] [stdout] 1103 ~ && let Some(&id) = win.tab_order.get(idx) { [INFO] [stdout] 1104 | win.active_tab = Some(id); [INFO] [stdout] 1105 | continue; [INFO] [stdout] 1106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1111:17 [INFO] [stdout] | [INFO] [stdout] 1111 | / if let Some(ref kb) = shortcuts.new_window { [INFO] [stdout] 1112 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1113 | | win.pending_actions.push(WindowAction::SpawnNewWindow); [INFO] [stdout] 1114 | | continue; [INFO] [stdout] 1115 | | } [INFO] [stdout] 1116 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1111 ~ if let Some(ref kb) = shortcuts.new_window [INFO] [stdout] 1112 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1113 | win.pending_actions.push(WindowAction::SpawnNewWindow); [INFO] [stdout] 1114 | continue; [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1117:17 [INFO] [stdout] | [INFO] [stdout] 1117 | / if let Some(ref kb) = shortcuts.new_tab { [INFO] [stdout] 1118 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1119 | | let user_config = shared.config.lock().user_config.clone(); [INFO] [stdout] 1120 | | win.open_local_tab(&user_config); [INFO] [stdout] ... | [INFO] [stdout] 1123 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1117 ~ if let Some(ref kb) = shortcuts.new_tab [INFO] [stdout] 1118 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1119 | let user_config = shared.config.lock().user_config.clone(); [INFO] [stdout] 1120 | win.open_local_tab(&user_config); [INFO] [stdout] 1121 | continue; [INFO] [stdout] 1122 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1124:17 [INFO] [stdout] | [INFO] [stdout] 1124 | / if let Some(ref kb) = shortcuts.close_tab { [INFO] [stdout] 1125 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1126 | | if let Some(id) = win.active_tab { [INFO] [stdout] 1127 | | win.remove_session(id); [INFO] [stdout] ... | [INFO] [stdout] 1131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1124 ~ if let Some(ref kb) = shortcuts.close_tab [INFO] [stdout] 1125 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1126 | if let Some(id) = win.active_tab { [INFO] [stdout] ... [INFO] [stdout] 1129 | continue; [INFO] [stdout] 1130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1132:17 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(ref kb) = shortcuts.quit { [INFO] [stdout] 1133 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1134 | | win.pending_actions.push(WindowAction::Quit); [INFO] [stdout] 1135 | | continue; [INFO] [stdout] 1136 | | } [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1132 ~ if let Some(ref kb) = shortcuts.quit [INFO] [stdout] 1133 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1134 | win.pending_actions.push(WindowAction::Quit); [INFO] [stdout] 1135 | continue; [INFO] [stdout] 1136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1138:17 [INFO] [stdout] | [INFO] [stdout] 1138 | / if let Some(ref kb) = shortcuts.toggle_left_panel { [INFO] [stdout] 1139 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1140 | | win.left_panel_visible = !win.left_panel_visible; [INFO] [stdout] 1141 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1144 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1138 ~ if let Some(ref kb) = shortcuts.toggle_left_panel [INFO] [stdout] 1139 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1140 | win.left_panel_visible = !win.left_panel_visible; [INFO] [stdout] 1141 | win.auto_revealed_panel = None; [INFO] [stdout] 1142 | continue; [INFO] [stdout] 1143 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1145:17 [INFO] [stdout] | [INFO] [stdout] 1145 | / if let Some(ref kb) = shortcuts.toggle_right_panel { [INFO] [stdout] 1146 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1147 | | win.right_panel_visible = !win.right_panel_visible; [INFO] [stdout] 1148 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1145 ~ if let Some(ref kb) = shortcuts.toggle_right_panel [INFO] [stdout] 1146 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1147 | win.right_panel_visible = !win.right_panel_visible; [INFO] [stdout] 1148 | win.auto_revealed_panel = None; [INFO] [stdout] 1149 | continue; [INFO] [stdout] 1150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1152:17 [INFO] [stdout] | [INFO] [stdout] 1152 | / if let Some(ref kb) = shortcuts.toggle_bottom_panel { [INFO] [stdout] 1153 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1154 | | win.bottom_panel_visible = !win.bottom_panel_visible; [INFO] [stdout] 1155 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1158 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1152 ~ if let Some(ref kb) = shortcuts.toggle_bottom_panel [INFO] [stdout] 1153 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1154 | win.bottom_panel_visible = !win.bottom_panel_visible; [INFO] [stdout] 1155 | win.auto_revealed_panel = None; [INFO] [stdout] 1156 | continue; [INFO] [stdout] 1157 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1159:17 [INFO] [stdout] | [INFO] [stdout] 1159 | / if let Some(ref kb) = shortcuts.zen_mode { [INFO] [stdout] 1160 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1161 | | win.toggle_zen_mode(); [INFO] [stdout] 1162 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1165 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1159 ~ if let Some(ref kb) = shortcuts.zen_mode [INFO] [stdout] 1160 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1161 | win.toggle_zen_mode(); [INFO] [stdout] 1162 | win.auto_revealed_panel = None; [INFO] [stdout] 1163 | continue; [INFO] [stdout] 1164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1201:25 [INFO] [stdout] | [INFO] [stdout] 1201 | / if let Ok(json) = serde_json::to_string(&event) { [INFO] [stdout] 1202 | | if let Some(sender) = shared.plugin_bus.sender_for(&pkb.plugin_name) { [INFO] [stdout] 1203 | | let _ = sender [INFO] [stdout] 1204 | | .try_send(conch_plugin::bus::PluginMail::WidgetEvent { json }); [INFO] [stdout] 1205 | | } [INFO] [stdout] 1206 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1201 ~ if let Ok(json) = serde_json::to_string(&event) [INFO] [stdout] 1202 ~ && let Some(sender) = shared.plugin_bus.sender_for(&pkb.plugin_name) { [INFO] [stdout] 1203 | let _ = sender [INFO] [stdout] 1204 | .try_send(conch_plugin::bus::PluginMail::WidgetEvent { json }); [INFO] [stdout] 1205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1222:21 [INFO] [stdout] | [INFO] [stdout] 1222 | / if let Some((start, end)) = win.selection.normalized() { [INFO] [stdout] 1223 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1224 | | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] 1225 | | if !text.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 1229 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1222 ~ if let Some((start, end)) = win.selection.normalized() [INFO] [stdout] 1223 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1224 | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] ... [INFO] [stdout] 1227 | } [INFO] [stdout] 1228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1235:17 [INFO] [stdout] | [INFO] [stdout] 1235 | / if !text_widget_focused { [INFO] [stdout] 1236 | | if let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | | key, [INFO] [stdout] 1238 | | modifiers, [INFO] [stdout] ... | [INFO] [stdout] 1251 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1235 ~ if !text_widget_focused [INFO] [stdout] 1236 ~ && let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | key, [INFO] [stdout] ... [INFO] [stdout] 1249 | } [INFO] [stdout] 1250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1236:21 [INFO] [stdout] | [INFO] [stdout] 1236 | / if let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | | key, [INFO] [stdout] 1238 | | modifiers, [INFO] [stdout] 1239 | | None, [INFO] [stdout] ... | [INFO] [stdout] 1250 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1243 ~ ) [INFO] [stdout] 1244 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1245 | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] ... [INFO] [stdout] 1248 | session.write(&bytes); [INFO] [stdout] 1249 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1254:17 [INFO] [stdout] | [INFO] [stdout] 1254 | / if !text_widget_focused { [INFO] [stdout] 1255 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1256 | | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] 1257 | | term.scroll_display(alacritty_terminal::grid::Scroll::Bottom); [INFO] [stdout] ... | [INFO] [stdout] 1261 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1254 ~ if !text_widget_focused [INFO] [stdout] 1255 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1256 | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] ... [INFO] [stdout] 1259 | session.write(text.as_bytes()); [INFO] [stdout] 1260 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | / if !self.active.contains_key(&viewport_id) { [INFO] [stdout] 296 | | if let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | | if !queue.is_empty() { [INFO] [stdout] 298 | | let request = queue.remove(0); [INFO] [stdout] ... | [INFO] [stdout] 306 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ if !self.active.contains_key(&viewport_id) [INFO] [stdout] 296 ~ && let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | if !queue.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 304 | } [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | / if let Some(queue) = self.pending.get_mut(&viewport_id) { [INFO] [stdout] 297 | | if !queue.is_empty() { [INFO] [stdout] 298 | | let request = queue.remove(0); [INFO] [stdout] 299 | | log::info!( [INFO] [stdout] ... | [INFO] [stdout] 305 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 296 ~ if let Some(queue) = self.pending.get_mut(&viewport_id) [INFO] [stdout] 297 ~ && !queue.is_empty() { [INFO] [stdout] 298 | let request = queue.remove(0); [INFO] [stdout] ... [INFO] [stdout] 303 | self.active.insert(viewport_id, activate_request(request)); [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / if should_close { [INFO] [stdout] 347 | | if let Some(dialog) = self.active.remove(&viewport_id) { [INFO] [stdout] 348 | | send_dialog_result(dialog); [INFO] [stdout] 349 | | } [INFO] [stdout] 350 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 346 ~ if should_close [INFO] [stdout] 347 ~ && let Some(dialog) = self.active.remove(&viewport_id) { [INFO] [stdout] 348 | send_dialog_result(dialog); [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:770:45 [INFO] [stdout] | [INFO] [stdout] 770 | / ... if resp.clicked() { [INFO] [stdout] 771 | | ... if let Some(FormValue::Text(val)) = [INFO] [stdout] 772 | | ... values.get_mut(id) [INFO] [stdout] ... | [INFO] [stdout] 776 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 770 ~ if resp.clicked() [INFO] [stdout] 771 ~ && let Some(FormValue::Text(val)) = [INFO] [stdout] 772 | values.get_mut(id) [INFO] [stdout] 773 | { [INFO] [stdout] 774 | *val = row_data.id.clone(); [INFO] [stdout] 775 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:876:39 [INFO] [stdout] | [INFO] [stdout] 876 | ... .join(&dir[2..]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:873:40 [INFO] [stdout] | [INFO] [stdout] 873 | let expanded = if dir.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 873 ~ let expanded = if let Some() = dir.strip_prefix("~/") { [INFO] [stdout] 874 | dirs::home_dir() [INFO] [stdout] 875 | .unwrap_or_default() [INFO] [stdout] 876 ~ .join() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/dialogs.rs:1076:9 [INFO] [stdout] | [INFO] [stdout] 1076 | / if let Some(rect) = area_rect { [INFO] [stdout] 1077 | | if !rect.contains(ctx.input(|i| i.pointer.hover_pos().unwrap_or_default())) { [INFO] [stdout] 1078 | | close = true; [INFO] [stdout] 1079 | | } [INFO] [stdout] 1080 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1076 ~ if let Some(rect) = area_rect [INFO] [stdout] 1077 ~ && !rect.contains(ctx.input(|i| i.pointer.hover_pos().unwrap_or_default())) { [INFO] [stdout] 1078 | close = true; [INFO] [stdout] 1079 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:431:25 [INFO] [stdout] | [INFO] [stdout] 431 | / if let Some(ic) = icon_cache { [INFO] [stdout] 432 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | | if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] ... | [INFO] [stdout] 437 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 431 ~ if let Some(ic) = icon_cache [INFO] [stdout] 432 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 | } [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:432:29 [INFO] [stdout] | [INFO] [stdout] 432 | / ... if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 433 | | ... if ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | | ... events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 | | ... } [INFO] [stdout] 436 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 432 ~ if let Some(img) = ic.image_by_name(icon_name, dark_mode) [INFO] [stdout] 433 ~ && ui.add(egui::ImageButton::new(img).frame(false)).clicked() { [INFO] [stdout] 434 | events.push(WidgetEvent::ButtonClick { id: id.clone() }); [INFO] [stdout] 435 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:443:29 [INFO] [stdout] | [INFO] [stdout] 443 | / ... if let Some(ic) = icon_cache { [INFO] [stdout] 444 | | ... if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 445 | | ... ui.add(img); [INFO] [stdout] 446 | | ... } [INFO] [stdout] 447 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ if let Some(ic) = icon_cache [INFO] [stdout] 444 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 445 | ui.add(img); [INFO] [stdout] 446 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:850:1 [INFO] [stdout] | [INFO] [stdout] 850 | / fn render_tree_node( [INFO] [stdout] 851 | | ui: &mut egui::Ui, [INFO] [stdout] 852 | | tree_id: &str, [INFO] [stdout] 853 | | node: &conch_plugin_sdk::widgets::TreeNode, [INFO] [stdout] ... | [INFO] [stdout] 859 | | icon_cache: Option<&IconCache>, [INFO] [stdout] 860 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:882:17 [INFO] [stdout] | [INFO] [stdout] 882 | / if let Some(ic) = icon_cache { [INFO] [stdout] 883 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 884 | | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] 885 | | Some("blue") => Some(theme.accent), [INFO] [stdout] ... | [INFO] [stdout] 896 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 882 ~ if let Some(ic) = icon_cache [INFO] [stdout] 883 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 884 | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] ... [INFO] [stdout] 894 | ui.add(img); [INFO] [stdout] 895 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:967:17 [INFO] [stdout] | [INFO] [stdout] 967 | / if let Some(ic) = icon_cache { [INFO] [stdout] 968 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 969 | | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] 970 | | Some("blue") => Some(theme.accent), [INFO] [stdout] ... | [INFO] [stdout] 981 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 967 ~ if let Some(ic) = icon_cache [INFO] [stdout] 968 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 969 | let icon_color = match node.icon_color.as_deref() { [INFO] [stdout] ... [INFO] [stdout] 979 | ui.add(img); [INFO] [stdout] 980 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:855:5 [INFO] [stdout] | [INFO] [stdout] 855 | depth: usize, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:950:25 [INFO] [stdout] | [INFO] [stdout] 950 | depth + 1, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:857:5 [INFO] [stdout] | [INFO] [stdout] 857 | text_input_state: &mut HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_text_input_state` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:952:25 [INFO] [stdout] | [INFO] [stdout] 952 | text_input_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1053:21 [INFO] [stdout] | [INFO] [stdout] 1053 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1054 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1055 | | ui.add(img); [INFO] [stdout] 1056 | | } [INFO] [stdout] 1057 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1053 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1054 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1055 | ui.add(img); [INFO] [stdout] 1056 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1108:17 [INFO] [stdout] | [INFO] [stdout] 1108 | / if let Some(icon_name) = icon { [INFO] [stdout] 1109 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1110 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | | let resp = ui [INFO] [stdout] ... | [INFO] [stdout] 1121 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1108 ~ if let Some(icon_name) = icon [INFO] [stdout] 1109 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1110 | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] ... [INFO] [stdout] 1119 | } [INFO] [stdout] 1120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1109:21 [INFO] [stdout] | [INFO] [stdout] 1109 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1110 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | | let resp = ui [INFO] [stdout] 1112 | | .add_enabled(is_enabled, egui::ImageButton::new(img).frame(false)); [INFO] [stdout] ... | [INFO] [stdout] 1120 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1109 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1110 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1111 | let resp = ui [INFO] [stdout] ... [INFO] [stdout] 1118 | } [INFO] [stdout] 1119 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1125:17 [INFO] [stdout] | [INFO] [stdout] 1125 | / if let Some(icon_name) = icon { [INFO] [stdout] 1126 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1127 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | | ui.add(img); [INFO] [stdout] ... | [INFO] [stdout] 1131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1125 ~ if let Some(icon_name) = icon [INFO] [stdout] 1126 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1127 | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | ui.add(img); [INFO] [stdout] 1129 | } [INFO] [stdout] 1130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1126:21 [INFO] [stdout] | [INFO] [stdout] 1126 | / if let Some(ic) = icon_cache { [INFO] [stdout] 1127 | | if let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | | ui.add(img); [INFO] [stdout] 1129 | | } [INFO] [stdout] 1130 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1126 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1127 ~ && let Some(img) = ic.image_by_name(icon_name, dark_mode) { [INFO] [stdout] 1128 | ui.add(img); [INFO] [stdout] 1129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1239:1 [INFO] [stdout] | [INFO] [stdout] 1239 | / fn render_table( [INFO] [stdout] 1240 | | ui: &mut egui::Ui, [INFO] [stdout] 1241 | | table_id: &str, [INFO] [stdout] 1242 | | columns: &[TableColumn], [INFO] [stdout] ... | [INFO] [stdout] 1249 | | icon_cache: Option<&IconCache>, [INFO] [stdout] 1250 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1440:25 [INFO] [stdout] | [INFO] [stdout] 1440 | / if let Some(name) = icon_name { [INFO] [stdout] 1441 | | if let Some(ic) = icon_cache { [INFO] [stdout] 1442 | | if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | | let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] ... | [INFO] [stdout] 1451 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1440 ~ if let Some(name) = icon_name [INFO] [stdout] 1441 ~ && let Some(ic) = icon_cache { [INFO] [stdout] 1442 | if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] ... [INFO] [stdout] 1449 | } [INFO] [stdout] 1450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/panel_renderer.rs:1441:29 [INFO] [stdout] | [INFO] [stdout] 1441 | / ... if let Some(ic) = icon_cache { [INFO] [stdout] 1442 | | ... if let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | | ... let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] 1444 | | ... egui::pos2(text_x, cell_rect.center().y - icon_size / 2.0), [INFO] [stdout] ... | [INFO] [stdout] 1450 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1441 ~ if let Some(ic) = icon_cache [INFO] [stdout] 1442 ~ && let Some(img) = ic.image_by_name(name, dark_mode) { [INFO] [stdout] 1443 | let icon_rect = egui::Rect::from_min_size( [INFO] [stdout] ... [INFO] [stdout] 1448 | text_x += icon_size + 4.0; [INFO] [stdout] 1449 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Ok(exe) = std::env::current_exe() { [INFO] [stdout] 34 | | if let Some(exe_dir) = exe.parent() { [INFO] [stdout] 35 | | // Same directory as the binary (Windows, portable builds). [INFO] [stdout] 36 | | dirs.push(exe_dir.to_path_buf()); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Ok(exe) = std::env::current_exe() [INFO] [stdout] 34 ~ && let Some(exe_dir) = exe.parent() { [INFO] [stdout] 35 | // Same directory as the binary (Windows, portable builds). [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | / if plugins_cfg.native { [INFO] [stdout] 83 | | if let Ok(paths) = conch_plugin::native::library::discover_library_paths(dir) { [INFO] [stdout] 84 | | for path in paths { [INFO] [stdout] 85 | | match unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ if plugins_cfg.native [INFO] [stdout] 83 ~ && let Ok(paths) = conch_plugin::native::library::discover_library_paths(dir) { [INFO] [stdout] 84 | for path in paths { [INFO] [stdout] ... [INFO] [stdout] 100 | } [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | / match unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] 86 | | Ok(lib) => { [INFO] [stdout] 87 | | let meta = unsafe { lib.read_info() }; [INFO] [stdout] 88 | | entries.push(PluginEntry { [INFO] [stdout] ... | [INFO] [stdout] 98 | | Err(_) => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Ok(lib) = unsafe { conch_plugin::native::PluginLibrary::load(&path) } { [INFO] [stdout] 86 + let meta = unsafe { lib.read_info() }; [INFO] [stdout] 87 + entries.push(PluginEntry { [INFO] [stdout] 88 + name: meta.name, [INFO] [stdout] 89 + description: meta.description, [INFO] [stdout] 90 + version: meta.version, [INFO] [stdout] 91 + plugin_type: meta.plugin_type, [INFO] [stdout] 92 + panel_location: meta.panel_location, [INFO] [stdout] 93 + source: PluginSource::Native, [INFO] [stdout] 94 + path, [INFO] [stdout] 95 + }); [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / if plugins_cfg.java { [INFO] [stdout] 106 | | if let Some(mgr) = &mut self.java_plugin_mgr { [INFO] [stdout] 107 | | for (path, meta) in mgr.discover(dir) { [INFO] [stdout] 108 | | entries.push(PluginEntry { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if plugins_cfg.java [INFO] [stdout] 106 ~ && let Some(mgr) = &mut self.java_plugin_mgr { [INFO] [stdout] 107 | for (path, meta) in mgr.discover(dir) { [INFO] [stdout] ... [INFO] [stdout] 117 | } [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:278:28 [INFO] [stdout] | [INFO] [stdout] 278 | if self.java_plugin_mgr.as_ref().map_or(false, |m| m.is_loaded(&name)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 278 - if self.java_plugin_mgr.as_ref().map_or(false, |m| m.is_loaded(&name)) { [INFO] [stdout] 278 + if self.java_plugin_mgr.as_ref().is_some_and(|m| m.is_loaded(&name)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:402:13 [INFO] [stdout] | [INFO] [stdout] 402 | / if !force_set.contains(&plugin_name) { [INFO] [stdout] 403 | | if let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 402 ~ if !force_set.contains(&plugin_name) [INFO] [stdout] 403 ~ && let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | continue; [INFO] [stdout] 406 | } [INFO] [stdout] 407 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_lifecycle.rs:403:17 [INFO] [stdout] | [INFO] [stdout] 403 | / if let Some(last) = self.render_last_request.get(&plugin_name) { [INFO] [stdout] 404 | | if now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | | continue; [INFO] [stdout] 406 | | } [INFO] [stdout] 407 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 403 ~ if let Some(last) = self.render_last_request.get(&plugin_name) [INFO] [stdout] 404 ~ && now.duration_since(*last) < Self::RENDER_POLL_INTERVAL { [INFO] [stdout] 405 | continue; [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/host/plugin_manager_ui.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | / impl Default for PluginManagerState { [INFO] [stdout] 66 | | fn default() -> Self { [INFO] [stdout] 67 | | Self { [INFO] [stdout] 68 | | plugins: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 45 + #[derive(Default)] [INFO] [stdout] 46 | pub struct PluginManagerState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (15/7) [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | / pub(crate) fn render_plugin_panels_for_ctx( [INFO] [stdout] 74 | | ctx: &egui::Context, [INFO] [stdout] 75 | | panel_registry: &Arc>, [INFO] [stdout] 76 | | plugin_bus: &Arc, [INFO] [stdout] ... | [INFO] [stdout] 88 | | viewport_id: egui::ViewportId, [INFO] [stdout] 89 | | ) -> PanelSizes { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/host/plugin_panels.rs:368:5 [INFO] [stdout] | [INFO] [stdout] 368 | / if let Some(ref e) = entry { [INFO] [stdout] 369 | | if (e.level == 0 || e.level == 3) [INFO] [stdout] 370 | | && e.progress < 0.0 [INFO] [stdout] 371 | | && e.timestamp.elapsed().as_secs() > 10 [INFO] [stdout] ... | [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 368 ~ if let Some(ref e) = entry [INFO] [stdout] 369 ~ && (e.level == 0 || e.level == 3) [INFO] [stdout] 370 | && e.progress < 0.0 [INFO] [stdout] ... [INFO] [stdout] 374 | entry = None; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/input.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | / if modifiers.ctrl { [INFO] [stdout] 138 | | if let Some(ch) = key_to_char(key) { [INFO] [stdout] 139 | | if ch.is_ascii_lowercase() { [INFO] [stdout] 140 | | return Some(vec![ch as u8 - b'a' + 1]); [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 137 ~ if modifiers.ctrl [INFO] [stdout] 138 ~ && let Some(ch) = key_to_char(key) { [INFO] [stdout] 139 | if ch.is_ascii_lowercase() { [INFO] [stdout] ... [INFO] [stdout] 149 | }; [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/input.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | / if let Some(txt) = text { [INFO] [stdout] 191 | | if !txt.is_empty() && !modifiers.ctrl { [INFO] [stdout] 192 | | if modifiers.alt { [INFO] [stdout] 193 | | let mut bytes = vec![0x1b]; [INFO] [stdout] ... | [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 190 ~ if let Some(txt) = text [INFO] [stdout] 191 ~ && !txt.is_empty() && !modifiers.ctrl { [INFO] [stdout] 192 | if modifiers.alt { [INFO] [stdout] ... [INFO] [stdout] 197 | return Some(txt.as_bytes().to_vec()); [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/menu_bar/egui_menu.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / if let Some(items) = items { [INFO] [stdout] 145 | | if !items.is_empty() { [INFO] [stdout] 146 | | ui.separator(); [INFO] [stdout] 147 | | for item in items { [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ if let Some(items) = items [INFO] [stdout] 145 ~ && !items.is_empty() { [INFO] [stdout] 146 | ui.separator(); [INFO] [stdout] ... [INFO] [stdout] 155 | } [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(col as u8).saturating_add(33)` is never greater than `255` and has therefore no effect [INFO] [stdout] --> crates/conch_app/src/mouse.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | let cx = (col as u8).saturating_add(33).min(255); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(col as u8).saturating_add(33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(row as u8).saturating_add(33)` is never greater than `255` and has therefore no effect [INFO] [stdout] --> crates/conch_app/src/mouse.rs:93:18 [INFO] [stdout] | [INFO] [stdout] 93 | let cy = (row as u8).saturating_add(33).min(255); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(row as u8).saturating_add(33)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_app/src/mouse.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | / pub fn handle_terminal_mouse( [INFO] [stdout] 108 | | ctx: &egui::Context, [INFO] [stdout] 109 | | response: &egui::Response, [INFO] [stdout] 110 | | size_info: &SizeInfo, [INFO] [stdout] ... | [INFO] [stdout] 115 | | scroll_sensitivity: f32, [INFO] [stdout] 116 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if mouse_mode { [INFO] [stdout] 164 | | if let Some(pos) = ctx.input(|i| i.pointer.hover_pos()) { [INFO] [stdout] 165 | | let (col, row) = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... | [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if mouse_mode [INFO] [stdout] 164 ~ && let Some(pos) = ctx.input(|i| i.pointer.hover_pos()) { [INFO] [stdout] 165 | let (col, row) = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 169 | write_fn(&bytes); [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(pos) = hover_pos { [INFO] [stdout] 221 | | if rect.contains(pos) { [INFO] [stdout] 222 | | let (col, row) = pixel_to_cell(pos, rect.min, size_info); [INFO] [stdout] ... | [INFO] [stdout] 272 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(pos) = hover_pos [INFO] [stdout] 221 ~ && rect.contains(pos) { [INFO] [stdout] 222 | let (col, row) = pixel_to_cell(pos, rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 270 | } [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | / if let Some(btn) = motion_button { [INFO] [stdout] 265 | | if response.dragged() { [INFO] [stdout] 266 | | let bytes = encode_mouse(btn, col, row, sgr, true); [INFO] [stdout] 267 | | write_fn(&bytes); [INFO] [stdout] 268 | | } [INFO] [stdout] 269 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if let Some(btn) = motion_button [INFO] [stdout] 265 ~ && response.dragged() { [INFO] [stdout] 266 | let bytes = encode_mouse(btn, col, row, sgr, true); [INFO] [stdout] 267 | write_fn(&bytes); [INFO] [stdout] 268 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | / if response.drag_started() { [INFO] [stdout] 276 | | if let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 277 | | let cell = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] 278 | | let click_count = selection.register_click(cell); [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 275 ~ if response.drag_started() [INFO] [stdout] 276 ~ && let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 277 | let cell = pixel_to_cell(pos, response.rect.min, size_info); [INFO] [stdout] ... [INFO] [stdout] 300 | } [INFO] [stdout] 301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/mouse.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | / if response.dragged() && selection.active { [INFO] [stdout] 304 | | if let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 305 | | selection.end = Some(pixel_to_cell(pos, response.rect.min, size_info)); [INFO] [stdout] 306 | | } [INFO] [stdout] 307 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if response.dragged() && selection.active [INFO] [stdout] 304 ~ && let Some(pos) = response.interact_pointer_pos() { [INFO] [stdout] 305 | selection.end = Some(pixel_to_cell(pos, response.rect.min, size_info)); [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | sel.start = Some((5, 3)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((5, 3)), end: Some((5, 3)), click_count: 1, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 404 | sel.start = Some((5, 3)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((5, 3)), end: Some((5, 3)), click_count: 2, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:413:9 [INFO] [stdout] | [INFO] [stdout] 413 | sel.start = Some((10, 5)); // col=10, row=5 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((10, 5)), end: Some((3, 2)), click_count: 1, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:412:9 [INFO] [stdout] | [INFO] [stdout] 412 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | sel.start = Some((10, 3)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((10, 3)), end: Some((2, 3)), click_count: 1, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | sel.start = Some((2, 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((2, 1)), end: Some((10, 5)), click_count: 1, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/mouse.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | sel.start = Some((1, 2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `mouse::Selection { start: Some((1, 2)), end: Some((3, 4)), active: true, click_count: 2, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/mouse.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | let mut sel = Selection::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/notifications.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | / if let Phase::Visible { until: Some(deadline) } = self.phase { [INFO] [stdout] 106 | | if Instant::now() >= deadline { [INFO] [stdout] 107 | | self.phase = Phase::Done; [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if let Phase::Visible { until: Some(deadline) } = self.phase [INFO] [stdout] 106 ~ && Instant::now() >= deadline { [INFO] [stdout] 107 | self.phase = Phase::Done; [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/sessions.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | tc.default_cursor_style = parse_style(&cfg.style); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `alacritty_terminal::term::Config { default_cursor_style: parse_style(&cfg.style), vi_mode_cursor_style: cfg.vi_mode_style.as_ref().map(parse_style), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/sessions.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | let mut tc = alacritty_terminal::term::Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/tab_bar.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / impl Default for TabBarState { [INFO] [stdout] 36 | | fn default() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | closing: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Default)] [INFO] [stdout] 30 | pub struct TabBarState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:112:1 [INFO] [stdout] | [INFO] [stdout] 112 | / impl Default for TerminalFrameCache { [INFO] [stdout] 113 | | fn default() -> Self { [INFO] [stdout] 114 | | Self { [INFO] [stdout] 115 | | cells: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 103 + #[derive(Default)] [INFO] [stdout] 104 | pub struct TerminalFrameCache { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn show_terminal( [INFO] [stdout] 127 | | ui: &mut egui::Ui, [INFO] [stdout] 128 | | term: &Arc>>, [INFO] [stdout] 129 | | cell_width: f32, [INFO] [stdout] ... | [INFO] [stdout] 135 | | frame_cache: &mut TerminalFrameCache, [INFO] [stdout] 136 | | ) -> (egui::Response, SizeInfo) { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Some((sel_start, sel_end)) = selection { [INFO] [stdout] 192 | | if is_in_selection(col, row, sel_start, sel_end) { [INFO] [stdout] 193 | | if let (Some(sel_bg), Some(sel_fg)) = (colors.selection_bg, colors.selection_text) { [INFO] [stdout] 194 | | bg = sel_bg; [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if let Some((sel_start, sel_end)) = selection [INFO] [stdout] 192 ~ && is_in_selection(col, row, sel_start, sel_end) { [INFO] [stdout] 193 | if let (Some(sel_bg), Some(sel_fg)) = (colors.selection_bg, colors.selection_text) { [INFO] [stdout] ... [INFO] [stdout] 198 | } [INFO] [stdout] 199 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:273:1 [INFO] [stdout] | [INFO] [stdout] 273 | / fn paint_cells_cached( [INFO] [stdout] 274 | | painter: &Painter, [INFO] [stdout] 275 | | cells: &[CellInfo], [INFO] [stdout] 276 | | cursor_pos: Option<(usize, usize, alacritty_terminal::vte::ansi::CursorShape)>, [INFO] [stdout] ... | [INFO] [stdout] 283 | | out_shapes: &mut Vec, [INFO] [stdout] 284 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:371:1 [INFO] [stdout] | [INFO] [stdout] 371 | / fn paint_char_cached( [INFO] [stdout] 372 | | painter: &Painter, [INFO] [stdout] 373 | | c: char, [INFO] [stdout] 374 | | pos: Pos2, [INFO] [stdout] ... | [INFO] [stdout] 381 | | out_shapes: &mut Vec, [INFO] [stdout] 382 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:404:1 [INFO] [stdout] | [INFO] [stdout] 404 | / fn draw_underline_cached( [INFO] [stdout] 405 | | painter: &Painter, [INFO] [stdout] 406 | | style: UnderlineStyle, [INFO] [stdout] 407 | | x_start: f32, [INFO] [stdout] ... | [INFO] [stdout] 412 | | out_shapes: &mut Vec, [INFO] [stdout] 413 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/terminal/widget.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | / if let Some(prev_row) = last_row { [INFO] [stdout] 544 | | if row > prev_row { [INFO] [stdout] 545 | | result.push('\n'); [INFO] [stdout] 546 | | } [INFO] [stdout] 547 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Some(prev_row) = last_row [INFO] [stdout] 544 ~ && row > prev_row { [INFO] [stdout] 545 | result.push('\n'); [INFO] [stdout] 546 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/conch_app/src/window_state.rs:468:21 [INFO] [stdout] | [INFO] [stdout] 468 | / if session.custom_title.is_none() { [INFO] [stdout] 469 | | session.title = t; [INFO] [stdout] 470 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 467 ~ alacritty_terminal::event::Event::Title(t) [INFO] [stdout] 468 ~ if session.custom_title.is_none() => { [INFO] [stdout] 469 | session.title = t; [INFO] [stdout] 470 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> crates/conch_app/src/window_state.rs:502:29 [INFO] [stdout] | [INFO] [stdout] 502 | for (_, session) in &win.sessions { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 502 - for (_, session) in &win.sessions { [INFO] [stdout] 502 + for session in win.sessions.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:545:5 [INFO] [stdout] | [INFO] [stdout] 545 | / if let Some(text) = paste_text { [INFO] [stdout] 546 | | if !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | | session.write(text.as_bytes()); [INFO] [stdout] ... | [INFO] [stdout] 551 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 545 ~ if let Some(text) = paste_text [INFO] [stdout] 546 ~ && !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | session.write(text.as_bytes()); [INFO] [stdout] 549 | } [INFO] [stdout] 550 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | / if !dialog_active && !any_widget_focused { [INFO] [stdout] 547 | | if let Some(session) = win.active_session() { [INFO] [stdout] 548 | | session.write(text.as_bytes()); [INFO] [stdout] 549 | | } [INFO] [stdout] 550 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ if !dialog_active && !any_widget_focused [INFO] [stdout] 547 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 548 | session.write(text.as_bytes()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:556:5 [INFO] [stdout] | [INFO] [stdout] 556 | / if !dropped.is_empty() && !dialog_active && !any_widget_focused { [INFO] [stdout] 557 | | if let Some(session) = win.active_session() { [INFO] [stdout] 558 | | let paths: Vec = dropped [INFO] [stdout] 559 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 568 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 556 ~ if !dropped.is_empty() && !dialog_active && !any_widget_focused [INFO] [stdout] 557 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 558 | let paths: Vec = dropped [INFO] [stdout] ... [INFO] [stdout] 566 | } [INFO] [stdout] 567 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:626:5 [INFO] [stdout] | [INFO] [stdout] 626 | / if win.has_focus && !show_in_window_menu { [INFO] [stdout] 627 | | if let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] 628 | | handle_menu_action(action, ctx, win, &cfg, shared); [INFO] [stdout] 629 | | } [INFO] [stdout] 630 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 626 ~ if win.has_focus && !show_in_window_menu [INFO] [stdout] 627 ~ && let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] 628 | handle_menu_action(action, ctx, win, &cfg, shared); [INFO] [stdout] 629 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/conch_app/src/window_state.rs:627:58 [INFO] [stdout] | [INFO] [stdout] 627 | if let Some(action) = crate::menu_bar::show(ctx, &mut *shared.menu_bar_state.lock()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut shared.menu_bar_state.lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> crates/conch_app/src/window_state.rs:637:13 [INFO] [stdout] | [INFO] [stdout] 637 | &mut *shared.plugin_manager.lock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut shared.plugin_manager.lock()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:766:33 [INFO] [stdout] | [INFO] [stdout] 766 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 767 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 768 | | ... let _ = reply.send(Some("true".to_string())); [INFO] [stdout] 769 | | ... } [INFO] [stdout] 770 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 766 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 767 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 768 | let _ = reply.send(Some("true".to_string())); [INFO] [stdout] 769 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:773:33 [INFO] [stdout] | [INFO] [stdout] 773 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 774 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 775 | | ... let _ = reply.send(None); [INFO] [stdout] 776 | | ... } [INFO] [stdout] 777 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 773 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 774 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 775 | let _ = reply.send(None); [INFO] [stdout] 776 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:780:33 [INFO] [stdout] | [INFO] [stdout] 780 | / ... if let Some(prompt) = session.prompt.take() { [INFO] [stdout] 781 | | ... if let Some(reply) = prompt.reply { [INFO] [stdout] 782 | | ... let _ = reply.send(Some(pw)); [INFO] [stdout] 783 | | ... } [INFO] [stdout] 784 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 780 ~ if let Some(prompt) = session.prompt.take() [INFO] [stdout] 781 ~ && let Some(reply) = prompt.reply { [INFO] [stdout] 782 | let _ = reply.send(Some(pw)); [INFO] [stdout] 783 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:850:5 [INFO] [stdout] | [INFO] [stdout] 850 | / if close_tab_requested { [INFO] [stdout] 851 | | if let Some(id) = win.active_tab { [INFO] [stdout] 852 | | win.remove_session(id); [INFO] [stdout] 853 | | } [INFO] [stdout] 854 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 850 ~ if close_tab_requested [INFO] [stdout] 851 ~ && let Some(id) = win.active_tab { [INFO] [stdout] 852 | win.remove_session(id); [INFO] [stdout] 853 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:935:13 [INFO] [stdout] | [INFO] [stdout] 935 | / if let Some((start, end)) = win.selection.normalized() { [INFO] [stdout] 936 | | if let Some(session) = win.active_session() { [INFO] [stdout] 937 | | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] 938 | | if !text.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 942 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 935 ~ if let Some((start, end)) = win.selection.normalized() [INFO] [stdout] 936 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 937 | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] ... [INFO] [stdout] 940 | } [INFO] [stdout] 941 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1039:12 [INFO] [stdout] | [INFO] [stdout] 1039 | && win.active_session().map_or(false, |s| { [INFO] [stdout] | ____________^ [INFO] [stdout] 1040 | | s.term() [INFO] [stdout] 1041 | | .try_lock_unfair() [INFO] [stdout] 1042 | | .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] 1043 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1039 - && win.active_session().map_or(false, |s| { [INFO] [stdout] 1039 + && win.active_session().is_some_and(|s| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1040:13 [INFO] [stdout] | [INFO] [stdout] 1040 | / s.term() [INFO] [stdout] 1041 | | .try_lock_unfair() [INFO] [stdout] 1042 | | .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1042 - .map_or(false, |term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] 1042 + .is_some_and(|term| term.mode().contains(TermMode::APP_CURSOR)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1254:17 [INFO] [stdout] | [INFO] [stdout] 1254 | / if !text_widget_focused { [INFO] [stdout] 1255 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1256 | | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] 1257 | | term.scroll_display(alacritty_terminal::grid::Scroll::Bottom); [INFO] [stdout] ... | [INFO] [stdout] 1261 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1253 ~ egui::Event::Text(text) [INFO] [stdout] 1254 ~ if !text_widget_focused => { [INFO] [stdout] 1255 | if let Some(session) = win.active_session() { [INFO] [stdout] ... [INFO] [stdout] 1260 | } [INFO] [stdout] 1261 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1102:21 [INFO] [stdout] | [INFO] [stdout] 1102 | / if let Some(idx) = tab_num { [INFO] [stdout] 1103 | | if let Some(&id) = win.tab_order.get(idx) { [INFO] [stdout] 1104 | | win.active_tab = Some(id); [INFO] [stdout] 1105 | | continue; [INFO] [stdout] 1106 | | } [INFO] [stdout] 1107 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1102 ~ if let Some(idx) = tab_num [INFO] [stdout] 1103 ~ && let Some(&id) = win.tab_order.get(idx) { [INFO] [stdout] 1104 | win.active_tab = Some(id); [INFO] [stdout] 1105 | continue; [INFO] [stdout] 1106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1111:17 [INFO] [stdout] | [INFO] [stdout] 1111 | / if let Some(ref kb) = shortcuts.new_window { [INFO] [stdout] 1112 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1113 | | win.pending_actions.push(WindowAction::SpawnNewWindow); [INFO] [stdout] 1114 | | continue; [INFO] [stdout] 1115 | | } [INFO] [stdout] 1116 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1111 ~ if let Some(ref kb) = shortcuts.new_window [INFO] [stdout] 1112 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1113 | win.pending_actions.push(WindowAction::SpawnNewWindow); [INFO] [stdout] 1114 | continue; [INFO] [stdout] 1115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1117:17 [INFO] [stdout] | [INFO] [stdout] 1117 | / if let Some(ref kb) = shortcuts.new_tab { [INFO] [stdout] 1118 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1119 | | let user_config = shared.config.lock().user_config.clone(); [INFO] [stdout] 1120 | | win.open_local_tab(&user_config); [INFO] [stdout] ... | [INFO] [stdout] 1123 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1117 ~ if let Some(ref kb) = shortcuts.new_tab [INFO] [stdout] 1118 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1119 | let user_config = shared.config.lock().user_config.clone(); [INFO] [stdout] 1120 | win.open_local_tab(&user_config); [INFO] [stdout] 1121 | continue; [INFO] [stdout] 1122 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1124:17 [INFO] [stdout] | [INFO] [stdout] 1124 | / if let Some(ref kb) = shortcuts.close_tab { [INFO] [stdout] 1125 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1126 | | if let Some(id) = win.active_tab { [INFO] [stdout] 1127 | | win.remove_session(id); [INFO] [stdout] ... | [INFO] [stdout] 1131 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1124 ~ if let Some(ref kb) = shortcuts.close_tab [INFO] [stdout] 1125 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1126 | if let Some(id) = win.active_tab { [INFO] [stdout] ... [INFO] [stdout] 1129 | continue; [INFO] [stdout] 1130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1132:17 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(ref kb) = shortcuts.quit { [INFO] [stdout] 1133 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1134 | | win.pending_actions.push(WindowAction::Quit); [INFO] [stdout] 1135 | | continue; [INFO] [stdout] 1136 | | } [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1132 ~ if let Some(ref kb) = shortcuts.quit [INFO] [stdout] 1133 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1134 | win.pending_actions.push(WindowAction::Quit); [INFO] [stdout] 1135 | continue; [INFO] [stdout] 1136 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1138:17 [INFO] [stdout] | [INFO] [stdout] 1138 | / if let Some(ref kb) = shortcuts.toggle_left_panel { [INFO] [stdout] 1139 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1140 | | win.left_panel_visible = !win.left_panel_visible; [INFO] [stdout] 1141 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1144 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1138 ~ if let Some(ref kb) = shortcuts.toggle_left_panel [INFO] [stdout] 1139 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1140 | win.left_panel_visible = !win.left_panel_visible; [INFO] [stdout] 1141 | win.auto_revealed_panel = None; [INFO] [stdout] 1142 | continue; [INFO] [stdout] 1143 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1145:17 [INFO] [stdout] | [INFO] [stdout] 1145 | / if let Some(ref kb) = shortcuts.toggle_right_panel { [INFO] [stdout] 1146 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1147 | | win.right_panel_visible = !win.right_panel_visible; [INFO] [stdout] 1148 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1145 ~ if let Some(ref kb) = shortcuts.toggle_right_panel [INFO] [stdout] 1146 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1147 | win.right_panel_visible = !win.right_panel_visible; [INFO] [stdout] 1148 | win.auto_revealed_panel = None; [INFO] [stdout] 1149 | continue; [INFO] [stdout] 1150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1152:17 [INFO] [stdout] | [INFO] [stdout] 1152 | / if let Some(ref kb) = shortcuts.toggle_bottom_panel { [INFO] [stdout] 1153 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1154 | | win.bottom_panel_visible = !win.bottom_panel_visible; [INFO] [stdout] 1155 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1158 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1152 ~ if let Some(ref kb) = shortcuts.toggle_bottom_panel [INFO] [stdout] 1153 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1154 | win.bottom_panel_visible = !win.bottom_panel_visible; [INFO] [stdout] 1155 | win.auto_revealed_panel = None; [INFO] [stdout] 1156 | continue; [INFO] [stdout] 1157 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1159:17 [INFO] [stdout] | [INFO] [stdout] 1159 | / if let Some(ref kb) = shortcuts.zen_mode { [INFO] [stdout] 1160 | | if kb.matches(key, modifiers) { [INFO] [stdout] 1161 | | win.toggle_zen_mode(); [INFO] [stdout] 1162 | | win.auto_revealed_panel = None; [INFO] [stdout] ... | [INFO] [stdout] 1165 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1159 ~ if let Some(ref kb) = shortcuts.zen_mode [INFO] [stdout] 1160 ~ && kb.matches(key, modifiers) { [INFO] [stdout] 1161 | win.toggle_zen_mode(); [INFO] [stdout] 1162 | win.auto_revealed_panel = None; [INFO] [stdout] 1163 | continue; [INFO] [stdout] 1164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1201:25 [INFO] [stdout] | [INFO] [stdout] 1201 | / if let Ok(json) = serde_json::to_string(&event) { [INFO] [stdout] 1202 | | if let Some(sender) = shared.plugin_bus.sender_for(&pkb.plugin_name) { [INFO] [stdout] 1203 | | let _ = sender [INFO] [stdout] 1204 | | .try_send(conch_plugin::bus::PluginMail::WidgetEvent { json }); [INFO] [stdout] 1205 | | } [INFO] [stdout] 1206 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1201 ~ if let Ok(json) = serde_json::to_string(&event) [INFO] [stdout] 1202 ~ && let Some(sender) = shared.plugin_bus.sender_for(&pkb.plugin_name) { [INFO] [stdout] 1203 | let _ = sender [INFO] [stdout] 1204 | .try_send(conch_plugin::bus::PluginMail::WidgetEvent { json }); [INFO] [stdout] 1205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1222:21 [INFO] [stdout] | [INFO] [stdout] 1222 | / if let Some((start, end)) = win.selection.normalized() { [INFO] [stdout] 1223 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1224 | | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] 1225 | | if !text.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 1229 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1222 ~ if let Some((start, end)) = win.selection.normalized() [INFO] [stdout] 1223 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1224 | let text = widget::get_selected_text(session.term(), start, end); [INFO] [stdout] ... [INFO] [stdout] 1227 | } [INFO] [stdout] 1228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1235:17 [INFO] [stdout] | [INFO] [stdout] 1235 | / if !text_widget_focused { [INFO] [stdout] 1236 | | if let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | | key, [INFO] [stdout] 1238 | | modifiers, [INFO] [stdout] ... | [INFO] [stdout] 1251 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1235 ~ if !text_widget_focused [INFO] [stdout] 1236 ~ && let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | key, [INFO] [stdout] ... [INFO] [stdout] 1249 | } [INFO] [stdout] 1250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1236:21 [INFO] [stdout] | [INFO] [stdout] 1236 | / if let Some(bytes) = input::key_to_bytes( [INFO] [stdout] 1237 | | key, [INFO] [stdout] 1238 | | modifiers, [INFO] [stdout] 1239 | | None, [INFO] [stdout] ... | [INFO] [stdout] 1250 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1243 ~ ) [INFO] [stdout] 1244 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1245 | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] ... [INFO] [stdout] 1248 | session.write(&bytes); [INFO] [stdout] 1249 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1254:17 [INFO] [stdout] | [INFO] [stdout] 1254 | / if !text_widget_focused { [INFO] [stdout] 1255 | | if let Some(session) = win.active_session() { [INFO] [stdout] 1256 | | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] 1257 | | term.scroll_display(alacritty_terminal::grid::Scroll::Bottom); [INFO] [stdout] ... | [INFO] [stdout] 1261 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1254 ~ if !text_widget_focused [INFO] [stdout] 1255 ~ && let Some(session) = win.active_session() { [INFO] [stdout] 1256 | if let Some(mut term) = session.term().try_lock_unfair() { [INFO] [stdout] ... [INFO] [stdout] 1259 | session.write(text.as_bytes()); [INFO] [stdout] 1260 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1368:9 [INFO] [stdout] | [INFO] [stdout] 1368 | layout.left_panel_visible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `conch_core::config::LayoutConfig { left_panel_visible: false, right_panel_visible: false, bottom_panel_visible: true, status_bar_visible: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1367:9 [INFO] [stdout] | [INFO] [stdout] 1367 | let mut layout = config::LayoutConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1485:9 [INFO] [stdout] | [INFO] [stdout] 1485 | assert!(UNFOCUSED_POLL_MS >= 100, "polling too aggressively when unfocused"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> crates/conch_app/src/window_state.rs:1486:9 [INFO] [stdout] | [INFO] [stdout] 1486 | assert!(UNFOCUSED_POLL_MS <= 1000, "polling too slowly — updates will feel laggy"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> crates/conch_app/src/host/session_bridge.rs:196:48 [INFO] [stdout] | [INFO] [stdout] 196 | assert!(cb as usize == output_callback as usize); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(function_casts_as_integer)]` on by default [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 196 | assert!(cb as usize == output_callback as *const () as usize); [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 06s [INFO] running `Command { std: "docker" "inspect" "3339bf43dc6bfb79b1bcdb8baecabf924962355ee17e9bf4e73cd290892c63e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3339bf43dc6bfb79b1bcdb8baecabf924962355ee17e9bf4e73cd290892c63e8", kill_on_drop: false }` [INFO] [stdout] 3339bf43dc6bfb79b1bcdb8baecabf924962355ee17e9bf4e73cd290892c63e8