[INFO] cloning repository https://github.com/an-prata/audio-tag [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/an-prata/audio-tag" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Faudio-tag", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Faudio-tag'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cc56292ed450b870bd3f66a020f023071eed3c6d [INFO] linting an-prata/audio-tag against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fan-prata%2Faudio-tag" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/an-prata/audio-tag [INFO] finished tweaking git repo https://github.com/an-prata/audio-tag [INFO] tweaked toml for git repo https://github.com/an-prata/audio-tag written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/an-prata/audio-tag on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/an-prata/audio-tag already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e8d36831ef83b6a985e1b5cf5d7f20c069787c6cb709168b069b1445a4175ae [INFO] running `Command { std: "docker" "start" "-a" "6e8d36831ef83b6a985e1b5cf5d7f20c069787c6cb709168b069b1445a4175ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e8d36831ef83b6a985e1b5cf5d7f20c069787c6cb709168b069b1445a4175ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e8d36831ef83b6a985e1b5cf5d7f20c069787c6cb709168b069b1445a4175ae", kill_on_drop: false }` [INFO] [stdout] 6e8d36831ef83b6a985e1b5cf5d7f20c069787c6cb709168b069b1445a4175ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91d135c8d777a5c0e50f85fb2f50c5729ba4a458584f09c5553daa16061ebd8e [INFO] running `Command { std: "docker" "start" "-a" "91d135c8d777a5c0e50f85fb2f50c5729ba4a458584f09c5553daa16061ebd8e", kill_on_drop: false }` [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking audio-tag v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/audio_info.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | fn initial_key(&self) -> Option { ($tag(self)).and_then(|t| t.initial_key()) } [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/audio_info.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | value: Option, [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/audio_info.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | fn initial_key(&self) -> Option { ($tag(self)).and_then(|t| t.initial_key()) } [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/audio_info.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | value: Option, [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/id3v2.rs:905:18 [INFO] [stdout] | [INFO] [stdout] 905 | self.0 & 0b_1000_000 > 0 [INFO] [stdout] | ^^^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/id3v2.rs:905:18 [INFO] [stdout] | [INFO] [stdout] 905 | self.0 & 0b_1000_000 > 0 [INFO] [stdout] | ^^^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vorbis_comment_block` [INFO] [stdout] --> src/flac.rs:639:42 [INFO] [stdout] | [INFO] [stdout] 639 | MetadataBlock::VorbisComment(vorbis_comment_block) => todo!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_vorbis_comment_block` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vorbis_comment_block` [INFO] [stdout] --> src/flac.rs:639:42 [INFO] [stdout] | [INFO] [stdout] 639 | MetadataBlock::VorbisComment(vorbis_comment_block) => todo!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_vorbis_comment_block` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Marker` is never constructed [INFO] [stdout] --> src/aiff.rs:664:8 [INFO] [stdout] | [INFO] [stdout] 664 | struct Marker<'s> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PascalShortString` is never constructed [INFO] [stdout] --> src/aiff.rs:678:8 [INFO] [stdout] | [INFO] [stdout] 678 | struct PascalShortString<'s> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Comment` is never constructed [INFO] [stdout] --> src/aiff.rs:711:8 [INFO] [stdout] | [INFO] [stdout] 711 | struct Comment<'t> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SeekTable`, `CueSheet`, and `Picture` are never constructed [INFO] [stdout] --> src/flac.rs:626:5 [INFO] [stdout] | [INFO] [stdout] 622 | enum MetadataBlock { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 626 | SeekTable(SeekTableBlock), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 627 | VorbisComment(VorbisCommentBlock), [INFO] [stdout] 628 | CueSheet(CueSheetBlock), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 629 | Picture(PictureBlock), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MetadataBlock` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_placeholder` is never used [INFO] [stdout] --> src/flac.rs:807:8 [INFO] [stdout] | [INFO] [stdout] 803 | impl SeekPoint { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 807 | fn is_placeholder(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `untype` is never used [INFO] [stdout] --> src/flac.rs:832:8 [INFO] [stdout] | [INFO] [stdout] 831 | impl VorbisCommentBlock { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] 832 | fn untype(self) -> TypelessMetadataBlock { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/flac.rs:967:5 [INFO] [stdout] | [INFO] [stdout] 966 | enum PictureType { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 967 | Other, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 968 | PngFileIcon, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 969 | GeneralFileIcon, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 970 | FrontCover, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 971 | BackCover, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 972 | LinerNotesPage, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 973 | MediaLabel, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 976 | LeadArtist, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 979 | Artist, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 980 | [INFO] [stdout] 981 | Conductor, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 984 | Band, [INFO] [stdout] | ^^^^ [INFO] [stdout] 985 | [INFO] [stdout] 986 | Composer, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 989 | Writer, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 990 | [INFO] [stdout] 991 | RecordingLocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 992 | DuringRecording, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 993 | DuringPerformance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 994 | VideoScreenCapture, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 995 | BrightColoredFish, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 996 | Illustration, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 999 | ArtistLogotype, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1002 | StudioLogotype, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PictureType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `remaining`, `is_empty`, and `take_unary` are never used [INFO] [stdout] --> src/flac.rs:1325:8 [INFO] [stdout] | [INFO] [stdout] 1306 | impl<'i> BitBuffer<'i> { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1325 | fn remaining(&self) -> &'i [u8] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1332 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1340 | fn take_unary(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialized_size` is never used [INFO] [stdout] --> src/id3v2.rs:805:8 [INFO] [stdout] | [INFO] [stdout] 773 | impl Frame { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 805 | fn serialized_size(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `unsynchonisation` and `experimental_indicator` are never used [INFO] [stdout] --> src/id3v2.rs:904:8 [INFO] [stdout] | [INFO] [stdout] 903 | impl HeaderFlags { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] 904 | fn unsynchonisation(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 912 | fn experimental_indicator(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `discard_with_tag_alter`, `discard_with_file_alter`, `read_only`, `compressed`, `encrypted`, and `contains_group_information` are never used [INFO] [stdout] --> src/id3v2.rs:924:8 [INFO] [stdout] | [INFO] [stdout] 923 | impl FrameHeaderFlags { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] 924 | fn discard_with_tag_alter(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 928 | fn discard_with_file_alter(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 932 | fn read_only(self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 936 | fn compressed(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 940 | fn encrypted(self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 944 | fn contains_group_information(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FRAME_SYNC_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:367:7 [INFO] [stdout] | [INFO] [stdout] 367 | const FRAME_SYNC_SHIFT: u32 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROTECTION_BIT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:375:7 [INFO] [stdout] | [INFO] [stdout] 375 | const PROTECTION_BIT_MASK: u32 = 0b_00000000_00000001_00000000_00000000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROTECTION_BIT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:376:7 [INFO] [stdout] | [INFO] [stdout] 376 | const PROTECTION_BIT_SHIFT: u32 = 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PRIVATE_BIT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:387:7 [INFO] [stdout] | [INFO] [stdout] 387 | const PRIVATE_BIT_MASK: u32 = 0b_00000000_00000000_00000001_00000000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PRIVATE_BIT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:388:7 [INFO] [stdout] | [INFO] [stdout] 388 | const PRIVATE_BIT_SHIFT: u32 = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COPYRIGHT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:396:7 [INFO] [stdout] | [INFO] [stdout] 396 | const COPYRIGHT_MASK: u32 = 0b_00000000_00000000_00000000_00001000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COPYRIGHT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:397:7 [INFO] [stdout] | [INFO] [stdout] 397 | const COPYRIGHT_SHIFT: u32 = 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ORIGINAL_MASK` is never used [INFO] [stdout] --> src/mp3.rs:399:7 [INFO] [stdout] | [INFO] [stdout] 399 | const ORIGINAL_MASK: u32 = 0b_00000000_00000000_00000000_00000100; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ORIGINAL_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:400:7 [INFO] [stdout] | [INFO] [stdout] 400 | const ORIGINAL_SHIFT: u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EMPHASIS_MASK` is never used [INFO] [stdout] --> src/mp3.rs:402:7 [INFO] [stdout] | [INFO] [stdout] 402 | const EMPHASIS_MASK: u32 = 0b_00000000_00000000_00000000_00000011; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EMPHASIS_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:403:7 [INFO] [stdout] | [INFO] [stdout] 403 | const EMPHASIS_SHIFT: u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `frame_size` are never used [INFO] [stdout] --> src/mp3.rs:406:8 [INFO] [stdout] | [INFO] [stdout] 405 | impl FrameHeader { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 406 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 512 | fn frame_size(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:32:44 [INFO] [stdout] | [INFO] [stdout] 32 | let bytes = fs::read(path).map_err(|e| ParseError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:58:55 [INFO] [stdout] | [INFO] [stdout] 58 | let mut file = fs::File::create(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | .map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Marker` is never constructed [INFO] [stdout] --> src/aiff.rs:664:8 [INFO] [stdout] | [INFO] [stdout] 664 | struct Marker<'s> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PascalShortString` is never constructed [INFO] [stdout] --> src/aiff.rs:678:8 [INFO] [stdout] | [INFO] [stdout] 678 | struct PascalShortString<'s> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Comment` is never constructed [INFO] [stdout] --> src/aiff.rs:711:8 [INFO] [stdout] | [INFO] [stdout] 711 | struct Comment<'t> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SeekTable`, `CueSheet`, and `Picture` are never constructed [INFO] [stdout] --> src/flac.rs:626:5 [INFO] [stdout] | [INFO] [stdout] 622 | enum MetadataBlock { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 626 | SeekTable(SeekTableBlock), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 627 | VorbisComment(VorbisCommentBlock), [INFO] [stdout] 628 | CueSheet(CueSheetBlock), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 629 | Picture(PictureBlock), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MetadataBlock` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_placeholder` is never used [INFO] [stdout] --> src/flac.rs:807:8 [INFO] [stdout] | [INFO] [stdout] 803 | impl SeekPoint { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 807 | fn is_placeholder(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `untype` is never used [INFO] [stdout] --> src/flac.rs:832:8 [INFO] [stdout] | [INFO] [stdout] 831 | impl VorbisCommentBlock { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] 832 | fn untype(self) -> TypelessMetadataBlock { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/flac.rs:967:5 [INFO] [stdout] | [INFO] [stdout] 966 | enum PictureType { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 967 | Other, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 968 | PngFileIcon, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 969 | GeneralFileIcon, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 970 | FrontCover, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 971 | BackCover, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 972 | LinerNotesPage, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 973 | MediaLabel, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 976 | LeadArtist, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 979 | Artist, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 980 | [INFO] [stdout] 981 | Conductor, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 984 | Band, [INFO] [stdout] | ^^^^ [INFO] [stdout] 985 | [INFO] [stdout] 986 | Composer, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 989 | Writer, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 990 | [INFO] [stdout] 991 | RecordingLocation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 992 | DuringRecording, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 993 | DuringPerformance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 994 | VideoScreenCapture, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 995 | BrightColoredFish, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 996 | Illustration, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 999 | ArtistLogotype, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1002 | StudioLogotype, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PictureType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `remaining`, `is_empty`, and `take_unary` are never used [INFO] [stdout] --> src/flac.rs:1325:8 [INFO] [stdout] | [INFO] [stdout] 1306 | impl<'i> BitBuffer<'i> { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1325 | fn remaining(&self) -> &'i [u8] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1332 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1340 | fn take_unary(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialized_size` is never used [INFO] [stdout] --> src/id3v2.rs:805:8 [INFO] [stdout] | [INFO] [stdout] 773 | impl Frame { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 805 | fn serialized_size(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `unsynchonisation` and `experimental_indicator` are never used [INFO] [stdout] --> src/id3v2.rs:904:8 [INFO] [stdout] | [INFO] [stdout] 903 | impl HeaderFlags { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] 904 | fn unsynchonisation(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 912 | fn experimental_indicator(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `discard_with_tag_alter`, `discard_with_file_alter`, `read_only`, `compressed`, `encrypted`, and `contains_group_information` are never used [INFO] [stdout] --> src/id3v2.rs:924:8 [INFO] [stdout] | [INFO] [stdout] 923 | impl FrameHeaderFlags { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] 924 | fn discard_with_tag_alter(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 928 | fn discard_with_file_alter(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 932 | fn read_only(self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 936 | fn compressed(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 940 | fn encrypted(self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 944 | fn contains_group_information(self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FRAME_SYNC_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:367:7 [INFO] [stdout] | [INFO] [stdout] 367 | const FRAME_SYNC_SHIFT: u32 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROTECTION_BIT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:375:7 [INFO] [stdout] | [INFO] [stdout] 375 | const PROTECTION_BIT_MASK: u32 = 0b_00000000_00000001_00000000_00000000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROTECTION_BIT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:376:7 [INFO] [stdout] | [INFO] [stdout] 376 | const PROTECTION_BIT_SHIFT: u32 = 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PRIVATE_BIT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:387:7 [INFO] [stdout] | [INFO] [stdout] 387 | const PRIVATE_BIT_MASK: u32 = 0b_00000000_00000000_00000001_00000000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PRIVATE_BIT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:388:7 [INFO] [stdout] | [INFO] [stdout] 388 | const PRIVATE_BIT_SHIFT: u32 = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COPYRIGHT_MASK` is never used [INFO] [stdout] --> src/mp3.rs:396:7 [INFO] [stdout] | [INFO] [stdout] 396 | const COPYRIGHT_MASK: u32 = 0b_00000000_00000000_00000000_00001000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COPYRIGHT_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:397:7 [INFO] [stdout] | [INFO] [stdout] 397 | const COPYRIGHT_SHIFT: u32 = 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ORIGINAL_MASK` is never used [INFO] [stdout] --> src/mp3.rs:399:7 [INFO] [stdout] | [INFO] [stdout] 399 | const ORIGINAL_MASK: u32 = 0b_00000000_00000000_00000000_00000100; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ORIGINAL_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:400:7 [INFO] [stdout] | [INFO] [stdout] 400 | const ORIGINAL_SHIFT: u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EMPHASIS_MASK` is never used [INFO] [stdout] --> src/mp3.rs:402:7 [INFO] [stdout] | [INFO] [stdout] 402 | const EMPHASIS_MASK: u32 = 0b_00000000_00000000_00000000_00000011; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EMPHASIS_SHIFT` is never used [INFO] [stdout] --> src/mp3.rs:403:7 [INFO] [stdout] | [INFO] [stdout] 403 | const EMPHASIS_SHIFT: u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `frame_size` are never used [INFO] [stdout] --> src/mp3.rs:406:8 [INFO] [stdout] | [INFO] [stdout] 405 | impl FrameHeader { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 406 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 512 | fn frame_size(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Looping` [INFO] [stdout] --> src/aiff.rs:701:1 [INFO] [stdout] | [INFO] [stdout] 701 | / enum LoopPlayMode { [INFO] [stdout] 702 | | NoLooping, [INFO] [stdout] 703 | | ForwardLooping, [INFO] [stdout] 704 | | ForwardBackwardLooping, [INFO] [stdout] 705 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/aiff.rs:772:17 [INFO] [stdout] | [INFO] [stdout] 772 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:32:44 [INFO] [stdout] | [INFO] [stdout] 32 | let bytes = fs::read(path).map_err(|e| ParseError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:58:55 [INFO] [stdout] | [INFO] [stdout] 58 | let mut file = fs::File::create(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/aiff.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | .map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.data.get(0)` [INFO] [stdout] --> src/aiff.rs:904:29 [INFO] [stdout] | [INFO] [stdout] 904 | base_note: *self.data.get(0)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1104:35 [INFO] [stdout] | [INFO] [stdout] 1104 | if form.chunks.iter().any(|c| match c { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1105 | | Chunk::Form(_) => true, [INFO] [stdout] 1106 | | _ => false, [INFO] [stdout] 1107 | | }) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1104 - if form.chunks.iter().any(|c| match c { [INFO] [stdout] 1105 - Chunk::Form(_) => true, [INFO] [stdout] 1106 - _ => false, [INFO] [stdout] 1107 - }) { [INFO] [stdout] 1104 + if form.chunks.iter().any(|c| matches!(c, Chunk::Form(_))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1115:21 [INFO] [stdout] | [INFO] [stdout] 1115 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1116 | | Chunk::Common(_) => true, [INFO] [stdout] 1117 | | _ => false, [INFO] [stdout] 1118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1115 - .filter(|c| match c { [INFO] [stdout] 1116 - Chunk::Common(_) => true, [INFO] [stdout] 1117 - _ => false, [INFO] [stdout] 1118 - }) [INFO] [stdout] 1115 + .filter(|c| matches!(c, Chunk::Common(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1130:21 [INFO] [stdout] | [INFO] [stdout] 1130 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1131 | | Chunk::SoundData(_) => true, [INFO] [stdout] 1132 | | _ => false, [INFO] [stdout] 1133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1130 - .filter(|c| match c { [INFO] [stdout] 1131 - Chunk::SoundData(_) => true, [INFO] [stdout] 1132 - _ => false, [INFO] [stdout] 1133 - }) [INFO] [stdout] 1130 + .filter(|c| matches!(c, Chunk::SoundData(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1158:21 [INFO] [stdout] | [INFO] [stdout] 1158 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1159 | | Chunk::Id3v2(_) => true, [INFO] [stdout] 1160 | | _ => false, [INFO] [stdout] 1161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1158 - .filter(|c| match c { [INFO] [stdout] 1159 - Chunk::Id3v2(_) => true, [INFO] [stdout] 1160 - _ => false, [INFO] [stdout] 1161 - }) [INFO] [stdout] 1158 + .filter(|c| matches!(c, Chunk::Id3v2(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Looping` [INFO] [stdout] --> src/aiff.rs:701:1 [INFO] [stdout] | [INFO] [stdout] 701 | / enum LoopPlayMode { [INFO] [stdout] 702 | | NoLooping, [INFO] [stdout] 703 | | ForwardLooping, [INFO] [stdout] 704 | | ForwardBackwardLooping, [INFO] [stdout] 705 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/aiff.rs:772:17 [INFO] [stdout] | [INFO] [stdout] 772 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.data.get(0)` [INFO] [stdout] --> src/aiff.rs:904:29 [INFO] [stdout] | [INFO] [stdout] 904 | base_note: *self.data.get(0)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `self.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1104:35 [INFO] [stdout] | [INFO] [stdout] 1104 | if form.chunks.iter().any(|c| match c { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1105 | | Chunk::Form(_) => true, [INFO] [stdout] 1106 | | _ => false, [INFO] [stdout] 1107 | | }) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1104 - if form.chunks.iter().any(|c| match c { [INFO] [stdout] 1105 - Chunk::Form(_) => true, [INFO] [stdout] 1106 - _ => false, [INFO] [stdout] 1107 - }) { [INFO] [stdout] 1104 + if form.chunks.iter().any(|c| matches!(c, Chunk::Form(_))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1115:21 [INFO] [stdout] | [INFO] [stdout] 1115 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1116 | | Chunk::Common(_) => true, [INFO] [stdout] 1117 | | _ => false, [INFO] [stdout] 1118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1115 - .filter(|c| match c { [INFO] [stdout] 1116 - Chunk::Common(_) => true, [INFO] [stdout] 1117 - _ => false, [INFO] [stdout] 1118 - }) [INFO] [stdout] 1115 + .filter(|c| matches!(c, Chunk::Common(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:459:26 [INFO] [stdout] | [INFO] [stdout] 459 | .map_err(|err| AudioFileError::AiffParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::AiffParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:465:26 [INFO] [stdout] | [INFO] [stdout] 465 | .map_err(|err| AudioFileError::Mp3ParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::Mp3ParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1130:21 [INFO] [stdout] | [INFO] [stdout] 1130 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1131 | | Chunk::SoundData(_) => true, [INFO] [stdout] 1132 | | _ => false, [INFO] [stdout] 1133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1130 - .filter(|c| match c { [INFO] [stdout] 1131 - Chunk::SoundData(_) => true, [INFO] [stdout] 1132 - _ => false, [INFO] [stdout] 1133 - }) [INFO] [stdout] 1130 + .filter(|c| matches!(c, Chunk::SoundData(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:469:26 [INFO] [stdout] | [INFO] [stdout] 469 | .map_err(|err| AudioFileError::WaveParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::WaveParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/aiff.rs:1158:21 [INFO] [stdout] | [INFO] [stdout] 1158 | .filter(|c| match c { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1159 | | Chunk::Id3v2(_) => true, [INFO] [stdout] 1160 | | _ => false, [INFO] [stdout] 1161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1158 - .filter(|c| match c { [INFO] [stdout] 1159 - Chunk::Id3v2(_) => true, [INFO] [stdout] 1160 - _ => false, [INFO] [stdout] 1161 - }) [INFO] [stdout] 1158 + .filter(|c| matches!(c, Chunk::Id3v2(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `audio_info::Key` [INFO] [stdout] --> src/audio_info.rs:765:5 [INFO] [stdout] | [INFO] [stdout] 765 | / pub fn to_string(self) -> String { [INFO] [stdout] 766 | | match self { [INFO] [stdout] 767 | | Key::C => "C", [INFO] [stdout] 768 | | Key::G => "G", [INFO] [stdout] ... | [INFO] [stdout] 796 | | .to_string() [INFO] [stdout] 797 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `audio_info::Key` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/flac.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | let bytes = fs::read(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/flac.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(block) = blocks_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for block in blocks_iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:459:26 [INFO] [stdout] | [INFO] [stdout] 459 | .map_err(|err| AudioFileError::AiffParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::AiffParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:465:26 [INFO] [stdout] | [INFO] [stdout] 465 | .map_err(|err| AudioFileError::Mp3ParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::Mp3ParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio_info.rs:469:26 [INFO] [stdout] | [INFO] [stdout] 469 | .map_err(|err| AudioFileError::WaveParseError(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AudioFileError::WaveParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `audio_info::Key` [INFO] [stdout] --> src/audio_info.rs:765:5 [INFO] [stdout] | [INFO] [stdout] 765 | / pub fn to_string(self) -> String { [INFO] [stdout] 766 | | match self { [INFO] [stdout] 767 | | Key::C => "C", [INFO] [stdout] 768 | | Key::G => "G", [INFO] [stdout] ... | [INFO] [stdout] 796 | | .to_string() [INFO] [stdout] 797 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `audio_info::Key` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/flac.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | let bytes = fs::read(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/flac.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(block) = blocks_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for block in blocks_iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/flac.rs:1043:17 [INFO] [stdout] | [INFO] [stdout] 1043 | fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> src/flac.rs:1314:27 [INFO] [stdout] | [INFO] [stdout] 1314 | current_byte: bytes.get(0), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.bytes.get(0)` [INFO] [stdout] --> src/flac.rs:1417:37 [INFO] [stdout] | [INFO] [stdout] 1417 | self.current_byte = self.bytes.get(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/flac.rs:1528:17 [INFO] [stdout] | [INFO] [stdout] 1528 | self.current_byte = self.current_byte << (8 - b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_byte <<= (8 - b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/id3v1.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 8 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 9 | #[derive(PartialEq, Eq, Debug, Clone, Copy)] [INFO] [stdout] 10 | / pub struct Tag { [INFO] [stdout] 11 | | id: [u8; 3], [INFO] [stdout] 12 | | title: [u8; 30], [INFO] [stdout] 13 | | artist: [u8; 30], [INFO] [stdout] ... | [INFO] [stdout] 17 | | genre: u8, [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] = note: `#[warn(clippy::repr_packed_without_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | / for i in 0..bytes.len() { [INFO] [stdout] 226 | | self.album[i] = bytes[i]; [INFO] [stdout] 227 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.album[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / for i in 0..bytes.len() { [INFO] [stdout] 297 | | self.title[i] = bytes[i]; [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.title[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | / for i in 0..bytes.len() { [INFO] [stdout] 361 | | self.artist[i] = bytes[i]; [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.artist[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/flac.rs:1043:17 [INFO] [stdout] | [INFO] [stdout] 1043 | fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> src/flac.rs:1314:27 [INFO] [stdout] | [INFO] [stdout] 1314 | current_byte: bytes.get(0), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.bytes.get(0)` [INFO] [stdout] --> src/flac.rs:1417:37 [INFO] [stdout] | [INFO] [stdout] 1417 | self.current_byte = self.bytes.get(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/flac.rs:1528:17 [INFO] [stdout] | [INFO] [stdout] 1528 | self.current_byte = self.current_byte << (8 - b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_byte <<= (8 - b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id3v2.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | return Some(frame); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 529 - return Some(frame); [INFO] [stdout] 529 + Some(frame) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/id3v1.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 8 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 9 | #[derive(PartialEq, Eq, Debug, Clone, Copy)] [INFO] [stdout] 10 | / pub struct Tag { [INFO] [stdout] 11 | | id: [u8; 3], [INFO] [stdout] 12 | | title: [u8; 30], [INFO] [stdout] 13 | | artist: [u8; 30], [INFO] [stdout] ... | [INFO] [stdout] 17 | | genre: u8, [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] = note: `#[warn(clippy::repr_packed_without_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | / for i in 0..bytes.len() { [INFO] [stdout] 226 | | self.album[i] = bytes[i]; [INFO] [stdout] 227 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.album[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/id3v2.rs:795:17 [INFO] [stdout] | [INFO] [stdout] 795 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id3v2.rs:845:18 [INFO] [stdout] | [INFO] [stdout] 845 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 845 - _ => return None, [INFO] [stdout] 845 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / for i in 0..bytes.len() { [INFO] [stdout] 297 | | self.title[i] = bytes[i]; [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.title[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/id3v1.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | / for i in 0..bytes.len() { [INFO] [stdout] 361 | | self.artist[i] = bytes[i]; [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.artist[..bytes.len()].copy_from_slice(&bytes[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:34:44 [INFO] [stdout] | [INFO] [stdout] 34 | let bytes = fs::read(path).map_err(|e| ParseError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:44:55 [INFO] [stdout] | [INFO] [stdout] 44 | let mut file = fs::File::create(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 47 | .map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mp3.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mp3.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(ParseError::Id3v2ParseError(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Err(ParseError::Id3v2ParseError(e)); [INFO] [stdout] 105 + Err(ParseError::Id3v2ParseError(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mp3.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | match id3v2::parse_tag(&bytes) { [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mp3.rs:90:38 [INFO] [stdout] | [INFO] [stdout] 90 | remaining_bytes: &bytes, [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/mp3.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | while let Some(frame) = frames_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for frame in frames_iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id3v2.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | return Some(frame); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 529 - return Some(frame); [INFO] [stdout] 529 + Some(frame) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mp3.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name starts with the enum's name [INFO] [stdout] --> src/mp3.rs:333:5 [INFO] [stdout] | [INFO] [stdout] 333 | LayerII = 0b10, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name starts with the enum's name [INFO] [stdout] --> src/mp3.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 336 | LayerIII = 0b01, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/mp3.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | / fn new( [INFO] [stdout] 407 | | version: Version, [INFO] [stdout] 408 | | layer: Layer, [INFO] [stdout] 409 | | bitrate_bits: u8, [INFO] [stdout] ... | [INFO] [stdout] 415 | | original: bool, [INFO] [stdout] 416 | | ) -> FrameHeader { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/id3v2.rs:795:17 [INFO] [stdout] | [INFO] [stdout] 795 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id3v2.rs:845:18 [INFO] [stdout] | [INFO] [stdout] 845 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 845 - _ => return None, [INFO] [stdout] 845 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/wave.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 66 | let bytes = fs::read(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/wave.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | fs::write(path, bytes).map_err(|io_err| ParseError::Io(io_err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wave.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | return Err(ParseError::ExpectedRiffChunk); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Err(ParseError::ExpectedRiffChunk); [INFO] [stdout] 96 + Err(ParseError::ExpectedRiffChunk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn to_bytes(self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:34:44 [INFO] [stdout] | [INFO] [stdout] 34 | let bytes = fs::read(path).map_err(|e| ParseError::Io(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:44:55 [INFO] [stdout] | [INFO] [stdout] 44 | let mut file = fs::File::create(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/mp3.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 47 | .map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mp3.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mp3.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(ParseError::Id3v2ParseError(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Err(ParseError::Id3v2ParseError(e)); [INFO] [stdout] 105 + Err(ParseError::Id3v2ParseError(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mp3.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | match id3v2::parse_tag(&bytes) { [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mp3.rs:90:38 [INFO] [stdout] | [INFO] [stdout] 90 | remaining_bytes: &bytes, [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/mp3.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | while let Some(frame) = frames_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for frame in frames_iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/mp3.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:451:17 [INFO] [stdout] | [INFO] [stdout] 451 | fn to_bytes(self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name starts with the enum's name [INFO] [stdout] --> src/mp3.rs:333:5 [INFO] [stdout] | [INFO] [stdout] 333 | LayerII = 0b10, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name starts with the enum's name [INFO] [stdout] --> src/mp3.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 336 | LayerIII = 0b01, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wave.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if !(fmt_position < wave_data_position) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(fmt_position >= wave_data_position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:565:27 [INFO] [stdout] | [INFO] [stdout] 565 | .position(|c| match c { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 566 | | Chunk::WaveFormat(_) => true, [INFO] [stdout] 567 | | _ => false, [INFO] [stdout] 568 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 565 - .position(|c| match c { [INFO] [stdout] 566 - Chunk::WaveFormat(_) => true, [INFO] [stdout] 567 - _ => false, [INFO] [stdout] 568 - }) [INFO] [stdout] 565 + .position(|c| matches!(c, Chunk::WaveFormat(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:574:27 [INFO] [stdout] | [INFO] [stdout] 574 | .position(|c| match c { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 575 | | Chunk::WaveData(_) => true, [INFO] [stdout] 576 | | _ => false, [INFO] [stdout] 577 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 574 - .position(|c| match c { [INFO] [stdout] 575 - Chunk::WaveData(_) => true, [INFO] [stdout] 576 - _ => false, [INFO] [stdout] 577 - }) [INFO] [stdout] 574 + .position(|c| matches!(c, Chunk::WaveData(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/mp3.rs:406:5 [INFO] [stdout] | [INFO] [stdout] 406 | / fn new( [INFO] [stdout] 407 | | version: Version, [INFO] [stdout] 408 | | layer: Layer, [INFO] [stdout] 409 | | bitrate_bits: u8, [INFO] [stdout] ... | [INFO] [stdout] 415 | | original: bool, [INFO] [stdout] 416 | | ) -> FrameHeader { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:863:64 [INFO] [stdout] | [INFO] [stdout] 863 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 864 | | Chunk::Copyright(_) => true, [INFO] [stdout] 865 | | _ => false, [INFO] [stdout] 866 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 863 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 864 - Chunk::Copyright(_) => true, [INFO] [stdout] 865 - _ => false, [INFO] [stdout] 866 - }); [INFO] [stdout] 863 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:897:64 [INFO] [stdout] | [INFO] [stdout] 897 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 898 | | Chunk::Copyright(_) => true, [INFO] [stdout] 899 | | _ => false, [INFO] [stdout] 900 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 897 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 898 - Chunk::Copyright(_) => true, [INFO] [stdout] 899 - _ => false, [INFO] [stdout] 900 - }); [INFO] [stdout] 897 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:950:64 [INFO] [stdout] | [INFO] [stdout] 950 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 951 | | Chunk::Copyright(_) => true, [INFO] [stdout] 952 | | _ => false, [INFO] [stdout] 953 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 950 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 951 - Chunk::Copyright(_) => true, [INFO] [stdout] 952 - _ => false, [INFO] [stdout] 953 - }); [INFO] [stdout] 950 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:991:64 [INFO] [stdout] | [INFO] [stdout] 991 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 992 | | Chunk::Copyright(_) => true, [INFO] [stdout] 993 | | _ => false, [INFO] [stdout] 994 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 991 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 992 - Chunk::Copyright(_) => true, [INFO] [stdout] 993 - _ => false, [INFO] [stdout] 994 - }); [INFO] [stdout] 991 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1044:64 [INFO] [stdout] | [INFO] [stdout] 1044 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1045 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1046 | | _ => false, [INFO] [stdout] 1047 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1044 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1045 - Chunk::Copyright(_) => true, [INFO] [stdout] 1046 - _ => false, [INFO] [stdout] 1047 - }); [INFO] [stdout] 1044 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1126:64 [INFO] [stdout] | [INFO] [stdout] 1126 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1127 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1128 | | _ => false, [INFO] [stdout] 1129 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1126 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1127 - Chunk::Copyright(_) => true, [INFO] [stdout] 1128 - _ => false, [INFO] [stdout] 1129 - }); [INFO] [stdout] 1126 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1167:64 [INFO] [stdout] | [INFO] [stdout] 1167 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1168 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1169 | | _ => false, [INFO] [stdout] 1170 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1167 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1168 - Chunk::Copyright(_) => true, [INFO] [stdout] 1169 - _ => false, [INFO] [stdout] 1170 - }); [INFO] [stdout] 1167 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1232:64 [INFO] [stdout] | [INFO] [stdout] 1232 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1233 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1234 | | _ => false, [INFO] [stdout] 1235 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1232 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1233 - Chunk::Copyright(_) => true, [INFO] [stdout] 1234 - _ => false, [INFO] [stdout] 1235 - }); [INFO] [stdout] 1232 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/wave.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 66 | let bytes = fs::read(path).map_err(|io_err| ParseError::Io(io_err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/wave.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | fs::write(path, bytes).map_err(|io_err| ParseError::Io(io_err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseError::Io` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wave.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | return Err(ParseError::ExpectedRiffChunk); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Err(ParseError::ExpectedRiffChunk); [INFO] [stdout] 96 + Err(ParseError::ExpectedRiffChunk) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn to_bytes(self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:451:17 [INFO] [stdout] | [INFO] [stdout] 451 | fn to_bytes(self) -> Result> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wave.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 580 | if !(fmt_position < wave_data_position) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(fmt_position >= wave_data_position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:565:27 [INFO] [stdout] | [INFO] [stdout] 565 | .position(|c| match c { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 566 | | Chunk::WaveFormat(_) => true, [INFO] [stdout] 567 | | _ => false, [INFO] [stdout] 568 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 565 - .position(|c| match c { [INFO] [stdout] 566 - Chunk::WaveFormat(_) => true, [INFO] [stdout] 567 - _ => false, [INFO] [stdout] 568 - }) [INFO] [stdout] 565 + .position(|c| matches!(c, Chunk::WaveFormat(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:1837:17 [INFO] [stdout] | [INFO] [stdout] 1837 | fn to_bytes(self) -> (WaveFormatTag, Vec) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:574:27 [INFO] [stdout] | [INFO] [stdout] 574 | .position(|c| match c { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 575 | | Chunk::WaveData(_) => true, [INFO] [stdout] 576 | | _ => false, [INFO] [stdout] 577 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 574 - .position(|c| match c { [INFO] [stdout] 575 - Chunk::WaveData(_) => true, [INFO] [stdout] 576 - _ => false, [INFO] [stdout] 577 - }) [INFO] [stdout] 574 + .position(|c| matches!(c, Chunk::WaveData(_))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/wave.rs:2061:18 [INFO] [stdout] | [INFO] [stdout] 2061 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:2103:17 [INFO] [stdout] | [INFO] [stdout] 2103 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:863:64 [INFO] [stdout] | [INFO] [stdout] 863 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 864 | | Chunk::Copyright(_) => true, [INFO] [stdout] 865 | | _ => false, [INFO] [stdout] 866 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 863 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 864 - Chunk::Copyright(_) => true, [INFO] [stdout] 865 - _ => false, [INFO] [stdout] 866 - }); [INFO] [stdout] 863 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:897:64 [INFO] [stdout] | [INFO] [stdout] 897 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 898 | | Chunk::Copyright(_) => true, [INFO] [stdout] 899 | | _ => false, [INFO] [stdout] 900 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 897 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 898 - Chunk::Copyright(_) => true, [INFO] [stdout] 899 - _ => false, [INFO] [stdout] 900 - }); [INFO] [stdout] 897 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:950:64 [INFO] [stdout] | [INFO] [stdout] 950 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 951 | | Chunk::Copyright(_) => true, [INFO] [stdout] 952 | | _ => false, [INFO] [stdout] 953 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 950 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 951 - Chunk::Copyright(_) => true, [INFO] [stdout] 952 - _ => false, [INFO] [stdout] 953 - }); [INFO] [stdout] 950 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:991:64 [INFO] [stdout] | [INFO] [stdout] 991 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 992 | | Chunk::Copyright(_) => true, [INFO] [stdout] 993 | | _ => false, [INFO] [stdout] 994 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 991 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 992 - Chunk::Copyright(_) => true, [INFO] [stdout] 993 - _ => false, [INFO] [stdout] 994 - }); [INFO] [stdout] 991 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1044:64 [INFO] [stdout] | [INFO] [stdout] 1044 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1045 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1046 | | _ => false, [INFO] [stdout] 1047 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1044 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1045 - Chunk::Copyright(_) => true, [INFO] [stdout] 1046 - _ => false, [INFO] [stdout] 1047 - }); [INFO] [stdout] 1044 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1126:64 [INFO] [stdout] | [INFO] [stdout] 1126 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1127 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1128 | | _ => false, [INFO] [stdout] 1129 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1126 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1127 - Chunk::Copyright(_) => true, [INFO] [stdout] 1128 - _ => false, [INFO] [stdout] 1129 - }); [INFO] [stdout] 1126 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1167:64 [INFO] [stdout] | [INFO] [stdout] 1167 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1168 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1169 | | _ => false, [INFO] [stdout] 1170 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1167 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1168 - Chunk::Copyright(_) => true, [INFO] [stdout] 1169 - _ => false, [INFO] [stdout] 1170 - }); [INFO] [stdout] 1167 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/wave.rs:1232:64 [INFO] [stdout] | [INFO] [stdout] 1232 | let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 1233 | | Chunk::Copyright(_) => true, [INFO] [stdout] 1234 | | _ => false, [INFO] [stdout] 1235 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 1232 - let maybe_pos = chunks.iter().position(|chunk| match chunk { [INFO] [stdout] 1233 - Chunk::Copyright(_) => true, [INFO] [stdout] 1234 - _ => false, [INFO] [stdout] 1235 - }); [INFO] [stdout] 1232 + let maybe_pos = chunks.iter().position(|chunk| matches!(chunk, Chunk::Copyright(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:1837:17 [INFO] [stdout] | [INFO] [stdout] 1837 | fn to_bytes(self) -> (WaveFormatTag, Vec) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/wave.rs:2061:18 [INFO] [stdout] | [INFO] [stdout] 2061 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_map_windows` is declared but not used [INFO] [stdout] --> src/lib.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(iter_map_windows)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iterator_try_reduce` is declared but not used [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(iterator_try_reduce)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/wave.rs:2103:17 [INFO] [stdout] | [INFO] [stdout] 2103 | fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `new_range_api` is declared but not used [INFO] [stdout] --> src/lib.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | #![feature(new_range_api)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_map_windows` is declared but not used [INFO] [stdout] --> src/lib.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(iter_map_windows)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iterator_try_reduce` is declared but not used [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(iterator_try_reduce)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `new_range_api` is declared but not used [INFO] [stdout] --> src/lib.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | #![feature(new_range_api)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `Command { std: "docker" "inspect" "91d135c8d777a5c0e50f85fb2f50c5729ba4a458584f09c5553daa16061ebd8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91d135c8d777a5c0e50f85fb2f50c5729ba4a458584f09c5553daa16061ebd8e", kill_on_drop: false }` [INFO] [stdout] 91d135c8d777a5c0e50f85fb2f50c5729ba4a458584f09c5553daa16061ebd8e