[INFO] cloning repository https://github.com/amarislabs/amaya [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/amarislabs/amaya" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famarislabs%2Famaya", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famarislabs%2Famaya'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cc5aae90f820f8b5ea71b8667b6a4a3d64886376 [INFO] linting amarislabs/amaya against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Famarislabs%2Famaya" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/amarislabs/amaya [INFO] finished tweaking git repo https://github.com/amarislabs/amaya [INFO] tweaked toml for git repo https://github.com/amarislabs/amaya written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/amarislabs/amaya on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/amarislabs/amaya already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dyn-clone v1.0.18 [INFO] [stderr] Downloaded newline-converter v0.3.0 [INFO] [stderr] Downloaded which v7.0.1 [INFO] [stderr] Downloaded inquire v0.7.5 [INFO] [stderr] Downloaded crossterm v0.25.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b3d14a91af763d0bffcc7e6cb5e5684b8b09d01cf95a4739e08008322a227d9 [INFO] running `Command { std: "docker" "start" "-a" "7b3d14a91af763d0bffcc7e6cb5e5684b8b09d01cf95a4739e08008322a227d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b3d14a91af763d0bffcc7e6cb5e5684b8b09d01cf95a4739e08008322a227d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b3d14a91af763d0bffcc7e6cb5e5684b8b09d01cf95a4739e08008322a227d9", kill_on_drop: false }` [INFO] [stdout] 7b3d14a91af763d0bffcc7e6cb5e5684b8b09d01cf95a4739e08008322a227d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 365c0e85ecd1037287ae4f526959a2974066ba75f0eb3d47d679fee9fc7c019f [INFO] running `Command { std: "docker" "start" "-a" "365c0e85ecd1037287ae4f526959a2974066ba75f0eb3d47d679fee9fc7c019f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.27 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking dyn-clone v1.0.18 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Checking which v7.0.1 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling clap_derive v4.5.24 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling async-trait v0.1.86 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking clap v4.5.27 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking amaya v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:79:67 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(provider) = registry.get_provider(&name) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/provider.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 54 | if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] 54 + if path.is_file() && path.extension().is_some_and(|ext| ext == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AmarisRegistry` [INFO] [stdout] --> src/provider.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / pub fn new() -> Self { [INFO] [stdout] 145 | | Self { [INFO] [stdout] 146 | | providers: HashMap::new(), [INFO] [stdout] 147 | | } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 143 + impl Default for AmarisRegistry { [INFO] [stdout] 144 + fn default() -> Self { [INFO] [stdout] 145 + Self::new() [INFO] [stdout] 146 + } [INFO] [stdout] 147 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/provider.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn get_provider(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn AmarisProvider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / if let Some(parent) = path.parent() { [INFO] [stdout] 90 | | if !parent.exists() { [INFO] [stdout] 91 | | tokio::fs::create_dir_all(parent) [INFO] [stdout] 92 | | .await [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Some(parent) = path.parent() [INFO] [stdout] 90 ~ && !parent.exists() { [INFO] [stdout] 91 | tokio::fs::create_dir_all(parent) [INFO] [stdout] 92 | .await [INFO] [stdout] 93 | .map_err(|e| ConfigError::FileWriteError(e.to_string()))?; [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | if path.to_str().unwrap() == "settings.json".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"settings.json"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:318:16 [INFO] [stdout] | [INFO] [stdout] 318 | if !package_json.get("scripts").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `package_json.get("scripts").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:347:13 [INFO] [stdout] | [INFO] [stdout] 347 | / if let Some(scripts) = package_json.get_mut("scripts") { [INFO] [stdout] 348 | | if let Some(obj) = scripts.as_object_mut() { [INFO] [stdout] 349 | | obj.remove(name); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 347 ~ if let Some(scripts) = package_json.get_mut("scripts") [INFO] [stdout] 348 ~ && let Some(obj) = scripts.as_object_mut() { [INFO] [stdout] 349 | obj.remove(name); [INFO] [stdout] 350 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:79:67 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(provider) = registry.get_provider(&name) { [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/provider.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 54 | if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - if path.is_file() && path.extension().map_or(false, |ext| ext == "json") { [INFO] [stdout] 54 + if path.is_file() && path.extension().is_some_and(|ext| ext == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AmarisRegistry` [INFO] [stdout] --> src/provider.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / pub fn new() -> Self { [INFO] [stdout] 145 | | Self { [INFO] [stdout] 146 | | providers: HashMap::new(), [INFO] [stdout] 147 | | } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 143 + impl Default for AmarisRegistry { [INFO] [stdout] 144 + fn default() -> Self { [INFO] [stdout] 145 + Self::new() [INFO] [stdout] 146 + } [INFO] [stdout] 147 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/provider.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn get_provider(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn AmarisProvider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / if let Some(parent) = path.parent() { [INFO] [stdout] 90 | | if !parent.exists() { [INFO] [stdout] 91 | | tokio::fs::create_dir_all(parent) [INFO] [stdout] 92 | | .await [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Some(parent) = path.parent() [INFO] [stdout] 90 ~ && !parent.exists() { [INFO] [stdout] 91 | tokio::fs::create_dir_all(parent) [INFO] [stdout] 92 | .await [INFO] [stdout] 93 | .map_err(|e| ConfigError::FileWriteError(e.to_string()))?; [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | if path.to_str().unwrap() == "settings.json".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"settings.json"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:318:16 [INFO] [stdout] | [INFO] [stdout] 318 | if !package_json.get("scripts").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `package_json.get("scripts").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:347:13 [INFO] [stdout] | [INFO] [stdout] 347 | / if let Some(scripts) = package_json.get_mut("scripts") { [INFO] [stdout] 348 | | if let Some(obj) = scripts.as_object_mut() { [INFO] [stdout] 349 | | obj.remove(name); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 347 ~ if let Some(scripts) = package_json.get_mut("scripts") [INFO] [stdout] 348 ~ && let Some(obj) = scripts.as_object_mut() { [INFO] [stdout] 349 | obj.remove(name); [INFO] [stdout] 350 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.25s [INFO] running `Command { std: "docker" "inspect" "365c0e85ecd1037287ae4f526959a2974066ba75f0eb3d47d679fee9fc7c019f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "365c0e85ecd1037287ae4f526959a2974066ba75f0eb3d47d679fee9fc7c019f", kill_on_drop: false }` [INFO] [stdout] 365c0e85ecd1037287ae4f526959a2974066ba75f0eb3d47d679fee9fc7c019f