[INFO] cloning repository https://github.com/aliftffd/experiment-tracker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aliftffd/experiment-tracker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faliftffd%2Fexperiment-tracker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faliftffd%2Fexperiment-tracker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 979272a41ef90df8b879d63302412a687ea582f9 [INFO] linting aliftffd/experiment-tracker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faliftffd%2Fexperiment-tracker" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aliftffd/experiment-tracker [INFO] finished tweaking git repo https://github.com/aliftffd/experiment-tracker [INFO] tweaked toml for git repo https://github.com/aliftffd/experiment-tracker written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aliftffd/experiment-tracker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aliftffd/experiment-tracker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded notify v7.0.0 [INFO] [stderr] Downloaded notify-types v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c51da6dbc14bf7d69719ce1cb760c9de4247a50c350ba982a389a59d3185495d [INFO] running `Command { std: "docker" "start" "-a" "c51da6dbc14bf7d69719ce1cb760c9de4247a50c350ba982a389a59d3185495d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c51da6dbc14bf7d69719ce1cb760c9de4247a50c350ba982a389a59d3185495d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c51da6dbc14bf7d69719ce1cb760c9de4247a50c350ba982a389a59d3185495d", kill_on_drop: false }` [INFO] [stdout] c51da6dbc14bf7d69719ce1cb760c9de4247a50c350ba982a389a59d3185495d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 271ec7c28463978a4e85d1a2ed687f7ea54dcc732c67a01c4dba7d4964fe9251 [INFO] running `Command { std: "docker" "start" "-a" "271ec7c28463978a4e85d1a2ed687f7ea54dcc732c67a01c4dba7d4964fe9251", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.23 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking clap_builder v4.5.58 [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking notify-types v1.0.1 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking notify v7.0.0 [INFO] [stderr] Checking similar v2.7.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking clap v4.5.58 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking experiment-tracker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/platform.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | / /// macOS: ~/Library/Application Support/experiment-tracker/ [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | pub fn data_dir() -> PathBuf { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/platform.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / /// macOS: ~/Library/Application Support/experiment-tracker/ [INFO] [stdout] 54 | | [INFO] [stdout] | |_^ [INFO] [stdout] 55 | pub fn config_dir() -> PathBuf { [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/platform.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | / /// macOS: ~/Library/Application Support/experiment-tracker/ [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | pub fn data_dir() -> PathBuf { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/ui/components/table.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// build a syled table widgets [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | pub fn styled_table<'a>( [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/platform.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / /// macOS: ~/Library/Application Support/experiment-tracker/ [INFO] [stdout] 54 | | [INFO] [stdout] | |_^ [INFO] [stdout] 55 | pub fn config_dir() -> PathBuf { [INFO] [stdout] | ----------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/ui/components/table.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// build a syled table widgets [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | pub fn styled_table<'a>( [INFO] [stdout] | ------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/handler.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | / if app.selected_run().is_some() { [INFO] [stdout] 351 | | app.input_mode = InputMode::DeleteConfirm; [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 349 ~ Action::DeleteRun [INFO] [stdout] 350 ~ if app.selected_run().is_some() => { [INFO] [stdout] 351 | app.input_mode = InputMode::DeleteConfirm; [INFO] [stdout] 352 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/handler.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 630 | / if app.refresh_runs().is_ok() { [INFO] [stdout] 631 | | // Also refresh detail if we're viewing one [INFO] [stdout] 632 | | if let Some(run) = app.current_run.clone() { [INFO] [stdout] 633 | | let _ = app.load_run_detail(run.id); [INFO] [stdout] 634 | | } [INFO] [stdout] 635 | | app.set_status("Refreshed"); [INFO] [stdout] 636 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 629 ~ Action::Refresh [INFO] [stdout] 630 ~ if app.refresh_runs().is_ok() => { [INFO] [stdout] 631 | // Also refresh detail if we're viewing one [INFO] [stdout] ... [INFO] [stdout] 635 | app.set_status("Refreshed"); [INFO] [stdout] 636 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/app/state.rs:553:28 [INFO] [stdout] | [INFO] [stdout] 553 | let batch: Vec<(i64, &str, Option, Option, f64)> = new_records [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/config/settings.rs:166:45 [INFO] [stdout] | [INFO] [stdout] 166 | return PathBuf::from(home).join(&path[2..]); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/config/settings.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 164 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 165 | if let Some(home) = std::env::var_os("HOME") { [INFO] [stdout] 166 ~ return PathBuf::from(home).join(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/db/metrics.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | metrics: &[(i64, &str, Option, Option, f64)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/docker/manager.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | / pub fn run_container( [INFO] [stdout] 136 | | &mut self, [INFO] [stdout] 137 | | run_id: i64, [INFO] [stdout] 138 | | image: &str, [INFO] [stdout] ... | [INFO] [stdout] 143 | | env_vars: &HashMap, [INFO] [stdout] 144 | | ) -> Result { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docker/manager.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 383 - '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] 383 + '\\' if !(!in_double && in_single) => { [INFO] [stdout] | [INFO] [stdout] 383 - '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] 383 + '\\' if in_double || !in_single => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/csv.rs:72:26 [INFO] [stdout] | [INFO] [stdout] 72 | let latest = metrics [INFO] [stdout] | __________________________^ [INFO] [stdout] 73 | | .iter() [INFO] [stdout] 74 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 75 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 75 - .last() [INFO] [stdout] 75 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/latex.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | / metrics [INFO] [stdout] 117 | | .iter() [INFO] [stdout] 118 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 119 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 119 - .last() [INFO] [stdout] 119 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/markdown.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / metrics [INFO] [stdout] 141 | | .iter() [INFO] [stdout] 142 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 143 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - .last() [INFO] [stdout] 143 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/handler.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | / if app.selected_run().is_some() { [INFO] [stdout] 351 | | app.input_mode = InputMode::DeleteConfirm; [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 349 ~ Action::DeleteRun [INFO] [stdout] 350 ~ if app.selected_run().is_some() => { [INFO] [stdout] 351 | app.input_mode = InputMode::DeleteConfirm; [INFO] [stdout] 352 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/handler.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 630 | / if app.refresh_runs().is_ok() { [INFO] [stdout] 631 | | // Also refresh detail if we're viewing one [INFO] [stdout] 632 | | if let Some(run) = app.current_run.clone() { [INFO] [stdout] 633 | | let _ = app.load_run_detail(run.id); [INFO] [stdout] 634 | | } [INFO] [stdout] 635 | | app.set_status("Refreshed"); [INFO] [stdout] 636 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 629 ~ Action::Refresh [INFO] [stdout] 630 ~ if app.refresh_runs().is_ok() => { [INFO] [stdout] 631 | // Also refresh detail if we're viewing one [INFO] [stdout] ... [INFO] [stdout] 635 | app.set_status("Refreshed"); [INFO] [stdout] 636 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/ui/compare.rs:203:21 [INFO] [stdout] | [INFO] [stdout] 203 | / metrics [INFO] [stdout] 204 | | .iter() [INFO] [stdout] 205 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 206 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 206 - .last() [INFO] [stdout] 206 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ui/components/table.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | .title(format!("{}", title)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `title.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/app/state.rs:553:28 [INFO] [stdout] | [INFO] [stdout] 553 | let batch: Vec<(i64, &str, Option, Option, f64)> = new_records [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/config/settings.rs:166:45 [INFO] [stdout] | [INFO] [stdout] 166 | return PathBuf::from(home).join(&path[2..]); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/config/settings.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 164 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 165 | if let Some(home) = std::env::var_os("HOME") { [INFO] [stdout] 166 ~ return PathBuf::from(home).join(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/db/metrics.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | metrics: &[(i64, &str, Option, Option, f64)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/watcher/directory.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | / ... if is_log_file(&path) { [INFO] [stdout] 43 | | ... if should_emit(&debounce_state, &path) { [INFO] [stdout] 44 | | ... let _ = tx_clone.send(WatchEvent::FileChanged(path)); [INFO] [stdout] 45 | | ... } [INFO] [stdout] 46 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ if is_log_file(&path) [INFO] [stdout] 43 ~ && should_emit(&debounce_state, &path) { [INFO] [stdout] 44 | let _ = tx_clone.send(WatchEvent::FileChanged(path)); [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/watcher/parser.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | / if let Value::Object(hp_map) = hp { [INFO] [stdout] 117 | | for (k, v) in hp_map { [INFO] [stdout] 118 | | hyperparams.insert(k.clone(), value_to_string(v)); [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/watcher/parser.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(hp) = map.get("hyperparams").or(map.get("config")) { [INFO] [stdout] | ^^ replace this binding [INFO] [stdout] 116 | if let Value::Object(hp_map) = hp { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/docker/manager.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | / pub fn run_container( [INFO] [stdout] 136 | | &mut self, [INFO] [stdout] 137 | | run_id: i64, [INFO] [stdout] 138 | | image: &str, [INFO] [stdout] ... | [INFO] [stdout] 143 | | env_vars: &HashMap, [INFO] [stdout] 144 | | ) -> Result { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui/run_detail.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | let tabs = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 118 | | ("Chart", DetailSubView::Chart), [INFO] [stdout] 119 | | ("Hyperparams", DetailSubView::Hyperparams), [INFO] [stdout] 120 | | ("Logs", DetailSubView::Logs), [INFO] [stdout] 121 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 117 ~ let tabs = [("Chart", DetailSubView::Chart), [INFO] [stdout] 118 + ("Hyperparams", DetailSubView::Hyperparams), [INFO] [stdout] 119 ~ ("Logs", DetailSubView::Logs)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docker/manager.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 383 - '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] 383 + '\\' if !(!in_double && in_single) => { [INFO] [stdout] | [INFO] [stdout] 383 - '\\' if in_double || (!in_single && !in_double) => { [INFO] [stdout] 383 + '\\' if in_double || !in_single => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/csv.rs:72:26 [INFO] [stdout] | [INFO] [stdout] 72 | let latest = metrics [INFO] [stdout] | __________________________^ [INFO] [stdout] 73 | | .iter() [INFO] [stdout] 74 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 75 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 75 - .last() [INFO] [stdout] 75 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/latex.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | / metrics [INFO] [stdout] 117 | | .iter() [INFO] [stdout] 118 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 119 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 119 - .last() [INFO] [stdout] 119 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/export/markdown.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / metrics [INFO] [stdout] 141 | | .iter() [INFO] [stdout] 142 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 143 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - .last() [INFO] [stdout] 143 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/ui/compare.rs:203:21 [INFO] [stdout] | [INFO] [stdout] 203 | / metrics [INFO] [stdout] 204 | | .iter() [INFO] [stdout] 205 | | .filter(|m| &m.name == metric_name) [INFO] [stdout] 206 | | .last() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 206 - .last() [INFO] [stdout] 206 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ui/components/table.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | .title(format!("{}", title)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `title.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/watcher/directory.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | / ... if is_log_file(&path) { [INFO] [stdout] 43 | | ... if should_emit(&debounce_state, &path) { [INFO] [stdout] 44 | | ... let _ = tx_clone.send(WatchEvent::FileChanged(path)); [INFO] [stdout] 45 | | ... } [INFO] [stdout] 46 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ if is_log_file(&path) [INFO] [stdout] 43 ~ && should_emit(&debounce_state, &path) { [INFO] [stdout] 44 | let _ = tx_clone.send(WatchEvent::FileChanged(path)); [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/watcher/parser.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | / if let Value::Object(hp_map) = hp { [INFO] [stdout] 117 | | for (k, v) in hp_map { [INFO] [stdout] 118 | | hyperparams.insert(k.clone(), value_to_string(v)); [INFO] [stdout] ... | [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/watcher/parser.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(hp) = map.get("hyperparams").or(map.get("config")) { [INFO] [stdout] | ^^ replace this binding [INFO] [stdout] 116 | if let Value::Object(hp_map) = hp { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ui/run_detail.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | let tabs = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 118 | | ("Chart", DetailSubView::Chart), [INFO] [stdout] 119 | | ("Hyperparams", DetailSubView::Hyperparams), [INFO] [stdout] 120 | | ("Logs", DetailSubView::Logs), [INFO] [stdout] 121 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 117 ~ let tabs = [("Chart", DetailSubView::Chart), [INFO] [stdout] 118 + ("Hyperparams", DetailSubView::Hyperparams), [INFO] [stdout] 119 ~ ("Logs", DetailSubView::Logs)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> tests/db_tests.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | let batch: Vec<(i64, &str, Option, Option, f64)> = (0..1000) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.85s [INFO] running `Command { std: "docker" "inspect" "271ec7c28463978a4e85d1a2ed687f7ea54dcc732c67a01c4dba7d4964fe9251", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "271ec7c28463978a4e85d1a2ed687f7ea54dcc732c67a01c4dba7d4964fe9251", kill_on_drop: false }` [INFO] [stdout] 271ec7c28463978a4e85d1a2ed687f7ea54dcc732c67a01c4dba7d4964fe9251