[INFO] cloning repository https://github.com/ali-valiev/simsync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ali-valiev/simsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fali-valiev%2Fsimsync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fali-valiev%2Fsimsync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 95168282ffa107ecaa184913e05f703fbc4f565f [INFO] linting ali-valiev/simsync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fali-valiev%2Fsimsync" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ali-valiev/simsync [INFO] finished tweaking git repo https://github.com/ali-valiev/simsync [INFO] tweaked toml for git repo https://github.com/ali-valiev/simsync written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ali-valiev/simsync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ali-valiev/simsync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pest_meta v2.7.10 [INFO] [stderr] Downloaded pest_derive v2.7.10 [INFO] [stderr] Downloaded pest_generator v2.7.10 [INFO] [stderr] Downloaded pest v2.7.10 [INFO] [stderr] Downloaded cc v1.0.100 [INFO] [stderr] Downloaded html_parser v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b9e6b9415df8bb6d64a4191fa3ce6fd23ed5a44a703994f5ad51f4b03c61480 [INFO] running `Command { std: "docker" "start" "-a" "8b9e6b9415df8bb6d64a4191fa3ce6fd23ed5a44a703994f5ad51f4b03c61480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b9e6b9415df8bb6d64a4191fa3ce6fd23ed5a44a703994f5ad51f4b03c61480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b9e6b9415df8bb6d64a4191fa3ce6fd23ed5a44a703994f5ad51f4b03c61480", kill_on_drop: false }` [INFO] [stdout] 8b9e6b9415df8bb6d64a4191fa3ce6fd23ed5a44a703994f5ad51f4b03c61480 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd5960b8b0ea44ca6241838f43ab3e5824c933c456749484d9e1f064de66591d [INFO] running `Command { std: "docker" "start" "-a" "fd5960b8b0ea44ca6241838f43ab3e5824c933c456749484d9e1f064de66591d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling cc v1.0.100 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking pest v2.7.10 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking html_parser v0.7.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking simsync v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/parse.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use html_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/parse.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use html_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_file_index.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return Err(e.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Err(e.into()); [INFO] [stdout] 32 + Err(e.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_file_index.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return Err(e.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Err(e.into()); [INFO] [stdout] 32 + Err(e.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | let current_files: Option>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `current_files` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ let current_files: Option> = match get_current_file_index(dir) { [INFO] [stdout] 56 | Ok(files) => { [INFO] [stdout] 57 ~ files [INFO] [stdout] 58 | } [INFO] [stdout] ... [INFO] [stdout] 62 | } [INFO] [stdout] 63 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | let current_files: Option>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `current_files` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ let current_files: Option> = match get_current_file_index(dir) { [INFO] [stdout] 56 | Ok(files) => { [INFO] [stdout] 57 ~ files [INFO] [stdout] 58 | } [INFO] [stdout] ... [INFO] [stdout] 62 | } [INFO] [stdout] 63 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 105 | match traverse_and_save(&file_index_name, &json, &dir) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `file_index_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 105 | match traverse_and_save(&file_index_name, &json, &dir) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `file_index_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:54 [INFO] [stdout] | [INFO] [stdout] 105 | match traverse_and_save(&file_index_name, &json, &dir) { [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:105:54 [INFO] [stdout] | [INFO] [stdout] 105 | match traverse_and_save(&file_index_name, &json, &dir) { [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.51s [INFO] running `Command { std: "docker" "inspect" "fd5960b8b0ea44ca6241838f43ab3e5824c933c456749484d9e1f064de66591d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd5960b8b0ea44ca6241838f43ab3e5824c933c456749484d9e1f064de66591d", kill_on_drop: false }` [INFO] [stdout] fd5960b8b0ea44ca6241838f43ab3e5824c933c456749484d9e1f064de66591d