[INFO] cloning repository https://github.com/alexjago/advent-of-code-2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alexjago/advent-of-code-2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexjago%2Fadvent-of-code-2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexjago%2Fadvent-of-code-2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18ce4fe7095b50ba4e46e37c576ea0fa41c70983 [INFO] linting alexjago/advent-of-code-2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falexjago%2Fadvent-of-code-2024" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/alexjago/advent-of-code-2024 [INFO] finished tweaking git repo https://github.com/alexjago/advent-of-code-2024 [INFO] tweaked toml for git repo https://github.com/alexjago/advent-of-code-2024 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/alexjago/advent-of-code-2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/alexjago/advent-of-code-2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/alexjago/range-split` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memoize v0.4.2 [INFO] [stderr] Downloaded memoize-inner v0.4.3 [INFO] [stderr] Downloaded env_filter v0.1.2 [INFO] [stderr] Downloaded clap_lex v0.7.3 [INFO] [stderr] Downloaded anstyle-wincon v3.0.6 [INFO] [stderr] Downloaded clap-verbosity-flag v3.0.2 [INFO] [stderr] Downloaded clap_derive v4.5.18 [INFO] [stderr] Downloaded unicode-ident v1.0.14 [INFO] [stderr] Downloaded clap v4.5.21 [INFO] [stderr] Downloaded proc-macro2 v1.0.92 [INFO] [stderr] Downloaded indexmap v2.7.0 [INFO] [stderr] Downloaded rustversion v1.0.18 [INFO] [stderr] Downloaded env_logger v0.11.5 [INFO] [stderr] Downloaded syn v2.0.90 [INFO] [stderr] Downloaded clap_builder v4.5.21 [INFO] [stderr] Downloaded libc v0.2.167 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cc026c4e7e2389fff6e0e3baecd6f9e5a35a4d95af4895e95e24be63f592362 [INFO] running `Command { std: "docker" "start" "-a" "2cc026c4e7e2389fff6e0e3baecd6f9e5a35a4d95af4895e95e24be63f592362", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cc026c4e7e2389fff6e0e3baecd6f9e5a35a4d95af4895e95e24be63f592362", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cc026c4e7e2389fff6e0e3baecd6f9e5a35a4d95af4895e95e24be63f592362", kill_on_drop: false }` [INFO] [stdout] 2cc026c4e7e2389fff6e0e3baecd6f9e5a35a4d95af4895e95e24be63f592362 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00ac90c5032a9da49d7345e3e4ffedfe5a576f40ed12f7b9f127e9c0f4b634b0 [INFO] running `Command { std: "docker" "start" "-a" "00ac90c5032a9da49d7345e3e4ffedfe5a576f40ed12f7b9f127e9c0f4b634b0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking range_split v0.1.0 (https://github.com/alexjago/range-split#a2c55535) [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking lru v0.7.8 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling memoize-inner v0.4.3 [INFO] [stderr] Checking memoize v0.4.2 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking clap-verbosity-flag v3.0.2 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking day-06 v0.2.0 (/opt/rustwide/workdir/day-06) [INFO] [stderr] Checking day-07 v0.2.0 (/opt/rustwide/workdir/day-07) [INFO] [stderr] Checking day-05 v0.2.0 (/opt/rustwide/workdir/day-05) [INFO] [stderr] Checking day-03 v0.2.0 (/opt/rustwide/workdir/day-03) [INFO] [stderr] Checking day-02 v0.2.0 (/opt/rustwide/workdir/day-02) [INFO] [stderr] Checking day-01 v0.2.0 (/opt/rustwide/workdir/day-01) [INFO] [stdout] warning: unused import: `hash_set::Iter` [INFO] [stdout] --> day-05/src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{hash_set::Iter, HashSet}, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-05/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-05/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-05/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-01/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-01/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-01/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-03/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-03/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-03/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-03/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-03/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-03/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-03/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::AddAssign` [INFO] [stdout] --> day-07/src/main.rs:1:54 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::VecDeque, fs::read_to_string, ops::AddAssign}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-07/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `memoize::memoize` [INFO] [stdout] --> day-07/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use memoize::memoize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-07/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-07/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-07/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-02/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-02/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-02/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-05/src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if v.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `v` [INFO] [stdout] --> day-05/src/main.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | for j in i..v.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for j in i..v.len() { [INFO] [stdout] 77 + for in v.iter().skip(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-05/src/main.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if v.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day-09 v0.2.0 (/opt/rustwide/workdir/day-09) [INFO] [stdout] warning: unused import: `hash_set::Iter` [INFO] [stdout] --> day-05/src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{hash_set::Iter, HashSet}, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-05/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-05/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-05/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-05/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-02/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-02/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-02/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-02/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-09/src/main.rs:34:45 [INFO] [stdout] | [INFO] [stdout] 34 | for (i, c) in infile.chars().filter(|x| x.is_digit(10)).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-09/src/main.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | for (i, c) in infile.chars().filter(|x| x.is_digit(10)).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> day-09/src/main.rs:143:24 [INFO] [stdout] | [INFO] [stdout] 143 | out += p * match i { [INFO] [stdout] | ________________________^ [INFO] [stdout] 144 | | Some(y) => y, [INFO] [stdout] 145 | | None => 0, [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____________^ help: ascribe the type usize and replace your expression with: `i.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day-04 v0.2.0 (/opt/rustwide/workdir/day-04) [INFO] [stdout] warning: unused import: `ops::AddAssign` [INFO] [stdout] --> day-07/src/main.rs:1:54 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::VecDeque, fs::read_to_string, ops::AddAssign}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-07/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `memoize::memoize` [INFO] [stdout] --> day-07/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use memoize::memoize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-07/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-07/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-07/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-07/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-04/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-04/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-04/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-04/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-05/src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if v.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `v` [INFO] [stdout] --> day-05/src/main.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | for j in i..v.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for j in i..v.len() { [INFO] [stdout] 77 + for in v.iter().skip(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-09/src/main.rs:34:45 [INFO] [stdout] | [INFO] [stdout] 34 | for (i, c) in infile.chars().filter(|x| x.is_digit(10)).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-01/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-01/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-01/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-01/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day-06/src/main.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | let turn = match grid[fr][fc] { [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | '#' => true, [INFO] [stdout] 75 | | _ => false, [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 73 - let turn = match grid[fr][fc] { [INFO] [stdout] 74 - '#' => true, [INFO] [stdout] 75 - _ => false, [INFO] [stdout] 76 - }; [INFO] [stdout] 73 + let turn = matches!(grid[fr][fc], '#'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-09/src/main.rs:86:45 [INFO] [stdout] | [INFO] [stdout] 86 | for (i, c) in infile.chars().filter(|x| x.is_digit(10)).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> day-06/src/main.rs:142:27 [INFO] [stdout] | [INFO] [stdout] 142 | Some((r.clone(), c, *x)) [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-05/src/main.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if v.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day-06/src/main.rs:192:24 [INFO] [stdout] | [INFO] [stdout] 192 | let turn = match grid[fr][fc] { [INFO] [stdout] | ________________________^ [INFO] [stdout] 193 | | '#' => true, [INFO] [stdout] 194 | | _ => false, [INFO] [stdout] 195 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 192 - let turn = match grid[fr][fc] { [INFO] [stdout] 193 - '#' => true, [INFO] [stdout] 194 - _ => false, [INFO] [stdout] 195 - }; [INFO] [stdout] 192 + let turn = matches!(grid[fr][fc], '#'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> day-09/src/main.rs:143:24 [INFO] [stdout] | [INFO] [stdout] 143 | out += p * match i { [INFO] [stdout] | ________________________^ [INFO] [stdout] 144 | | Some(y) => y, [INFO] [stdout] 145 | | None => 0, [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____________^ help: ascribe the type usize and replace your expression with: `i.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> day-01/src/main.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> day-01/src/main.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | unreachable expression [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> day-01/src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> day-01/src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | unreachable expression [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> day-01/src/main.rs:79:39 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: `#[warn(clippy::diverging_sub_expression)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> day-01/src/main.rs:84:39 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day-06/src/main.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | let turn = match grid[fr][fc] { [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | '#' => true, [INFO] [stdout] 75 | | _ => false, [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 73 - let turn = match grid[fr][fc] { [INFO] [stdout] 74 - '#' => true, [INFO] [stdout] 75 - _ => false, [INFO] [stdout] 76 - }; [INFO] [stdout] 73 + let turn = matches!(grid[fr][fc], '#'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> day-06/src/main.rs:142:27 [INFO] [stdout] | [INFO] [stdout] 142 | Some((r.clone(), c, *x)) [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-04/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-04/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-04/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-04/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-04/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day-06/src/main.rs:192:24 [INFO] [stdout] | [INFO] [stdout] 192 | let turn = match grid[fr][fc] { [INFO] [stdout] | ________________________^ [INFO] [stdout] 193 | | '#' => true, [INFO] [stdout] 194 | | _ => false, [INFO] [stdout] 195 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 192 - let turn = match grid[fr][fc] { [INFO] [stdout] 193 - '#' => true, [INFO] [stdout] 194 - _ => false, [INFO] [stdout] 195 - }; [INFO] [stdout] 192 + let turn = matches!(grid[fr][fc], '#'); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | return Some(output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return Some(output); [INFO] [stdout] 54 + Some(output) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return None; [INFO] [stdout] 56 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | return Some(right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return Some(right); [INFO] [stdout] 60 + Some(right) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> day-07/src/main.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | let rez = line [INFO] [stdout] | _______________________^ [INFO] [stdout] 73 | | .split(":") [INFO] [stdout] 74 | | .nth(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 72 ~ let rez = line [INFO] [stdout] 73 + .split(":").next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> day-07/src/main.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | kk = kk >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `kk >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> day-07/src/main.rs:126:23 [INFO] [stdout] | [INFO] [stdout] 126 | let rez = line [INFO] [stdout] | _______________________^ [INFO] [stdout] 127 | | .split(":") [INFO] [stdout] 128 | | .nth(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 126 ~ let rez = line [INFO] [stdout] 127 + .split(":").next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> day-07/src/main.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | kk = kk / 3; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `kk /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | return Some(output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return Some(output); [INFO] [stdout] 54 + Some(output) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return None; [INFO] [stdout] 56 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-07/src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | return Some(right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return Some(right); [INFO] [stdout] 60 + Some(right) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> day-07/src/main.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | let rez = line [INFO] [stdout] | _______________________^ [INFO] [stdout] 73 | | .split(":") [INFO] [stdout] 74 | | .nth(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 72 ~ let rez = line [INFO] [stdout] 73 + .split(":").next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> day-07/src/main.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | kk = kk >> 1; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `kk >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> day-07/src/main.rs:126:23 [INFO] [stdout] | [INFO] [stdout] 126 | let rez = line [INFO] [stdout] | _______________________^ [INFO] [stdout] 127 | | .split(":") [INFO] [stdout] 128 | | .nth(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 126 ~ let rez = line [INFO] [stdout] 127 + .split(":").next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> day-07/src/main.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | kk = kk / 3; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `kk /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking mapgrid v0.2.1 (/opt/rustwide/workdir/mapgrid) [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | let xmax = self.iter().map(|(v, _)| v[0]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let ymax = self.iter().map(|(v, _)| v[1]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let xmin = self.iter().map(|(v, _)| v[0]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | let ymin = self.iter().map(|(v, _)| v[1]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | let xmax = self.iter().map(|(v, _)| v[0]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 162 | let ymax = self.iter().map(|(v, _)| v[1]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 163 | let xmin = self.iter().map(|(v, _)| v[0]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | let ymin = self.iter().map(|(v, _)| v[1]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking template v0.1.0 (/opt/rustwide/workdir/template) [INFO] [stderr] Checking day-08 v0.1.0 (/opt/rustwide/workdir/day-08) [INFO] [stderr] Checking day-15 v0.2.0 (/opt/rustwide/workdir/day-15) [INFO] [stderr] Checking day-18 v0.2.0 (/opt/rustwide/workdir/day-18) [INFO] [stderr] Checking day-16 v0.2.0 (/opt/rustwide/workdir/day-16) [INFO] [stderr] Checking day-13 v0.1.0 (/opt/rustwide/workdir/day-13) [INFO] [stderr] Checking day-17 v0.2.0 (/opt/rustwide/workdir/day-17) [INFO] [stderr] Checking day-10 v0.1.0 (/opt/rustwide/workdir/day-10) [INFO] [stderr] Checking advent-of-code-2024 v0.20.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking day-12 v0.2.1 (/opt/rustwide/workdir/day-12) [INFO] [stderr] Checking day-20 v0.2.0 (/opt/rustwide/workdir/day-20) [INFO] [stderr] Checking day-14 v0.2.2 (/opt/rustwide/workdir/day-14) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-20/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-20/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-20/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-12/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-12/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-12/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashSet` and `ops::RangeBounds` [INFO] [stdout] --> day-08/src/main.rs:2:28 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 3 | fs::read_to_string, [INFO] [stdout] 4 | ops::RangeBounds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Unique` [INFO] [stdout] --> day-08/src/main.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use itertools::{Itertools, Unique}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-08/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-08/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-08/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-12/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-17/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error`, `info`, and `warn` [INFO] [stdout] --> day-17/src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::RangeBounds` [INFO] [stdout] --> day-20/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::RangeBounds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-08/src/main.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if x.is_digit(10) || x.is_ascii_alphabetic() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> day-08/src/main.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | outpos.iter().map(|(k, _)| k).unique().count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outpos.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-08/src/main.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 109 | if x.is_digit(10) || x.is_ascii_alphabetic() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> day-08/src/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | outpos.iter().map(|(k, _)| k).unique().count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outpos.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-16/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-16/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-16/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day-19 v0.2.0 (/opt/rustwide/workdir/day-19) [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | visited.insert(goal.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | queue.insert(goal.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> day-20/src/main.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if d >= 2 && d <= 20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(2..=20).contains(&d)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-20/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-20/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-20/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Integer` and `integer::ExtendedGcd` [INFO] [stdout] --> day-13/src/main.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use num::{integer::ExtendedGcd, Integer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `root` [INFO] [stdout] --> day-12/src/main.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | for (root, plots) in regions { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_root` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-18/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-18/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> day-18/src/main.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-18/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> template/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `info`, and `warn` [INFO] [stdout] --> template/src/main.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, info, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mapgrid::*` [INFO] [stdout] --> template/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use mapgrid::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> template/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> template/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap`, `BTreeSet`, `HashMap`, and `HashSet` [INFO] [stdout] --> template/src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> template/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-12/src/main.rs:32:69 [INFO] [stdout] | [INFO] [stdout] 32 | as Grid>::from_str_with(infile, |x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | let mut queue = vec![coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> day-12/src/main.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | / if regions_rev.contains_key(&next) { [INFO] [stdout] 58 | | continue; [INFO] [stdout] 59 | | } else if cha == nc { [INFO] [stdout] 60 | | regions_rev.insert(next, coord.clone()); [INFO] [stdout] 61 | | queue.push(next) [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let std::collections::hash_map::Entry::Vacant(e) = regions_rev.entry(next) if cha == nc { [INFO] [stdout] 58 + e.insert(coord.clone()); [INFO] [stdout] 59 + queue.push(next) [INFO] [stdout] 60 + } else { [INFO] [stdout] 61 + continue; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | regions_rev.insert(next, coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-12/src/main.rs:94:69 [INFO] [stdout] | [INFO] [stdout] 94 | as Grid>::from_str_with(infile, |x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-10/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-10/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-10/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-10/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:105:47 [INFO] [stdout] | [INFO] [stdout] 105 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:108:30 [INFO] [stdout] | [INFO] [stdout] 108 | let mut queue = vec![coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> day-12/src/main.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | / if regions_rev.contains_key(&next) { [INFO] [stdout] 116 | | continue; [INFO] [stdout] 117 | | } else if cha == nc { [INFO] [stdout] 118 | | regions_rev.insert(next, coord.clone()); [INFO] [stdout] 119 | | queue.push(next) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 115 ~ if let std::collections::hash_map::Entry::Vacant(e) = regions_rev.entry(next) if cha == nc { [INFO] [stdout] 116 + e.insert(coord.clone()); [INFO] [stdout] 117 + queue.push(next) [INFO] [stdout] 118 + } else { [INFO] [stdout] 119 + continue; [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | regions_rev.insert(next, coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | k.clone(), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:189:32 [INFO] [stdout] | [INFO] [stdout] 189 | corners.insert(v.clone(), '@'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:199:40 [INFO] [stdout] | [INFO] [stdout] 199 | edges.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:199:51 [INFO] [stdout] | [INFO] [stdout] 199 | edges.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | k.clone(), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | corners.insert(v.clone(), '@'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day-16/src/main.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | && !(grid.get(&newpos).unwrap_or(&'#') == &'#') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(grid.get(&newpos).unwrap_or(&'#') != &'#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-16/src/main.rs:64:76 [INFO] [stdout] | [INFO] [stdout] 64 | let grid = as Grid>::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | scores.insert(start_pos.clone(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-20/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-20/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-20/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-16/src/main.rs:142:76 [INFO] [stdout] | [INFO] [stdout] 142 | let grid = as Grid>::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-18/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-18/src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> day-18/src/main.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-18/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-18/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-10/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-10/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-10/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-10/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-10/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:166:23 [INFO] [stdout] | [INFO] [stdout] 166 | histories.insert((start_pos.clone(), EAST), HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | scores.insert((start_pos.clone(), EAST), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> day-16/src/main.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if scores.len() % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `scores.len().is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | .map(|(p, _)| p.clone()) [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | let xmax = self.iter().map(|(v, _)| v[0]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let ymax = self.iter().map(|(v, _)| v[1]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let xmin = self.iter().map(|(v, _)| v[0]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | let ymin = self.iter().map(|(v, _)| v[1]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> day-14/src/main.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 84 | quads.iter().fold(1, |acc, x| acc * x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-14/src/main.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return seconds; [INFO] [stdout] 110 + seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-14/src/main.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return -1; [INFO] [stdout] 127 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> template/src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> template/src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | unreachable expression [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> template/src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> template/src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | unreachable expression [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | let xmax = self.iter().map(|(v, _)| v[0]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 162 | let ymax = self.iter().map(|(v, _)| v[1]).max().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 163 | let xmin = self.iter().map(|(v, _)| v[0]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> mapgrid/src/lib.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | let ymin = self.iter().map(|(v, _)| v[1]).min().unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.keys().map(|v| v[1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `infile` [INFO] [stdout] --> template/src/main.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 41 | fn part_1(infile: &str) -> usize { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_infile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `infile` [INFO] [stdout] --> template/src/main.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | fn part_2(infile: &str) -> usize { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_infile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-20/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-20/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-20/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-20/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> template/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `info`, and `warn` [INFO] [stdout] --> template/src/main.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, info, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mapgrid::*` [INFO] [stdout] --> template/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use mapgrid::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> template/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> template/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap`, `BTreeSet`, `HashMap`, and `HashSet` [INFO] [stdout] --> template/src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> template/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> template/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::RangeBounds` [INFO] [stdout] --> day-20/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::RangeBounds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> template/src/main.rs:57:39 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(part_1(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: `#[warn(clippy::diverging_sub_expression)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> template/src/main.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(part_2(EXAMPLE_1), todo!()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> day-15/src/main.rs:187:10 [INFO] [stdout] | [INFO] [stdout] 187 | for (i, dir) in moves.chars().filter_map(move_to_dir).enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-13/src/main.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day-11 v0.2.0 (/opt/rustwide/workdir/day-11) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-19/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `info` and `warn` [INFO] [stdout] --> day-19/src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, info, trace, warn}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mapgrid::*` [INFO] [stdout] --> day-19/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use mapgrid::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-19/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-19/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> day-19/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap`, `BTreeSet`, and `HashSet` [INFO] [stdout] --> day-19/src/main.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::AddAssign` [INFO] [stdout] --> day-19/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::ops::AddAssign; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-19/src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::RangeBounds` [INFO] [stdout] --> day-20/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::RangeBounds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Integer` and `integer::ExtendedGcd` [INFO] [stdout] --> day-13/src/main.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use num::{integer::ExtendedGcd, Integer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> day-15/src/main.rs:187:10 [INFO] [stdout] | [INFO] [stdout] 187 | for (i, dir) in moves.chars().filter_map(move_to_dir).enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | combine.insert(k.clone(), 'O'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::RangeBounds` [INFO] [stdout] --> day-20/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::ops::RangeBounds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | visited.insert(start.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | queue.insert(start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-13/src/main.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `infile` [INFO] [stdout] --> template/src/main.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 41 | fn part_1(infile: &str) -> usize { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_infile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `infile` [INFO] [stdout] --> template/src/main.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | fn part_2(infile: &str) -> usize { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_infile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> day-11/src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{BTreeMap, HashMap}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-11/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-11/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-11/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-11/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> day-10/src/main.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | c.to_digit(10).and_then(|x| Some(x as isize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).map(|x| x as isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-12/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-12/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-12/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-12/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | visited.insert(goal.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | queue.insert(goal.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | visited.insert(goal.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | queue.insert(goal.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | visited.insert(goal.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-20/src/main.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | queue.insert(goal.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `goal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> day-19/src/main.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | for (i, d) in lines.enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashSet` and `ops::RangeBounds` [INFO] [stdout] --> day-08/src/main.rs:2:28 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 3 | fs::read_to_string, [INFO] [stdout] 4 | ops::RangeBounds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Unique` [INFO] [stdout] --> day-08/src/main.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use itertools::{Itertools, Unique}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> day-20/src/main.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if d >= 2 && d <= 20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(2..=20).contains(&d)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-08/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-08/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-08/src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-08/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> day-20/src/main.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if d >= 2 && d <= 20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(2..=20).contains(&d)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> day-20/src/main.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if d >= 2 && d <= 20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(2..=20).contains(&d)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-20/src/main.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | let grid: HashMap = Grid::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:50:42 [INFO] [stdout] | [INFO] [stdout] 50 | let mut queue: Vec = vec![head_coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day-17/src/main.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | &instrs, [INFO] [stdout] | ^^^^^^^ help: change this to: `instrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:57:34 [INFO] [stdout] | [INFO] [stdout] 57 | reachable.insert(this.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `this` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> day-10/src/main.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | c.to_digit(10).and_then(|x| Some(x as isize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).map(|x| x as isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-16/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-16/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-16/src/main.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-16/src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:99:42 [INFO] [stdout] | [INFO] [stdout] 99 | let mut queue: Vec = vec![head_coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | reachable.insert(this.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `this` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> day-11/src/main.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 44 | let digits = (n.ilog(10) + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `n.ilog(10).div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | combine.insert(k.clone(), 'O'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-17/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error`, `info`, and `warn` [INFO] [stdout] --> day-17/src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | ... histories.entry(next.clone()).or_default().insert(h.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | visited.insert(start.clone(), 0_usize); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-18/src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | queue.insert(start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-11/src/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return *rez; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return *rez; [INFO] [stdout] 100 + *rez [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-11/src/main.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return rez; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return rez; [INFO] [stdout] 114 + rez [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-19/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `info` and `warn` [INFO] [stdout] --> day-19/src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{debug, info, trace, warn}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mapgrid::*` [INFO] [stdout] --> day-19/src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use mapgrid::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-19/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-19/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> day-19/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap`, `BTreeSet`, and `HashSet` [INFO] [stdout] --> day-19/src/main.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::AddAssign` [INFO] [stdout] --> day-19/src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::ops::AddAssign; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-19/src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-19/src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-19/src/main.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | let mut lines = infile.lines().filter(|s| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-19/src/main.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return false; [INFO] [stdout] 102 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> day-19/src/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | } else if design.starts_with(t) { [INFO] [stdout] | ________________^ [INFO] [stdout] 95 | | if part_1_helper(towels, &design[t.len()..], memo) { [INFO] [stdout] 96 | | memo.insert(design, true); [INFO] [stdout] 97 | | return true; [INFO] [stdout] 98 | | } [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ } else if design.starts_with(t) [INFO] [stdout] 95 ~ && part_1_helper(towels, &design[t.len()..], memo) { [INFO] [stdout] 96 | memo.insert(design, true); [INFO] [stdout] 97 | return true; [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-19/src/main.rs:120:47 [INFO] [stdout] | [INFO] [stdout] 120 | let mut lines = infile.lines().filter(|s| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-19/src/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | return arrangements; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return arrangements; [INFO] [stdout] 164 + arrangements [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-12/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> day-10/src/main.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | c.to_digit(10).and_then(|x| Some(x as isize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).map(|x| x as isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:50:42 [INFO] [stdout] | [INFO] [stdout] 50 | let mut queue: Vec = vec![head_coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:57:34 [INFO] [stdout] | [INFO] [stdout] 57 | reachable.insert(this.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `this` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `root` [INFO] [stdout] --> day-12/src/main.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | for (root, plots) in regions { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_root` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> day-10/src/main.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | c.to_digit(10).and_then(|x| Some(x as isize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).map(|x| x as isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> day-19/src/main.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | for (i, d) in lines.enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:99:42 [INFO] [stdout] | [INFO] [stdout] 99 | let mut queue: Vec = vec![head_coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*head_coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | reachable.insert(this.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `this` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-10/src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | ... histories.entry(next.clone()).or_default().insert(h.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-12/src/main.rs:32:69 [INFO] [stdout] | [INFO] [stdout] 32 | as Grid>::from_str_with(infile, |x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | let mut queue = vec![coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> day-12/src/main.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | / if regions_rev.contains_key(&next) { [INFO] [stdout] 58 | | continue; [INFO] [stdout] 59 | | } else if cha == nc { [INFO] [stdout] 60 | | regions_rev.insert(next, coord.clone()); [INFO] [stdout] 61 | | queue.push(next) [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let std::collections::hash_map::Entry::Vacant(e) = regions_rev.entry(next) if cha == nc { [INFO] [stdout] 58 + e.insert(coord.clone()); [INFO] [stdout] 59 + queue.push(next) [INFO] [stdout] 60 + } else { [INFO] [stdout] 61 + continue; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | regions_rev.insert(next, coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-12/src/main.rs:94:69 [INFO] [stdout] | [INFO] [stdout] 94 | as Grid>::from_str_with(infile, |x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-19/src/main.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | let mut lines = infile.lines().filter(|s| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 105 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:105:47 [INFO] [stdout] | [INFO] [stdout] 105 | regions_rev.insert(coord.clone(), coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:108:30 [INFO] [stdout] | [INFO] [stdout] 108 | let mut queue = vec![coord.clone()]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> day-12/src/main.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | / if regions_rev.contains_key(&next) { [INFO] [stdout] 116 | | continue; [INFO] [stdout] 117 | | } else if cha == nc { [INFO] [stdout] 118 | | regions_rev.insert(next, coord.clone()); [INFO] [stdout] 119 | | queue.push(next) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 115 ~ if let std::collections::hash_map::Entry::Vacant(e) = regions_rev.entry(next) if cha == nc { [INFO] [stdout] 116 + e.insert(coord.clone()); [INFO] [stdout] 117 + queue.push(next) [INFO] [stdout] 118 + } else { [INFO] [stdout] 119 + continue; [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-19/src/main.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return false; [INFO] [stdout] 102 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | regions_rev.insert(next, coord.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*coord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> day-19/src/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | } else if design.starts_with(t) { [INFO] [stdout] | ________________^ [INFO] [stdout] 95 | | if part_1_helper(towels, &design[t.len()..], memo) { [INFO] [stdout] 96 | | memo.insert(design, true); [INFO] [stdout] 97 | | return true; [INFO] [stdout] 98 | | } [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ } else if design.starts_with(t) [INFO] [stdout] 95 ~ && part_1_helper(towels, &design[t.len()..], memo) { [INFO] [stdout] 96 | memo.insert(design, true); [INFO] [stdout] 97 | return true; [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> day-19/src/main.rs:120:47 [INFO] [stdout] | [INFO] [stdout] 120 | let mut lines = infile.lines().filter(|s| s.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | k.clone(), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:189:32 [INFO] [stdout] | [INFO] [stdout] 189 | corners.insert(v.clone(), '@'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-19/src/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | return arrangements; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return arrangements; [INFO] [stdout] 164 + arrangements [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:199:40 [INFO] [stdout] | [INFO] [stdout] 199 | edges.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:199:51 [INFO] [stdout] | [INFO] [stdout] 199 | edges.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | k.clone(), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-12/src/main.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | corners.insert(v.clone(), '@'); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-08/src/main.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if x.is_digit(10) || x.is_ascii_alphabetic() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> day-08/src/main.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | outpos.iter().map(|(k, _)| k).unique().count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outpos.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> day-08/src/main.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 109 | if x.is_digit(10) || x.is_ascii_alphabetic() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day-17/src/main.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | &instrs, [INFO] [stdout] | ^^^^^^^ help: change this to: `instrs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's keys [INFO] [stdout] --> day-08/src/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | outpos.iter().map(|(k, _)| k).unique().count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outpos.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> day-11/src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{BTreeMap, HashMap}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> day-11/src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom` [INFO] [stdout] --> day-11/src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use nom; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> day-11/src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day-11/src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `strum` [INFO] [stdout] --> day-11/src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use strum; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day-16/src/main.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | && !(grid.get(&newpos).unwrap_or(&'#') == &'#') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(grid.get(&newpos).unwrap_or(&'#') != &'#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-16/src/main.rs:64:76 [INFO] [stdout] | [INFO] [stdout] 64 | let grid = as Grid>::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | scores.insert(start_pos.clone(), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day-16/src/main.rs:142:76 [INFO] [stdout] | [INFO] [stdout] 142 | let grid = as Grid>::from_str_with(infile, |c| Some(c)); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:166:23 [INFO] [stdout] | [INFO] [stdout] 166 | histories.insert((start_pos.clone(), EAST), HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | scores.insert((start_pos.clone(), EAST), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> day-16/src/main.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if scores.len() % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `scores.len().is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[isize; 2]` which implements the `Copy` trait [INFO] [stdout] --> day-16/src/main.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | .map(|(p, _)| p.clone()) [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> day-11/src/main.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 44 | let digits = (n.ilog(10) + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `n.ilog(10).div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-11/src/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return *rez; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return *rez; [INFO] [stdout] 100 + *rez [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-11/src/main.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return rez; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return rez; [INFO] [stdout] 114 + rez [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> day-11/src/main.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | assert!(String::from("11") < String::from("2")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"11"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> day-11/src/main.rs:136:38 [INFO] [stdout] | [INFO] [stdout] 136 | assert!(String::from("11") < String::from("2")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"2"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> day-14/src/main.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 84 | quads.iter().fold(1, |acc, x| acc * x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-14/src/main.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return seconds; [INFO] [stdout] 110 + seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> day-14/src/main.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return -1; [INFO] [stdout] 127 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 35s [INFO] running `Command { std: "docker" "inspect" "00ac90c5032a9da49d7345e3e4ffedfe5a576f40ed12f7b9f127e9c0f4b634b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00ac90c5032a9da49d7345e3e4ffedfe5a576f40ed12f7b9f127e9c0f4b634b0", kill_on_drop: false }` [INFO] [stdout] 00ac90c5032a9da49d7345e3e4ffedfe5a576f40ed12f7b9f127e9c0f4b634b0