[INFO] cloning repository https://github.com/alelopezperez/rust-algorithms [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alelopezperez/rust-algorithms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falelopezperez%2Frust-algorithms", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falelopezperez%2Frust-algorithms'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f9ef80284b46dc9e90d4e1058ce8db8a2f390be [INFO] linting alelopezperez/rust-algorithms against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falelopezperez%2Frust-algorithms" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/alelopezperez/rust-algorithms [INFO] finished tweaking git repo https://github.com/alelopezperez/rust-algorithms [INFO] tweaked toml for git repo https://github.com/alelopezperez/rust-algorithms written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/alelopezperez/rust-algorithms on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/alelopezperez/rust-algorithms already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2a554e227a44495b92b9cf299d57afade51ecfc9d9c6b59c9bb3c8f5df4e9b9 [INFO] running `Command { std: "docker" "start" "-a" "c2a554e227a44495b92b9cf299d57afade51ecfc9d9c6b59c9bb3c8f5df4e9b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2a554e227a44495b92b9cf299d57afade51ecfc9d9c6b59c9bb3c8f5df4e9b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2a554e227a44495b92b9cf299d57afade51ecfc9d9c6b59c9bb3c8f5df4e9b9", kill_on_drop: false }` [INFO] [stdout] c2a554e227a44495b92b9cf299d57afade51ecfc9d9c6b59c9bb3c8f5df4e9b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e61f3782f28247331a2eddc74f4f7e38333da8db8e25e5d3c15b6091cedd5bb3 [INFO] running `Command { std: "docker" "start" "-a" "e61f3782f28247331a2eddc74f4f7e38333da8db8e25e5d3c15b6091cedd5bb3", kill_on_drop: false }` [INFO] [stderr] Checking rust-algorithms v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/bin/example/example.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `counter` and `is_balanced` are never used [INFO] [stdout] --> src/bin/example/example.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 26 | pub fn counter(root: &Option>>, mut curr: i32) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn is_balanced(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/bin/is-anagram/is-anagram.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 26 | for (_, v) in &char_count { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 26 - for (_, v) in &char_count { [INFO] [stdout] 26 + for v in char_count.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/bin/is-anagram/is-anagram.rs:56:31 [INFO] [stdout] | [INFO] [stdout] 56 | let mut char_count = [0 as u16; 26]; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/contains-duplicate/contains-duplicate.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / nums.iter() [INFO] [stdout] 35 | | .try_for_each(|x| { [INFO] [stdout] 36 | | if !num_set.insert(*x) { [INFO] [stdout] 37 | | return ControlFlow::Break(true); [INFO] [stdout] ... | [INFO] [stdout] 41 | | .is_break() [INFO] [stdout] 42 | | || false [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ nums.iter() [INFO] [stdout] 35 + .try_for_each(|x| { [INFO] [stdout] 36 + if !num_set.insert(*x) { [INFO] [stdout] 37 + return ControlFlow::Break(true); [INFO] [stdout] 38 + } [INFO] [stdout] 39 + ControlFlow::Continue(()) [INFO] [stdout] 40 + }) [INFO] [stdout] 41 + .is_break() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/bin/example/example.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `counter` and `is_balanced` are never used [INFO] [stdout] --> src/bin/example/example.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 26 | pub fn counter(root: &Option>>, mut curr: i32) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn is_balanced(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut letter_set = vec![0; 26]; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `strs` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let strs = String::from("Asd"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_strs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fol` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | let fol = letter_set.iter().fold(true, |acc, item| acc && *item == 0); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fol` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | let fol = letter_set.iter().fold(true, |acc, item| acc && *item == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `all(|item| *item == 0)` [INFO] [stdout] | [INFO] [stdout] = note: the `all` method is short circuiting and may change the program semantics if the iterator has side effects [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | let mut letter_set = vec![0; 26]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 26]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut letter_set = vec![0; 26]; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `strs` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let strs = String::from("Asd"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_strs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fol` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | let fol = letter_set.iter().fold(true, |acc, item| acc && *item == 0); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fol` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | let fol = letter_set.iter().fold(true, |acc, item| acc && *item == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `all(|item| *item == 0)` [INFO] [stdout] | [INFO] [stdout] = note: the `all` method is short circuiting and may change the program semantics if the iterator has side effects [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/group-anagrams/group-anagrams.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | let mut letter_set = vec![0; 26]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 26]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/bin/is-anagram/is-anagram.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 26 | for (_, v) in &char_count { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 26 - for (_, v) in &char_count { [INFO] [stdout] 26 + for v in char_count.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/bin/is-anagram/is-anagram.rs:56:31 [INFO] [stdout] | [INFO] [stdout] 56 | let mut char_count = [0 as u16; 26]; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/contains-duplicate/contains-duplicate.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / nums.iter() [INFO] [stdout] 35 | | .try_for_each(|x| { [INFO] [stdout] 36 | | if !num_set.insert(*x) { [INFO] [stdout] 37 | | return ControlFlow::Break(true); [INFO] [stdout] ... | [INFO] [stdout] 41 | | .is_break() [INFO] [stdout] 42 | | || false [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ nums.iter() [INFO] [stdout] 35 + .try_for_each(|x| { [INFO] [stdout] 36 + if !num_set.insert(*x) { [INFO] [stdout] 37 + return ControlFlow::Break(true); [INFO] [stdout] 38 + } [INFO] [stdout] 39 + ControlFlow::Continue(()) [INFO] [stdout] 40 + }) [INFO] [stdout] 41 + .is_break() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `Command { std: "docker" "inspect" "e61f3782f28247331a2eddc74f4f7e38333da8db8e25e5d3c15b6091cedd5bb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e61f3782f28247331a2eddc74f4f7e38333da8db8e25e5d3c15b6091cedd5bb3", kill_on_drop: false }` [INFO] [stdout] e61f3782f28247331a2eddc74f4f7e38333da8db8e25e5d3c15b6091cedd5bb3