[INFO] cloning repository https://github.com/akgvn/bc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/akgvn/bc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakgvn%2Fbc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakgvn%2Fbc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f627e7123b884abd22683b5b04aa42c09cecf4a [INFO] linting akgvn/bc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fakgvn%2Fbc" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/akgvn/bc [INFO] finished tweaking git repo https://github.com/akgvn/bc [INFO] tweaked toml for git repo https://github.com/akgvn/bc written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/akgvn/bc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/akgvn/bc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd2b271b826b29383f3a5c9bc99dd40f11aaffa9e9ade8b98d63c1f75598eb86 [INFO] running `Command { std: "docker" "start" "-a" "bd2b271b826b29383f3a5c9bc99dd40f11aaffa9e9ade8b98d63c1f75598eb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd2b271b826b29383f3a5c9bc99dd40f11aaffa9e9ade8b98d63c1f75598eb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd2b271b826b29383f3a5c9bc99dd40f11aaffa9e9ade8b98d63c1f75598eb86", kill_on_drop: false }` [INFO] [stdout] bd2b271b826b29383f3a5c9bc99dd40f11aaffa9e9ade8b98d63c1f75598eb86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ccb2955b20f72feb0ab744ce43a9704066674b551e9428534cb9fcd38f211ff [INFO] running `Command { std: "docker" "start" "-a" "8ccb2955b20f72feb0ab744ce43a9704066674b551e9428534cb9fcd38f211ff", kill_on_drop: false }` [INFO] [stderr] Checking bc v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `val` after checking its variant with `is_some` [INFO] [stdout] --> src/interpreter.rs:114:28 [INFO] [stdout] | [INFO] [stdout] 113 | if val.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = val` [INFO] [stdout] 114 | println!("{}", val.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `val` after checking its variant with `is_some` [INFO] [stdout] --> src/interpreter.rs:114:28 [INFO] [stdout] | [INFO] [stdout] 113 | if val.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = val` [INFO] [stdout] 114 | println!("{}", val.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/tokenizer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/tokenizer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/tokenizer.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match text { [INFO] [stdout] 77 | | _ => Token::Identifier(text, self.line_num), [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `Token::Identifier(text, self.line_num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/tokenizer.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match text { [INFO] [stdout] 77 | | _ => Token::Identifier(text, self.line_num), [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `Token::Identifier(text, self.line_num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/tokenizer.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / match ch { [INFO] [stdout] 163 | | '0'..='9' | 'a'..='z' | 'A'..='Z' | '_' => true, [INFO] [stdout] 164 | | _ => false, [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 162 - match ch { [INFO] [stdout] 163 - '0'..='9' | 'a'..='z' | 'A'..='Z' | '_' => true, [INFO] [stdout] 164 - _ => false, [INFO] [stdout] 165 - } [INFO] [stdout] 162 + matches!(ch, '0'..='9' | 'a'..='z' | 'A'..='Z' | '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/tokenizer.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | / match ch { [INFO] [stdout] 170 | | '0'..='9' => true, [INFO] [stdout] 171 | | _ => false, [INFO] [stdout] 172 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 169 - match ch { [INFO] [stdout] 170 - '0'..='9' => true, [INFO] [stdout] 171 - _ => false, [INFO] [stdout] 172 - } [INFO] [stdout] 169 + matches!(ch, '0'..='9') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !(user_input.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(user_input.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | if !(user_input.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/tokenizer.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / match ch { [INFO] [stdout] 163 | | '0'..='9' | 'a'..='z' | 'A'..='Z' | '_' => true, [INFO] [stdout] 164 | | _ => false, [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 162 - match ch { [INFO] [stdout] 163 - '0'..='9' | 'a'..='z' | 'A'..='Z' | '_' => true, [INFO] [stdout] 164 - _ => false, [INFO] [stdout] 165 - } [INFO] [stdout] 162 + matches!(ch, '0'..='9' | 'a'..='z' | 'A'..='Z' | '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/tokenizer.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | / match ch { [INFO] [stdout] 170 | | '0'..='9' => true, [INFO] [stdout] 171 | | _ => false, [INFO] [stdout] 172 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 169 - match ch { [INFO] [stdout] 170 - '0'..='9' => true, [INFO] [stdout] 171 - _ => false, [INFO] [stdout] 172 - } [INFO] [stdout] 169 + matches!(ch, '0'..='9') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !(user_input.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(user_input.len() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | if !(user_input.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/tokenizer.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn tokens_from_text(source: &str) -> Vec { [INFO] [stdout] | ^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 25 | pub fn tokens_from_text(source: &str) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/tokenizer.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn tokens_from_text(source: &str) -> Vec { [INFO] [stdout] | ^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 25 | pub fn tokens_from_text(source: &str) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "8ccb2955b20f72feb0ab744ce43a9704066674b551e9428534cb9fcd38f211ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ccb2955b20f72feb0ab744ce43a9704066674b551e9428534cb9fcd38f211ff", kill_on_drop: false }` [INFO] [stdout] 8ccb2955b20f72feb0ab744ce43a9704066674b551e9428534cb9fcd38f211ff