[INFO] cloning repository https://github.com/aidan-coward/porpoiseful
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aidan-coward/porpoiseful" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faidan-coward%2Fporpoiseful", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faidan-coward%2Fporpoiseful'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 834507bf4428e736fe4def21622d082e42330d98
[INFO] linting aidan-coward/porpoiseful against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faidan-coward%2Fporpoiseful" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/aidan-coward/porpoiseful
[INFO] finished tweaking git repo https://github.com/aidan-coward/porpoiseful
[INFO] tweaked toml for git repo https://github.com/aidan-coward/porpoiseful written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/aidan-coward/porpoiseful on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/aidan-coward/porpoiseful already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded lazy_static v1.0.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] eaf4c3390aa0283a1a0c999fa2218097702f707f33b2c332efdc8076c5fe2daf
[INFO] running `Command { std: "docker" "start" "-a" "eaf4c3390aa0283a1a0c999fa2218097702f707f33b2c332efdc8076c5fe2daf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "eaf4c3390aa0283a1a0c999fa2218097702f707f33b2c332efdc8076c5fe2daf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "eaf4c3390aa0283a1a0c999fa2218097702f707f33b2c332efdc8076c5fe2daf", kill_on_drop: false }`
[INFO] [stdout] eaf4c3390aa0283a1a0c999fa2218097702f707f33b2c332efdc8076c5fe2daf
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 530bd33cf9bf2828ca3e7873f6eb87520410a0b7c71b6cca439e6ece045e9978
[INFO] running `Command { std: "docker" "start" "-a" "530bd33cf9bf2828ca3e7873f6eb87520410a0b7c71b6cca439e6ece045e9978", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking lazy_static v1.0.1
[INFO] [stderr]     Checking porpoiseful v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:272:1
[INFO] [stdout]     |
[INFO] [stdout] 272 | / /// ```
[INFO] [stdout] 273 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 274 |   pub fn arg_parser(args: &[String]) -> Result<Vec<Vec<String>>, String> {
[INFO] [stdout]     |   ----------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:330:1
[INFO] [stdout]     |
[INFO] [stdout] 330 | / /// ```
[INFO] [stdout] 331 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 332 |       pub fn new(args: &mut [String]) -> Result<Config, String> {
[INFO] [stdout]     |       ---------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:382:1
[INFO] [stdout]     |
[INFO] [stdout] 382 | / /// ```
[INFO] [stdout] 383 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 384 |       pub fn new_battery(mut self, args: &[String]) -> Result<Config, String> {
[INFO] [stdout]     |       ------------------ the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]    --> src/lib.rs:432:1
[INFO] [stdout]     |
[INFO] [stdout] 432 | / /// ```
[INFO] [stdout] 433 | |
[INFO] [stdout] 434 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 435 |       pub fn new_conf_file(mut self, args: &[String]) -> Result<Config, String> {
[INFO] [stdout]     |       -------------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty lines are unintentional, remove them
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred
[INFO] [stdout]    --> src/lib.rs:147:1
[INFO] [stdout]     |
[INFO] [stdout] 147 | / lazy_static! {
[INFO] [stdout] 148 | |
[INFO] [stdout] 149 | |
[INFO] [stdout] 150 | | /// The list of all the flags recognized as valid
[INFO] [stdout] ...   |
[INFO] [stdout] 167 | |         ];
[INFO] [stdout] 168 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout]     = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:208:13
[INFO] [stdout]     |
[INFO] [stdout] 208 |             return Ok(true);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 208 -             return Ok(true);
[INFO] [stdout] 208 +             Ok(true)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:210:13
[INFO] [stdout]     |
[INFO] [stdout] 210 |             return Err(format!("{} is not a valid flag", arg).to_string());
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 210 -             return Err(format!("{} is not a valid flag", arg).to_string());
[INFO] [stdout] 210 +             Err(format!("{} is not a valid flag", arg).to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `list`
[INFO] [stdout]    --> src/lib.rs:221:14
[INFO] [stdout]     |
[INFO] [stdout] 221 |     for i in 0..list.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 221 -     for i in 0..list.len() {
[INFO] [stdout] 221 +     for <item> in &list {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:281:20
[INFO] [stdout]     |
[INFO] [stdout] 281 |                 if !(i == 0) {
[INFO] [stdout]     |                    ^^^^^^^^^ help: try: `(i != 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `args`
[INFO] [stdout]    --> src/lib.rs:278:14
[INFO] [stdout]     |
[INFO] [stdout] 278 |     for i in 0..args.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 278 -     for i in 0..args.len() {
[INFO] [stdout] 278 +     for (i, <item>) in args.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:272:1
[INFO] [stdout]     |
[INFO] [stdout] 272 | / /// ```
[INFO] [stdout] 273 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 274 |   pub fn arg_parser(args: &[String]) -> Result<Vec<Vec<String>>, String> {
[INFO] [stdout]     |   ----------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:330:1
[INFO] [stdout]     |
[INFO] [stdout] 330 | / /// ```
[INFO] [stdout] 331 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 332 |       pub fn new(args: &mut [String]) -> Result<Config, String> {
[INFO] [stdout]     |       ---------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:382:1
[INFO] [stdout]     |
[INFO] [stdout] 382 | / /// ```
[INFO] [stdout] 383 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 384 |       pub fn new_battery(mut self, args: &[String]) -> Result<Config, String> {
[INFO] [stdout]     |       ------------------ the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:344:43
[INFO] [stdout]     |
[INFO] [stdout] 344 |                 output_config.new_battery(&args)
[INFO] [stdout]     |                                           ^^^^^ help: change this to: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]    --> src/lib.rs:432:1
[INFO] [stdout]     |
[INFO] [stdout] 432 | / /// ```
[INFO] [stdout] 433 | |
[INFO] [stdout] 434 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 435 |       pub fn new_conf_file(mut self, args: &[String]) -> Result<Config, String> {
[INFO] [stdout]     |       -------------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = help: if the empty lines are unintentional, remove them
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:348:45
[INFO] [stdout]     |
[INFO] [stdout] 348 |                 output_config.new_conf_file(&args)
[INFO] [stdout]     |                                             ^^^^^ help: change this to: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:444:17
[INFO] [stdout]     |
[INFO] [stdout] 444 |                 return Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 444 -                 return Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string());
[INFO] [stdout] 444 +                 Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:455:21
[INFO] [stdout]     |
[INFO] [stdout] 455 |                     return Ok(self);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 455 -                     return Ok(self);
[INFO] [stdout] 455 +                     Ok(self)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:457:21
[INFO] [stdout]     |
[INFO] [stdout] 457 |                     return Err("the given configuration file does not exist or is inaccessible".to_string());
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 457 -                     return Err("the given configuration file does not exist or is inaccessible".to_string());
[INFO] [stdout] 457 +                     Err("the given configuration file does not exist or is inaccessible".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:464:17
[INFO] [stdout]     |
[INFO] [stdout] 464 |                 return Ok(self);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 464 -                 return Ok(self);
[INFO] [stdout] 464 +                 Ok(self)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred
[INFO] [stdout]    --> src/lib.rs:147:1
[INFO] [stdout]     |
[INFO] [stdout] 147 | / lazy_static! {
[INFO] [stdout] 148 | |
[INFO] [stdout] 149 | |
[INFO] [stdout] 150 | | /// The list of all the flags recognized as valid
[INFO] [stdout] ...   |
[INFO] [stdout] 167 | |         ];
[INFO] [stdout] 168 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout]     = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:208:13
[INFO] [stdout]     |
[INFO] [stdout] 208 |             return Ok(true);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 208 -             return Ok(true);
[INFO] [stdout] 208 +             Ok(true)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:210:13
[INFO] [stdout]     |
[INFO] [stdout] 210 |             return Err(format!("{} is not a valid flag", arg).to_string());
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 210 -             return Err(format!("{} is not a valid flag", arg).to_string());
[INFO] [stdout] 210 +             Err(format!("{} is not a valid flag", arg).to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `list`
[INFO] [stdout]    --> src/lib.rs:221:14
[INFO] [stdout]     |
[INFO] [stdout] 221 |     for i in 0..list.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 221 -     for i in 0..list.len() {
[INFO] [stdout] 221 +     for <item> in &list {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:281:20
[INFO] [stdout]     |
[INFO] [stdout] 281 |                 if !(i == 0) {
[INFO] [stdout]     |                    ^^^^^^^^^ help: try: `(i != 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `args`
[INFO] [stdout]    --> src/lib.rs:278:14
[INFO] [stdout]     |
[INFO] [stdout] 278 |     for i in 0..args.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 278 -     for i in 0..args.len() {
[INFO] [stdout] 278 +     for (i, <item>) in args.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:344:43
[INFO] [stdout]     |
[INFO] [stdout] 344 |                 output_config.new_battery(&args)
[INFO] [stdout]     |                                           ^^^^^ help: change this to: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:348:45
[INFO] [stdout]     |
[INFO] [stdout] 348 |                 output_config.new_conf_file(&args)
[INFO] [stdout]     |                                             ^^^^^ help: change this to: `args`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:444:17
[INFO] [stdout]     |
[INFO] [stdout] 444 |                 return Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 444 -                 return Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string());
[INFO] [stdout] 444 +                 Err("--config flag takes up to one argument: an absolute file path to the config file desired".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:455:21
[INFO] [stdout]     |
[INFO] [stdout] 455 |                     return Ok(self);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 455 -                     return Ok(self);
[INFO] [stdout] 455 +                     Ok(self)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:457:21
[INFO] [stdout]     |
[INFO] [stdout] 457 |                     return Err("the given configuration file does not exist or is inaccessible".to_string());
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 457 -                     return Err("the given configuration file does not exist or is inaccessible".to_string());
[INFO] [stdout] 457 +                     Err("the given configuration file does not exist or is inaccessible".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:464:17
[INFO] [stdout]     |
[INFO] [stdout] 464 |                 return Ok(self);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 464 -                 return Ok(self);
[INFO] [stdout] 464 +                 Ok(self)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.42s
[INFO] running `Command { std: "docker" "inspect" "530bd33cf9bf2828ca3e7873f6eb87520410a0b7c71b6cca439e6ece045e9978", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "530bd33cf9bf2828ca3e7873f6eb87520410a0b7c71b6cca439e6ece045e9978", kill_on_drop: false }`
[INFO] [stdout] 530bd33cf9bf2828ca3e7873f6eb87520410a0b7c71b6cca439e6ece045e9978