[INFO] cloning repository https://github.com/ai-b-z/sdm845-abootctl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ai-b-z/sdm845-abootctl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fai-b-z%2Fsdm845-abootctl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fai-b-z%2Fsdm845-abootctl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 883fa123a886c1ef37b01f13b6683d64bc67e8cb [INFO] linting ai-b-z/sdm845-abootctl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fai-b-z%2Fsdm845-abootctl" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ai-b-z/sdm845-abootctl [INFO] finished tweaking git repo https://github.com/ai-b-z/sdm845-abootctl [INFO] tweaked toml for git repo https://github.com/ai-b-z/sdm845-abootctl written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ai-b-z/sdm845-abootctl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ai-b-z/sdm845-abootctl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/Quyzi/gpt` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded modular-bitfield-impl v0.11.2 [INFO] [stderr] Downloaded modular-bitfield v0.11.2 [INFO] [stderr] Downloaded fstab v0.3.1 [INFO] [stderr] Downloaded shellscript v0.3.1 [INFO] [stderr] Downloaded udev v0.5.0 [INFO] [stderr] Downloaded block-utils v0.10.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.25 [INFO] [stderr] Downloaded thiserror v1.0.25 [INFO] [stderr] Downloaded proc-macro2 v1.0.27 [INFO] [stderr] Downloaded unicode-segmentation v1.7.1 [INFO] [stderr] Downloaded syn v1.0.72 [INFO] [stderr] Downloaded regex v1.4.6 [INFO] [stderr] Downloaded libc v0.2.95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c5564aacd85f426c8ea22ec2a04469d8897cbdbf4a48d177f25fca41553a1eb [INFO] running `Command { std: "docker" "start" "-a" "7c5564aacd85f426c8ea22ec2a04469d8897cbdbf4a48d177f25fca41553a1eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c5564aacd85f426c8ea22ec2a04469d8897cbdbf4a48d177f25fca41553a1eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c5564aacd85f426c8ea22ec2a04469d8897cbdbf4a48d177f25fca41553a1eb", kill_on_drop: false }` [INFO] [stdout] 7c5564aacd85f426c8ea22ec2a04469d8897cbdbf4a48d177f25fca41553a1eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a653b01102c092794f82bc676d376ee0871a8edb7d65d5cb8431615942ecd83 [INFO] running `Command { std: "docker" "start" "-a" "4a653b01102c092794f82bc676d376ee0871a8edb7d65d5cb8431615942ecd83", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking shellscript v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking fstab v0.3.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking udev v0.5.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking gpt v2.0.0 (https://github.com/Quyzi/gpt#f8dd37ae) [INFO] [stderr] Checking regex v1.4.6 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking block-utils v0.10.2 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking sdm845-abootctl v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | is_active: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - is_active: B1, [INFO] [stdout] 13 + s_active: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | boot_successful: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - boot_successful: B1, [INFO] [stdout] 16 + oot_successful: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | is_unbootable: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - is_unbootable: B1, [INFO] [stdout] 17 + s_unbootable: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | is_active: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - is_active: B1, [INFO] [stdout] 13 + s_active: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | boot_successful: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - boot_successful: B1, [INFO] [stdout] 16 + oot_successful: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | is_unbootable: B1, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - is_unbootable: B1, [INFO] [stdout] 17 + s_unbootable: B , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `unbootable` is never read [INFO] [stdout] --> src/main.rs:195:26 [INFO] [stdout] | [INFO] [stdout] 195 | let mut unbootable = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `successful` is never read [INFO] [stdout] --> src/main.rs:221:26 [INFO] [stdout] | [INFO] [stdout] 221 | let mut successful = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/partitions.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(!blockdevs.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `blockdevs.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/partitions.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / return ( [INFO] [stdout] 50 | | boot_a, [INFO] [stdout] 51 | | boot_b, [INFO] [stdout] 52 | | dev_path.as_path().to_str().unwrap().to_string(), [INFO] [stdout] 53 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ ( [INFO] [stdout] 50 + boot_a, [INFO] [stdout] 51 + boot_b, [INFO] [stdout] 52 + dev_path.as_path().to_str().unwrap().to_string(), [INFO] [stdout] 53 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/partitions.rs:75:40 [INFO] [stdout] | [INFO] [stdout] 75 | for (key, partition) in part_table.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SlotInfo` [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / #[derive(Debug,Clone)] [INFO] [stdout] 10 | | pub struct SlotInfo { [INFO] [stdout] 11 | | #[skip] [INFO] [stdout] 12 | | __: B2, [INFO] [stdout] ... | [INFO] [stdout] 17 | | is_unbootable: B1, [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for SlotInfo { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return slot; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return slot; [INFO] [stdout] 29 + slot [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return (self.clone().into_bytes()[0] as u64) << 48; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return (self.clone().into_bytes()[0] as u64) << 48; [INFO] [stdout] 33 + (self.clone().into_bytes()[0] as u64) << 48 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return (slot_a, slot_b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return (slot_a, slot_b); [INFO] [stdout] 141 + (slot_a, slot_b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return 0; [INFO] [stdout] 147 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return 1; [INFO] [stdout] 149 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `unbootable` is never read [INFO] [stdout] --> src/main.rs:195:26 [INFO] [stdout] | [INFO] [stdout] 195 | let mut unbootable = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `successful` is never read [INFO] [stdout] --> src/main.rs:221:26 [INFO] [stdout] | [INFO] [stdout] 221 | let mut successful = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | return unbootable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return unbootable; [INFO] [stdout] 216 + unbootable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | / if slot_a.is_unbootable() == 0 { [INFO] [stdout] 199 | | unbootable = true; [INFO] [stdout] 200 | | } else { [INFO] [stdout] 201 | | unbootable = false; [INFO] [stdout] 202 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `unbootable = slot_a.is_unbootable() == 0;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | / if slot_b.is_unbootable() == 0 { [INFO] [stdout] 206 | | unbootable = true; [INFO] [stdout] 207 | | } else { [INFO] [stdout] 208 | | unbootable = false; [INFO] [stdout] 209 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `unbootable = slot_b.is_unbootable() == 0;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | return successful; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return successful; [INFO] [stdout] 242 + successful [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | / if slot_a.boot_successful() == 1 { [INFO] [stdout] 225 | | successful = true; [INFO] [stdout] 226 | | } else { [INFO] [stdout] 227 | | successful = false; [INFO] [stdout] 228 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `successful = slot_a.boot_successful() == 1;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | / if slot_b.boot_successful() == 1 { [INFO] [stdout] 232 | | successful = true; [INFO] [stdout] 233 | | } else { [INFO] [stdout] 234 | | successful = false; [INFO] [stdout] 235 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `successful = slot_b.boot_successful() == 1;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | return "_a".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return "_a".to_string(); [INFO] [stdout] 248 + "_a".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | return "_b".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 251 - return "_b".to_string(); [INFO] [stdout] 251 + "_b".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/partitions.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(!blockdevs.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `blockdevs.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/partitions.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / return ( [INFO] [stdout] 50 | | boot_a, [INFO] [stdout] 51 | | boot_b, [INFO] [stdout] 52 | | dev_path.as_path().to_str().unwrap().to_string(), [INFO] [stdout] 53 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ ( [INFO] [stdout] 50 + boot_a, [INFO] [stdout] 51 + boot_b, [INFO] [stdout] 52 + dev_path.as_path().to_str().unwrap().to_string(), [INFO] [stdout] 53 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap` [INFO] [stdout] --> src/partitions.rs:75:40 [INFO] [stdout] | [INFO] [stdout] 75 | for (key, partition) in part_table.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SlotInfo` [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / #[derive(Debug,Clone)] [INFO] [stdout] 10 | | pub struct SlotInfo { [INFO] [stdout] 11 | | #[skip] [INFO] [stdout] 12 | | __: B2, [INFO] [stdout] ... | [INFO] [stdout] 17 | | is_unbootable: B1, [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for SlotInfo { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return slot; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return slot; [INFO] [stdout] 29 + slot [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return (self.clone().into_bytes()[0] as u64) << 48; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return (self.clone().into_bytes()[0] as u64) << 48; [INFO] [stdout] 33 + (self.clone().into_bytes()[0] as u64) << 48 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return (slot_a, slot_b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return (slot_a, slot_b); [INFO] [stdout] 141 + (slot_a, slot_b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return 0; [INFO] [stdout] 147 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return 1; [INFO] [stdout] 149 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | return unbootable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return unbootable; [INFO] [stdout] 216 + unbootable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | / if slot_a.is_unbootable() == 0 { [INFO] [stdout] 199 | | unbootable = true; [INFO] [stdout] 200 | | } else { [INFO] [stdout] 201 | | unbootable = false; [INFO] [stdout] 202 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `unbootable = slot_a.is_unbootable() == 0;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | / if slot_b.is_unbootable() == 0 { [INFO] [stdout] 206 | | unbootable = true; [INFO] [stdout] 207 | | } else { [INFO] [stdout] 208 | | unbootable = false; [INFO] [stdout] 209 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `unbootable = slot_b.is_unbootable() == 0;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | return successful; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return successful; [INFO] [stdout] 242 + successful [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | / if slot_a.boot_successful() == 1 { [INFO] [stdout] 225 | | successful = true; [INFO] [stdout] 226 | | } else { [INFO] [stdout] 227 | | successful = false; [INFO] [stdout] 228 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `successful = slot_a.boot_successful() == 1;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | / if slot_b.boot_successful() == 1 { [INFO] [stdout] 232 | | successful = true; [INFO] [stdout] 233 | | } else { [INFO] [stdout] 234 | | successful = false; [INFO] [stdout] 235 | | }; [INFO] [stdout] | |_____________^ help: you can reduce it to: `successful = slot_b.boot_successful() == 1;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | return "_a".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return "_a".to_string(); [INFO] [stdout] 248 + "_a".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | return "_b".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 251 - return "_b".to_string(); [INFO] [stdout] 251 + "_b".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.59s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: block-utils v0.10.2, nom v5.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "4a653b01102c092794f82bc676d376ee0871a8edb7d65d5cb8431615942ecd83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a653b01102c092794f82bc676d376ee0871a8edb7d65d5cb8431615942ecd83", kill_on_drop: false }` [INFO] [stdout] 4a653b01102c092794f82bc676d376ee0871a8edb7d65d5cb8431615942ecd83