[INFO] cloning repository https://github.com/ahmednooor/mr_huffy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ahmednooor/mr_huffy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmednooor%2Fmr_huffy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmednooor%2Fmr_huffy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] df72a715d6f8f9026d249a77ec701edb9fb26407 [INFO] linting ahmednooor/mr_huffy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmednooor%2Fmr_huffy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ahmednooor/mr_huffy [INFO] finished tweaking git repo https://github.com/ahmednooor/mr_huffy [INFO] tweaked toml for git repo https://github.com/ahmednooor/mr_huffy written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ahmednooor/mr_huffy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ahmednooor/mr_huffy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09c318a96eb8bca441828e9a34e502679d549e6f81f0c46e52769f76ee53b6cd [INFO] running `Command { std: "docker" "start" "-a" "09c318a96eb8bca441828e9a34e502679d549e6f81f0c46e52769f76ee53b6cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09c318a96eb8bca441828e9a34e502679d549e6f81f0c46e52769f76ee53b6cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09c318a96eb8bca441828e9a34e502679d549e6f81f0c46e52769f76ee53b6cd", kill_on_drop: false }` [INFO] [stdout] 09c318a96eb8bca441828e9a34e502679d549e6f81f0c46e52769f76ee53b6cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cda200134e489d7bae6268930b360b382abdfbe0508c6fa4fc0da7b507ca08ff [INFO] running `Command { std: "docker" "start" "-a" "cda200134e489d7bae6268930b360b382abdfbe0508c6fa4fc0da7b507ca08ff", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking mr_huffy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove them: `(u8_arr[3] as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove them: `(u8_arr[3] as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/helpers.rs:19:44 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn write_bytes(file_path: &str, bytes: &mut Vec) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn write_bytes(file_path: &str, bytes: &mut Vec) -> io::Result<()> { [INFO] [stdout] 19 + pub fn write_bytes(file_path: &str, bytes: &mut [u8]) -> io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | bitstring = String::from("1".to_owned() + &bitstring); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `("1".to_owned() + &bitstring)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | bitstring = String::from(offset_bits + &bitstring); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `(offset_bits + &bitstring)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | bitstring = String::from(bitstring[offset_index..].to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[offset_index..].to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | bitstring = String::from(bitstring[..].to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[..].to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 78 | let b1: u32 = ((u8_arr[0] as u32) << 24) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[0] as u32) << 24)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | let b2: u32 = ((u8_arr[1] as u32) << 16) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[1] as u32) << 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | let b3: u32 = ((u8_arr[2] as u32) << 8) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[2] as u32) << 8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[3] as u32))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/mr_huffy/helpers.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 87 | / let bitstring = [INFO] [stdout] 88 | | U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] 89 | | .clone().to_string(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 90 | [INFO] [stdout] 91 | bitstring [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 | [INFO] [stdout] 89 ~ U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] 90 + .clone().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `idx` after checking its variant with `is_none` [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 13 | if idx.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = idx` [INFO] [stdout] ... [INFO] [stdout] 16 | freq_map[idx.unwrap()].1 += 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:3:38 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stdout] 3 + pub fn get_freq_map(input_bytes_vec: &[u8]) -> Vec<(u8, u32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | freq_map.push((byte.clone(), 1)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | byte: Some(byte.clone()), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | freq: freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/mr_huffy/make_tree.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let min_1_node: Tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 30 | min_1_node = tree.remove(min_1_key.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `min_1_node` here [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 | let min_2_node: Tree; [INFO] [stdout] ... [INFO] [stdout] 29 | [INFO] [stdout] 30 ~ let min_1_node: Tree = tree.remove(min_1_key.unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/mr_huffy/make_tree.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let min_2_node: Tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 41 | min_2_node = tree.remove(min_2_key.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `min_2_node` here [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 | [INFO] [stdout] ... [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ let min_2_node: Tree = tree.remove(min_2_key.unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/make_tree.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if min_1_key == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_1_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/make_tree.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | if min_2_key == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_2_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_1_node.freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_2_node.freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/mr_huffy/make_tree.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | tree.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `tree.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if !tree.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `tree.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !tree.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 12 | if tree.left.is_none() && tree.right.is_none() && tree.byte != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `tree.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 13 | bits_map.insert(tree.byte.unwrap().clone(), bits.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:38:55 [INFO] [stdout] | [INFO] [stdout] 38 | if tree.left.is_none() && tree.right.is_none() && tree.byte != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `tree.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | comrpessed_bits_map.insert(tree.byte.unwrap().clone(), "1".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:16:33 [INFO] [stdout] | [INFO] [stdout] 16 | final_output_bytes.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:19:33 [INFO] [stdout] | [INFO] [stdout] 19 | final_output_bytes.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mr_huffy/freq_bytes_to_freq_map.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | while freq_bytes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!freq_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | &u8_to_bitstring(byte.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | if bit == '0' && !current_node.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | if bit == '1' && !current_node.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !current_node.byte.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:5:57 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stdout] 5 + pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/mr_huffy/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if input_bytes.len() < 1 { return input_bytes.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | let freq_map = get_freq_map(&input_bytes); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | ... &input_bytes); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:52:44 [INFO] [stdout] | [INFO] [stdout] 52 | let mut input_bytes = match read_bytes(&input_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `input_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | write_bytes(&output_file_path, &mut encoded_output_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `output_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/mr_huffy/mod.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 90 | / let decoded_bytes = [INFO] [stdout] 91 | | decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stdout] 92 | | &tree); [INFO] [stdout] | |_____________________________________________________- unnecessary `let` binding [INFO] [stdout] 93 | decoded_bytes [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 90 ~ [INFO] [stdout] 91 ~ decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stdout] 92 + &tree) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/mr_huffy/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if encoded_input_bytes.len() < 1 { return encoded_input_bytes.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `encoded_input_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | let mut input_bytes = match read_bytes(&input_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `input_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | write_bytes(&output_file_path, &mut encoded_output_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `output_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/mr_huffy/helpers.rs:88:42 [INFO] [stdout] | [INFO] [stdout] 88 | U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 89 | | .clone().to_string(); [INFO] [stdout] | |________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/helpers.rs:19:44 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn write_bytes(file_path: &str, bytes: &mut Vec) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn write_bytes(file_path: &str, bytes: &mut Vec) -> io::Result<()> { [INFO] [stdout] 19 + pub fn write_bytes(file_path: &str, bytes: &mut [u8]) -> io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | bitstring = String::from("1".to_owned() + &bitstring); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `("1".to_owned() + &bitstring)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | bitstring = String::from(offset_bits + &bitstring); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `(offset_bits + &bitstring)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | bitstring = String::from(bitstring[offset_index..].to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[offset_index..].to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/mr_huffy/helpers.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | bitstring = String::from(bitstring[..].to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[..].to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 78 | let b1: u32 = ((u8_arr[0] as u32) << 24) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[0] as u32) << 24)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | let b2: u32 = ((u8_arr[1] as u32) << 16) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[1] as u32) << 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | let b3: u32 = ((u8_arr[2] as u32) << 8) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[2] as u32) << 8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((u8_arr[3] as u32))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/mr_huffy/helpers.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 87 | / let bitstring = [INFO] [stdout] 88 | | U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] 89 | | .clone().to_string(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 90 | [INFO] [stdout] 91 | bitstring [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 | [INFO] [stdout] 89 ~ U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] 90 + .clone().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `idx` after checking its variant with `is_none` [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 13 | if idx.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = idx` [INFO] [stdout] ... [INFO] [stdout] 16 | freq_map[idx.unwrap()].1 += 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:3:38 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stdout] 3 + pub fn get_freq_map(input_bytes_vec: &[u8]) -> Vec<(u8, u32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_freq_map.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | freq_map.push((byte.clone(), 1)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | byte: Some(byte.clone()), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | freq: freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/mr_huffy/make_tree.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let min_1_node: Tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 30 | min_1_node = tree.remove(min_1_key.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `min_1_node` here [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 | let min_2_node: Tree; [INFO] [stdout] ... [INFO] [stdout] 29 | [INFO] [stdout] 30 ~ let min_1_node: Tree = tree.remove(min_1_key.unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/mr_huffy/make_tree.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let min_2_node: Tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 41 | min_2_node = tree.remove(min_2_key.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `min_2_node` here [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 | [INFO] [stdout] ... [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ let min_2_node: Tree = tree.remove(min_2_key.unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/make_tree.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if min_1_key == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_1_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/make_tree.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | if min_2_key == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_2_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_1_node.freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/make_tree.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_2_node.freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/mr_huffy/make_tree.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | tree.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `tree.into_iter().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if !tree.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `tree.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !tree.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 12 | if tree.left.is_none() && tree.right.is_none() && tree.byte != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `tree.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 13 | bits_map.insert(tree.byte.unwrap().clone(), bits.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:38:55 [INFO] [stdout] | [INFO] [stdout] 38 | if tree.left.is_none() && tree.right.is_none() && tree.byte != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `tree.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/get_comrpessed_bits_map.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | comrpessed_bits_map.insert(tree.byte.unwrap().clone(), "1".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:16:33 [INFO] [stdout] | [INFO] [stdout] 16 | final_output_bytes.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:19:33 [INFO] [stdout] | [INFO] [stdout] 19 | final_output_bytes.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mr_huffy/freq_bytes_to_freq_map.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | while freq_bytes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!freq_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | &u8_to_bitstring(byte.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | if bit == '0' && !current_node.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | if bit == '1' && !current_node.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !current_node.byte.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.byte.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:5:57 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stdout] 5 + pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/mr_huffy/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if input_bytes.len() < 1 { return input_bytes.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | let freq_map = get_freq_map(&input_bytes); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | ... &input_bytes); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:52:44 [INFO] [stdout] | [INFO] [stdout] 52 | let mut input_bytes = match read_bytes(&input_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `input_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | write_bytes(&output_file_path, &mut encoded_output_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `output_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/mr_huffy/mod.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 90 | / let decoded_bytes = [INFO] [stdout] 91 | | decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stdout] 92 | | &tree); [INFO] [stdout] | |_____________________________________________________- unnecessary `let` binding [INFO] [stdout] 93 | decoded_bytes [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 90 ~ [INFO] [stdout] 91 ~ decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stdout] 92 + &tree) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/mr_huffy/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if encoded_input_bytes.len() < 1 { return encoded_input_bytes.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `encoded_input_bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | let mut input_bytes = match read_bytes(&input_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `input_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mr_huffy/mod.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | write_bytes(&output_file_path, &mut encoded_output_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `output_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/mr_huffy/helpers.rs:88:42 [INFO] [stdout] | [INFO] [stdout] 88 | U8_BITSTR_ARR[integer as usize].1 [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 89 | | .clone().to_string(); [INFO] [stdout] | |________________^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s [INFO] running `Command { std: "docker" "inspect" "cda200134e489d7bae6268930b360b382abdfbe0508c6fa4fc0da7b507ca08ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cda200134e489d7bae6268930b360b382abdfbe0508c6fa4fc0da7b507ca08ff", kill_on_drop: false }` [INFO] [stdout] cda200134e489d7bae6268930b360b382abdfbe0508c6fa4fc0da7b507ca08ff