[INFO] cloning repository https://github.com/ahmaddynugroho/global-thresholding [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ahmaddynugroho/global-thresholding" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmaddynugroho%2Fglobal-thresholding", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmaddynugroho%2Fglobal-thresholding'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bef37648503fe77a76fa3a538a2e104c9a5b0014 [INFO] linting ahmaddynugroho/global-thresholding against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahmaddynugroho%2Fglobal-thresholding" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ahmaddynugroho/global-thresholding [INFO] finished tweaking git repo https://github.com/ahmaddynugroho/global-thresholding [INFO] tweaked toml for git repo https://github.com/ahmaddynugroho/global-thresholding written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ahmaddynugroho/global-thresholding on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ahmaddynugroho/global-thresholding already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytemuck v1.6.1 [INFO] [stderr] Downloaded gif v0.11.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaf5658d6b0d28666613ea75e547c4d25eda75d27659582989617a21e600c4f7 [INFO] running `Command { std: "docker" "start" "-a" "eaf5658d6b0d28666613ea75e547c4d25eda75d27659582989617a21e600c4f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaf5658d6b0d28666613ea75e547c4d25eda75d27659582989617a21e600c4f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaf5658d6b0d28666613ea75e547c4d25eda75d27659582989617a21e600c4f7", kill_on_drop: false }` [INFO] [stdout] eaf5658d6b0d28666613ea75e547c4d25eda75d27659582989617a21e600c4f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27a7f8768995e36459e768e7d88e5733b4390d486c866b4e41c52c01a525f7c0 [INFO] running `Command { std: "docker" "start" "-a" "27a7f8768995e36459e768e7d88e5733b4390d486c866b4e41c52c01a525f7c0", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking bytemuck v1.6.1 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking num-iter v0.1.42 [INFO] [stderr] Checking num-rational v0.3.2 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking global-thresholding v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(selisih_abs > selisih_t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(selisih_abs <= selisih_t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:23:52 [INFO] [stdout] | [INFO] [stdout] 23 | fn find_threshold_value(img: &mut GrayImage, args: &Vec) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn find_threshold_value(img: &mut GrayImage, args: &Vec) -> u8 { [INFO] [stdout] 23 + fn find_threshold_value(img: &mut GrayImage, args: &[String]) -> u8 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / match args.len() { [INFO] [stdout] 26 | | 4 => { [INFO] [stdout] 27 | | initial_t = args[3].parse().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ if args.len() == 4 { [INFO] [stdout] 26 + initial_t = args[3].parse().unwrap(); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | let mut t = 0 + initial_t; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `initial_t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !(selisih_abs > selisih_t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(selisih_abs <= selisih_t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:23:52 [INFO] [stdout] | [INFO] [stdout] 23 | fn find_threshold_value(img: &mut GrayImage, args: &Vec) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn find_threshold_value(img: &mut GrayImage, args: &Vec) -> u8 { [INFO] [stdout] 23 + fn find_threshold_value(img: &mut GrayImage, args: &[String]) -> u8 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / match args.len() { [INFO] [stdout] 26 | | 4 => { [INFO] [stdout] 27 | | initial_t = args[3].parse().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ if args.len() == 4 { [INFO] [stdout] 26 + initial_t = args[3].parse().unwrap(); [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | let mut t = 0 + initial_t; [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider reducing it to: `initial_t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.37s [INFO] running `Command { std: "docker" "inspect" "27a7f8768995e36459e768e7d88e5733b4390d486c866b4e41c52c01a525f7c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27a7f8768995e36459e768e7d88e5733b4390d486c866b4e41c52c01a525f7c0", kill_on_drop: false }` [INFO] [stdout] 27a7f8768995e36459e768e7d88e5733b4390d486c866b4e41c52c01a525f7c0