[INFO] cloning repository https://github.com/agoalofalife/kani [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/agoalofalife/kani" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagoalofalife%2Fkani", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagoalofalife%2Fkani'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 416cf6282cbd910b3ebe650cc4df20a324be42cf [INFO] linting agoalofalife/kani against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagoalofalife%2Fkani" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/agoalofalife/kani [INFO] finished tweaking git repo https://github.com/agoalofalife/kani [INFO] tweaked toml for git repo https://github.com/agoalofalife/kani written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/agoalofalife/kani on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/agoalofalife/kani already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 291e5d1dafd8be16da7f6f50fb4c3d3650d3783bf0689b177c755684e5c0c995 [INFO] running `Command { std: "docker" "start" "-a" "291e5d1dafd8be16da7f6f50fb4c3d3650d3783bf0689b177c755684e5c0c995", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "291e5d1dafd8be16da7f6f50fb4c3d3650d3783bf0689b177c755684e5c0c995", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "291e5d1dafd8be16da7f6f50fb4c3d3650d3783bf0689b177c755684e5c0c995", kill_on_drop: false }` [INFO] [stdout] 291e5d1dafd8be16da7f6f50fb4c3d3650d3783bf0689b177c755684e5c0c995 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2848b34978ce48a83e6b5cce1583db8351a252f1dd0cb9fa056724a79dd4fd6d [INFO] running `Command { std: "docker" "start" "-a" "2848b34978ce48a83e6b5cce1583db8351a252f1dd0cb9fa056724a79dd4fd6d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking kani v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `current` and `start` are never read [INFO] [stdout] --> src/scanner.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Scanner { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | current: usize, // think about when len of chars greater them limit of i32 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 12 | start: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Scanner` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Expr` is never used [INFO] [stdout] --> src/expr.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum Expr<'a> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `accept` is never used [INFO] [stdout] --> src/expr.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 22 | impl<'a> Expr<'a> { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] 23 | fn accept(&self, visitor: &mut dyn Visitor) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AstPrinter` is never constructed [INFO] [stdout] --> src/expr.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct AstPrinter; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print` and `parenthesize` are never used [INFO] [stdout] --> src/expr.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl AstPrinter { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] 36 | pub fn print (&mut self, expr:Box) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn parenthesize(&mut self, name:String, expressions: Vec<&Box>) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Visitor` is never used [INFO] [stdout] --> src/expr.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub trait Visitor { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/token.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / write!( [INFO] [stdout] 105 | | f, [INFO] [stdout] 106 | | "{}", [INFO] [stdout] 107 | | format!("{} {} {} {}", self.token_type, self.lexeme, self.literal, self.line) [INFO] [stdout] 108 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:157:28 [INFO] [stdout] | [INFO] [stdout] 157 | if !iter.peek().is_none() && iter.peek().unwrap().1 == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn scan_tokens(&mut self, source: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn scan_tokens(&mut self, source: &String) { [INFO] [stdout] 26 + pub fn scan_tokens(&mut self, source: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | / if *char == candidate { [INFO] [stdout] 207 | | iter.next(); [INFO] [stdout] 208 | | true [INFO] [stdout] 209 | | } else { [INFO] [stdout] 210 | | false [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 205 ~ Some((_, char)) [INFO] [stdout] 206 ~ if *char == candidate => { [INFO] [stdout] 207 | iter.next(); [INFO] [stdout] 208 | true [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/scanner.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | c >= '0' && c <= '9' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:25:56 [INFO] [stdout] | [INFO] [stdout] 25 | Binary(_,_,_) => visitor.visit_binary_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:26:54 [INFO] [stdout] | [INFO] [stdout] 26 | Literal(_) => visitor.visit_literal_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | Grouping(_) => visitor.visit_grouping_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:28:53 [INFO] [stdout] | [INFO] [stdout] 28 | Unary(_, _) => visitor.visit_unary_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: local variable doesn't need to be boxed here [INFO] [stdout] --> src/expr.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn print (&mut self, expr:Box) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stdout] = note: `#[warn(clippy::boxed_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/expr.rs:39:62 [INFO] [stdout] | [INFO] [stdout] 39 | fn parenthesize(&mut self, name:String, expressions: Vec<&Box>) -> String { [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | str.push_str("("); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | str.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | str.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `current` and `start` are never read [INFO] [stdout] --> src/scanner.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Scanner { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | current: usize, // think about when len of chars greater them limit of i32 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 12 | start: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Scanner` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/token.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / write!( [INFO] [stdout] 105 | | f, [INFO] [stdout] 106 | | "{}", [INFO] [stdout] 107 | | format!("{} {} {} {}", self.token_type, self.lexeme, self.literal, self.line) [INFO] [stdout] 108 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner.rs:157:28 [INFO] [stdout] | [INFO] [stdout] 157 | if !iter.peek().is_none() && iter.peek().unwrap().1 == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/scanner.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn scan_tokens(&mut self, source: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn scan_tokens(&mut self, source: &String) { [INFO] [stdout] 26 + pub fn scan_tokens(&mut self, source: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | / if *char == candidate { [INFO] [stdout] 207 | | iter.next(); [INFO] [stdout] 208 | | true [INFO] [stdout] 209 | | } else { [INFO] [stdout] 210 | | false [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 205 ~ Some((_, char)) [INFO] [stdout] 206 ~ if *char == candidate => { [INFO] [stdout] 207 | iter.next(); [INFO] [stdout] 208 | true [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/scanner.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | c >= '0' && c <= '9' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:25:56 [INFO] [stdout] | [INFO] [stdout] 25 | Binary(_,_,_) => visitor.visit_binary_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:26:54 [INFO] [stdout] | [INFO] [stdout] 26 | Literal(_) => visitor.visit_literal_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | Grouping(_) => visitor.visit_grouping_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expr.rs:28:53 [INFO] [stdout] | [INFO] [stdout] 28 | Unary(_, _) => visitor.visit_unary_expr(&self), [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: local variable doesn't need to be boxed here [INFO] [stdout] --> src/expr.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn print (&mut self, expr:Box) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stdout] = note: `#[warn(clippy::boxed_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/expr.rs:39:62 [INFO] [stdout] | [INFO] [stdout] 39 | fn parenthesize(&mut self, name:String, expressions: Vec<&Box>) -> String { [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | str.push_str("("); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | str.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/expr.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | str.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.45s [INFO] running `Command { std: "docker" "inspect" "2848b34978ce48a83e6b5cce1583db8351a252f1dd0cb9fa056724a79dd4fd6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2848b34978ce48a83e6b5cce1583db8351a252f1dd0cb9fa056724a79dd4fd6d", kill_on_drop: false }` [INFO] [stdout] 2848b34978ce48a83e6b5cce1583db8351a252f1dd0cb9fa056724a79dd4fd6d