[INFO] cloning repository https://github.com/agent-stream-kit/askit-llm-agents [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/agent-stream-kit/askit-llm-agents" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagent-stream-kit%2Faskit-llm-agents", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagent-stream-kit%2Faskit-llm-agents'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5aff225edf50970f51925275d84802ec830f5fe2 [INFO] linting agent-stream-kit/askit-llm-agents/5aff225edf50970f51925275d84802ec830f5fe2 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagent-stream-kit%2Faskit-llm-agents" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/agent-stream-kit/askit-llm-agents [INFO] finished tweaking git repo https://github.com/agent-stream-kit/askit-llm-agents [INFO] tweaked toml for git repo https://github.com/agent-stream-kit/askit-llm-agents written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/agent-stream-kit/askit-llm-agents on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/agent-stream-kit/askit-llm-agents already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unit-prefix v0.5.2 [INFO] [stderr] Downloaded icu_locale v2.1.1 [INFO] [stderr] Downloaded askit-macros v0.19.0 [INFO] [stderr] Downloaded eventsource-stream v0.2.3 [INFO] [stderr] Downloaded ollama-rs-macros v0.3.3 [INFO] [stderr] Downloaded async-openai-macros v0.1.1 [INFO] [stderr] Downloaded palette_derive v0.6.1 [INFO] [stderr] Downloaded perlin2d v0.2.6 [INFO] [stderr] Downloaded reqwest-eventsource v0.6.0 [INFO] [stderr] Downloaded rmcp-macros v0.13.0 [INFO] [stderr] Downloaded rand_distr v0.2.2 [INFO] [stderr] Downloaded ollama-rs v0.3.3 [INFO] [stderr] Downloaded agent-stream-kit v0.19.0 [INFO] [stderr] Downloaded simba v0.7.3 [INFO] [stderr] Downloaded async-openai v0.30.1 [INFO] [stderr] Downloaded icu_locale_data v2.1.2 [INFO] [stderr] Downloaded palette v0.6.1 [INFO] [stderr] Downloaded process-wrap v9.0.0 [INFO] [stderr] Downloaded tokenizers v0.22.2 [INFO] [stderr] Downloaded text-splitter v0.29.3 [INFO] [stderr] Downloaded rmcp v0.13.0 [INFO] [stderr] Downloaded photon-rs v0.3.3 [INFO] [stderr] Downloaded node-sys v0.4.2 [INFO] [stderr] Downloaded schemars_derive v1.2.0 [INFO] [stderr] Downloaded schemars v1.2.0 [INFO] [stderr] Downloaded indicatif v0.18.3 [INFO] [stderr] Downloaded nalgebra v0.30.1 [INFO] [stderr] Downloaded icu_segmenter v2.1.2 [INFO] [stderr] Downloaded imageproc v0.23.0 [INFO] [stderr] Downloaded icu_segmenter_data v2.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a76edb302ca2db0174a45d188afb6bafaa2faa9232118ce653a82f8e2f4ddb48 [INFO] running `Command { std: "docker" "start" "-a" "a76edb302ca2db0174a45d188afb6bafaa2faa9232118ce653a82f8e2f4ddb48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a76edb302ca2db0174a45d188afb6bafaa2faa9232118ce653a82f8e2f4ddb48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a76edb302ca2db0174a45d188afb6bafaa2faa9232118ce653a82f8e2f4ddb48", kill_on_drop: false }` [INFO] [stdout] a76edb302ca2db0174a45d188afb6bafaa2faa9232118ce653a82f8e2f4ddb48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c28d47dca3467b83e4c3601bc143dcd2ff4c2e0e405a4c8211d627bb68ceeda3 [INFO] running `Command { std: "docker" "start" "-a" "c28d47dca3467b83e4c3601bc143dcd2ff4c2e0e405a4c8211d627bb68ceeda3", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling cc v1.2.53 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling zmij v1.0.14 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling wasm-bindgen v0.2.108 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking openssl-probe v0.2.0 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling icu_locale_data v2.1.2 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling bitmaps v2.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling icu_segmenter_data v2.1.1 [INFO] [stderr] Compiling palette v0.6.1 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Compiling esaxx-rs v0.1.10 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling sized-chunks v0.6.5 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Compiling find-crate v0.6.3 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling rand_xoshiro v0.6.0 [INFO] [stderr] Compiling rmcp v0.13.0 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.2 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking indicatif v0.18.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking macro_rules_attribute v0.2.2 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Checking unicode-normalization-alignments v0.1.12 [INFO] [stderr] Checking perlin2d v0.2.6 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking inventory v0.3.21 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking rayon-cond v0.4.0 [INFO] [stderr] Compiling palette_derive v0.6.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.108 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling derive_utils v0.15.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling schemars_derive v1.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Compiling monostate-impl v0.1.18 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking monostate v0.1.18 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling askit-macros v0.19.0 [INFO] [stderr] Compiling auto_enums v0.8.7 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling ollama-rs-macros v0.3.3 [INFO] [stderr] Compiling async-openai-macros v0.1.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.108 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling rmcp-macros v0.13.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking dary_heap v0.3.8 [INFO] [stderr] Checking spm_precompiled v0.1.4 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking js-sys v0.3.85 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_locale v2.1.1 [INFO] [stderr] Checking schemars v1.2.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking process-wrap v9.0.0 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking icu_segmenter v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking hf-hub v0.4.3 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking tokenizers v0.22.2 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking web-sys v0.3.85 [INFO] [stderr] Checking imageproc v0.23.0 [INFO] [stderr] Checking reqwest-eventsource v0.6.0 [INFO] [stderr] Checking ollama-rs v0.3.3 [INFO] [stderr] Checking async-openai v0.30.1 [INFO] [stderr] Checking text-splitter v0.29.3 [INFO] [stderr] Checking node-sys v0.4.2 [INFO] [stderr] Checking photon-rs v0.3.3 [INFO] [stderr] Checking agent-stream-kit v0.19.0 [INFO] [stderr] Checking askit-llm-agents v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/message.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 341 | if messages.len() > 0 && first_in_message_id.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!messages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / if let Some(ollama_url) = [INFO] [stdout] 69 | | global_config.and_then(|cfg| cfg.get_string(CONFIG_OLLAMA_URL).ok()) [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | if !ollama_url.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ global_config.and_then(|cfg| cfg.get_string(CONFIG_OLLAMA_URL).ok()) [INFO] [stdout] 70 ~ && !ollama_url.is_empty() { [INFO] [stdout] 71 | return ollama_url; [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if use_context { [INFO] [stdout] 177 | | if let Some(context) = &self.context { [INFO] [stdout] 178 | | request = request.context(context.clone()); [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if use_context [INFO] [stdout] 177 ~ && let Some(context) = &self.context { [INFO] [stdout] 178 | request = request.context(context.clone()); [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ollama.rs:284:22 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|tool| from_tool_info_to_ollama_tool_info(tool)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `from_tool_info_to_ollama_tool_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded cloning of iterator items [INFO] [stdout] --> src/ollama.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | / messages [INFO] [stdout] 295 | | .iter() [INFO] [stdout] 296 | | .cloned() [INFO] [stdout] 297 | | .map(|m| message_to_chat(m.as_message().unwrap().clone())) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_iter_cloned [INFO] [stdout] = note: `#[warn(clippy::redundant_iter_cloned)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ .iter() [INFO] [stdout] 296 + .map(|m| message_to_chat(m.as_message().unwrap().clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ollama.rs:321:63 [INFO] [stdout] | [INFO] [stdout] 321 | let res = res.map_err(|_| AgentError::IoError(format!("Ollama Stream Error")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Ollama Stream Error".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:329:21 [INFO] [stdout] | [INFO] [stdout] 329 | / if parameters.is_object() { [INFO] [stdout] 330 | | if let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | | parameters = props.clone(); [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 329 ~ if parameters.is_object() [INFO] [stdout] 330 ~ && let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | parameters = props.clone(); [INFO] [stdout] 333 | } [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 330 | / if let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | | parameters = props.clone(); [INFO] [stdout] 333 | | } [INFO] [stdout] 334 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if let Some(obj) = parameters.as_object() [INFO] [stdout] 331 ~ && let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | parameters = props.clone(); [INFO] [stdout] 333 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ollama.rs:351:20 [INFO] [stdout] | [INFO] [stdout] 351 | if tool_calls.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tool_calls.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/openai.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | / if let Some(last_msg) = messages.last() { [INFO] [stdout] 152 | | if last_msg.role != "user" { [INFO] [stdout] 153 | | return Ok(()); [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ if let Some(last_msg) = messages.last() [INFO] [stdout] 152 ~ && last_msg.role != "user" { [INFO] [stdout] 153 | return Ok(()); [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/openai.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|tool| try_from_tool_info_to_chat_completion_tool(tool)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `try_from_tool_info_to_chat_completion_tool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/openai.rs:345:63 [INFO] [stdout] | [INFO] [stdout] 345 | let res = res.map_err(|_| AgentError::IoError(format!("OpenAI Stream Error")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"OpenAI Stream Error".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/message.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 341 | if messages.len() > 0 && first_in_message_id.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!messages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / if let Some(ollama_url) = [INFO] [stdout] 69 | | global_config.and_then(|cfg| cfg.get_string(CONFIG_OLLAMA_URL).ok()) [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | if !ollama_url.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ global_config.and_then(|cfg| cfg.get_string(CONFIG_OLLAMA_URL).ok()) [INFO] [stdout] 70 ~ && !ollama_url.is_empty() { [INFO] [stdout] 71 | return ollama_url; [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if use_context { [INFO] [stdout] 177 | | if let Some(context) = &self.context { [INFO] [stdout] 178 | | request = request.context(context.clone()); [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if use_context [INFO] [stdout] 177 ~ && let Some(context) = &self.context { [INFO] [stdout] 178 | request = request.context(context.clone()); [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/openai.rs:989:5 [INFO] [stdout] | [INFO] [stdout] 989 | / Ok(ChatCompletionToolArgs::default() [INFO] [stdout] 990 | | .function(function.build().map_err(|e| { [INFO] [stdout] 991 | | AgentError::InvalidValue(format!("Failed to build tool function: {}", e)) [INFO] [stdout] 992 | | })?) [INFO] [stdout] 993 | | .build() [INFO] [stdout] 994 | | .map_err(|e| AgentError::InvalidValue(format!("Failed to build tool: {}", e)))?) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 989 ~ ChatCompletionToolArgs::default() [INFO] [stdout] 990 | .function(function.build().map_err(|e| { [INFO] [stdout] ... [INFO] [stdout] 993 | .build() [INFO] [stdout] 994 ~ .map_err(|e| AgentError::InvalidValue(format!("Failed to build tool: {}", e))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ollama.rs:284:22 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|tool| from_tool_info_to_ollama_tool_info(tool)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `from_tool_info_to_ollama_tool_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded cloning of iterator items [INFO] [stdout] --> src/ollama.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | / messages [INFO] [stdout] 295 | | .iter() [INFO] [stdout] 296 | | .cloned() [INFO] [stdout] 297 | | .map(|m| message_to_chat(m.as_message().unwrap().clone())) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_iter_cloned [INFO] [stdout] = note: `#[warn(clippy::redundant_iter_cloned)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ .iter() [INFO] [stdout] 296 + .map(|m| message_to_chat(m.as_message().unwrap().clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ollama.rs:321:63 [INFO] [stdout] | [INFO] [stdout] 321 | let res = res.map_err(|_| AgentError::IoError(format!("Ollama Stream Error")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Ollama Stream Error".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:329:21 [INFO] [stdout] | [INFO] [stdout] 329 | / if parameters.is_object() { [INFO] [stdout] 330 | | if let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | | parameters = props.clone(); [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 329 ~ if parameters.is_object() [INFO] [stdout] 330 ~ && let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | parameters = props.clone(); [INFO] [stdout] 333 | } [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ollama.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 330 | / if let Some(obj) = parameters.as_object() { [INFO] [stdout] 331 | | if let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | | parameters = props.clone(); [INFO] [stdout] 333 | | } [INFO] [stdout] 334 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if let Some(obj) = parameters.as_object() [INFO] [stdout] 331 ~ && let Some(props) = obj.get("properties") { [INFO] [stdout] 332 | parameters = props.clone(); [INFO] [stdout] 333 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ollama.rs:351:20 [INFO] [stdout] | [INFO] [stdout] 351 | if tool_calls.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tool_calls.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/openai.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | / if let Some(last_msg) = messages.last() { [INFO] [stdout] 152 | | if last_msg.role != "user" { [INFO] [stdout] 153 | | return Ok(()); [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ if let Some(last_msg) = messages.last() [INFO] [stdout] 152 ~ && last_msg.role != "user" { [INFO] [stdout] 153 | return Ok(()); [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/openai.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|tool| try_from_tool_info_to_chat_completion_tool(tool)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `try_from_tool_info_to_chat_completion_tool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/openai.rs:345:63 [INFO] [stdout] | [INFO] [stdout] 345 | let res = res.map_err(|_| AgentError::IoError(format!("OpenAI Stream Error")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"OpenAI Stream Error".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/openai.rs:989:5 [INFO] [stdout] | [INFO] [stdout] 989 | / Ok(ChatCompletionToolArgs::default() [INFO] [stdout] 990 | | .function(function.build().map_err(|e| { [INFO] [stdout] 991 | | AgentError::InvalidValue(format!("Failed to build tool function: {}", e)) [INFO] [stdout] 992 | | })?) [INFO] [stdout] 993 | | .build() [INFO] [stdout] 994 | | .map_err(|e| AgentError::InvalidValue(format!("Failed to build tool: {}", e)))?) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 989 ~ ChatCompletionToolArgs::default() [INFO] [stdout] 990 | .function(function.build().map_err(|e| { [INFO] [stdout] ... [INFO] [stdout] 993 | .build() [INFO] [stdout] 994 ~ .map_err(|e| AgentError::InvalidValue(format!("Failed to build tool: {}", e))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 32s [INFO] running `Command { std: "docker" "inspect" "c28d47dca3467b83e4c3601bc143dcd2ff4c2e0e405a4c8211d627bb68ceeda3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c28d47dca3467b83e4c3601bc143dcd2ff4c2e0e405a4c8211d627bb68ceeda3", kill_on_drop: false }` [INFO] [stdout] c28d47dca3467b83e4c3601bc143dcd2ff4c2e0e405a4c8211d627bb68ceeda3