[INFO] cloning repository https://github.com/afmhenry/advent-of-code-2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/afmhenry/advent-of-code-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fafmhenry%2Fadvent-of-code-2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fafmhenry%2Fadvent-of-code-2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a9e74abec4e35a7ded11a360bbba3e7b9183ab03 [INFO] linting afmhenry/advent-of-code-2022 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fafmhenry%2Fadvent-of-code-2022" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/afmhenry/advent-of-code-2022 [INFO] finished tweaking git repo https://github.com/afmhenry/advent-of-code-2022 [INFO] tweaked toml for git repo https://github.com/afmhenry/advent-of-code-2022 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/afmhenry/advent-of-code-2022 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/afmhenry/advent-of-code-2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db8e81ee19285282160a1ba5ad8f20b497ee2cf1181b910e133e3218d9ab3215 [INFO] running `Command { std: "docker" "start" "-a" "db8e81ee19285282160a1ba5ad8f20b497ee2cf1181b910e133e3218d9ab3215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db8e81ee19285282160a1ba5ad8f20b497ee2cf1181b910e133e3218d9ab3215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db8e81ee19285282160a1ba5ad8f20b497ee2cf1181b910e133e3218d9ab3215", kill_on_drop: false }` [INFO] [stdout] db8e81ee19285282160a1ba5ad8f20b497ee2cf1181b910e133e3218d9ab3215 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7d158f4045fe53c035152a4f6b6cd75be10c678b341d464bad78f055147165b [INFO] running `Command { std: "docker" "start" "-a" "b7d158f4045fe53c035152a4f6b6cd75be10c678b341d464bad78f055147165b", kill_on_drop: false }` [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking advent-of-code-2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sols/dec5.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | let mut result: i32 = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `task` [INFO] [stdout] --> src/sols/dec5.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | fn task(task: &str, data: &str, mode: &str) -> i32 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_task` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec1.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return max_calories; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return max_calories; [INFO] [stdout] 37 + max_calories [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | "a" => &self.a, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | "b" => &self.b, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | "c" => &self.c, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | _ => &self.a, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | "x" => &self.x, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | "y" => &self.y, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | "z" => &self.z, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 32 | _ => &self.x, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec2.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return my_score; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return my_score; [INFO] [stdout] 122 + my_score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec3.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return prio_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return prio_sum; [INFO] [stdout] 48 + prio_sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec3.rs:29:50 [INFO] [stdout] | [INFO] [stdout] 29 | ... if group[1].contains(&gm_char) && group[2].contains(&gm_char) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `gm_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec3.rs:29:81 [INFO] [stdout] | [INFO] [stdout] 29 | ... if group[1].contains(&gm_char) && group[2].contains(&gm_char) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `gm_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sols/dec4.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | if !(e1_end < e2_start && e1_end < e2_end) [INFO] [stdout] | ________________________^ [INFO] [stdout] 33 | | && !(e2_end < e1_start && e2_end < e1_end) [INFO] [stdout] | |__________________________________________________________________^ help: try: `!(e1_end < e2_start && e1_end < e2_end || e2_end < e1_start && e2_end < e1_end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec4.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec5.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return result; [INFO] [stdout] 38 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/helpers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return name.to_string(); [INFO] [stdout] 8 + name.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | name = name.replace("", &day); [INFO] [stdout] | ^^^^ help: change this to: `day` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:6:35 [INFO] [stdout] | [INFO] [stdout] 6 | name = name.replace("", &data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | name = name.replace("", &mode); [INFO] [stdout] | ^^^^^ help: change this to: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec1.rs:6:54 [INFO] [stdout] | [INFO] [stdout] 6 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec2.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec3.rs:8:57 [INFO] [stdout] | [INFO] [stdout] 8 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec4.rs:6:57 [INFO] [stdout] | [INFO] [stdout] 6 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec5.rs:7:57 [INFO] [stdout] | [INFO] [stdout] 7 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sols/dec5.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | let mut result: i32 = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `task` [INFO] [stdout] --> src/sols/dec5.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | fn task(task: &str, data: &str, mode: &str) -> i32 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_task` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec1.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return max_calories; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return max_calories; [INFO] [stdout] 37 + max_calories [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | "a" => &self.a, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | "b" => &self.b, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | "c" => &self.c, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | _ => &self.a, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | "x" => &self.x, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | "y" => &self.y, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | "z" => &self.z, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec2.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 32 | _ => &self.x, [INFO] [stdout] | ^^^^^^^ help: change this to: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec2.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return my_score; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return my_score; [INFO] [stdout] 122 + my_score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec3.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return prio_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return prio_sum; [INFO] [stdout] 48 + prio_sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec3.rs:29:50 [INFO] [stdout] | [INFO] [stdout] 29 | ... if group[1].contains(&gm_char) && group[2].contains(&gm_char) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `gm_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/dec3.rs:29:81 [INFO] [stdout] | [INFO] [stdout] 29 | ... if group[1].contains(&gm_char) && group[2].contains(&gm_char) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `gm_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sols/dec4.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | if !(e1_end < e2_start && e1_end < e2_end) [INFO] [stdout] | ________________________^ [INFO] [stdout] 33 | | && !(e2_end < e1_start && e2_end < e1_end) [INFO] [stdout] | |__________________________________________________________________^ help: try: `!(e1_end < e2_start && e1_end < e2_end || e2_end < e1_start && e2_end < e1_end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec4.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/dec5.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return result; [INFO] [stdout] 38 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sols/helpers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return name.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return name.to_string(); [INFO] [stdout] 8 + name.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | name = name.replace("", &day); [INFO] [stdout] | ^^^^ help: change this to: `day` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:6:35 [INFO] [stdout] | [INFO] [stdout] 6 | name = name.replace("", &data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sols/helpers.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | name = name.replace("", &mode); [INFO] [stdout] | ^^^^^ help: change this to: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec1.rs:6:54 [INFO] [stdout] | [INFO] [stdout] 6 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec2.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec3.rs:8:57 [INFO] [stdout] | [INFO] [stdout] 8 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec4.rs:6:57 [INFO] [stdout] | [INFO] [stdout] 6 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sols/dec5.rs:7:57 [INFO] [stdout] | [INFO] [stdout] 7 | let contents = h::read_all_lines::(DAY, data.clone(), mode); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.60s [INFO] running `Command { std: "docker" "inspect" "b7d158f4045fe53c035152a4f6b6cd75be10c678b341d464bad78f055147165b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7d158f4045fe53c035152a4f6b6cd75be10c678b341d464bad78f055147165b", kill_on_drop: false }` [INFO] [stdout] b7d158f4045fe53c035152a4f6b6cd75be10c678b341d464bad78f055147165b