[INFO] cloning repository https://github.com/aetherwing-io/slipstream [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aetherwing-io/slipstream" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faetherwing-io%2Fslipstream", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faetherwing-io%2Fslipstream'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3db59a38bd0ab10c3a5d3e8ec65b86e303445ce5 [INFO] linting aetherwing-io/slipstream against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faetherwing-io%2Fslipstream" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aetherwing-io/slipstream [INFO] finished tweaking git repo https://github.com/aetherwing-io/slipstream [INFO] tweaked toml for git repo https://github.com/aetherwing-io/slipstream written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aetherwing-io/slipstream on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aetherwing-io/slipstream already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/aetherwing-io/fcp-regex.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.57 [INFO] [stderr] Downloaded pastey v0.2.1 [INFO] [stderr] Downloaded clap_lex v0.7.7 [INFO] [stderr] Downloaded rmcp-macros v0.14.0 [INFO] [stderr] Downloaded schemars v1.2.1 [INFO] [stderr] Downloaded schemars_derive v1.2.1 [INFO] [stderr] Downloaded zmij v1.0.19 [INFO] [stderr] Downloaded ref-cast v1.0.25 [INFO] [stderr] Downloaded ref-cast-impl v1.0.25 [INFO] [stderr] Downloaded clap_builder v4.5.57 [INFO] [stderr] Downloaded rmcp v0.14.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7abbe6be9a8af7cce47cf01704723471fc18562c37899e30859ab32a83a0c87b [INFO] running `Command { std: "docker" "start" "-a" "7abbe6be9a8af7cce47cf01704723471fc18562c37899e30859ab32a83a0c87b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7abbe6be9a8af7cce47cf01704723471fc18562c37899e30859ab32a83a0c87b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7abbe6be9a8af7cce47cf01704723471fc18562c37899e30859ab32a83a0c87b", kill_on_drop: false }` [INFO] [stdout] 7abbe6be9a8af7cce47cf01704723471fc18562c37899e30859ab32a83a0c87b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a480e2696502c905f5d7c5c6ab5e268168d9f8b71e6af68f9313ae8b8fa5a937 [INFO] running `Command { std: "docker" "start" "-a" "a480e2696502c905f5d7c5c6ab5e268168d9f8b71e6af68f9313ae8b8fa5a937", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rmcp v0.14.0 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Compiling pastey v0.2.1 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking clap_builder v4.5.57 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling schemars_derive v1.2.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking fcp-regex-core v0.1.0 (https://github.com/aetherwing-io/fcp-regex.git?tag=v0.1.1#930c31d2) [INFO] [stderr] Checking clap v4.5.57 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling rmcp-macros v0.14.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking schemars v1.2.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking slipstream-core v0.5.19 (/opt/rustwide/workdir/crates/slipstream-core) [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> crates/slipstream-core/src/str_match.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// to line ranges compatible with the `Edit` pipeline. [INFO] [stdout] 5 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 8 | pub struct MatchResult { [INFO] [stdout] | ---------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! String-match resolution for `file.str_replace`. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! Finds substring matches in a line buffer and resolves them [INFO] [stdout] 4 ~ //! to line ranges compatible with the `Edit` pipeline. [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 5 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> crates/slipstream-core/src/str_match.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// to line ranges compatible with the `Edit` pipeline. [INFO] [stdout] 5 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 8 | pub struct MatchResult { [INFO] [stdout] | ---------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! String-match resolution for `file.str_replace`. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! Finds substring matches in a line buffer and resolves them [INFO] [stdout] 4 ~ //! to line ranges compatible with the `Edit` pipeline. [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 5 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/slipstream-core/src/edit.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | lines.splice(start..end, edit.content.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/alloc/src/vec/mod.rs:4087:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 77 - lines.splice(start..end, edit.content.into_iter()); [INFO] [stdout] 77 + lines.splice(start..end, edit.content); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/slipstream-core/src/format.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl Default for SessionState { [INFO] [stdout] 56 | | fn default() -> Self { [INFO] [stdout] 57 | | SessionState::Closed [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 50 + #[derive(Default)] [INFO] [stdout] 51 | pub enum SessionState { [INFO] [stdout] 52 ~ #[default] [INFO] [stdout] 53 ~ Closed, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | bar.session = SessionState::Closed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Closed, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | bar.session = SessionState::Closed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Closed, flush: FlushState::Skip, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/slipstream-core/src/manager.rs:236:10 [INFO] [stdout] | [INFO] [stdout] 236 | ) -> Result)>, ManagerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | let force = rest.iter().any(|t| *t == "--force"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--force")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | let flush = !rest.iter().any(|t| *t == "--no-flush"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--no-flush")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | let force = rest.iter().any(|t| *t == "--force"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--force")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:129:39 [INFO] [stdout] | [INFO] [stdout] 129 | let args: Vec<&str> = rest.iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:605:20 [INFO] [stdout] | [INFO] [stdout] 605 | if !item.get("method").and_then(|v| v.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item.get("method").and_then(|v| v.as_str()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> crates/slipstream-core/src/str_match.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | results.sort_unstable_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 242 - results.sort_unstable_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 242 + results.sort_unstable_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking slipstream-daemon v0.5.19 (/opt/rustwide/workdir/crates/slipstream-daemon) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/slipstream-core/src/edit.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | lines.splice(start..end, edit.content.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/alloc/src/vec/mod.rs:4087:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 77 - lines.splice(start..end, edit.content.into_iter()); [INFO] [stdout] 77 + lines.splice(start..end, edit.content); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/slipstream-core/src/format.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl Default for SessionState { [INFO] [stdout] 56 | | fn default() -> Self { [INFO] [stdout] 57 | | SessionState::Closed [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 50 + #[derive(Default)] [INFO] [stdout] 51 | pub enum SessionState { [INFO] [stdout] 52 ~ #[default] [INFO] [stdout] 53 ~ Closed, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | bar.session = SessionState::Closed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Closed, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | bar.session = SessionState::Closed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Closed, flush: FlushState::Skip, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> crates/slipstream-core/src/format.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | bar.session = SessionState::Named(session_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `format::StatusBar { session: SessionState::Named(session_name.to_string()), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> crates/slipstream-core/src/format.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | let mut bar = StatusBar::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/slipstream-core/src/manager.rs:236:10 [INFO] [stdout] | [INFO] [stdout] 236 | ) -> Result)>, ManagerError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | let force = rest.iter().any(|t| *t == "--force"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--force")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | let flush = !rest.iter().any(|t| *t == "--no-flush"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--no-flush")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | let force = rest.iter().any(|t| *t == "--force"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.contains(&"--force")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:129:39 [INFO] [stdout] | [INFO] [stdout] 129 | let args: Vec<&str> = rest.iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-core/src/parse.rs:605:20 [INFO] [stdout] | [INFO] [stdout] 605 | if !item.get("method").and_then(|v| v.as_str()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item.get("method").and_then(|v| v.as_str()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> crates/slipstream-core/src/str_match.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | results.sort_unstable_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 242 - results.sort_unstable_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 242 + results.sort_unstable_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Coordinator` [INFO] [stdout] --> crates/slipstream-daemon/src/coordinator.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | / pub fn new() -> Self { [INFO] [stdout] 196 | | Self { [INFO] [stdout] 197 | | files: DashMap::new(), [INFO] [stdout] 198 | | tracking_index: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 194 + impl Default for Coordinator { [INFO] [stdout] 195 + fn default() -> Self { [INFO] [stdout] 196 + Self::new() [INFO] [stdout] 197 + } [INFO] [stdout] 198 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FcpBridge` [INFO] [stdout] --> crates/slipstream-daemon/src/fcp_bridge.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | / pub fn new() -> Self { [INFO] [stdout] 101 | | Self { [INFO] [stdout] 102 | | handlers: DashMap::new(), [INFO] [stdout] 103 | | live_ext_map: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 99 + impl Default for FcpBridge { [INFO] [stdout] 100 + fn default() -> Self { [INFO] [stdout] 101 + Self::new() [INFO] [stdout] 102 + } [INFO] [stdout] 103 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PluginManager` [INFO] [stdout] --> crates/slipstream-daemon/src/plugin_manager.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | / pub fn new() -> Self { [INFO] [stdout] 65 | | Self { [INFO] [stdout] 66 | | ext_map: DashMap::new(), [INFO] [stdout] 67 | | entries: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 63 + impl Default for PluginManager { [INFO] [stdout] 64 + fn default() -> Self { [INFO] [stdout] 65 + Self::new() [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Coordinator` [INFO] [stdout] --> crates/slipstream-daemon/src/coordinator.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | / pub fn new() -> Self { [INFO] [stdout] 196 | | Self { [INFO] [stdout] 197 | | files: DashMap::new(), [INFO] [stdout] 198 | | tracking_index: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 194 + impl Default for Coordinator { [INFO] [stdout] 195 + fn default() -> Self { [INFO] [stdout] 196 + Self::new() [INFO] [stdout] 197 + } [INFO] [stdout] 198 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FcpBridge` [INFO] [stdout] --> crates/slipstream-daemon/src/fcp_bridge.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | / pub fn new() -> Self { [INFO] [stdout] 101 | | Self { [INFO] [stdout] 102 | | handlers: DashMap::new(), [INFO] [stdout] 103 | | live_ext_map: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 99 + impl Default for FcpBridge { [INFO] [stdout] 100 + fn default() -> Self { [INFO] [stdout] 101 + Self::new() [INFO] [stdout] 102 + } [INFO] [stdout] 103 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PluginManager` [INFO] [stdout] --> crates/slipstream-daemon/src/plugin_manager.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | / pub fn new() -> Self { [INFO] [stdout] 65 | | Self { [INFO] [stdout] 66 | | ext_map: DashMap::new(), [INFO] [stdout] 67 | | entries: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 63 + impl Default for PluginManager { [INFO] [stdout] 64 + fn default() -> Self { [INFO] [stdout] 65 + Self::new() [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking slipstream-mcp v0.5.19 (/opt/rustwide/workdir/crates/slipstream-mcp) [INFO] [stderr] Checking slipstream-cli v0.5.19 (/opt/rustwide/workdir/crates/slipstream-cli) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-cli/src/shim/cat.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !(is_final_line && !trailing_newline) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_final_line || trailing_newline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:97:31 [INFO] [stdout] | [INFO] [stdout] 97 | } else if arg == "-f" { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 98 | | return Err(ParseResult::Fallback); [INFO] [stdout] 99 | | } else if arg.starts_with('-') && arg.len() > 1 && arg != "--" { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:99:72 [INFO] [stdout] | [INFO] [stdout] 99 | } else if arg.starts_with('-') && arg.len() > 1 && arg != "--" { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 100 | | return Err(ParseResult::Fallback); [INFO] [stdout] 101 | | } else if arg == "--" { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:102:51 [INFO] [stdout] | [INFO] [stdout] 102 | files.extend(args[i + 1..].iter().map(|a| PathBuf::from(a))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:278:32 [INFO] [stdout] | [INFO] [stdout] 278 | async fn sed_print_range(file: &PathBuf, start: usize, end: usize) -> Result<(), ShimError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 278 ~ async fn sed_print_range(file: &Path, start: usize, end: usize) -> Result<(), ShimError> { [INFO] [stdout] 279 | let mut client = common::connect().await?; [INFO] [stdout] 280 ~ let session_id = common::session_open(&mut client, &[file.to_path_buf()]).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:280:56 [INFO] [stdout] | [INFO] [stdout] 280 | let session_id = common::session_open(&mut client, &[file.clone()]).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-cli/src/shim/tail.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if !(is_final_line && !trailing_newline) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_final_line || trailing_newline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/slipstream-cli/src/shim/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / if stdin_is_tty { [INFO] [stdout] 20 | | if common::shim_interstitial(binary_name, "read") { [INFO] [stdout] 21 | | return 2; [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if stdin_is_tty [INFO] [stdout] 20 ~ && common::shim_interstitial(binary_name, "read") { [INFO] [stdout] 21 | return 2; [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-cli/src/shim/cat.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !(is_final_line && !trailing_newline) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_final_line || trailing_newline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:97:31 [INFO] [stdout] | [INFO] [stdout] 97 | } else if arg == "-f" { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 98 | | return Err(ParseResult::Fallback); [INFO] [stdout] 99 | | } else if arg.starts_with('-') && arg.len() > 1 && arg != "--" { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:99:72 [INFO] [stdout] | [INFO] [stdout] 99 | } else if arg.starts_with('-') && arg.len() > 1 && arg != "--" { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 100 | | return Err(ParseResult::Fallback); [INFO] [stdout] 101 | | } else if arg == "--" { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:102:51 [INFO] [stdout] | [INFO] [stdout] 102 | files.extend(args[i + 1..].iter().map(|a| PathBuf::from(a))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:278:32 [INFO] [stdout] | [INFO] [stdout] 278 | async fn sed_print_range(file: &PathBuf, start: usize, end: usize) -> Result<(), ShimError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 278 ~ async fn sed_print_range(file: &Path, start: usize, end: usize) -> Result<(), ShimError> { [INFO] [stdout] 279 | let mut client = common::connect().await?; [INFO] [stdout] 280 ~ let session_id = common::session_open(&mut client, &[file.to_path_buf()]).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> crates/slipstream-cli/src/shim/sed.rs:280:56 [INFO] [stdout] | [INFO] [stdout] 280 | let session_id = common::session_open(&mut client, &[file.clone()]).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/slipstream-cli/src/shim/tail.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if !(is_final_line && !trailing_newline) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_final_line || trailing_newline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/slipstream-cli/src/shim/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / if stdin_is_tty { [INFO] [stdout] 20 | | if common::shim_interstitial(binary_name, "read") { [INFO] [stdout] 21 | | return 2; [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if stdin_is_tty [INFO] [stdout] 20 ~ && common::shim_interstitial(binary_name, "read") { [INFO] [stdout] 21 | return 2; [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/slipstream-cli/tests/shim_e2e.rs:624:19 [INFO] [stdout] | [INFO] [stdout] 624 | .args(&[fp]) [INFO] [stdout] | ^^^^^ help: change this to: `[fp]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-cli/src/main.rs:654:17 [INFO] [stdout] | [INFO] [stdout] 654 | if !fcp_protocols.iter().any(|p| *p == short) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fcp_protocols.contains(&short)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/slipstream-cli/src/main.rs:654:17 [INFO] [stdout] | [INFO] [stdout] 654 | if !fcp_protocols.iter().any(|p| *p == short) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fcp_protocols.contains(&short)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.40s [INFO] running `Command { std: "docker" "inspect" "a480e2696502c905f5d7c5c6ab5e268168d9f8b71e6af68f9313ae8b8fa5a937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a480e2696502c905f5d7c5c6ab5e268168d9f8b71e6af68f9313ae8b8fa5a937", kill_on_drop: false }` [INFO] [stdout] a480e2696502c905f5d7c5c6ab5e268168d9f8b71e6af68f9313ae8b8fa5a937