[INFO] cloning repository https://github.com/aenlr/esbokio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aenlr/esbokio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faenlr%2Fesbokio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faenlr%2Fesbokio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d95cf0f65ccc016f127ef007f9904675a1f38c1d [INFO] linting aenlr/esbokio against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faenlr%2Fesbokio" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aenlr/esbokio [INFO] finished tweaking git repo https://github.com/aenlr/esbokio [INFO] tweaked toml for git repo https://github.com/aenlr/esbokio written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aenlr/esbokio on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aenlr/esbokio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tabled_derive v0.11.0 [INFO] [stderr] Downloaded rtoolbox v0.0.3 [INFO] [stderr] Downloaded testing_table v0.3.0 [INFO] [stderr] Downloaded zmij v1.0.12 [INFO] [stderr] Downloaded rust_decimal_macros v1.39.0 [INFO] [stderr] Downloaded litrs v0.4.2 [INFO] [stderr] Downloaded cookie_store v0.22.0 [INFO] [stderr] Downloaded papergrid v0.17.0 [INFO] [stderr] Downloaded multipart v0.18.0 [INFO] [stderr] Downloaded uuid v1.17.0 [INFO] [stderr] Downloaded cc v1.2.31 [INFO] [stderr] Downloaded rpassword v7.4.0 [INFO] [stderr] Downloaded tabled v0.20.0 [INFO] [stderr] Downloaded winnow v0.7.12 [INFO] [stderr] Downloaded webpki-roots v1.0.2 [INFO] [stderr] Downloaded rustix v1.0.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 644403adc36d884f36e12b638e19b64c972744ef87b1c03f1a79032f7fd243b4 [INFO] running `Command { std: "docker" "start" "-a" "644403adc36d884f36e12b638e19b64c972744ef87b1c03f1a79032f7fd243b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "644403adc36d884f36e12b638e19b64c972744ef87b1c03f1a79032f7fd243b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "644403adc36d884f36e12b638e19b64c972744ef87b1c03f1a79032f7fd243b4", kill_on_drop: false }` [INFO] [stdout] 644403adc36d884f36e12b638e19b64c972744ef87b1c03f1a79032f7fd243b4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d93910fbe5011d1036c76eb2e6765908e79cedbfd0e519c80ea9062fe68a059b [INFO] running `Command { std: "docker" "start" "-a" "d93910fbe5011d1036c76eb2e6765908e79cedbfd0e519c80ea9062fe68a059b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Compiling rust_decimal v1.39.0 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking testing_table v0.3.0 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking papergrid v0.17.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rtoolbox v0.0.3 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tabled_derive v0.11.0 [INFO] [stderr] Compiling rust_decimal_macros v1.39.0 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking tabled v0.20.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking cookie_store v0.22.0 [INFO] [stderr] Checking ureq v3.1.4 [INFO] [stderr] Checking esbokio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | pub const APPLICATION_JSON: &'static str = "application/json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | pub const APPLICATION_JSON: &'static str = "application/json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `web_user_id` and `expires_date_time` are never read [INFO] [stdout] --> src/eskassa.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct WebLoginResponse { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 72 | pub web_user_id: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 73 | #[serde(rename = "ExpiresDateTime")] [INFO] [stdout] 74 | pub expires_date_time: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `unit` and `control_unit_serial_number` are never read [INFO] [stdout] --> src/eskassa.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct SettingsResponse { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 79 | #[serde(rename = "Unit")] [INFO] [stdout] 80 | pub unit: String, // default unit [INFO] [stdout] | ^^^^ [INFO] [stdout] 81 | #[serde(rename = "ControlUnitSerialNumber")] [INFO] [stdout] 82 | pub control_unit_serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `date_time` and `created_by` are never read [INFO] [stdout] --> src/eskassa.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 118 | pub struct ZReportListItem { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 124 | pub date_time: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 125 | #[serde(rename = "CreatedBy")] [INFO] [stdout] 126 | pub created_by: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ZReportListItem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bokio.rs:101:24 [INFO] [stdout] | [INFO] [stdout] 101 | .send_json(&entry)? [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/bokio.rs:115:51 [INFO] [stdout] | [INFO] [stdout] 115 | let file = std::fs::File::open(&filename).expect(&format!("Kunde inte öppna {}", filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Kunde inte öppna {}", filename))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bokio.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | let file = std::fs::File::open(&filename).expect(&format!("Kunde inte öppna {}", filename)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 40 | if std::io::stdin().is_terminal() && !std::env::var("BROKEN_TERMINAL").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("BROKEN_TERMINAL").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/utils.rs:62:63 [INFO] [stdout] | [INFO] [stdout] 62 | } else if s.starts_with("-") && s.chars().skip(1).all(|c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | return Some(val.expect(&format!("{} expected value", prefix))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} expected value", prefix))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | .expect(&format!("{} expected value", prefix)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} expected value", prefix))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 72 | let nr = sie.number().expect(&format!("Kunde inte tolka rapport {}", sie.zreport)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Kunde inte tolka rapport {}", sie.zreport))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | .expect(&format!("Z-Rapport {} hittades inte", nr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Z-Rapport {} hittades inte", nr))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:91:42 [INFO] [stdout] | [INFO] [stdout] 91 | fn rakna_importerade_rapporter(importer: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn rakna_importerade_rapporter(importer: &Vec) -> usize { [INFO] [stdout] 91 + fn rakna_importerade_rapporter(importer: &[RapportImport]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:124:40 [INFO] [stdout] | [INFO] [stdout] 124 | let amount = rapport.konto(&acc).unwrap_or(Decimal::ZERO); [INFO] [stdout] | ^^^^ help: change this to: `acc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:150:30 [INFO] [stdout] | [INFO] [stdout] 150 | fn valj_rapporter(rapporter: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 150 - fn valj_rapporter(rapporter: &Vec) -> Vec { [INFO] [stdout] 150 + fn valj_rapporter(rapporter: &[RapportImport]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:325:25 [INFO] [stdout] | [INFO] [stdout] 325 | lista_rapporter(&rapporter); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `rapporter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:326:36 [INFO] [stdout] | [INFO] [stdout] 326 | let valda = valj_rapporter(&rapporter); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `rapporter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:337:37 [INFO] [stdout] | [INFO] [stdout] 337 | match importera_rapport(&kassa, &bokio, imp, save_files) { [INFO] [stdout] | ^^^^^^ help: change this to: `kassa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:337:45 [INFO] [stdout] | [INFO] [stdout] 337 | match importera_rapport(&kassa, &bokio, imp, save_files) { [INFO] [stdout] | ^^^^^^ help: change this to: `bokio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `web_user_id` and `expires_date_time` are never read [INFO] [stdout] --> src/eskassa.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct WebLoginResponse { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 72 | pub web_user_id: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 73 | #[serde(rename = "ExpiresDateTime")] [INFO] [stdout] 74 | pub expires_date_time: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `unit` and `control_unit_serial_number` are never read [INFO] [stdout] --> src/eskassa.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct SettingsResponse { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 79 | #[serde(rename = "Unit")] [INFO] [stdout] 80 | pub unit: String, // default unit [INFO] [stdout] | ^^^^ [INFO] [stdout] 81 | #[serde(rename = "ControlUnitSerialNumber")] [INFO] [stdout] 82 | pub control_unit_serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `date_time` and `created_by` are never read [INFO] [stdout] --> src/eskassa.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 118 | pub struct ZReportListItem { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 124 | pub date_time: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 125 | #[serde(rename = "CreatedBy")] [INFO] [stdout] 126 | pub created_by: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ZReportListItem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bokio.rs:101:24 [INFO] [stdout] | [INFO] [stdout] 101 | .send_json(&entry)? [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/bokio.rs:115:51 [INFO] [stdout] | [INFO] [stdout] 115 | let file = std::fs::File::open(&filename).expect(&format!("Kunde inte öppna {}", filename)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Kunde inte öppna {}", filename))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bokio.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | let file = std::fs::File::open(&filename).expect(&format!("Kunde inte öppna {}", filename)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 40 | if std::io::stdin().is_terminal() && !std::env::var("BROKEN_TERMINAL").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("BROKEN_TERMINAL").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/utils.rs:62:63 [INFO] [stdout] | [INFO] [stdout] 62 | } else if s.starts_with("-") && s.chars().skip(1).all(|c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | return Some(val.expect(&format!("{} expected value", prefix))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} expected value", prefix))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | .expect(&format!("{} expected value", prefix)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} expected value", prefix))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 72 | let nr = sie.number().expect(&format!("Kunde inte tolka rapport {}", sie.zreport)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Kunde inte tolka rapport {}", sie.zreport))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | .expect(&format!("Z-Rapport {} hittades inte", nr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Z-Rapport {} hittades inte", nr))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:91:42 [INFO] [stdout] | [INFO] [stdout] 91 | fn rakna_importerade_rapporter(importer: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn rakna_importerade_rapporter(importer: &Vec) -> usize { [INFO] [stdout] 91 + fn rakna_importerade_rapporter(importer: &[RapportImport]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:124:40 [INFO] [stdout] | [INFO] [stdout] 124 | let amount = rapport.konto(&acc).unwrap_or(Decimal::ZERO); [INFO] [stdout] | ^^^^ help: change this to: `acc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:150:30 [INFO] [stdout] | [INFO] [stdout] 150 | fn valj_rapporter(rapporter: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 150 - fn valj_rapporter(rapporter: &Vec) -> Vec { [INFO] [stdout] 150 + fn valj_rapporter(rapporter: &[RapportImport]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:325:25 [INFO] [stdout] | [INFO] [stdout] 325 | lista_rapporter(&rapporter); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `rapporter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:326:36 [INFO] [stdout] | [INFO] [stdout] 326 | let valda = valj_rapporter(&rapporter); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `rapporter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:337:37 [INFO] [stdout] | [INFO] [stdout] 337 | match importera_rapport(&kassa, &bokio, imp, save_files) { [INFO] [stdout] | ^^^^^^ help: change this to: `kassa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:337:45 [INFO] [stdout] | [INFO] [stdout] 337 | match importera_rapport(&kassa, &bokio, imp, save_files) { [INFO] [stdout] | ^^^^^^ help: change this to: `bokio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.59s [INFO] running `Command { std: "docker" "inspect" "d93910fbe5011d1036c76eb2e6765908e79cedbfd0e519c80ea9062fe68a059b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d93910fbe5011d1036c76eb2e6765908e79cedbfd0e519c80ea9062fe68a059b", kill_on_drop: false }` [INFO] [stdout] d93910fbe5011d1036c76eb2e6765908e79cedbfd0e519c80ea9062fe68a059b