[INFO] cloning repository https://github.com/adventureshin/leetcode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adventureshin/leetcode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadventureshin%2Fleetcode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadventureshin%2Fleetcode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f74fc9a8aa6c870dd7a705dc21392b48630b2b56 [INFO] linting adventureshin/leetcode against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadventureshin%2Fleetcode" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adventureshin/leetcode [INFO] finished tweaking git repo https://github.com/adventureshin/leetcode [INFO] tweaked toml for git repo https://github.com/adventureshin/leetcode written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adventureshin/leetcode on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adventureshin/leetcode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7e04d2d8e7f8930dbb23342ccc16f11e97c06e203202a665f01268ea5737abe [INFO] running `Command { std: "docker" "start" "-a" "b7e04d2d8e7f8930dbb23342ccc16f11e97c06e203202a665f01268ea5737abe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7e04d2d8e7f8930dbb23342ccc16f11e97c06e203202a665f01268ea5737abe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7e04d2d8e7f8930dbb23342ccc16f11e97c06e203202a665f01268ea5737abe", kill_on_drop: false }` [INFO] [stdout] b7e04d2d8e7f8930dbb23342ccc16f11e97c06e203202a665f01268ea5737abe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c09c6a07524a1abcff5ea77418dd5b9dff18dac15ab4d1e40997f38c8aba4fc5 [INFO] running `Command { std: "docker" "start" "-a" "c09c6a07524a1abcff5ea77418dd5b9dff18dac15ab4d1e40997f38c8aba4fc5", kill_on_drop: false }` [INFO] [stderr] Checking leetcode v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p004_is_balance.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p005_invert_tree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let mut init_path = n.val.clone().to_string(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p002_same_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p002_same_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p002_same_tree.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `is_same_tree` is never used [INFO] [stdout] --> src/problems/p002_same_tree.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 26 | pub fn is_same_tree(p: Option>>, q: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `is_mirror` and `is_symmetric` are never used [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 26 | pub fn is_mirror(node_1: Option>>, node_2: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn is_symmetric(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p004_is_balance.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p004_is_balance.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p004_is_balance.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `height` and `is_balanced` are never used [INFO] [stdout] --> src/problems/p004_is_balance.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn height(node: Option>>) -> i32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn is_balanced(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p005_invert_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p005_invert_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p005_invert_tree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `invert_tree` is never used [INFO] [stdout] --> src/problems/p005_invert_tree.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 27 | pub fn invert_tree(root: Option>>) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `make_paths` and `binary_tree_paths` are never used [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn make_paths(path: String, node: Rc>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn binary_tree_paths(root: Option>>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p007_find_center.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `find_center` is never used [INFO] [stdout] --> src/problems/p007_find_center.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 6 | pub fn find_center(edges: Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p008_find_tilt.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p008_find_tilt.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p008_find_tilt.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `dfs` and `find_tilt` are never used [INFO] [stdout] --> src/problems/p008_find_tilt.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 25 | fn dfs(node:Option>>, total_tilt: &mut i32) -> i32 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn find_tilt(root: Option>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `check_unival` and `is_unival_tree` are never used [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn check_unival(node: Option>>, is_unival: bool, init_val: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn is_unival_tree(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p004_is_balance.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p005_invert_tree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::char::MAX` [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use std::char::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/problems/p005_invert_tree.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | None => return root, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - None => return root, [INFO] [stdout] 29 + None => root, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !left_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `left_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | if !right_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `right_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left_node` after checking its variant with `is_none` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:37:64 [INFO] [stdout] | [INFO] [stdout] 36 | if !left_node.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 37 | path_vec.extend(Self::make_paths(new_path.clone(), left_node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right_node` after checking its variant with `is_none` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:40:56 [INFO] [stdout] | [INFO] [stdout] 39 | if !right_node.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 40 | path_vec.extend(Self::make_paths(new_path, right_node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 56 | if !left_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `left_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 59 | if !right_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `right_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let mut init_path = n.val.clone().to_string(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p002_same_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p002_same_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p002_same_tree.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `is_same_tree` is never used [INFO] [stdout] --> src/problems/p002_same_tree.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 26 | pub fn is_same_tree(p: Option>>, q: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `is_mirror` and `is_symmetric` are never used [INFO] [stdout] --> src/problems/p003_symmetric_tree.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 26 | pub fn is_mirror(node_1: Option>>, node_2: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn is_symmetric(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p004_is_balance.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p004_is_balance.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p004_is_balance.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `height` and `is_balanced` are never used [INFO] [stdout] --> src/problems/p004_is_balance.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn height(node: Option>>) -> i32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn is_balanced(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p005_invert_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p005_invert_tree.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p005_invert_tree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `invert_tree` is never used [INFO] [stdout] --> src/problems/p005_invert_tree.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 27 | pub fn invert_tree(root: Option>>) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `make_paths` and `binary_tree_paths` are never used [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn make_paths(path: String, node: Rc>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn binary_tree_paths(root: Option>>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p007_find_center.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `find_center` is never used [INFO] [stdout] --> src/problems/p007_find_center.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 6 | pub fn find_center(edges: Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p008_find_tilt.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p008_find_tilt.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p008_find_tilt.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `dfs` and `find_tilt` are never used [INFO] [stdout] --> src/problems/p008_find_tilt.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 25 | fn dfs(node:Option>>, total_tilt: &mut i32) -> i32 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn find_tilt(root: Option>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `check_unival` and `is_unival_tree` are never used [INFO] [stdout] --> src/problems/p009_is_unival_tree.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Solution { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] 27 | fn check_unival(node: Option>>, is_unival: bool, init_val: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn is_unival_tree(root: Option>>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/problems/p005_invert_tree.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | None => return root, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - None => return root, [INFO] [stdout] 29 + None => root, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !left_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `left_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | if !right_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `right_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left_node` after checking its variant with `is_none` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:37:64 [INFO] [stdout] | [INFO] [stdout] 36 | if !left_node.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 37 | path_vec.extend(Self::make_paths(new_path.clone(), left_node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right_node` after checking its variant with `is_none` [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:40:56 [INFO] [stdout] | [INFO] [stdout] 39 | if !right_node.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 40 | path_vec.extend(Self::make_paths(new_path, right_node.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 56 | if !left_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `left_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/p006_binary_tree_path.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 59 | if !right_node.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `right_node.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s [INFO] running `Command { std: "docker" "inspect" "c09c6a07524a1abcff5ea77418dd5b9dff18dac15ab4d1e40997f38c8aba4fc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c09c6a07524a1abcff5ea77418dd5b9dff18dac15ab4d1e40997f38c8aba4fc5", kill_on_drop: false }` [INFO] [stdout] c09c6a07524a1abcff5ea77418dd5b9dff18dac15ab4d1e40997f38c8aba4fc5