[INFO] cloning repository https://github.com/adriankiezik/wgpu-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adriankiezik/wgpu-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadriankiezik%2Fwgpu-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadriankiezik%2Fwgpu-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54b4c82a2b83ea640347107721a1371209f52c95 [INFO] linting adriankiezik/wgpu-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadriankiezik%2Fwgpu-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adriankiezik/wgpu-rust [INFO] finished tweaking git repo https://github.com/adriankiezik/wgpu-rust [INFO] tweaked toml for git repo https://github.com/adriankiezik/wgpu-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adriankiezik/wgpu-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adriankiezik/wgpu-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quick-xml v0.37.3 [INFO] [stderr] Downloaded glyphon v0.8.0 [INFO] [stderr] Downloaded wgpu-hal v24.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca7211f20a98c7fff8ec67b1e4d4f361c5131267e7b7a118f7297e38c16d6f36 [INFO] running `Command { std: "docker" "start" "-a" "ca7211f20a98c7fff8ec67b1e4d4f361c5131267e7b7a118f7297e38c16d6f36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca7211f20a98c7fff8ec67b1e4d4f361c5131267e7b7a118f7297e38c16d6f36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca7211f20a98c7fff8ec67b1e4d4f361c5131267e7b7a118f7297e38c16d6f36", kill_on_drop: false }` [INFO] [stdout] ca7211f20a98c7fff8ec67b1e4d4f361c5131267e7b7a118f7297e38c16d6f36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a7c37272f46e35c84cf544f42620612102859c023c33c03cfb46d09c4c61780 [INFO] running `Command { std: "docker" "start" "-a" "2a7c37272f46e35c84cf544f42620612102859c023c33c03cfb46d09c4c61780", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling cc v1.2.17 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Compiling quick-xml v0.37.3 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling naga v24.0.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling wgpu-hal v24.0.2 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Compiling wgpu-core v24.0.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking fontconfig-parser v0.5.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling wgpu v24.0.3 [INFO] [stderr] Checking indexmap v2.8.0 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Compiling winit v0.30.9 [INFO] [stderr] Checking self_cell v1.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking svg_fmt v0.4.4 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking jiff v0.2.5 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking etagere v0.2.15 [INFO] [stderr] Compiling wayland-backend v0.3.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fontdb v0.16.2 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking wgpu-types v24.0.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking gpu-descriptor v0.3.1 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling bytemuck_derive v1.9.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking env_logger v0.11.7 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking font-types v0.7.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking rustybuzz v0.14.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking read-fonts v0.22.7 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-client v0.31.8 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.6 [INFO] [stderr] Checking wayland-cursor v0.31.8 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking skrifa v0.22.3 [INFO] [stderr] Checking swash v0.1.19 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.6 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.6 [INFO] [stderr] Checking cosmic-text v0.12.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking glyphon v0.8.0 [INFO] [stderr] Checking ferrite_engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/text_engine.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut text_buffer = Buffer::new( [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / enum AppState { [INFO] [stdout] 11 | | Uninitialized, [INFO] [stdout] | | ------------- the second-largest variant carries no data at all [INFO] [stdout] 12 | |/ Initialized { [INFO] [stdout] 13 | || window: Arc, [INFO] [stdout] 14 | || gpu_context: GpuContext, [INFO] [stdout] 15 | || frame_stats: FrameStats, [INFO] [stdout] 16 | || text_engine: TextEngine, [INFO] [stdout] 17 | || }, [INFO] [stdout] | ||_____- the largest variant contains at least 2040 bytes [INFO] [stdout] 18 | | } [INFO] [stdout] | |__^ the entire enum is at least 2040 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 14 ~ gpu_context: Box, [INFO] [stdout] 15 | frame_stats: FrameStats, [INFO] [stdout] 16 ~ text_engine: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/app.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | state: AppState::Uninitialized, [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for App { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/text_engine.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut text_buffer = Buffer::new( [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | &gpu_context, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `gpu_context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/app.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | &*format!("{:.0} fps", frame_stats.fps).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{:.0} fps", frame_stats.fps).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FrameStats` [INFO] [stdout] --> src/frame_stats.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | last_frame_time: Instant::now(), [INFO] [stdout] 14 | | frame_count: 0, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for FrameStats { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / enum AppState { [INFO] [stdout] 11 | | Uninitialized, [INFO] [stdout] | | ------------- the second-largest variant carries no data at all [INFO] [stdout] 12 | |/ Initialized { [INFO] [stdout] 13 | || window: Arc, [INFO] [stdout] 14 | || gpu_context: GpuContext, [INFO] [stdout] 15 | || frame_stats: FrameStats, [INFO] [stdout] 16 | || text_engine: TextEngine, [INFO] [stdout] 17 | || }, [INFO] [stdout] | ||_____- the largest variant contains at least 2040 bytes [INFO] [stdout] 18 | | } [INFO] [stdout] | |__^ the entire enum is at least 2040 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 14 ~ gpu_context: Box, [INFO] [stdout] 15 | frame_stats: FrameStats, [INFO] [stdout] 16 ~ text_engine: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `App` [INFO] [stdout] --> src/app.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | state: AppState::Uninitialized, [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for App { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | &gpu_context, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `gpu_context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/app.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | &*format!("{:.0} fps", frame_stats.fps).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{:.0} fps", frame_stats.fps).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FrameStats` [INFO] [stdout] --> src/frame_stats.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | last_frame_time: Instant::now(), [INFO] [stdout] 14 | | frame_count: 0, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for FrameStats { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.87s [INFO] running `Command { std: "docker" "inspect" "2a7c37272f46e35c84cf544f42620612102859c023c33c03cfb46d09c4c61780", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a7c37272f46e35c84cf544f42620612102859c023c33c03cfb46d09c4c61780", kill_on_drop: false }` [INFO] [stdout] 2a7c37272f46e35c84cf544f42620612102859c023c33c03cfb46d09c4c61780