[INFO] cloning repository https://github.com/adivarshnei/data-structs-algos [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adivarshnei/data-structs-algos" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadivarshnei%2Fdata-structs-algos", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadivarshnei%2Fdata-structs-algos'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fee2122cb94bf1030126ca630911f4026ed63b3d [INFO] linting adivarshnei/data-structs-algos against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadivarshnei%2Fdata-structs-algos" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adivarshnei/data-structs-algos [INFO] finished tweaking git repo https://github.com/adivarshnei/data-structs-algos [INFO] tweaked toml for git repo https://github.com/adivarshnei/data-structs-algos written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adivarshnei/data-structs-algos on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adivarshnei/data-structs-algos already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0cf903cf60da103f6a9745995b669e515f5055f6b746f2e1e03d9872bf9d2467 [INFO] running `Command { std: "docker" "start" "-a" "0cf903cf60da103f6a9745995b669e515f5055f6b746f2e1e03d9872bf9d2467", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cf903cf60da103f6a9745995b669e515f5055f6b746f2e1e03d9872bf9d2467", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cf903cf60da103f6a9745995b669e515f5055f6b746f2e1e03d9872bf9d2467", kill_on_drop: false }` [INFO] [stdout] 0cf903cf60da103f6a9745995b669e515f5055f6b746f2e1e03d9872bf9d2467 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d056e0eaafaaa600e7d208f8863d181833cef6686871a76d406511915ce8de92 [INFO] running `Command { std: "docker" "start" "-a" "d056e0eaafaaa600e7d208f8863d181833cef6686871a76d406511915ce8de92", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.142 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking data-structs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/searches/binary.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn binsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return mid as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return mid as i32; [INFO] [stdout] 18 + mid as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return binsearch_util(query, vec, start, mid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return binsearch_util(query, vec, start, mid); [INFO] [stdout] 20 + binsearch_util(query, vec, start, mid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return binsearch_util(query, vec, mid, end); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return binsearch_util(query, vec, mid, end); [INFO] [stdout] 22 + binsearch_util(query, vec, mid, end) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/searches/linear.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/searches/linear.rs:1:35 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] 1 + pub fn linsearch(query: i32, vec: &[i32], len: usize) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/searches/binary.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn binsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vec` [INFO] [stdout] --> src/searches/linear.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 2 - for i in 0..len { [INFO] [stdout] 2 + for (i, ) in vec.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return mid as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return mid as i32; [INFO] [stdout] 18 + mid as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return binsearch_util(query, vec, start, mid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return binsearch_util(query, vec, start, mid); [INFO] [stdout] 20 + binsearch_util(query, vec, start, mid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/searches/binary.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return binsearch_util(query, vec, mid, end); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return binsearch_util(query, vec, mid, end); [INFO] [stdout] 22 + binsearch_util(query, vec, mid, end) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sorts/bubble.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn bubblesort(vec: &Vec, len: usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn bubblesort(vec: &Vec, len: usize) { [INFO] [stdout] 1 + pub fn bubblesort(vec: &[i32], len: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `sorted` manually [INFO] [stdout] --> src/sorts/bubble.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | / let tmp = sorted[i]; [INFO] [stdout] 9 | | sorted[i] = sorted[j]; [INFO] [stdout] 10 | | sorted[j] = tmp; [INFO] [stdout] | |________________________^ help: try: `sorted.swap(i, j);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/searches/linear.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/searches/linear.rs:1:35 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn linsearch(query: i32, vec: &Vec, len: usize) -> () { [INFO] [stdout] 1 + pub fn linsearch(query: i32, vec: &[i32], len: usize) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vec` [INFO] [stdout] --> src/searches/linear.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 2 - for i in 0..len { [INFO] [stdout] 2 + for (i, ) in vec.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/utils.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] 34 + pub fn print_vec(vec: &[i32]) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/utils.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 35 | vec[..].into_iter().for_each(|x| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | while input.is_empty() || !input.trim().parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.trim().parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sorts/bubble.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn bubblesort(vec: &Vec, len: usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn bubblesort(vec: &Vec, len: usize) { [INFO] [stdout] 1 + pub fn bubblesort(vec: &[i32], len: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `sorted` manually [INFO] [stdout] --> src/sorts/bubble.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | / let tmp = sorted[i]; [INFO] [stdout] 9 | | sorted[i] = sorted[j]; [INFO] [stdout] 10 | | sorted[j] = tmp; [INFO] [stdout] | |________________________^ help: try: `sorted.swap(i, j);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | fn sorts() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:56:3 [INFO] [stdout] | [INFO] [stdout] 56 | / match choice { [INFO] [stdout] 57 | | 1..=28 => { [INFO] [stdout] 58 | | let vec: Vec = utils::gen_vec(utils::ARR_LEN as usize); [INFO] [stdout] 59 | | utils::print_vec(&vec); [INFO] [stdout] ... | [INFO] [stdout] 66 | | _ => (), [INFO] [stdout] 67 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let 1..=28 = choice { [INFO] [stdout] 57 + let vec: Vec = utils::gen_vec(utils::ARR_LEN as usize); [INFO] [stdout] 58 + utils::print_vec(&vec); [INFO] [stdout] 59 + [INFO] [stdout] 60 + match choice { [INFO] [stdout] 61 + 1 => sorts::bubble::bubblesort(&vec, vec.len()), [INFO] [stdout] 62 + _ => (), [INFO] [stdout] 63 + } [INFO] [stdout] 64 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:61:7 [INFO] [stdout] | [INFO] [stdout] 61 | / match choice { [INFO] [stdout] 62 | | 1 => sorts::bubble::bubblesort(&vec, vec.len()), [INFO] [stdout] 63 | | _ => (), [INFO] [stdout] 64 | | } [INFO] [stdout] | |_______^ help: try: `if choice == 1 { sorts::bubble::bubblesort(&vec, vec.len()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | fn searches() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:77:3 [INFO] [stdout] | [INFO] [stdout] 77 | / match choice { [INFO] [stdout] 78 | | 1..=2 => { [INFO] [stdout] 79 | | let vec: Vec = utils::gen_sorted_vec(utils::ARR_LEN as usize); [INFO] [stdout] 80 | | println!("Element List: "); [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => (), [INFO] [stdout] 95 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if let 1..=2 = choice { [INFO] [stdout] 78 + let vec: Vec = utils::gen_sorted_vec(utils::ARR_LEN as usize); [INFO] [stdout] 79 + println!("Element List: "); [INFO] [stdout] 80 + [INFO] [stdout] 81 + utils::print_vec(&vec); [INFO] [stdout] 82 + [INFO] [stdout] 83 + print!("\nEnter element to find: "); [INFO] [stdout] 84 + let query: i32 = utils::get_num_input(); [INFO] [stdout] 85 + [INFO] [stdout] 86 + match choice { [INFO] [stdout] 87 + 1 => searches::linear::linsearch(query, &vec, vec.len()), [INFO] [stdout] 88 + 2 => searches::binary::binsearch(query, &vec, vec.len()), [INFO] [stdout] 89 + _ => (), [INFO] [stdout] 90 + } [INFO] [stdout] 91 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/utils.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn print_vec(vec: &Vec) -> () { [INFO] [stdout] 34 + pub fn print_vec(vec: &[i32]) -> () { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/utils.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 35 | vec[..].into_iter().for_each(|x| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | while input.is_empty() || !input.trim().parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.trim().parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | fn sorts() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:56:3 [INFO] [stdout] | [INFO] [stdout] 56 | / match choice { [INFO] [stdout] 57 | | 1..=28 => { [INFO] [stdout] 58 | | let vec: Vec = utils::gen_vec(utils::ARR_LEN as usize); [INFO] [stdout] 59 | | utils::print_vec(&vec); [INFO] [stdout] ... | [INFO] [stdout] 66 | | _ => (), [INFO] [stdout] 67 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let 1..=28 = choice { [INFO] [stdout] 57 + let vec: Vec = utils::gen_vec(utils::ARR_LEN as usize); [INFO] [stdout] 58 + utils::print_vec(&vec); [INFO] [stdout] 59 + [INFO] [stdout] 60 + match choice { [INFO] [stdout] 61 + 1 => sorts::bubble::bubblesort(&vec, vec.len()), [INFO] [stdout] 62 + _ => (), [INFO] [stdout] 63 + } [INFO] [stdout] 64 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:61:7 [INFO] [stdout] | [INFO] [stdout] 61 | / match choice { [INFO] [stdout] 62 | | 1 => sorts::bubble::bubblesort(&vec, vec.len()), [INFO] [stdout] 63 | | _ => (), [INFO] [stdout] 64 | | } [INFO] [stdout] | |_______^ help: try: `if choice == 1 { sorts::bubble::bubblesort(&vec, vec.len()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | fn searches() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:77:3 [INFO] [stdout] | [INFO] [stdout] 77 | / match choice { [INFO] [stdout] 78 | | 1..=2 => { [INFO] [stdout] 79 | | let vec: Vec = utils::gen_sorted_vec(utils::ARR_LEN as usize); [INFO] [stdout] 80 | | println!("Element List: "); [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => (), [INFO] [stdout] 95 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ if let 1..=2 = choice { [INFO] [stdout] 78 + let vec: Vec = utils::gen_sorted_vec(utils::ARR_LEN as usize); [INFO] [stdout] 79 + println!("Element List: "); [INFO] [stdout] 80 + [INFO] [stdout] 81 + utils::print_vec(&vec); [INFO] [stdout] 82 + [INFO] [stdout] 83 + print!("\nEnter element to find: "); [INFO] [stdout] 84 + let query: i32 = utils::get_num_input(); [INFO] [stdout] 85 + [INFO] [stdout] 86 + match choice { [INFO] [stdout] 87 + 1 => searches::linear::linsearch(query, &vec, vec.len()), [INFO] [stdout] 88 + 2 => searches::binary::binsearch(query, &vec, vec.len()), [INFO] [stdout] 89 + _ => (), [INFO] [stdout] 90 + } [INFO] [stdout] 91 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `Command { std: "docker" "inspect" "d056e0eaafaaa600e7d208f8863d181833cef6686871a76d406511915ce8de92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d056e0eaafaaa600e7d208f8863d181833cef6686871a76d406511915ce8de92", kill_on_drop: false }` [INFO] [stdout] d056e0eaafaaa600e7d208f8863d181833cef6686871a76d406511915ce8de92