[INFO] cloning repository https://github.com/aditya-giri/fsim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aditya-giri/fsim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faditya-giri%2Ffsim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faditya-giri%2Ffsim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f95fe842dc0e2bdcf455b26a1019cb290458d70 [INFO] linting aditya-giri/fsim against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faditya-giri%2Ffsim" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aditya-giri/fsim [INFO] finished tweaking git repo https://github.com/aditya-giri/fsim [INFO] tweaked toml for git repo https://github.com/aditya-giri/fsim written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aditya-giri/fsim on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aditya-giri/fsim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d422153c6e8f465940072a7aedb239a9f45c9eea31de2743ea346fd60059f49 [INFO] running `Command { std: "docker" "start" "-a" "8d422153c6e8f465940072a7aedb239a9f45c9eea31de2743ea346fd60059f49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d422153c6e8f465940072a7aedb239a9f45c9eea31de2743ea346fd60059f49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d422153c6e8f465940072a7aedb239a9f45c9eea31de2743ea346fd60059f49", kill_on_drop: false }` [INFO] [stdout] 8d422153c6e8f465940072a7aedb239a9f45c9eea31de2743ea346fd60059f49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1995c1bce35f0b06963a120248dcb3d68f096c7499f05c2274a47adb3fec1b6 [INFO] running `Command { std: "docker" "start" "-a" "a1995c1bce35f0b06963a120248dcb3d68f096c7499f05c2274a47adb3fec1b6", kill_on_drop: false }` [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking fsim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `states` is never read [INFO] [stdout] --> src/dfa.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct DFA { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 27 | states: HashSet, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `states` is never read [INFO] [stdout] --> src/nfa.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct NFA { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 27 | states: HashSet, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dfa.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(start < states) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(start >= states)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dfa.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(tfn.len() == states * alphabet.len()) || !(tfn.values().all(|&v| v < states)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tfn.len() != states * alphabet.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/dfa.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] 62 + fn validate_input(&self, input: &str) -> Result<(), InputError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dfa.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match new_state { [INFO] [stdout] 98 | | Some(&s) => { [INFO] [stdout] 99 | | current_state = s; [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Some(&s) = new_state { [INFO] [stdout] 98 + current_state = s; [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nfa.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(start < states) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(start >= states)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/nfa.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] 87 + fn validate_input(&self, input: &str) -> Result<(), InputError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/nfa.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / match new_states_for_current_state { [INFO] [stdout] 121 | | Some(s) => new_states.extend(s), [INFO] [stdout] 122 | | None => (), [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ help: try: `if let Some(s) = new_states_for_current_state { new_states.extend(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `states` is never read [INFO] [stdout] --> src/dfa.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct DFA { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 27 | states: HashSet, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `states` is never read [INFO] [stdout] --> src/nfa.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct NFA { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 27 | states: HashSet, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dfa.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(start < states) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(start >= states)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dfa.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(tfn.len() == states * alphabet.len()) || !(tfn.values().all(|&v| v < states)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tfn.len() != states * alphabet.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/dfa.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] 62 + fn validate_input(&self, input: &str) -> Result<(), InputError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dfa.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match new_state { [INFO] [stdout] 98 | | Some(&s) => { [INFO] [stdout] 99 | | current_state = s; [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Some(&s) = new_state { [INFO] [stdout] 98 + current_state = s; [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/dfa.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nfa.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !(start < states) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(start >= states)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/nfa.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - fn validate_input(&self, input: &String) -> Result<(), InputError> { [INFO] [stdout] 87 + fn validate_input(&self, input: &str) -> Result<(), InputError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/nfa.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / match new_states_for_current_state { [INFO] [stdout] 121 | | Some(s) => new_states.extend(s), [INFO] [stdout] 122 | | None => (), [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ help: try: `if let Some(s) = new_states_for_current_state { new_states.extend(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/nfa.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `Command { std: "docker" "inspect" "a1995c1bce35f0b06963a120248dcb3d68f096c7499f05c2274a47adb3fec1b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1995c1bce35f0b06963a120248dcb3d68f096c7499f05c2274a47adb3fec1b6", kill_on_drop: false }` [INFO] [stdout] a1995c1bce35f0b06963a120248dcb3d68f096c7499f05c2274a47adb3fec1b6