[INFO] cloning repository https://github.com/adihodos/rust-opengl-particle-simulation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adihodos/rust-opengl-particle-simulation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9334b43e04aeb3eb7ae8d4598e393f521830ce14 [INFO] linting adihodos/rust-opengl-particle-simulation against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adihodos/rust-opengl-particle-simulation [INFO] finished tweaking git repo https://github.com/adihodos/rust-opengl-particle-simulation [INFO] tweaked toml for git repo https://github.com/adihodos/rust-opengl-particle-simulation written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adihodos/rust-opengl-particle-simulation on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adihodos/rust-opengl-particle-simulation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-xid v0.1.0 [INFO] [stderr] Downloaded pkg-config v0.3.17 [INFO] [stderr] Downloaded adler32 v1.0.4 [INFO] [stderr] Downloaded num-derive v0.2.5 [INFO] [stderr] Downloaded autocfg v1.0.0 [INFO] [stderr] Downloaded c2-chacha v0.2.3 [INFO] [stderr] Downloaded byteorder v1.3.4 [INFO] [stderr] Downloaded bitflags v1.2.1 [INFO] [stderr] Downloaded deflate v0.8.3 [INFO] [stderr] Downloaded cc v1.0.50 [INFO] [stderr] Downloaded syn v0.15.44 [INFO] [stderr] Downloaded num-rational v0.2.3 [INFO] [stderr] Downloaded proc-macro2 v0.4.30 [INFO] [stderr] Downloaded num-traits v0.2.11 [INFO] [stderr] Downloaded x11 v2.18.2 [INFO] [stderr] Downloaded crc32fast v1.2.0 [INFO] [stderr] Downloaded png v0.16.0 [INFO] [stderr] Downloaded inflate v0.4.5 [INFO] [stderr] Downloaded ppv-lite86 v0.2.6 [INFO] [stderr] Downloaded rand_chacha v0.2.1 [INFO] [stderr] Downloaded getrandom v0.1.14 [INFO] [stderr] Downloaded xml-rs v0.8.0 [INFO] [stderr] Downloaded gl_loader v0.1.2 [INFO] [stderr] Downloaded num-iter v0.1.40 [INFO] [stderr] Downloaded num-integer v0.1.42 [INFO] [stderr] Downloaded quote v0.6.13 [INFO] [stderr] Downloaded cfg-if v0.1.10 [INFO] [stderr] Downloaded libc v0.2.67 [INFO] [stderr] Downloaded log v0.4.8 [INFO] [stderr] Downloaded gl v0.14.0 [INFO] [stderr] Downloaded winapi v0.3.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56497b3b93838886f1ae160c325a8f5fa3ed5076bb0833157a16577f372e0155 [INFO] running `Command { std: "docker" "start" "-a" "56497b3b93838886f1ae160c325a8f5fa3ed5076bb0833157a16577f372e0155", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56497b3b93838886f1ae160c325a8f5fa3ed5076bb0833157a16577f372e0155", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56497b3b93838886f1ae160c325a8f5fa3ed5076bb0833157a16577f372e0155", kill_on_drop: false }` [INFO] [stdout] 56497b3b93838886f1ae160c325a8f5fa3ed5076bb0833157a16577f372e0155 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] adf60f81e564b5b89837f7fbcc75ec1f2dd4f0d98a3af026926c9897bdd6c692 [INFO] running `Command { std: "docker" "start" "-a" "adf60f81e564b5b89837f7fbcc75ec1f2dd4f0d98a3af026926c9897bdd6c692", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking deflate v0.8.3 [INFO] [stderr] Compiling x11 v2.18.2 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking png v0.16.0 [INFO] [stderr] Compiling gl_loader v0.1.2 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking math v0.1.0 (/opt/rustwide/workdir/math) [INFO] [stderr] Checking sys v0.1.0 (/opt/rustwide/workdir/sys) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:6:51 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `FromPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `ToPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `FromPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:13:66 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `ToPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GLXDrawable` [INFO] [stdout] --> sys/src/window_x11.rs:15:50 [INFO] [stdout] | [INFO] [stdout] 15 | glXQueryVersion, glXSwapBuffers, GLXContext, GLXDrawable, GLXFBConfig, GLX_BUFFER_SIZE, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AlreadyGrabbed`, `Button5`, `FocusIn`, `FocusOut`, `GrabFrozen`, `GrabInvalidTime`, `GrabModeAsync`, `GrabNotViewable`, `PropModeReplace`, `Screen`, `XA_ATOM`, `XChangeProperty`, `XFocusChangeEvent`, `XGrabKeyboard`, `XQueryPointer`, `XSync`, `XUngrabKeyboard`, and `XWarpPointer` [INFO] [stdout] --> sys/src/window_x11.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | AllocNone, AlreadyGrabbed, Atom, Bool, Button1, Button1Mask, Button2, Button2Mask, Button3, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | Button3Mask, Button4, Button4Mask, Button5, Button5Mask, ButtonPress, ButtonPressMask, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | ExposureMask, False, FocusChangeMask, FocusIn, FocusOut, GrabFrozen, GrabInvalidTime, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | GrabModeAsync, GrabNotViewable, InputHint, InputOutput, KeyPress, KeyPressMask, KeyRelease, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 29 | KeyReleaseMask, KeySym, LeaveWindowMask, MotionNotify, NoSymbol, PBaseSize, PMinSize, [INFO] [stdout] 30 | PointerMotionMask, PropModeReplace, RevertToNone, Screen, ShiftMask, StateHint, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | XAllocWMHints, XButtonEvent, XChangeProperty, XClearWindow, XClientMessageEvent, XCloseDisplay, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 34 | XConfigureEvent, XCreateColormap, XCreateWindow, XDefaultRootWindow, XDefaultScreen, [INFO] [stdout] 35 | XDestroyWindow, XEvent, XEventsQueued, XFlush, XFocusChangeEvent, XFree, XGetGeometry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | XGrabKeyboard, XInternAtom, XKeyEvent, XLookupString, XMapRaised, XMotionEvent, XMoveWindow, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | XNextEvent, XOpenDisplay, XQueryPointer, XRootWindow, XSendEvent, XSetInputFocus, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 38 | XSetWMProperties, XSetWMProtocols, XSetWindowAttributes, XSizeHints, XSync, XUngrabKeyboard, [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | XVisibilityEvent, XVisualInfo, XWMHints, XWarpPointer, XWhitePixel, XA_ATOM, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:6:51 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `FromPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `ToPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `FromPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> sys/src/events.rs:13:66 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `ToPrimitive` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GLXDrawable` [INFO] [stdout] --> sys/src/window_x11.rs:15:50 [INFO] [stdout] | [INFO] [stdout] 15 | glXQueryVersion, glXSwapBuffers, GLXContext, GLXDrawable, GLXFBConfig, GLX_BUFFER_SIZE, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AlreadyGrabbed`, `Button5`, `FocusIn`, `FocusOut`, `GrabFrozen`, `GrabInvalidTime`, `GrabModeAsync`, `GrabNotViewable`, `PropModeReplace`, `Screen`, `XA_ATOM`, `XChangeProperty`, `XFocusChangeEvent`, `XGrabKeyboard`, `XQueryPointer`, `XSync`, `XUngrabKeyboard`, and `XWarpPointer` [INFO] [stdout] --> sys/src/window_x11.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | AllocNone, AlreadyGrabbed, Atom, Bool, Button1, Button1Mask, Button2, Button2Mask, Button3, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | Button3Mask, Button4, Button4Mask, Button5, Button5Mask, ButtonPress, ButtonPressMask, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | ExposureMask, False, FocusChangeMask, FocusIn, FocusOut, GrabFrozen, GrabInvalidTime, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | GrabModeAsync, GrabNotViewable, InputHint, InputOutput, KeyPress, KeyPressMask, KeyRelease, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 29 | KeyReleaseMask, KeySym, LeaveWindowMask, MotionNotify, NoSymbol, PBaseSize, PMinSize, [INFO] [stdout] 30 | PointerMotionMask, PropModeReplace, RevertToNone, Screen, ShiftMask, StateHint, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | XAllocWMHints, XButtonEvent, XChangeProperty, XClearWindow, XClientMessageEvent, XCloseDisplay, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 34 | XConfigureEvent, XCreateColormap, XCreateWindow, XDefaultRootWindow, XDefaultScreen, [INFO] [stdout] 35 | XDestroyWindow, XEvent, XEventsQueued, XFlush, XFocusChangeEvent, XFree, XGetGeometry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | XGrabKeyboard, XInternAtom, XKeyEvent, XLookupString, XMapRaised, XMotionEvent, XMoveWindow, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | XNextEvent, XOpenDisplay, XQueryPointer, XRootWindow, XSendEvent, XSetInputFocus, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 38 | XSetWMProperties, XSetWMProtocols, XSetWindowAttributes, XSizeHints, XSync, XUngrabKeyboard, [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | XVisibilityEvent, XVisualInfo, XWMHints, XWarpPointer, XWhitePixel, XA_ATOM, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> math/src/colors.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> math/src/colors.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 73 - let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] 73 + let s = if let Some() = s.strip_prefix('#') { } else { s }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> math/src/colors.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> math/src/colors.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 73 - let s = if s.starts_with('#') { &s[1..] } else { s }; [INFO] [stdout] 73 + let s = if let Some() = s.strip_prefix('#') { } else { s }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PFNGLXCREATECONTEXTATTRIBSARBPROC` contains a capitalized acronym [INFO] [stdout] --> sys/src/window_x11.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | type PFNGLXCREATECONTEXTATTRIBSARBPROC = unsafe extern "C" fn( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pfnglxcreatecontextattribsarbproc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> sys/src/window_x11.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | event_receiver: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> math/src/colors.rs:968:9 [INFO] [stdout] | [INFO] [stdout] 968 | assert_eq!(RGBAColor::from_html("invalid str").is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 968 - assert_eq!(RGBAColor::from_html("invalid str").is_ok(), false); [INFO] [stdout] 968 + assert!(!RGBAColor::from_html("invalid str").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PFNGLXCREATECONTEXTATTRIBSARBPROC` contains a capitalized acronym [INFO] [stdout] --> sys/src/window_x11.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | type PFNGLXCREATECONTEXTATTRIBSARBPROC = unsafe extern "C" fn( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pfnglxcreatecontextattribsarbproc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> math/src/utility.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | (x.min(1_f32)).max(0_f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `x.clamp(0_f32, 1_f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> math/src/utility.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | std::mem::size_of::() * s.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> sys/src/window_x11.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | event_receiver: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> math/src/utility.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | (x.min(1_f32)).max(0_f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `x.clamp(0_f32, 1_f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> math/src/utility.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | std::mem::size_of::() * s.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | mwe.delta = if xbe.button == Button4 { -1 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseWheelEventData { delta: if xbe.button == Button4 { -1 } else { 1 }, pointer_x: xbe.x, pointer_y: xbe.y, button1: (xbe.state & Button1Mask) != 0, button2: (xbe.state & Button2Mask) != 0, button3: (xbe.state & Button3Mask) != 0, button4: (xbe.state & Button4Mask) != 0, button5: (xbe.state & Button5Mask) != 0, shift: (xbe.state & ShiftMask) != 0, control: (xbe.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let mut mwe = MouseWheelEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/mat2x3.rs:354:26 [INFO] [stdout] | [INFO] [stdout] 354 | (a - b).abs() <= std::f32::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 354 - (a - b).abs() <= std::f32::EPSILON [INFO] [stdout] 354 + (a - b).abs() <= f32::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | mbtn_evt.pointer_x = xbe.x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseButtonEventData { pointer_x: xbe.x, pointer_y: xbe.y, type_: if xbe.type_ == ButtonPress { [INFO] [stdout] ActionType::Press [INFO] [stdout] } else { [INFO] [stdout] ActionType::Release [INFO] [stdout] }, button: btn, button1: (xbe.state & Button1Mask) != 0, button2: (xbe.state & Button2Mask) != 0, button3: (xbe.state & Button3Mask) != 0, button4: (xbe.state & Button4Mask) != 0, button5: (xbe.state & Button5Mask) != 0, shift: (xbe.state & ShiftMask) != 0, control: (xbe.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | let mut mbtn_evt = MouseButtonEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | mme.pointer_x = x11evt.x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseMotionEventData { pointer_x: x11evt.x, pointer_y: x11evt.y, button1: (x11evt.state & Button1Mask) != 0, button2: (x11evt.state & Button2Mask) != 0, button3: (x11evt.state & Button3Mask) != 0, button4: (x11evt.state & Button4Mask) != 0, button5: (x11evt.state & Button5Mask) != 0, shift: (x11evt.state & ShiftMask) != 0, control: (x11evt.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | let mut mme = MouseMotionEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:358:13 [INFO] [stdout] | [INFO] [stdout] 358 | / self.event_receiver [INFO] [stdout] 359 | | .as_ref() [INFO] [stdout] 360 | | .map(|evrec| (evrec)(&Event::InputBegin)); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 358 ~ if let Some(evrec) = self.event_receiver [INFO] [stdout] 359 + .as_ref() { (evrec)(&Event::InputBegin) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:412:13 [INFO] [stdout] | [INFO] [stdout] 412 | / self.event_receiver [INFO] [stdout] 413 | | .as_ref() [INFO] [stdout] 414 | | .map(|evrec| (evrec)(&Event::InputEnd)); [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 412 ~ if let Some(evrec) = self.event_receiver [INFO] [stdout] 413 + .as_ref() { (evrec)(&Event::InputEnd) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | / self.event_receiver.as_ref().map(|evrec| { [INFO] [stdout] 419 | | let (w, h) = self.size.get(); [INFO] [stdout] 420 | | (evrec)(&Event::Loop(LoopEventData { [INFO] [stdout] 421 | | surface_width: w, [INFO] [stdout] ... | [INFO] [stdout] 425 | | })); [INFO] [stdout] 426 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 418 - self.event_receiver.as_ref().map(|evrec| { [INFO] [stdout] 419 - let (w, h) = self.size.get(); [INFO] [stdout] 420 - (evrec)(&Event::Loop(LoopEventData { [INFO] [stdout] 421 - surface_width: w, [INFO] [stdout] 422 - surface_height: h, [INFO] [stdout] 423 - window_width: self.win_size.get().0, [INFO] [stdout] 424 - window_height: self.win_size.get().1, [INFO] [stdout] 425 - })); [INFO] [stdout] 426 - }); [INFO] [stdout] 418 + if let Some(evrec) = self.event_receiver.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 299 | mwe.delta = if xbe.button == Button4 { -1 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseWheelEventData { delta: if xbe.button == Button4 { -1 } else { 1 }, pointer_x: xbe.x, pointer_y: xbe.y, button1: (xbe.state & Button1Mask) != 0, button2: (xbe.state & Button2Mask) != 0, button3: (xbe.state & Button3Mask) != 0, button4: (xbe.state & Button4Mask) != 0, button5: (xbe.state & Button5Mask) != 0, shift: (xbe.state & ShiftMask) != 0, control: (xbe.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let mut mwe = MouseWheelEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | mbtn_evt.pointer_x = xbe.x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseButtonEventData { pointer_x: xbe.x, pointer_y: xbe.y, type_: if xbe.type_ == ButtonPress { [INFO] [stdout] ActionType::Press [INFO] [stdout] } else { [INFO] [stdout] ActionType::Release [INFO] [stdout] }, button: btn, button1: (xbe.state & Button1Mask) != 0, button2: (xbe.state & Button2Mask) != 0, button3: (xbe.state & Button3Mask) != 0, button4: (xbe.state & Button4Mask) != 0, button5: (xbe.state & Button5Mask) != 0, shift: (xbe.state & ShiftMask) != 0, control: (xbe.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | let mut mbtn_evt = MouseButtonEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> sys/src/window_x11.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | mme.pointer_x = x11evt.x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `events::MouseMotionEventData { pointer_x: x11evt.x, pointer_y: x11evt.y, button1: (x11evt.state & Button1Mask) != 0, button2: (x11evt.state & Button2Mask) != 0, button3: (x11evt.state & Button3Mask) != 0, button4: (x11evt.state & Button4Mask) != 0, button5: (x11evt.state & Button5Mask) != 0, shift: (x11evt.state & ShiftMask) != 0, control: (x11evt.state & ControlMask) != 0 }` and removing relevant reassignments [INFO] [stdout] --> sys/src/window_x11.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | let mut mme = MouseMotionEventData::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:358:13 [INFO] [stdout] | [INFO] [stdout] 358 | / self.event_receiver [INFO] [stdout] 359 | | .as_ref() [INFO] [stdout] 360 | | .map(|evrec| (evrec)(&Event::InputBegin)); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 358 ~ if let Some(evrec) = self.event_receiver [INFO] [stdout] 359 + .as_ref() { (evrec)(&Event::InputBegin) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> sys/src/window_x11.rs:608:24 [INFO] [stdout] | [INFO] [stdout] 608 | Ok(transmute::<_, PFNGLXCREATECONTEXTATTRIBSARBPROC>(func_addr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut libc::c_void, unsafe extern "C" fn(*mut x11::xlib::_XDisplay, *mut x11::glx::__GLXFBConfigRec, *mut x11::glx::__GLXcontextRec, i32, *const i32) -> *mut x11::glx::__GLXcontextRec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:412:13 [INFO] [stdout] | [INFO] [stdout] 412 | / self.event_receiver [INFO] [stdout] 413 | | .as_ref() [INFO] [stdout] 414 | | .map(|evrec| (evrec)(&Event::InputEnd)); [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 412 ~ if let Some(evrec) = self.event_receiver [INFO] [stdout] 413 + .as_ref() { (evrec)(&Event::InputEnd) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> sys/src/window_x11.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | / self.event_receiver.as_ref().map(|evrec| { [INFO] [stdout] 419 | | let (w, h) = self.size.get(); [INFO] [stdout] 420 | | (evrec)(&Event::Loop(LoopEventData { [INFO] [stdout] 421 | | surface_width: w, [INFO] [stdout] ... | [INFO] [stdout] 425 | | })); [INFO] [stdout] 426 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 418 - self.event_receiver.as_ref().map(|evrec| { [INFO] [stdout] 419 - let (w, h) = self.size.get(); [INFO] [stdout] 420 - (evrec)(&Event::Loop(LoopEventData { [INFO] [stdout] 421 - surface_width: w, [INFO] [stdout] 422 - surface_height: h, [INFO] [stdout] 423 - window_width: self.win_size.get().0, [INFO] [stdout] 424 - window_height: self.win_size.get().1, [INFO] [stdout] 425 - })); [INFO] [stdout] 426 - }); [INFO] [stdout] 418 + if let Some(evrec) = self.event_receiver.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> sys/src/window_x11.rs:608:24 [INFO] [stdout] | [INFO] [stdout] 608 | Ok(transmute::<_, PFNGLXCREATECONTEXTATTRIBSARBPROC>(func_addr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut libc::c_void, unsafe extern "C" fn(*mut x11::xlib::_XDisplay, *mut x11::glx::__GLXFBConfigRec, *mut x11::glx::__GLXcontextRec, i32, *const i32) -> *mut x11::glx::__GLXcontextRec>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> math/src/vec4.rs:72:1 [INFO] [stdout] | [INFO] [stdout] 72 | / impl Into<(T, T, T, T)> for TVec4 [INFO] [stdout] 73 | | where [INFO] [stdout] 74 | | T: Num + Copy + Clone + std::fmt::Debug, [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 72 ~ impl From> for (T, T, T, T) [INFO] [stdout] 73 | where [INFO] [stdout] 74 | T: Num + Copy + Clone + std::fmt::Debug, [INFO] [stdout] 75 | { [INFO] [stdout] 76 ~ fn from(val: TVec4) -> Self { [INFO] [stdout] 77 ~ (val.x, val.y, val.z, val.w) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> math/src/vec4.rs:72:1 [INFO] [stdout] | [INFO] [stdout] 72 | / impl Into<(T, T, T, T)> for TVec4 [INFO] [stdout] 73 | | where [INFO] [stdout] 74 | | T: Num + Copy + Clone + std::fmt::Debug, [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 72 ~ impl From> for (T, T, T, T) [INFO] [stdout] 73 | where [INFO] [stdout] 74 | T: Num + Copy + Clone + std::fmt::Debug, [INFO] [stdout] 75 | { [INFO] [stdout] 76 ~ fn from(val: TVec4) -> Self { [INFO] [stdout] 77 ~ (val.x, val.y, val.z, val.w) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:120:1 [INFO] [stdout] | [INFO] [stdout] 120 | / impl std::default::Default for MouseWheelEventData { [INFO] [stdout] 121 | | fn default() -> Self { [INFO] [stdout] 122 | | Self { [INFO] [stdout] 123 | | pointer_x: 0, [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 103 + #[derive(Default)] [INFO] [stdout] 104 | pub struct MouseWheelEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:153:1 [INFO] [stdout] | [INFO] [stdout] 153 | / impl std::default::Default for MouseMotionEventData { [INFO] [stdout] 154 | | fn default() -> Self { [INFO] [stdout] 155 | | Self { [INFO] [stdout] 156 | | pointer_x: 0, [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 138 + #[derive(Default)] [INFO] [stdout] 139 | pub struct MouseMotionEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / impl std::default::Default for WindowConfigureEventData { [INFO] [stdout] 176 | | fn default() -> Self { [INFO] [stdout] 177 | | Self { [INFO] [stdout] 178 | | width: 0, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 170 + #[derive(Default)] [INFO] [stdout] 171 | pub struct WindowConfigureEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / impl std::default::Default for LoopEventData { [INFO] [stdout] 193 | | fn default() -> Self { [INFO] [stdout] 194 | | Self { [INFO] [stdout] 195 | | surface_width: 0, [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 185 + #[derive(Default)] [INFO] [stdout] 186 | pub struct LoopEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:120:1 [INFO] [stdout] | [INFO] [stdout] 120 | / impl std::default::Default for MouseWheelEventData { [INFO] [stdout] 121 | | fn default() -> Self { [INFO] [stdout] 122 | | Self { [INFO] [stdout] 123 | | pointer_x: 0, [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 103 + #[derive(Default)] [INFO] [stdout] 104 | pub struct MouseWheelEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:153:1 [INFO] [stdout] | [INFO] [stdout] 153 | / impl std::default::Default for MouseMotionEventData { [INFO] [stdout] 154 | | fn default() -> Self { [INFO] [stdout] 155 | | Self { [INFO] [stdout] 156 | | pointer_x: 0, [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 138 + #[derive(Default)] [INFO] [stdout] 139 | pub struct MouseMotionEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:175:1 [INFO] [stdout] | [INFO] [stdout] 175 | / impl std::default::Default for WindowConfigureEventData { [INFO] [stdout] 176 | | fn default() -> Self { [INFO] [stdout] 177 | | Self { [INFO] [stdout] 178 | | width: 0, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 170 + #[derive(Default)] [INFO] [stdout] 171 | pub struct WindowConfigureEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/keysyms.rs:110:1 [INFO] [stdout] | [INFO] [stdout] 110 | / impl std::default::Default for KeySymbol { [INFO] [stdout] 111 | | fn default() -> Self { [INFO] [stdout] 112 | | KeySymbol::Unknown [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 3 + #[derive(Default)] [INFO] [stdout] 4 | pub enum KeySymbol { [INFO] [stdout] 5 ~ #[default] [INFO] [stdout] 6 ~ Unknown = 0x0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/events.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / impl std::default::Default for LoopEventData { [INFO] [stdout] 193 | | fn default() -> Self { [INFO] [stdout] 194 | | Self { [INFO] [stdout] 195 | | surface_width: 0, [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 185 + #[derive(Default)] [INFO] [stdout] 186 | pub struct LoopEventData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> sys/src/memory_mapped_file.rs:178:29 [INFO] [stdout] | [INFO] [stdout] 178 | / ... UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 | | ... unsafe { [INFO] [stdout] 180 | | ... mmap( [INFO] [stdout] 181 | | ... null_mut(), [INFO] [stdout] ... | [INFO] [stdout] 197 | | ... }) [INFO] [stdout] 198 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 + unsafe { [INFO] [stdout] 180 + mmap( [INFO] [stdout] 181 + null_mut(), [INFO] [stdout] 182 + metadata.len() as usize, [INFO] [stdout] 183 + PROT_READ, [INFO] [stdout] 184 + MAP_PRIVATE, [INFO] [stdout] 185 + *ufd, [INFO] [stdout] 186 + 0, [INFO] [stdout] 187 + ) [INFO] [stdout] 188 + }, [INFO] [stdout] 189 + unix::MappedMemoryHandleDeleter(metadata.len() as usize), [INFO] [stdout] 190 + ) [INFO] [stdout] 191 + .ok_or(Error::last_os_error()).map(|ummap| MemoryMappedFile { [INFO] [stdout] 192 + memory: ummap, [INFO] [stdout] 193 + file_handle: ufd, [INFO] [stdout] 194 + bytes: metadata.len() as usize, [INFO] [stdout] 195 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MemoryMappedFile` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> sys/src/memory_mapped_file.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> math/src/color_conversion.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | v - v * s * ((k.min(4f32 - k)).min(1f32)).max(0f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(k.min(4f32 - k)).clamp(0f32, 1f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> sys/src/keysyms.rs:110:1 [INFO] [stdout] | [INFO] [stdout] 110 | / impl std::default::Default for KeySymbol { [INFO] [stdout] 111 | | fn default() -> Self { [INFO] [stdout] 112 | | KeySymbol::Unknown [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 3 + #[derive(Default)] [INFO] [stdout] 4 | pub enum KeySymbol { [INFO] [stdout] 5 ~ #[default] [INFO] [stdout] 6 ~ Unknown = 0x0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:6:51 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_ActionType` [INFO] [stdout] 7 | #[repr(u8)] [INFO] [stdout] 8 | pub enum ActionType { [INFO] [stdout] | ---------- `ActionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_ActionType` [INFO] [stdout] 7 | #[repr(u8)] [INFO] [stdout] 8 | pub enum ActionType { [INFO] [stdout] | ---------- `ActionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> math/src/color_conversion.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | v - v * s * ((k.min(4f32 - k)).min(1f32)).max(0f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(k.min(4f32 - k)).clamp(0f32, 1f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_MouseButtonId` [INFO] [stdout] 14 | #[repr(u8)] [INFO] [stdout] 15 | pub enum MouseButtonId { [INFO] [stdout] | ------------- `MouseButtonId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:13:66 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_MouseButtonId` [INFO] [stdout] 14 | #[repr(u8)] [INFO] [stdout] 15 | pub enum MouseButtonId { [INFO] [stdout] | ------------- `MouseButtonId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> sys/src/memory_mapped_file.rs:178:29 [INFO] [stdout] | [INFO] [stdout] 178 | / ... UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 | | ... unsafe { [INFO] [stdout] 180 | | ... mmap( [INFO] [stdout] 181 | | ... null_mut(), [INFO] [stdout] ... | [INFO] [stdout] 197 | | ... }) [INFO] [stdout] 198 | | ... }) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 + unsafe { [INFO] [stdout] 180 + mmap( [INFO] [stdout] 181 + null_mut(), [INFO] [stdout] 182 + metadata.len() as usize, [INFO] [stdout] 183 + PROT_READ, [INFO] [stdout] 184 + MAP_PRIVATE, [INFO] [stdout] 185 + *ufd, [INFO] [stdout] 186 + 0, [INFO] [stdout] 187 + ) [INFO] [stdout] 188 + }, [INFO] [stdout] 189 + unix::MappedMemoryHandleDeleter(metadata.len() as usize), [INFO] [stdout] 190 + ) [INFO] [stdout] 191 + .ok_or(Error::last_os_error()).map(|ummap| MemoryMappedFile { [INFO] [stdout] 192 + memory: ummap, [INFO] [stdout] 193 + file_handle: ufd, [INFO] [stdout] 194 + bytes: metadata.len() as usize, [INFO] [stdout] 195 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MemoryMappedFile` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> sys/src/memory_mapped_file.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | let r_inc = (end.r as f32 / 255f32 - r0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.r as f32 / 255f32 - r0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | let g_inc = (end.g as f32 / 255f32 - g0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.g as f32 / 255f32 - g0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | let b_inc = (end.b as f32 / 255f32 - b0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.b as f32 / 255f32 - b0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> sys/src/memory_mapped_file.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 285 | assert!(!mmfile.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `mmfile.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | let r_inc = (end.r as f32 / 255f32 - r0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.r as f32 / 255f32 - r0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | let g_inc = (end.g as f32 / 255f32 - g0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.g as f32 / 255f32 - g0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | let b_inc = (end.b as f32 / 255f32 - b0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.b as f32 / 255f32 - b0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:6:51 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_ActionType` [INFO] [stdout] 7 | #[repr(u8)] [INFO] [stdout] 8 | pub enum ActionType { [INFO] [stdout] | ---------- `ActionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / ColorMap::create_linear( [INFO] [stdout] 108 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 109 | | RGBAColor::from(StdColors::DK_GREEN), [INFO] [stdout] 110 | | 128, [INFO] [stdout] 111 | | ) [INFO] [stdout] 112 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 111 - ) [INFO] [stdout] 112 - .into_iter(), [INFO] [stdout] 111 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | let r_inc = (end.r as f32 / 255f32 - r0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.r as f32 / 255f32 - r0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_ActionType` [INFO] [stdout] 7 | #[repr(u8)] [INFO] [stdout] 8 | pub enum ActionType { [INFO] [stdout] | ---------- `ActionType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | let g_inc = (end.g as f32 / 255f32 - g0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.g as f32 / 255f32 - g0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | / ColorMap::create_linear( [INFO] [stdout] 131 | | RGBAColor::from(StdColors::DK_BLUE), [INFO] [stdout] 132 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 133 | | 128, [INFO] [stdout] 134 | | ) [INFO] [stdout] 135 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 134 - ) [INFO] [stdout] 135 - .into_iter(), [INFO] [stdout] 134 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | let b_inc = (end.b as f32 / 255f32 - b0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.b as f32 / 255f32 - b0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_MouseButtonId` [INFO] [stdout] 14 | #[repr(u8)] [INFO] [stdout] 15 | pub enum MouseButtonId { [INFO] [stdout] | ------------- `MouseButtonId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> sys/src/events.rs:13:66 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Copy, Debug, Clone, PartialEq, Eq, Hash, FromPrimitive, ToPrimitive)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_MouseButtonId` [INFO] [stdout] 14 | #[repr(u8)] [INFO] [stdout] 15 | pub enum MouseButtonId { [INFO] [stdout] | ------------- `MouseButtonId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | / ColorMap::create_linear( [INFO] [stdout] 145 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 146 | | RGBAColor::from(StdColors::DK_BLUE), [INFO] [stdout] 147 | | 255, [INFO] [stdout] 148 | | ) [INFO] [stdout] 149 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 148 - ) [INFO] [stdout] 149 - .into_iter(), [INFO] [stdout] 148 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | let r_inc = (end.r as f32 / 255f32 - r0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.r as f32 / 255f32 - r0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | let g_inc = (end.g as f32 / 255f32 - g0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.g as f32 / 255f32 - g0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> math/src/colormap.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | let b_inc = (end.b as f32 / 255f32 - b0) as f32 / (num as f32 - 1f32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((end.b as f32 / 255f32 - b0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / ColorMap::create_linear( [INFO] [stdout] 108 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 109 | | RGBAColor::from(StdColors::DK_GREEN), [INFO] [stdout] 110 | | 128, [INFO] [stdout] 111 | | ) [INFO] [stdout] 112 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 111 - ) [INFO] [stdout] 112 - .into_iter(), [INFO] [stdout] 111 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | / ColorMap::create_linear( [INFO] [stdout] 131 | | RGBAColor::from(StdColors::DK_BLUE), [INFO] [stdout] 132 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 133 | | 128, [INFO] [stdout] 134 | | ) [INFO] [stdout] 135 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 134 - ) [INFO] [stdout] 135 - .into_iter(), [INFO] [stdout] 134 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> math/src/colormap.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | / ColorMap::create_linear( [INFO] [stdout] 145 | | RGBAColor::from(StdColors::CYAN), [INFO] [stdout] 146 | | RGBAColor::from(StdColors::DK_BLUE), [INFO] [stdout] 147 | | 255, [INFO] [stdout] 148 | | ) [INFO] [stdout] 149 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 148 - ) [INFO] [stdout] 149 - .into_iter(), [INFO] [stdout] 148 + ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i8::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i8::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u8::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u8::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i16::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u16::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i8::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i8::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u8::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u8::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = f32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i16::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = f32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = f64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u16::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = f64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = usize::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rendering v0.1.0 (/opt/rustwide/workdir/rendering) [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = isize::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = isize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = i64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = u64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = f32::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = f32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = f64::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = f64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = usize::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:16:44 [INFO] [stdout] | [INFO] [stdout] 16 | const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - const MIN : Self::Output = std::$t::MIN; [INFO] [stdout] 16 + const MIN : Self::Output = isize::MIN; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> math/src/minmax.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | impl_minmax!(i8, u8, i16, u16, i32, u32, i64, u64, f32, f64, usize, isize); [INFO] [stdout] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `impl_minmax` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - const MAX : Self::Output = std::$t::MAX; [INFO] [stdout] 17 + const MAX : Self::Output = isize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> rendering/src/renderer_gl.rs:160:31 [INFO] [stdout] | [INFO] [stdout] 160 | let linked_successfully = (|| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 161 | | let mut link_status = 0i32; [INFO] [stdout] 162 | | unsafe { [INFO] [stdout] 163 | | gl::GetProgramiv(*prg, gl::LINK_STATUS, &mut link_status); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | link_status == gl::TRUE as i32 [INFO] [stdout] 166 | | })(); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_call)]` on by default [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 160 ~ let linked_successfully = { [INFO] [stdout] 161 + let mut link_status = 0i32; [INFO] [stdout] 162 + unsafe { [INFO] [stdout] 163 + gl::GetProgramiv(*prg, gl::LINK_STATUS, &mut link_status); [INFO] [stdout] 164 + } [INFO] [stdout] 165 + link_status == gl::TRUE as i32 [INFO] [stdout] 166 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OpenGLStateSnapshot` [INFO] [stdout] --> rendering/src/renderer_gl.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | / pub fn new() -> Self { [INFO] [stdout] 206 | | unsafe { [INFO] [stdout] 207 | | let mut glstate = std::mem::MaybeUninit::::zeroed().assume_init(); [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 204 + impl Default for OpenGLStateSnapshot { [INFO] [stdout] 205 + fn default() -> Self { [INFO] [stdout] 206 + Self::new() [INFO] [stdout] 207 + } [INFO] [stdout] 208 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PipelineBuilder<'a>` [INFO] [stdout] --> rendering/src/renderer_gl.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | / pub fn new() -> Self { [INFO] [stdout] 267 | | PipelineBuilder { [INFO] [stdout] 268 | | vertexshader: None, [INFO] [stdout] 269 | | fragmentshader: None, [INFO] [stdout] 270 | | } [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 265 + impl<'a> Default for PipelineBuilder<'a> { [INFO] [stdout] 266 + fn default() -> Self { [INFO] [stdout] 267 + Self::new() [INFO] [stdout] 268 + } [INFO] [stdout] 269 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SamplerBuilder` [INFO] [stdout] --> rendering/src/renderer_gl.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / pub fn new() -> SamplerBuilder { [INFO] [stdout] 317 | | SamplerBuilder { [INFO] [stdout] 318 | | border_color: None, [INFO] [stdout] 319 | | mag_filter: None, [INFO] [stdout] ... | [INFO] [stdout] 324 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 315 + impl Default for SamplerBuilder { [INFO] [stdout] 316 + fn default() -> Self { [INFO] [stdout] 317 + Self::new() [INFO] [stdout] 318 + } [INFO] [stdout] 319 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: try not to call a closure in the expression where it is declared [INFO] [stdout] --> rendering/src/renderer_gl.rs:160:31 [INFO] [stdout] | [INFO] [stdout] 160 | let linked_successfully = (|| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 161 | | let mut link_status = 0i32; [INFO] [stdout] 162 | | unsafe { [INFO] [stdout] 163 | | gl::GetProgramiv(*prg, gl::LINK_STATUS, &mut link_status); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | link_status == gl::TRUE as i32 [INFO] [stdout] 166 | | })(); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_call)]` on by default [INFO] [stdout] help: try doing something like [INFO] [stdout] | [INFO] [stdout] 160 ~ let linked_successfully = { [INFO] [stdout] 161 + let mut link_status = 0i32; [INFO] [stdout] 162 + unsafe { [INFO] [stdout] 163 + gl::GetProgramiv(*prg, gl::LINK_STATUS, &mut link_status); [INFO] [stdout] 164 + } [INFO] [stdout] 165 + link_status == gl::TRUE as i32 [INFO] [stdout] 166 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OpenGLStateSnapshot` [INFO] [stdout] --> rendering/src/renderer_gl.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | / pub fn new() -> Self { [INFO] [stdout] 206 | | unsafe { [INFO] [stdout] 207 | | let mut glstate = std::mem::MaybeUninit::::zeroed().assume_init(); [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 204 + impl Default for OpenGLStateSnapshot { [INFO] [stdout] 205 + fn default() -> Self { [INFO] [stdout] 206 + Self::new() [INFO] [stdout] 207 + } [INFO] [stdout] 208 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PipelineBuilder<'a>` [INFO] [stdout] --> rendering/src/renderer_gl.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | / pub fn new() -> Self { [INFO] [stdout] 267 | | PipelineBuilder { [INFO] [stdout] 268 | | vertexshader: None, [INFO] [stdout] 269 | | fragmentshader: None, [INFO] [stdout] 270 | | } [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 265 + impl<'a> Default for PipelineBuilder<'a> { [INFO] [stdout] 266 + fn default() -> Self { [INFO] [stdout] 267 + Self::new() [INFO] [stdout] 268 + } [INFO] [stdout] 269 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SamplerBuilder` [INFO] [stdout] --> rendering/src/renderer_gl.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / pub fn new() -> SamplerBuilder { [INFO] [stdout] 317 | | SamplerBuilder { [INFO] [stdout] 318 | | border_color: None, [INFO] [stdout] 319 | | mag_filter: None, [INFO] [stdout] ... | [INFO] [stdout] 324 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 315 + impl Default for SamplerBuilder { [INFO] [stdout] 316 + fn default() -> Self { [INFO] [stdout] 317 + Self::new() [INFO] [stdout] 318 + } [INFO] [stdout] 319 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking particles v0.1.0 (/opt/rustwide/workdir/particles) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> particles/src/particles.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | world_size: world_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> particles/src/particles.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | s.len() * std::mem::size_of::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> particles/src/particles.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | self.velocity = self.velocity + dv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity += dv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> particles/src/particles.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.position = self.position + ds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += ds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> particles/src/particles.rs:266:21 [INFO] [stdout] | [INFO] [stdout] 266 | sprite_idx as i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `sprite_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> particles/src/particles.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | world_size: world_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> particles/src/particles.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | s.len() * std::mem::size_of::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> particles/src/particles.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | self.velocity = self.velocity + dv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity += dv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> particles/src/particles.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.position = self.position + ds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += ds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> particles/src/particles.rs:266:21 [INFO] [stdout] | [INFO] [stdout] 266 | sprite_idx as i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `sprite_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.70s [INFO] running `Command { std: "docker" "inspect" "adf60f81e564b5b89837f7fbcc75ec1f2dd4f0d98a3af026926c9897bdd6c692", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adf60f81e564b5b89837f7fbcc75ec1f2dd4f0d98a3af026926c9897bdd6c692", kill_on_drop: false }` [INFO] [stdout] adf60f81e564b5b89837f7fbcc75ec1f2dd4f0d98a3af026926c9897bdd6c692