[INFO] cloning repository https://github.com/adi-joshi/equation_parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adi-joshi/equation_parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadi-joshi%2Fequation_parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadi-joshi%2Fequation_parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b9899448fb8785dc3a8d2120405a0d2aa9cd031e [INFO] linting adi-joshi/equation_parser against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadi-joshi%2Fequation_parser" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adi-joshi/equation_parser [INFO] finished tweaking git repo https://github.com/adi-joshi/equation_parser [INFO] tweaked toml for git repo https://github.com/adi-joshi/equation_parser written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adi-joshi/equation_parser on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adi-joshi/equation_parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 395811c569545daeebe6b7fff96108b5b7da8e2c13dcd5173f14628f5992c068 [INFO] running `Command { std: "docker" "start" "-a" "395811c569545daeebe6b7fff96108b5b7da8e2c13dcd5173f14628f5992c068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "395811c569545daeebe6b7fff96108b5b7da8e2c13dcd5173f14628f5992c068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "395811c569545daeebe6b7fff96108b5b7da8e2c13dcd5173f14628f5992c068", kill_on_drop: false }` [INFO] [stdout] 395811c569545daeebe6b7fff96108b5b7da8e2c13dcd5173f14628f5992c068 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2749b0b12d6c175e4e4e2cbdbadcb09a6f92e4626759543d65b41b0e11914cd [INFO] running `Command { std: "docker" "start" "-a" "c2749b0b12d6c175e4e4e2cbdbadcb09a6f92e4626759543d65b41b0e11914cd", kill_on_drop: false }` [INFO] [stderr] Checking equation_parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:38 [INFO] [stdout] | [INFO] [stdout] 85 | if !(first_char.is_numeric()) && !(first_char == '-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(first_char != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | / loop { [INFO] [stdout] 107 | | if let Some(n) = eq_chars.peek() { [INFO] [stdout] 108 | | println!("{}", n); [INFO] [stdout] 109 | | if *n >= '0' && *n <= '9' { // cannot have - in the middle of a number [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(n) = eq_chars.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:38 [INFO] [stdout] | [INFO] [stdout] 85 | if !(first_char.is_numeric()) && !(first_char == '-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(first_char != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | / loop { [INFO] [stdout] 107 | | if let Some(n) = eq_chars.peek() { [INFO] [stdout] 108 | | println!("{}", n); [INFO] [stdout] 109 | | if *n >= '0' && *n <= '9' { // cannot have - in the middle of a number [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(n) = eq_chars.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "c2749b0b12d6c175e4e4e2cbdbadcb09a6f92e4626759543d65b41b0e11914cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2749b0b12d6c175e4e4e2cbdbadcb09a6f92e4626759543d65b41b0e11914cd", kill_on_drop: false }` [INFO] [stdout] c2749b0b12d6c175e4e4e2cbdbadcb09a6f92e4626759543d65b41b0e11914cd