[INFO] cloning repository https://github.com/adem-ilhan/pfcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adem-ilhan/pfcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadem-ilhan%2Fpfcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadem-ilhan%2Fpfcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 29f1e17adcd69965252193b2f128a157035c2b68 [INFO] linting adem-ilhan/pfcp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadem-ilhan%2Fpfcp" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adem-ilhan/pfcp [INFO] finished tweaking git repo https://github.com/adem-ilhan/pfcp [INFO] tweaked toml for git repo https://github.com/adem-ilhan/pfcp written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adem-ilhan/pfcp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adem-ilhan/pfcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a1b5c3f230ffbc20cddaf4bbc6744d8286eb8ce5beae967015ff1ea28afa82e [INFO] running `Command { std: "docker" "start" "-a" "9a1b5c3f230ffbc20cddaf4bbc6744d8286eb8ce5beae967015ff1ea28afa82e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a1b5c3f230ffbc20cddaf4bbc6744d8286eb8ce5beae967015ff1ea28afa82e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a1b5c3f230ffbc20cddaf4bbc6744d8286eb8ce5beae967015ff1ea28afa82e", kill_on_drop: false }` [INFO] [stdout] 9a1b5c3f230ffbc20cddaf4bbc6744d8286eb8ce5beae967015ff1ea28afa82e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5632c9e29fa03d00ff8a1fe305eb6fd985509dc9bc732ffb512ff11b243b6ee4 [INFO] running `Command { std: "docker" "start" "-a" "5632c9e29fa03d00ff8a1fe305eb6fd985509dc9bc732ffb512ff11b243b6ee4", kill_on_drop: false }` [INFO] [stderr] Checking pfcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/message/association_setup.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | message.header.lenght += (message.node_id.ie_lenght [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 27 | + 4); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 ~ message.header.lenght += message.node_id.ie_lenght [INFO] [stdout] 23 | + 4 [INFO] [stdout] ... [INFO] [stdout] 26 | + message.cp.ie_lenght [INFO] [stdout] 27 ~ + 4 ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `F_Seid` should have an upper camel case name [INFO] [stdout] --> src/message/elements.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct F_Seid { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FSeid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | pre: pre, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | interface: interface, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `F_Teid` should have an upper camel case name [INFO] [stdout] --> src/message/elements.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 222 | pub struct F_Teid { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FTeid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | flags: flags, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | flags: flags, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/headers.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | seid: seid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `seid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/message/association_setup.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | message.header.lenght += (message.node_id.ie_lenght [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 27 | + 4); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 ~ message.header.lenght += message.node_id.ie_lenght [INFO] [stdout] 23 | + 4 [INFO] [stdout] ... [INFO] [stdout] 26 | + message.cp.ie_lenght [INFO] [stdout] 27 ~ + 4 ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `F_Seid` should have an upper camel case name [INFO] [stdout] --> src/message/elements.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct F_Seid { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FSeid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | pre: pre, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | interface: interface, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `F_Teid` should have an upper camel case name [INFO] [stdout] --> src/message/elements.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 222 | pub struct F_Teid { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `FTeid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | flags: flags, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/elements.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 394 | flags: flags, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message/headers.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | seid: seid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `seid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/association_setup.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `timestamp` [INFO] [stdout] --> src/message/elements.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(timestamp: u64) -> RecoveryTimestampIE { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_timestamp` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let mut cp: CPFunctionFeatures = CPFunctionFeatures { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | let mut fseid: F_Seid = F_Seid { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | let mut pdr: PdrId = PdrId { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | let mut ie: Precedence = Precedence { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | let mut source: SourceInterface = SourceInterface { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let mut outerheader: OuterHeaderRemoval = OuterHeaderRemoval { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | let mut farid: FarId = FarId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | let mut urrid: UrrId = UrrId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 366 | let mut qerid: QerId = QerId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:373:21 [INFO] [stdout] | [INFO] [stdout] 373 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | let mut action: ApplyAction = ApplyAction { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 442 | let mut pdi: PDI = PDI { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:452:21 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 470 | let mut interface: DestinationInterfae = DestinationInterfae { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/heartbeat.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AssociationSetup` is never constructed [INFO] [stdout] --> src/message/association_setup.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct AssociationSetup { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/association_setup.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl AssociationSetup { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new() -> AssociationSetup { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RecoveryTimestampIE` is never constructed [INFO] [stdout] --> src/message/elements.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct RecoveryTimestampIE { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/association_setup.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `timestamp` [INFO] [stdout] --> src/message/elements.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(timestamp: u64) -> RecoveryTimestampIE { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_timestamp` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/elements.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl RecoveryTimestampIE { [INFO] [stdout] | ------------------------ associated items in this implementation [INFO] [stdout] 12 | pub fn new(timestamp: u64) -> RecoveryTimestampIE { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CPFunctionFeatures` is never constructed [INFO] [stdout] --> src/message/elements.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct CPFunctionFeatures { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/elements.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl CPFunctionFeatures { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 80 | pub fn new() -> CPFunctionFeatures { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ipv6` is never read [INFO] [stdout] --> src/message/elements.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct F_Seid { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 105 | pub ipv6: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spare` is never read [INFO] [stdout] --> src/message/headers.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub spare: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HeartbeatRequest` is never constructed [INFO] [stdout] --> src/message/heartbeat.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct HeartbeatRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/heartbeat.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl HeartbeatRequest { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 11 | // New function [INFO] [stdout] 12 | pub fn new() -> HeartbeatRequest { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let mut cp: CPFunctionFeatures = CPFunctionFeatures { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | let mut fseid: F_Seid = F_Seid { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | let mut pdr: PdrId = PdrId { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/association_setup.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | let mut ie: Precedence = Precedence { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/message/elements.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | timestamp: 14 as u32, [INFO] [stdout] | ^^^^^^^^^ help: try: `14_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | let mut source: SourceInterface = SourceInterface { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let mut outerheader: OuterHeaderRemoval = OuterHeaderRemoval { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/message/elements.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | _ => println!(""), [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | let mut farid: FarId = FarId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | let mut urrid: UrrId = UrrId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 366 | let mut qerid: QerId = QerId { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:373:21 [INFO] [stdout] | [INFO] [stdout] 373 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | let mut action: ApplyAction = ApplyAction { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 442 | let mut pdi: PDI = PDI { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:452:21 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/elements.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 470 | let mut interface: DestinationInterfae = DestinationInterfae { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.teid` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:264:29 [INFO] [stdout] | [INFO] [stdout] 263 | if self.teid.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.teid` [INFO] [stdout] 264 | res.append(&mut self.teid.unwrap().to_be_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message/heartbeat.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.ipv4` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:267:29 [INFO] [stdout] | [INFO] [stdout] 266 | if self.ipv4.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.ipv4` [INFO] [stdout] 267 | res.append(&mut self.ipv4.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.ipv6` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:270:29 [INFO] [stdout] | [INFO] [stdout] 269 | if self.ipv6.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.ipv6` [INFO] [stdout] 270 | res.append(&mut self.ipv6.unwrap().into_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.choose` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 272 | if self.choose.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.choose` [INFO] [stdout] 273 | res.push(self.choose.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AssociationSetup` is never constructed [INFO] [stdout] --> src/message/association_setup.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct AssociationSetup { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/association_setup.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl AssociationSetup { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new() -> AssociationSetup { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RecoveryTimestampIE` is never constructed [INFO] [stdout] --> src/message/elements.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct RecoveryTimestampIE { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/elements.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl RecoveryTimestampIE { [INFO] [stdout] | ------------------------ associated items in this implementation [INFO] [stdout] 12 | pub fn new(timestamp: u64) -> RecoveryTimestampIE { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CPFunctionFeatures` is never constructed [INFO] [stdout] --> src/message/elements.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct CPFunctionFeatures { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/elements.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl CPFunctionFeatures { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 80 | pub fn new() -> CPFunctionFeatures { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ipv6` is never read [INFO] [stdout] --> src/message/elements.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 99 | pub struct F_Seid { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 105 | pub ipv6: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spare` is never read [INFO] [stdout] --> src/message/headers.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub spare: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HeartbeatRequest` is never constructed [INFO] [stdout] --> src/message/heartbeat.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct HeartbeatRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:373:21 [INFO] [stdout] | [INFO] [stdout] 373 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `to_bytes` are never used [INFO] [stdout] --> src/message/heartbeat.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl HeartbeatRequest { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 11 | // New function [INFO] [stdout] 12 | pub fn new() -> HeartbeatRequest { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:422:21 [INFO] [stdout] | [INFO] [stdout] 422 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PDI` contains a capitalized acronym [INFO] [stdout] --> src/message/elements.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 432 | pub struct PDI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pdi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:452:21 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:478:21 [INFO] [stdout] | [INFO] [stdout] 478 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/association_setup.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:501:21 [INFO] [stdout] | [INFO] [stdout] 501 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/message/elements.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | timestamp: 14 as u32, [INFO] [stdout] | ^^^^^^^^^ help: try: `14_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/message/elements.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | _ => println!(""), [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:548:21 [INFO] [stdout] | [INFO] [stdout] 548 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:587:21 [INFO] [stdout] | [INFO] [stdout] 587 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/message/headers.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !self.seid.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.seid.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/headers.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/heartbeat.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:258:21 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.teid` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:264:29 [INFO] [stdout] | [INFO] [stdout] 263 | if self.teid.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.teid` [INFO] [stdout] 264 | res.append(&mut self.teid.unwrap().to_be_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/session_establishment.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.ipv4` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:267:29 [INFO] [stdout] | [INFO] [stdout] 266 | if self.ipv4.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.ipv4` [INFO] [stdout] 267 | res.append(&mut self.ipv4.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.ipv6` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:270:29 [INFO] [stdout] | [INFO] [stdout] 269 | if self.ipv6.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.ipv6` [INFO] [stdout] 270 | res.append(&mut self.ipv6.unwrap().into_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.choose` after checking its variant with `is_some` [INFO] [stdout] --> src/message/elements.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 272 | if self.choose.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = self.choose` [INFO] [stdout] 273 | res.push(self.choose.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/message/elements.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut X) => res.append(&mut X), [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `New` should have a snake case name [INFO] [stdout] --> src/message/headers.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn New(t: u8, seid: Option, pri: Option) -> Header { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `new` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:373:21 [INFO] [stdout] | [INFO] [stdout] 373 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:422:21 [INFO] [stdout] | [INFO] [stdout] 422 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PDI` contains a capitalized acronym [INFO] [stdout] --> src/message/elements.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 432 | pub struct PDI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pdi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:452:21 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:478:21 [INFO] [stdout] | [INFO] [stdout] 478 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:501:21 [INFO] [stdout] | [INFO] [stdout] 501 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:548:21 [INFO] [stdout] | [INFO] [stdout] 548 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/elements.rs:587:21 [INFO] [stdout] | [INFO] [stdout] 587 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/message/headers.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !self.seid.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.seid.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/headers.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/heartbeat.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/message/session_establishment.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/message/elements.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut X) => res.append(&mut X), [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `New` should have a snake case name [INFO] [stdout] --> src/message/headers.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn New(t: u8, seid: Option, pri: Option) -> Header { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `new` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s [INFO] running `Command { std: "docker" "inspect" "5632c9e29fa03d00ff8a1fe305eb6fd985509dc9bc732ffb512ff11b243b6ee4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5632c9e29fa03d00ff8a1fe305eb6fd985509dc9bc732ffb512ff11b243b6ee4", kill_on_drop: false }` [INFO] [stdout] 5632c9e29fa03d00ff8a1fe305eb6fd985509dc9bc732ffb512ff11b243b6ee4