[INFO] cloning repository https://github.com/adamulrich/rust-life-expectancy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamulrich/rust-life-expectancy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamulrich%2Frust-life-expectancy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamulrich%2Frust-life-expectancy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 741ab0583748bdcdb7dcf2ed3b0d28e38e4f9869 [INFO] linting adamulrich/rust-life-expectancy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamulrich%2Frust-life-expectancy" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adamulrich/rust-life-expectancy [INFO] finished tweaking git repo https://github.com/adamulrich/rust-life-expectancy [INFO] tweaked toml for git repo https://github.com/adamulrich/rust-life-expectancy written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adamulrich/rust-life-expectancy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adamulrich/rust-life-expectancy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dict v0.1.5 [INFO] [stderr] Downloaded list_comprehension_macro v0.1.1 [INFO] [stderr] Downloaded copy_to_output v2.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a1abe6a72d78adee8ef981d97833cd9b9374beefdd946c8afc5571d55e56f26 [INFO] running `Command { std: "docker" "start" "-a" "8a1abe6a72d78adee8ef981d97833cd9b9374beefdd946c8afc5571d55e56f26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a1abe6a72d78adee8ef981d97833cd9b9374beefdd946c8afc5571d55e56f26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a1abe6a72d78adee8ef981d97833cd9b9374beefdd946c8afc5571d55e56f26", kill_on_drop: false }` [INFO] [stdout] 8a1abe6a72d78adee8ef981d97833cd9b9374beefdd946c8afc5571d55e56f26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 073a0ba14dcfd60774de28b61eead97b7e643f313c221178d0a3862a2bf283c9 [INFO] running `Command { std: "docker" "start" "-a" "073a0ba14dcfd60774de28b61eead97b7e643f313c221178d0a3862a2bf283c9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking dict v0.1.5 [INFO] [stderr] Compiling list_comprehension_macro v0.1.1 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking copy_to_output v2.1.0 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking which v4.4.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Checking thiserror v1.0.40 [INFO] [stderr] Checking clearscreen v2.0.1 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking life-expectancy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | let mut order_text: String; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut query_order_input: i32; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `order_descending_requested` is never read [INFO] [stdout] --> src/main.rs:120:52 [INFO] [stdout] | [INFO] [stdout] 120 | let mut order_descending_requested: bool = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `bad_code_flag` is never read [INFO] [stdout] --> src/main.rs:432:13 [INFO] [stdout] | [INFO] [stdout] 432 | bad_code_flag = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct HashStruct { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 37 | code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HashStruct` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 164 | if (user_region_count) > (1 as usize) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/main.rs:167:39 [INFO] [stdout] | [INFO] [stdout] 167 | query_only_common_years = get_user_input(prompt_common_years).to_lowercase().chars().next().unwrap() == 'y'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `get_user_input(prompt_common_years).to_lowercase().starts_with('y')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 212 | if (user_region_count) > (1 as usize) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/main.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 248 | if get_user_input(prompt).to_lowercase().chars().next().unwrap() == 'n' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `get_user_input(prompt).to_lowercase().starts_with('n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | if !result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 275 | if !result.is_err() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 276 | // if it is ok, unwrap [INFO] [stdout] 277 | input_value = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:300:36 [INFO] [stdout] | [INFO] [stdout] 300 | fn read_from_file(path: String) -> Result<(HashMap, Vec), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:378:39 [INFO] [stdout] | [INFO] [stdout] 378 | if region_input_cleaned[0] == "all".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"all"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if region_output.len() > 0 && bad_code_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!region_output.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:427:39 [INFO] [stdout] | [INFO] [stdout] 427 | if region_output.len() > 0 && bad_code_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!bad_code_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if !region_dict.contains_key(&i.region) { [INFO] [stdout] 448 | | region_dict.insert(i.region, i.code); [INFO] [stdout] 449 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 447 ~ if let std::collections::hash_map::Entry::Vacant(e) = region_dict.entry(i.region) { [INFO] [stdout] 448 + e.insert(i.code); [INFO] [stdout] 449 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | let mut order_text: String; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut query_order_input: i32; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `order_descending_requested` is never read [INFO] [stdout] --> src/main.rs:120:52 [INFO] [stdout] | [INFO] [stdout] 120 | let mut order_descending_requested: bool = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 483 | data_set.sort_by(|a,b| a.year.cmp(&b.year)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 483 - data_set.sort_by(|a,b| a.year.cmp(&b.year)); [INFO] [stdout] 483 + data_set.sort_by_key(|a| a.year); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | data_set.sort_by(|a,b| b.year.cmp(&a.year)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 485 - data_set.sort_by(|a,b| b.year.cmp(&a.year)); [INFO] [stdout] 485 + data_set.sort_by_key(|b| std::cmp::Reverse(b.year)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | let remove_list = vec!["Oceania".to_string(), [INFO] [stdout] | _______________________________^ [INFO] [stdout] 390 | | "Americas".to_string(), [INFO] [stdout] 391 | | "Northern America".to_string(), [INFO] [stdout] 392 | | "Asia".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 395 | | "Latin America and the Caribbean".to_string(), [INFO] [stdout] 396 | | "Africa".to_string()]; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 389 ~ let remove_list = ["Oceania".to_string(), [INFO] [stdout] 390 + "Americas".to_string(), [INFO] [stdout] 391 + "Northern America".to_string(), [INFO] [stdout] 392 + "Asia".to_string(), [INFO] [stdout] 393 + "Europe".to_string(), [INFO] [stdout] 394 + "World".to_string(), [INFO] [stdout] 395 + "Latin America and the Caribbean".to_string(), [INFO] [stdout] 396 ~ "Africa".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `bad_code_flag` is never read [INFO] [stdout] --> src/main.rs:432:13 [INFO] [stdout] | [INFO] [stdout] 432 | bad_code_flag = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct HashStruct { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 37 | code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HashStruct` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 164 | if (user_region_count) > (1 as usize) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/main.rs:167:39 [INFO] [stdout] | [INFO] [stdout] 167 | query_only_common_years = get_user_input(prompt_common_years).to_lowercase().chars().next().unwrap() == 'y'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `get_user_input(prompt_common_years).to_lowercase().starts_with('y')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 212 | if (user_region_count) > (1 as usize) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `1_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/main.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 248 | if get_user_input(prompt).to_lowercase().chars().next().unwrap() == 'n' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `get_user_input(prompt).to_lowercase().starts_with('n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | if !result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 275 | if !result.is_err() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 276 | // if it is ok, unwrap [INFO] [stdout] 277 | input_value = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:300:36 [INFO] [stdout] | [INFO] [stdout] 300 | fn read_from_file(path: String) -> Result<(HashMap, Vec), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:378:39 [INFO] [stdout] | [INFO] [stdout] 378 | if region_input_cleaned[0] == "all".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"all"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if region_output.len() > 0 && bad_code_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!region_output.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:427:39 [INFO] [stdout] | [INFO] [stdout] 427 | if region_output.len() > 0 && bad_code_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!bad_code_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if !region_dict.contains_key(&i.region) { [INFO] [stdout] 448 | | region_dict.insert(i.region, i.code); [INFO] [stdout] 449 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 447 ~ if let std::collections::hash_map::Entry::Vacant(e) = region_dict.entry(i.region) { [INFO] [stdout] 448 + e.insert(i.code); [INFO] [stdout] 449 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 483 | data_set.sort_by(|a,b| a.year.cmp(&b.year)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 483 - data_set.sort_by(|a,b| a.year.cmp(&b.year)); [INFO] [stdout] 483 + data_set.sort_by_key(|a| a.year); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | data_set.sort_by(|a,b| b.year.cmp(&a.year)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 485 - data_set.sort_by(|a,b| b.year.cmp(&a.year)); [INFO] [stdout] 485 + data_set.sort_by_key(|b| std::cmp::Reverse(b.year)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | let remove_list = vec!["Oceania".to_string(), [INFO] [stdout] | _______________________________^ [INFO] [stdout] 390 | | "Americas".to_string(), [INFO] [stdout] 391 | | "Northern America".to_string(), [INFO] [stdout] 392 | | "Asia".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 395 | | "Latin America and the Caribbean".to_string(), [INFO] [stdout] 396 | | "Africa".to_string()]; [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 389 ~ let remove_list = ["Oceania".to_string(), [INFO] [stdout] 390 + "Americas".to_string(), [INFO] [stdout] 391 + "Northern America".to_string(), [INFO] [stdout] 392 + "Asia".to_string(), [INFO] [stdout] 393 + "Europe".to_string(), [INFO] [stdout] 394 + "World".to_string(), [INFO] [stdout] 395 + "Latin America and the Caribbean".to_string(), [INFO] [stdout] 396 ~ "Africa".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.15s [INFO] running `Command { std: "docker" "inspect" "073a0ba14dcfd60774de28b61eead97b7e643f313c221178d0a3862a2bf283c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "073a0ba14dcfd60774de28b61eead97b7e643f313c221178d0a3862a2bf283c9", kill_on_drop: false }` [INFO] [stdout] 073a0ba14dcfd60774de28b61eead97b7e643f313c221178d0a3862a2bf283c9