[INFO] cloning repository https://github.com/adamnieto/codeography [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamnieto/codeography" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamnieto%2Fcodeography", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamnieto%2Fcodeography'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 610d27d78232d38a9c98285ca9e5571ee0d22871 [INFO] linting adamnieto/codeography against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamnieto%2Fcodeography" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adamnieto/codeography [INFO] finished tweaking git repo https://github.com/adamnieto/codeography [INFO] tweaked toml for git repo https://github.com/adamnieto/codeography written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adamnieto/codeography on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adamnieto/codeography already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding autocfg v1.5.0 [INFO] [stderr] Updating image v0.19.0 -> v0.21.3 [INFO] [stderr] Updating num-integer v0.1.39 -> v0.1.46 [INFO] [stderr] Updating num-rational v0.1.42 -> v0.2.4 [INFO] [stderr] Updating num-traits v0.2.6 -> v0.2.19 [INFO] [stderr] Updating png v0.12.0 -> v0.14.1 [INFO] [stderr] Updating steganography v1.0.1 -> v1.0.2 [INFO] [stderr] Adding tiff v0.2.2 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy_static v1.3.0 [INFO] [stderr] Downloaded num_cpus v1.10.0 [INFO] [stderr] Downloaded byteorder v1.3.1 [INFO] [stderr] Downloaded num-derive v0.2.4 [INFO] [stderr] Downloaded redox_syscall v0.1.53 [INFO] [stderr] Downloaded ansi_term v0.7.5 [INFO] [stderr] Downloaded strum_macros v0.8.0 [INFO] [stderr] Downloaded cfg-if v0.1.7 [INFO] [stderr] Downloaded ansi-escapes v0.1.0 [INFO] [stderr] Downloaded spinner v0.4.0 [INFO] [stderr] Downloaded term v0.2.14 [INFO] [stderr] Downloaded arrayvec v0.4.10 [INFO] [stderr] Downloaded either v1.5.2 [INFO] [stderr] Downloaded proc-macro2 v0.4.27 [INFO] [stderr] Downloaded quote v0.6.11 [INFO] [stderr] Downloaded strum v0.8.0 [INFO] [stderr] Downloaded ansi_term v0.9.0 [INFO] [stderr] Downloaded syn v0.15.30 [INFO] [stderr] Downloaded bitflags v0.9.1 [INFO] [stderr] Downloaded clap v2.27.1 [INFO] [stderr] Downloaded libc v0.2.51 [INFO] [stderr] Downloaded winapi v0.3.7 [INFO] [stderr] Downloaded spinners v1.0.0 [INFO] [stderr] Downloaded steganography v1.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9294dc46b985ffc87e04aceeaee481eeae838169bced10004bbd9bf9cb1b337 [INFO] running `Command { std: "docker" "start" "-a" "a9294dc46b985ffc87e04aceeaee481eeae838169bced10004bbd9bf9cb1b337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9294dc46b985ffc87e04aceeaee481eeae838169bced10004bbd9bf9cb1b337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9294dc46b985ffc87e04aceeaee481eeae838169bced10004bbd9bf9cb1b337", kill_on_drop: false }` [INFO] [stdout] a9294dc46b985ffc87e04aceeaee481eeae838169bced10004bbd9bf9cb1b337 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd00ee15fee02d5be24687634dca1091e275b5d6a56d396902cd9fdb2a751622 [INFO] running `Command { std: "docker" "start" "-a" "bd00ee15fee02d5be24687634dca1091e275b5d6a56d396902cd9fdb2a751622", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling syn v0.15.30 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking ansi_term v0.7.5 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking strum v0.8.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking ansi-escapes v0.1.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking term v0.2.14 [INFO] [stderr] Checking spinner v0.4.0 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Compiling strum_macros v0.8.0 [INFO] [stderr] Checking spinners v1.0.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.3 [INFO] [stderr] Checking steganography v1.0.2 [INFO] [stderr] Checking codeography v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Some(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Some(file_name); [INFO] [stdout] 41 + Some(file_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Some(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Some(file_name); [INFO] [stdout] 41 + Some(file_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/main.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if allowed_photo_extensions.iter().any(|&extension| extension==photo_path_extension_type){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `allowed_photo_extensions.contains(&photo_path_extension_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/main.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if allowed_photo_extensions.iter().any(|&extension| extension==photo_path_extension_type){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `allowed_photo_extensions.contains(&photo_path_extension_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `expect()` on `Some` value [INFO] [stdout] --> src/main.rs:65:37 [INFO] [stdout] | [INFO] [stdout] 65 | let enc = Encoder::new(payload, destination_image.expect("Something is wrong with the input image file.\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `expect()` [INFO] [stdout] --> src/main.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let destination_image = Some(file_as_dynamic_image(photo_path.to_str().unwrap().to_owned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | let res = Some(save_image_buffer(result,(output_name + "." + photo_path_extension_type).to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 69 ~ let res = { [INFO] [stdout] 70 + save_image_buffer(result,(output_name + "." + photo_path_extension_type).to_string()); [INFO] [stdout] 71 + Some(()) [INFO] [stdout] 72 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `expect()` on `Some` value [INFO] [stdout] --> src/main.rs:65:37 [INFO] [stdout] | [INFO] [stdout] 65 | let enc = Encoder::new(payload, destination_image.expect("Something is wrong with the input image file.\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `expect()` [INFO] [stdout] --> src/main.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let destination_image = Some(file_as_dynamic_image(photo_path.to_str().unwrap().to_owned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 124 | if !(input_image_path.extension().unwrap() == "png") && !(input_image_path.extension().unwrap() == "svg") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(input_image_path.extension().unwrap() != "png")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:65 [INFO] [stdout] | [INFO] [stdout] 124 | if !(input_image_path.extension().unwrap() == "png") && !(input_image_path.extension().unwrap() == "svg") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(input_image_path.extension().unwrap() != "svg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | let res = Some(save_image_buffer(result,(output_name + "." + photo_path_extension_type).to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 69 ~ let res = { [INFO] [stdout] 70 + save_image_buffer(result,(output_name + "." + photo_path_extension_type).to_string()); [INFO] [stdout] 71 + Some(()) [INFO] [stdout] 72 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 124 | if !(input_image_path.extension().unwrap() == "png") && !(input_image_path.extension().unwrap() == "svg") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(input_image_path.extension().unwrap() != "png")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:65 [INFO] [stdout] | [INFO] [stdout] 124 | if !(input_image_path.extension().unwrap() == "png") && !(input_image_path.extension().unwrap() == "svg") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(input_image_path.extension().unwrap() != "svg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | encode(&input_code_file_path, &input_image_path, output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `input_code_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | encode(&input_code_file_path, &input_image_path, output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `input_code_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | encode(&input_code_file_path, &input_image_path, output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `input_image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | encode(&input_code_file_path, &input_image_path, output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `input_image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/main.rs:136:75 [INFO] [stdout] | [INFO] [stdout] 136 | println!(" ✅ Successfully created: {}.png",output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/main.rs:136:75 [INFO] [stdout] | [INFO] [stdout] 136 | println!(" ✅ Successfully created: {}.png",output_image_file_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:150:32 [INFO] [stdout] | [INFO] [stdout] 150 | let file_name = decode(&input_image_path, output_code_file_name.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `input_image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/main.rs:164:18 [INFO] [stdout] | [INFO] [stdout] 164 | .arg(input_code_path.to_str().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `input_code_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:150:32 [INFO] [stdout] | [INFO] [stdout] 150 | let file_name = decode(&input_image_path, output_code_file_name.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `input_image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:47:36 [INFO] [stdout] | [INFO] [stdout] 47 | let allowed_photo_extensions = vec!["png","svg", "jpg", "jpeg"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["png","svg", "jpg", "jpeg"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/main.rs:164:18 [INFO] [stdout] | [INFO] [stdout] 164 | .arg(input_code_path.to_str().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `input_code_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:47:36 [INFO] [stdout] | [INFO] [stdout] 47 | let allowed_photo_extensions = vec!["png","svg", "jpg", "jpeg"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["png","svg", "jpg", "jpeg"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.00s [INFO] running `Command { std: "docker" "inspect" "bd00ee15fee02d5be24687634dca1091e275b5d6a56d396902cd9fdb2a751622", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd00ee15fee02d5be24687634dca1091e275b5d6a56d396902cd9fdb2a751622", kill_on_drop: false }` [INFO] [stdout] bd00ee15fee02d5be24687634dca1091e275b5d6a56d396902cd9fdb2a751622