[INFO] cloning repository https://github.com/adamhott/sharkviz
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamhott/sharkviz" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamhott%2Fsharkviz", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamhott%2Fsharkviz'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 80c8a320e9afda27586296d5ac6df2430cdc69b1
[INFO] linting adamhott/sharkviz against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamhott%2Fsharkviz" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/adamhott/sharkviz
[INFO] finished tweaking git repo https://github.com/adamhott/sharkviz
[INFO] tweaked toml for git repo https://github.com/adamhott/sharkviz written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/adamhott/sharkviz on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/adamhott/sharkviz already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded circular v0.3.0
[INFO] [stderr]   Downloaded pcap-parser v0.14.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 2cc7e2b0407f0e09eb444b84dbe12f7c5e8338506ca5069a9dcbab02c2d8a8e6
[INFO] running `Command { std: "docker" "start" "-a" "2cc7e2b0407f0e09eb444b84dbe12f7c5e8338506ca5069a9dcbab02c2d8a8e6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2cc7e2b0407f0e09eb444b84dbe12f7c5e8338506ca5069a9dcbab02c2d8a8e6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2cc7e2b0407f0e09eb444b84dbe12f7c5e8338506ca5069a9dcbab02c2d8a8e6", kill_on_drop: false }`
[INFO] [stdout] 2cc7e2b0407f0e09eb444b84dbe12f7c5e8338506ca5069a9dcbab02c2d8a8e6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c4c93f35a0b2e1a8cadf68df65c11dedc8840d3f7d3fe6def85ea7af50d4ea3c
[INFO] running `Command { std: "docker" "start" "-a" "c4c93f35a0b2e1a8cadf68df65c11dedc8840d3f7d3fe6def85ea7af50d4ea3c", kill_on_drop: false }`
[INFO] [stderr]     Checking memchr v2.8.0
[INFO] [stderr]     Checking circular v0.3.0
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]     Checking serde_json v1.0.149
[INFO] [stderr]     Checking rusticata-macros v4.1.0
[INFO] [stderr]     Checking pcap-parser v0.14.1
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]    Compiling clap_derive v4.5.55
[INFO] [stderr]     Checking clap v4.5.60
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking sharkviz v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/main.rs:7:15
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::fs::{self, File};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/main.rs:7:15
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::fs::{self, File};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `src_addr` is assigned to, but never used
[INFO] [stdout]    --> src/main.rs:610:9
[INFO] [stdout]     |
[INFO] [stdout] 610 |     let mut src_addr = src_mac.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: consider using `_src_addr` instead
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `dst_addr` is assigned to, but never used
[INFO] [stdout]    --> src/main.rs:611:9
[INFO] [stdout]     |
[INFO] [stdout] 611 |     let mut dst_addr = dst_mac.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: consider using `_dst_addr` instead
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:626:13
[INFO] [stdout]     |
[INFO] [stdout] 626 |             src_addr = format!("{} ({})", sha, spa);
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout]     = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:655:13
[INFO] [stdout]     |
[INFO] [stdout] 655 |             src_addr = src_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:773:13
[INFO] [stdout]     |
[INFO] [stdout] 773 |             src_addr = src_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:627:13
[INFO] [stdout]     |
[INFO] [stdout] 627 |             dst_addr = format!("{} ({})", tha, tpa);
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:656:13
[INFO] [stdout]     |
[INFO] [stdout] 656 |             dst_addr = dst_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:774:13
[INFO] [stdout]     |
[INFO] [stdout] 774 |             dst_addr = dst_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `src_addr` is assigned to, but never used
[INFO] [stdout]    --> src/main.rs:610:9
[INFO] [stdout]     |
[INFO] [stdout] 610 |     let mut src_addr = src_mac.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: consider using `_src_addr` instead
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `dst_addr` is assigned to, but never used
[INFO] [stdout]    --> src/main.rs:611:9
[INFO] [stdout]     |
[INFO] [stdout] 611 |     let mut dst_addr = dst_mac.clone();
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: consider using `_dst_addr` instead
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:626:13
[INFO] [stdout]     |
[INFO] [stdout] 626 |             src_addr = format!("{} ({})", sha, spa);
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout]     = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:655:13
[INFO] [stdout]     |
[INFO] [stdout] 655 |             src_addr = src_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `src_addr` is never read
[INFO] [stdout]    --> src/main.rs:773:13
[INFO] [stdout]     |
[INFO] [stdout] 773 |             src_addr = src_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:627:13
[INFO] [stdout]     |
[INFO] [stdout] 627 |             dst_addr = format!("{} ({})", tha, tpa);
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:656:13
[INFO] [stdout]     |
[INFO] [stdout] 656 |             dst_addr = dst_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `dst_addr` is never read
[INFO] [stdout]    --> src/main.rs:774:13
[INFO] [stdout]     |
[INFO] [stdout] 774 |             dst_addr = dst_ip.clone();
[INFO] [stdout]     |             ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:527:20
[INFO] [stdout]     |
[INFO] [stdout] 527 |                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 527 -                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout] 527 +                 if !(version != 0x00000001 && version != 0xff000020) {
[INFO] [stdout]     |
[INFO] [stdout] 527 -                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout] 527 +                 if version == 0x00000001 || version == 0xff000020 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of both operands
[INFO] [stdout]    --> src/main.rs:473:40
[INFO] [stdout]     |
[INFO] [stdout] 473 |             if payload.len() >= 240 && &payload[236..240] == &[99, 130, 83, 99] {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]     = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] help: use the values directly
[INFO] [stdout]     |
[INFO] [stdout] 473 -             if payload.len() >= 240 && &payload[236..240] == &[99, 130, 83, 99] {
[INFO] [stdout] 473 +             if payload.len() >= 240 && payload[236..240] == [99, 130, 83, 99] {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:555:9
[INFO] [stdout]     |
[INFO] [stdout] 555 | /         if starts_with(b"M-SEARCH ") || starts_with(b"NOTIFY * HTTP") || starts_with(b"HTTP/1.1 200") {
[INFO] [stdout] 556 | |             if dst_port == Some(1900) || src_port == Some(1900) {
[INFO] [stdout] 557 | |                 detected = Some("SSDP/UPnP".to_string());
[INFO] [stdout] 558 | |                 details.push("UPnP Service Discovery".to_string());
[INFO] [stdout] 559 | |             }
[INFO] [stdout] 560 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 555 ~         if (starts_with(b"M-SEARCH ") || starts_with(b"NOTIFY * HTTP") || starts_with(b"HTTP/1.1 200")) {
[INFO] [stdout] 556 ~             && (dst_port == Some(1900) || src_port == Some(1900)) {
[INFO] [stdout] 557 |                 detected = Some("SSDP/UPnP".to_string());
[INFO] [stdout] 558 |                 details.push("UPnP Service Discovery".to_string());
[INFO] [stdout] 559 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:527:20
[INFO] [stdout]     |
[INFO] [stdout] 527 |                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 527 -                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout] 527 +                 if !(version != 0x00000001 && version != 0xff000020) {
[INFO] [stdout]     |
[INFO] [stdout] 527 -                 if version == 0x00000001 || version == 0xff000020 || version == 0x1 {
[INFO] [stdout] 527 +                 if version == 0x00000001 || version == 0xff000020 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of both operands
[INFO] [stdout]    --> src/main.rs:473:40
[INFO] [stdout]     |
[INFO] [stdout] 473 |             if payload.len() >= 240 && &payload[236..240] == &[99, 130, 83, 99] {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]     = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] help: use the values directly
[INFO] [stdout]     |
[INFO] [stdout] 473 -             if payload.len() >= 240 && &payload[236..240] == &[99, 130, 83, 99] {
[INFO] [stdout] 473 +             if payload.len() >= 240 && payload[236..240] == [99, 130, 83, 99] {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:555:9
[INFO] [stdout]     |
[INFO] [stdout] 555 | /         if starts_with(b"M-SEARCH ") || starts_with(b"NOTIFY * HTTP") || starts_with(b"HTTP/1.1 200") {
[INFO] [stdout] 556 | |             if dst_port == Some(1900) || src_port == Some(1900) {
[INFO] [stdout] 557 | |                 detected = Some("SSDP/UPnP".to_string());
[INFO] [stdout] 558 | |                 details.push("UPnP Service Discovery".to_string());
[INFO] [stdout] 559 | |             }
[INFO] [stdout] 560 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 555 ~         if (starts_with(b"M-SEARCH ") || starts_with(b"NOTIFY * HTTP") || starts_with(b"HTTP/1.1 200")) {
[INFO] [stdout] 556 ~             && (dst_port == Some(1900) || src_port == Some(1900)) {
[INFO] [stdout] 557 |                 detected = Some("SSDP/UPnP".to_string());
[INFO] [stdout] 558 |                 details.push("UPnP Service Discovery".to_string());
[INFO] [stdout] 559 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.86s
[INFO] running `Command { std: "docker" "inspect" "c4c93f35a0b2e1a8cadf68df65c11dedc8840d3f7d3fe6def85ea7af50d4ea3c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c4c93f35a0b2e1a8cadf68df65c11dedc8840d3f7d3fe6def85ea7af50d4ea3c", kill_on_drop: false }`
[INFO] [stdout] c4c93f35a0b2e1a8cadf68df65c11dedc8840d3f7d3fe6def85ea7af50d4ea3c