[INFO] cloning repository https://github.com/acunniffe/git-ai [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/acunniffe/git-ai" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facunniffe%2Fgit-ai", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facunniffe%2Fgit-ai'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ec19abc82d9b172ae40f5e1c849f00be69f2e96 [INFO] linting acunniffe/git-ai against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facunniffe%2Fgit-ai" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/acunniffe/git-ai [INFO] finished tweaking git repo https://github.com/acunniffe/git-ai [INFO] tweaked toml for git repo https://github.com/acunniffe/git-ai written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/acunniffe/git-ai on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/acunniffe/git-ai already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial_test v3.4.0 [INFO] [stderr] Downloaded serial_test_derive v3.4.0 [INFO] [stderr] Downloaded gix-lock v21.0.0 [INFO] [stderr] Downloaded gix-config-value v0.17.0 [INFO] [stderr] Downloaded async-net v1.8.0 [INFO] [stderr] Downloaded gix-hashtable v0.12.0 [INFO] [stderr] Downloaded gix-glob v0.24.0 [INFO] [stderr] Downloaded faster-hex v0.10.0 [INFO] [stderr] Downloaded smol v1.3.0 [INFO] [stderr] Downloaded assert_cmd v2.1.1 [INFO] [stderr] Downloaded gix-object v0.55.0 [INFO] [stderr] Downloaded jiff-tzdb v0.1.5 [INFO] [stderr] Downloaded jiff-static v0.2.18 [INFO] [stderr] Downloaded prodash v31.0.0 [INFO] [stderr] Downloaded dbus v0.9.10 [INFO] [stderr] Downloaded insta v1.46.3 [INFO] [stderr] Downloaded scc v2.4.0 [INFO] [stderr] Downloaded imara-diff v0.2.0 [INFO] [stderr] Downloaded rstest_macros v0.23.0 [INFO] [stderr] Downloaded rusqlite v0.31.0 [INFO] [stderr] Downloaded git2 v0.20.4 [INFO] [stderr] Downloaded zip v2.4.2 [INFO] [stderr] Downloaded gix-config v0.51.0 [INFO] [stderr] Downloaded keyring v3.6.3 [INFO] [stderr] Downloaded minreq v2.14.1 [INFO] [stderr] Downloaded ryu-js v1.0.2 [INFO] [stderr] Downloaded gix-features v0.46.0 [INFO] [stderr] Downloaded gix-ref v0.58.0 [INFO] [stderr] Downloaded similar v2.7.0 [INFO] [stderr] Downloaded jsonc-parser v0.29.0 [INFO] [stderr] Downloaded rstest v0.23.0 [INFO] [stderr] Downloaded gix-tempfile v21.0.0 [INFO] [stderr] Downloaded gix-validate v0.11.0 [INFO] [stderr] Downloaded dbus-secret-service v4.1.0 [INFO] [stderr] Downloaded serde_json_canonicalizer v0.3.2 [INFO] [stderr] Downloaded sdd v3.0.10 [INFO] [stderr] Downloaded toml v0.9.8 [INFO] [stderr] Downloaded ratatui v0.28.1 [INFO] [stderr] Downloaded gix-actor v0.38.0 [INFO] [stderr] Downloaded gix-error v0.0.0 [INFO] [stderr] Downloaded gix-date v0.13.0 [INFO] [stderr] Downloaded gix-hash v0.22.0 [INFO] [stderr] Downloaded gix-fs v0.19.0 [INFO] [stderr] Downloaded gix-utils v0.3.1 [INFO] [stderr] Downloaded gix-trace v0.1.17 [INFO] [stderr] Downloaded gix-path v0.11.0 [INFO] [stderr] Downloaded bzip2 v0.5.2 [INFO] [stderr] Downloaded gix-sec v0.13.0 [INFO] [stderr] Downloaded jiff v0.2.18 [INFO] [stderr] Downloaded jiff-tzdb-platform v0.1.3 [INFO] [stderr] Downloaded instability v0.3.10 [INFO] [stderr] Downloaded sha1-checked v0.10.0 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded libdbus-sys v0.2.7 [INFO] [stderr] Downloaded libgit2-sys v0.18.3+1.9.2 [INFO] [stderr] Downloaded libsqlite3-sys v0.28.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0f8acd2bd55034ae0654a0fc8978e9557f1f76aace5bc4665abc310b2af226b [INFO] running `Command { std: "docker" "start" "-a" "a0f8acd2bd55034ae0654a0fc8978e9557f1f76aace5bc4665abc310b2af226b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0f8acd2bd55034ae0654a0fc8978e9557f1f76aace5bc4665abc310b2af226b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0f8acd2bd55034ae0654a0fc8978e9557f1f76aace5bc4665abc310b2af226b", kill_on_drop: false }` [INFO] [stdout] a0f8acd2bd55034ae0654a0fc8978e9557f1f76aace5bc4665abc310b2af226b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6eb9c87450e47fa2639e52bfb90d8dfc6ea47d5630d9fb7992fa9ed8bda3c0dd [INFO] running `Command { std: "docker" "start" "-a" "6eb9c87450e47fa2639e52bfb90d8dfc6ea47d5630d9fb7992fa9ed8bda3c0dd", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking gix-trace v0.1.17 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Checking prodash v31.0.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking sha1-checked v0.10.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking gix-utils v0.3.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking faster-hex v0.10.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking jiff v0.2.18 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking crc v3.4.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking zmij v1.0.21 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling libgit2-sys v0.18.3+1.9.2 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking gix-validate v0.11.0 [INFO] [stderr] Checking gix-error v0.0.0 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling toml_edit v0.23.7 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling rstest_macros v0.23.0 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking gix-sec v0.13.0 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking ryu-js v1.0.2 [INFO] [stderr] Checking deflate64 v0.1.10 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking imara-diff v0.2.0 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking jsonc-parser v0.29.0 [INFO] [stderr] Compiling assert_cmd v2.1.1 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking similar v2.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking gix-date v0.13.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling serial_test_derive v3.4.0 [INFO] [stderr] Checking insta v1.46.3 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking gix-path v0.11.0 [INFO] [stderr] Checking gix-actor v0.38.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking gix-features v0.46.0 [INFO] [stderr] Checking gix-config-value v0.17.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking gix-hash v0.22.0 [INFO] [stderr] Checking gix-fs v0.19.0 [INFO] [stderr] Checking gix-hashtable v0.12.0 [INFO] [stderr] Checking gix-glob v0.24.0 [INFO] [stderr] Checking gix-object v0.55.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking gix-tempfile v21.0.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking gix-lock v21.0.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking gix-ref v0.58.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde_json_canonicalizer v0.3.2 [INFO] [stderr] Checking envy v0.4.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking serial_test v3.4.0 [INFO] [stderr] Checking gix-config v0.51.0 [INFO] [stderr] Checking minreq v2.14.1 [INFO] [stderr] Checking rstest v0.23.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking git2 v0.20.4 [INFO] [stderr] Checking git-ai v1.1.16 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `METRICS_API_VERSION` [INFO] [stdout] --> src/observability/mod.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::metrics::{METRICS_API_VERSION, MetricEvent}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `AGENT_USAGE_MIN_INTERVAL_SECS` is never used [INFO] [stdout] --> src/commands/checkpoint.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | const AGENT_USAGE_MIN_INTERVAL_SECS: u64 = 150; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Metrics` is never constructed [INFO] [stdout] --> src/observability/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 61 | enum LogEnvelope { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 66 | Metrics(MetricsEnvelope), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LogEnvelope` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/commands/blame.rs:1182:51 [INFO] [stdout] | [INFO] [stdout] 1182 | let mut authorship_logs: Vec = commit_authorship_cache [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1183 | | .into_iter() [INFO] [stdout] 1184 | | .filter_map(|(_, log)| log) [INFO] [stdout] | |___________________________________^ help: try: `commit_authorship_cache.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/checkpoint_agent/agent_presets.rs:2584:17 [INFO] [stdout] | [INFO] [stdout] 2584 | / if s.starts_with("file://") { [INFO] [stdout] 2585 | | out.push(s.to_string()); [INFO] [stdout] 2586 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2583 ~ serde_json::Value::String(s) [INFO] [stdout] 2584 ~ if s.starts_with("file://") => { [INFO] [stdout] 2585 | out.push(s.to_string()); [INFO] [stdout] 2586 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:182:29 [INFO] [stdout] | [INFO] [stdout] 182 | / ... if config.title_cursor > 0 { [INFO] [stdout] 183 | | ... config.title.remove(config.title_cursor - 1); [INFO] [stdout] 184 | | ... config.title_cursor -= 1; [INFO] [stdout] 185 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 181 ~ KeyCode::Backspace [INFO] [stdout] 182 ~ if config.title_cursor > 0 => { [INFO] [stdout] 183 | config.title.remove(config.title_cursor - 1); [INFO] [stdout] 184 | config.title_cursor -= 1; [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | / ... if config.title_cursor > 0 { [INFO] [stdout] 189 | | ... config.title_cursor -= 1; [INFO] [stdout] 190 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ KeyCode::Left [INFO] [stdout] 188 ~ if config.title_cursor > 0 => { [INFO] [stdout] 189 | config.title_cursor -= 1; [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:193:29 [INFO] [stdout] | [INFO] [stdout] 193 | / ... if config.title_cursor < config.title.len() { [INFO] [stdout] 194 | | ... config.title_cursor += 1; [INFO] [stdout] 195 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ KeyCode::Right [INFO] [stdout] 193 ~ if config.title_cursor < config.title.len() => { [INFO] [stdout] 194 | config.title_cursor += 1; [INFO] [stdout] 195 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:211:29 [INFO] [stdout] | [INFO] [stdout] 211 | / ... if config.focused_checkbox > 0 { [INFO] [stdout] 212 | | ... config.focused_checkbox -= 1; [INFO] [stdout] 213 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 209 ~ KeyCode::Up | KeyCode::Char('k') [INFO] [stdout] 210 | // Move focus up between checkboxes [INFO] [stdout] 211 ~ if config.focused_checkbox > 0 => { [INFO] [stdout] 212 | config.focused_checkbox -= 1; [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | / ... if config.focused_checkbox < 1 { [INFO] [stdout] 218 | | ... config.focused_checkbox += 1; [INFO] [stdout] 219 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ KeyCode::Down | KeyCode::Char('j') [INFO] [stdout] 216 | // Move focus down between checkboxes [INFO] [stdout] 217 ~ if config.focused_checkbox < 1 => { [INFO] [stdout] 218 | config.focused_checkbox += 1; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | / ... if config.can_share_commit { [INFO] [stdout] 227 | | ... config.share_all_in_commit = !config.share_all_in_commit; [INFO] [stdout] 228 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ 0 [INFO] [stdout] 225 | // Share all in commit - only toggle if can_share_commit [INFO] [stdout] 226 ~ if config.can_share_commit => { [INFO] [stdout] 227 | config.share_all_in_commit = !config.share_all_in_commit; [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `git_ai::git::repository::Repository` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use git_ai::git::repository::Repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `repos::test_file::ExpectedLineExt` [INFO] [stdout] --> tests/multi_repo_workspace.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use repos::test_file::ExpectedLineExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::ExitStatus` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | use std::process::ExitStatus; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `git_ai::git::repository::Repository` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use git_ai::git::repository::Repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base_commit` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | let base_commit = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_commit` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base_commit` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | let base_commit = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_commit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:362:9 [INFO] [stdout] | [INFO] [stdout] 362 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:492:9 [INFO] [stdout] | [INFO] [stdout] 492 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:545:9 [INFO] [stdout] | [INFO] [stdout] 545 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit2` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:554:9 [INFO] [stdout] | [INFO] [stdout] 554 | let commit2 = repo.commit("commit 2").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `working_log` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | let working_log = repository [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_working_log` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 573 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `feature_commit` [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:582:9 [INFO] [stdout] | [INFO] [stdout] 582 | let feature_commit = repo.commit("feature commit").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_feature_commit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:616:9 [INFO] [stdout] | [INFO] [stdout] 616 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:664:9 [INFO] [stdout] | [INFO] [stdout] 664 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/switch_hooks_comprehensive.rs:696:9 [INFO] [stdout] | [INFO] [stdout] 696 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let base = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_base` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `feature` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | let feature = repo.commit("feature commit").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_feature` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_count` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | let initial_count = events_before.len(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_initial_count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `events_after` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let events_after = repository.storage.read_rewrite_events().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_events_after` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | let base = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_base` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | let base = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_base` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `feature` [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:383:9 [INFO] [stdout] | [INFO] [stdout] 383 | let feature = repo.commit("feature commit 2").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_feature` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/merge_hooks_comprehensive.rs:518:9 [INFO] [stdout] | [INFO] [stdout] 518 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/squash_merge.rs:357:26 [INFO] [stdout] | [INFO] [stdout] 357 | for (_id, prompt) in &feature_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 357 - for (_id, prompt) in &feature_log.metadata.prompts { [INFO] [stdout] 357 + for prompt in feature_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/squash_merge.rs:380:26 [INFO] [stdout] | [INFO] [stdout] 380 | for (_id, prompt) in &squash_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 380 - for (_id, prompt) in &squash_log.metadata.prompts { [INFO] [stdout] 380 + for prompt in squash_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | assert!(true, "ci_handlers module compiled successfully"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:220:42 [INFO] [stdout] | [INFO] [stdout] 220 | assert!(valid_platforms.contains(&platform)); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `platform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:225:40 [INFO] [stdout] | [INFO] [stdout] 225 | assert!(valid_actions.contains(&action)); [INFO] [stdout] | ^^^^^^^ help: change this to: `action` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 105 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 106 | | "--merge-commit-sha".to_string(), [INFO] [stdout] 107 | | "abc123".to_string(), [INFO] [stdout] 108 | | "--base-ref".to_string(), [INFO] [stdout] 109 | | "main".to_string(), [INFO] [stdout] 110 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 105 ~ let args = ["--merge-commit-sha".to_string(), [INFO] [stdout] 106 + "abc123".to_string(), [INFO] [stdout] 107 + "--base-ref".to_string(), [INFO] [stdout] 108 ~ "main".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 121 | | "--head-ref".to_string(), [INFO] [stdout] 122 | | "feature-branch".to_string(), [INFO] [stdout] 123 | | "--head-sha".to_string(), [INFO] [stdout] 124 | | "def456".to_string(), [INFO] [stdout] 125 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 120 ~ let args = ["--head-ref".to_string(), [INFO] [stdout] 121 + "feature-branch".to_string(), [INFO] [stdout] 122 + "--head-sha".to_string(), [INFO] [stdout] 123 ~ "def456".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | let args1 = vec!["run".to_string(), "--no-cleanup".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["run".to_string(), "--no-cleanup".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | let args2 = vec!["run".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["run".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | let args = vec!["--merge-commit-sha".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["--merge-commit-sha".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 183 | let required_flags = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 184 | | "--merge-commit-sha", [INFO] [stdout] 185 | | "--base-ref", [INFO] [stdout] 186 | | "--head-ref", [INFO] [stdout] 187 | | "--head-sha", [INFO] [stdout] 188 | | "--base-sha", [INFO] [stdout] 189 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 183 ~ let required_flags = ["--merge-commit-sha", [INFO] [stdout] 184 + "--base-ref", [INFO] [stdout] 185 + "--head-ref", [INFO] [stdout] 186 + "--head-sha", [INFO] [stdout] 187 ~ "--base-sha"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 201 | let optional_flags = vec!["--skip-fetch-notes", "--skip-fetch-base", "--skip-fetch"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["--skip-fetch-notes", "--skip-fetch-base", "--skip-fetch"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:231:23 [INFO] [stdout] | [INFO] [stdout] 231 | let subcommands = vec!["run", "install"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["run", "install"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:240:23 [INFO] [stdout] | [INFO] [stdout] 240 | let subcommands = vec!["run", "install"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["run", "install"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ci_handlers_comprehensive.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 249 | let events = vec!["merge"]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `["merge"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:665:9 [INFO] [stdout] | [INFO] [stdout] 665 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:682:9 [INFO] [stdout] | [INFO] [stdout] 682 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:697:9 [INFO] [stdout] | [INFO] [stdout] 697 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:145:16 [INFO] [stdout] | [INFO] [stdout] 145 | let args = vec!["abc123".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["abc123".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 161 | | "commit1".to_string(), [INFO] [stdout] 162 | | "commit2".to_string(), [INFO] [stdout] 163 | | "commit3".to_string(), [INFO] [stdout] 164 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 160 ~ let args = ["commit1".to_string(), [INFO] [stdout] 161 + "commit2".to_string(), [INFO] [stdout] 162 ~ "commit3".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 181 | | "-x".to_string(), [INFO] [stdout] 182 | | "commit1".to_string(), [INFO] [stdout] 183 | | "--edit".to_string(), [INFO] [stdout] 184 | | "commit2".to_string(), [INFO] [stdout] 185 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 180 ~ let args = ["-x".to_string(), [INFO] [stdout] 181 + "commit1".to_string(), [INFO] [stdout] 182 + "--edit".to_string(), [INFO] [stdout] 183 ~ "commit2".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:200:16 [INFO] [stdout] | [INFO] [stdout] 200 | let args = vec!["-m".to_string(), "1".to_string(), "commit1".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-m".to_string(), "1".to_string(), "commit1".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:222:16 [INFO] [stdout] | [INFO] [stdout] 222 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 223 | | "continue".to_string(), [INFO] [stdout] 224 | | "abort".to_string(), [INFO] [stdout] 225 | | "quit".to_string(), [INFO] [stdout] 226 | | "skip".to_string(), [INFO] [stdout] 227 | | "commit1".to_string(), [INFO] [stdout] 228 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 222 ~ let args = ["continue".to_string(), [INFO] [stdout] 223 + "abort".to_string(), [INFO] [stdout] 224 + "quit".to_string(), [INFO] [stdout] 225 + "skip".to_string(), [INFO] [stdout] 226 ~ "commit1".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 230 | let keywords = vec!["continue", "abort", "quit", "skip"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["continue", "abort", "quit", "skip"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | let expected_args = vec!["rev-list", reverse_flag, range]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["rev-list", reverse_flag, range]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:538:23 [INFO] [stdout] | [INFO] [stdout] 538 | let mut commits = vec![ [INFO] [stdout] | _______________________^ [INFO] [stdout] 539 | | "commit3".to_string(), [INFO] [stdout] 540 | | "commit2".to_string(), [INFO] [stdout] 541 | | "commit1".to_string(), [INFO] [stdout] 542 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 538 ~ let mut commits = ["commit3".to_string(), [INFO] [stdout] 539 + "commit2".to_string(), [INFO] [stdout] 540 ~ "commit1".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:645:17 [INFO] [stdout] | [INFO] [stdout] 645 | let args1 = vec![ [INFO] [stdout] | _________________^ [INFO] [stdout] 646 | | "cherry-pick".to_string(), [INFO] [stdout] 647 | | "--dry-run".to_string(), [INFO] [stdout] 648 | | "commit".to_string(), [INFO] [stdout] 649 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 645 ~ let args1 = ["cherry-pick".to_string(), [INFO] [stdout] 646 + "--dry-run".to_string(), [INFO] [stdout] 647 ~ "commit".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:650:17 [INFO] [stdout] | [INFO] [stdout] 650 | let args2 = vec!["cherry-pick".to_string(), "commit".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["cherry-pick".to_string(), "commit".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:661:16 [INFO] [stdout] | [INFO] [stdout] 661 | let args = vec!["--dry-run".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["--dry-run".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:756:16 [INFO] [stdout] | [INFO] [stdout] 756 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 757 | | "-s".to_string(), [INFO] [stdout] 758 | | "recursive".to_string(), [INFO] [stdout] 759 | | "commit1".to_string(), [INFO] [stdout] 760 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 756 ~ let args = ["-s".to_string(), [INFO] [stdout] 757 + "recursive".to_string(), [INFO] [stdout] 758 ~ "commit1".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:782:16 [INFO] [stdout] | [INFO] [stdout] 782 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 783 | | "--mainline".to_string(), [INFO] [stdout] 784 | | "1".to_string(), [INFO] [stdout] 785 | | "commit1".to_string(), [INFO] [stdout] 786 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 782 ~ let args = ["--mainline".to_string(), [INFO] [stdout] 783 + "1".to_string(), [INFO] [stdout] 784 ~ "commit1".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:814:16 [INFO] [stdout] | [INFO] [stdout] 814 | let args = vec!["rev-parse".to_string(), commit_ref.to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["rev-parse".to_string(), commit_ref.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:839:18 [INFO] [stdout] | [INFO] [stdout] 839 | let events = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 840 | | RewriteLogEvent::cherry_pick_start(CherryPickStartEvent::new( [INFO] [stdout] 841 | | "abc".to_string(), [INFO] [stdout] 842 | | vec!["commit".to_string()], [INFO] [stdout] ... | [INFO] [stdout] 849 | | )), [INFO] [stdout] 850 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 839 ~ let events = [RewriteLogEvent::cherry_pick_start(CherryPickStartEvent::new( [INFO] [stdout] 840 + "abc".to_string(), [INFO] [stdout] 841 + vec!["commit".to_string()], [INFO] [stdout] 842 + )), [INFO] [stdout] 843 + RewriteLogEvent::cherry_pick_complete(CherryPickCompleteEvent::new( [INFO] [stdout] 844 + "abc".to_string(), [INFO] [stdout] 845 + "def".to_string(), [INFO] [stdout] 846 + vec!["commit".to_string()], [INFO] [stdout] 847 + vec!["new".to_string()], [INFO] [stdout] 848 ~ ))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/cherry_pick_hooks_comprehensive.rs:870:18 [INFO] [stdout] | [INFO] [stdout] 870 | let events = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 871 | | RewriteLogEvent::cherry_pick_start(CherryPickStartEvent::new( [INFO] [stdout] 872 | | "abc".to_string(), [INFO] [stdout] 873 | | vec!["commit".to_string()], [INFO] [stdout] 874 | | )), [INFO] [stdout] 875 | | RewriteLogEvent::cherry_pick_abort(CherryPickAbortEvent::new("abc".to_string())), [INFO] [stdout] 876 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 870 ~ let events = [RewriteLogEvent::cherry_pick_start(CherryPickStartEvent::new( [INFO] [stdout] 871 + "abc".to_string(), [INFO] [stdout] 872 + vec!["commit".to_string()], [INFO] [stdout] 873 + )), [INFO] [stdout] 874 ~ RewriteLogEvent::cherry_pick_abort(CherryPickAbortEvent::new("abc".to_string()))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> tests/agent_commits_blame.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// integrated into overlay_ai_authorship. [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | #[macro_use] [INFO] [stdout] 12 | mod repos; [INFO] [stdout] | --------- the comment documents this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Tests for agent commit detection in blame. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! These tests verify that commits made by known AI agents (identified by [INFO] [stdout] 4 ~ //! their author email) are correctly attributed as AI-authored in blame output, [INFO] [stdout] 5 ~ //! even when no explicit authorship note exists. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! TDD: These tests define the expected behavior BEFORE implementation. [INFO] [stdout] 8 ~ //! They should fail initially and pass once agent commit detection is [INFO] [stdout] 9 ~ //! integrated into overlay_ai_authorship. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `InstallStatus` which implements the `Copy` trait [INFO] [stdout] --> tests/install_hooks_comprehensive.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | let cloned = status.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> tests/blame_comprehensive.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// 9. File path normalization (absolute vs relative) [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | #[macro_use] [INFO] [stdout] 19 | mod repos; [INFO] [stdout] | --------- the comment documents this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Comprehensive tests for src/commands/blame.rs [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! This test module covers critical functionality in blame.rs (1,811 LOC) [INFO] [stdout] 4 ~ //! including integration tests for AI authorship overlay, error handling, [INFO] [stdout] 5 ~ //! edge cases, and output formatting. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! Test coverage areas: [INFO] [stdout] 8 ~ //! 1. Core blame functionality with AI authorship [INFO] [stdout] 9 ~ //! 2. Error handling (invalid refs, missing files, git errors) [INFO] [stdout] 10 ~ //! 3. Edge cases (empty files, binary files, renamed files) [INFO] [stdout] 11 ~ //! 4. Output formatting (default, porcelain, incremental, JSON) [INFO] [stdout] 12 ~ //! 5. Line range handling [INFO] [stdout] 13 ~ //! 6. Commit filtering (newest_commit, oldest_commit, oldest_date) [INFO] [stdout] 14 ~ //! 7. AI authorship splitting by human author [INFO] [stdout] 15 ~ //! 8. Foreign prompt lookups [INFO] [stdout] 16 ~ //! 9. File path normalization (absolute vs relative) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> tests/non_utf8_files.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | commit.authorship_log.attestations.len() >= 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!commit.authorship_log.attestations.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/rebase.rs:1496:26 [INFO] [stdout] | [INFO] [stdout] 1496 | for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 1496 - for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] 1496 + for prompt in original_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/rebase.rs:1524:26 [INFO] [stdout] | [INFO] [stdout] 1524 | for (_id, prompt) in &rebased_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 1524 - for (_id, prompt) in &rebased_log.metadata.prompts { [INFO] [stdout] 1524 + for prompt in rebased_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/agent_commits_blame.rs:532:13 [INFO] [stdout] | [INFO] [stdout] 532 | / if parts.len() == 2 { [INFO] [stdout] 533 | | if let (Ok(start), Ok(end)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 534 | | if start <= 2 && end >= 2 { [INFO] [stdout] 535 | | line2_prompt_hash = Some(val_str.to_string()); [INFO] [stdout] ... | [INFO] [stdout] 538 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 532 ~ if parts.len() == 2 [INFO] [stdout] 533 ~ && let (Ok(start), Ok(end)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 534 | if start <= 2 && end >= 2 { [INFO] [stdout] 535 | line2_prompt_hash = Some(val_str.to_string()); [INFO] [stdout] 536 | } [INFO] [stdout] 537 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/agent_commits_blame.rs:533:17 [INFO] [stdout] | [INFO] [stdout] 533 | / if let (Ok(start), Ok(end)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 534 | | if start <= 2 && end >= 2 { [INFO] [stdout] 535 | | line2_prompt_hash = Some(val_str.to_string()); [INFO] [stdout] 536 | | } [INFO] [stdout] 537 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 533 ~ if let (Ok(start), Ok(end)) = (parts[0].parse::(), parts[1].parse::()) [INFO] [stdout] 534 ~ && start <= 2 && end >= 2 { [INFO] [stdout] 535 | line2_prompt_hash = Some(val_str.to_string()); [INFO] [stdout] 536 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | options.newest_commit = Some(commit1.commit_sha.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { newest_commit: Some(commit1.commit_sha.clone()), no_output: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:681:5 [INFO] [stdout] | [INFO] [stdout] 681 | options.split_hunks_by_ai_author = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { split_hunks_by_ai_author: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:680:5 [INFO] [stdout] | [INFO] [stdout] 680 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:737:5 [INFO] [stdout] | [INFO] [stdout] 737 | options.split_hunks_by_ai_author = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { split_hunks_by_ai_author: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:736:5 [INFO] [stdout] | [INFO] [stdout] 736 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:759:5 [INFO] [stdout] | [INFO] [stdout] 759 | options.return_human_authors_as_human = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { return_human_authors_as_human: true, no_output: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:758:5 [INFO] [stdout] | [INFO] [stdout] 758 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:797:5 [INFO] [stdout] | [INFO] [stdout] 797 | options.oldest_commit = Some(commit1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { oldest_commit: Some(commit1), newest_commit: Some(commit2), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:796:5 [INFO] [stdout] | [INFO] [stdout] 796 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:825:5 [INFO] [stdout] | [INFO] [stdout] 825 | options.oldest_date = Some(now.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { oldest_date: Some(now.into()), no_output: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:824:5 [INFO] [stdout] | [INFO] [stdout] 824 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:927:5 [INFO] [stdout] | [INFO] [stdout] 927 | options.line_ranges = vec![(1, 2), (4, 5)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { line_ranges: vec![(1, 2), (4, 5)], no_output: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:926:5 [INFO] [stdout] | [INFO] [stdout] 926 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:958:5 [INFO] [stdout] | [INFO] [stdout] 958 | options.line_ranges = vec![(1, 2), (4, 5)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { line_ranges: vec![(1, 2), (4, 5)], no_output: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:957:5 [INFO] [stdout] | [INFO] [stdout] 957 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:982:5 [INFO] [stdout] | [INFO] [stdout] 982 | options.line_ranges = vec![(1, 2), (5, 6)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { line_ranges: vec![(1, 2), (5, 6)], ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:981:5 [INFO] [stdout] | [INFO] [stdout] 981 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/blame_comprehensive.rs:1019:5 [INFO] [stdout] | [INFO] [stdout] 1019 | options.ignore_whitespace = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `git_ai::commands::blame::GitAiBlameOptions { ignore_whitespace: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/blame_comprehensive.rs:1018:5 [INFO] [stdout] | [INFO] [stdout] 1018 | let mut options = GitAiBlameOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `git_ai::git::repository::Repository` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use git_ai::git::repository::Repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let commit = repo.commit("test commit").unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amended_commit` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | let amended_commit = repo [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_amended_commit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:646:9 [INFO] [stdout] | [INFO] [stdout] 646 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:662:9 [INFO] [stdout] | [INFO] [stdout] 662 | let commit = repo.commit("test commit").unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:690:9 [INFO] [stdout] | [INFO] [stdout] 690 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amended_commit` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:714:9 [INFO] [stdout] | [INFO] [stdout] 714 | let amended_commit = repo [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_amended_commit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error as SqlError` [INFO] [stdout] --> src/error.rs:189:36 [INFO] [stdout] | [INFO] [stdout] 189 | use rusqlite::{Connection, Error as SqlError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:602:16 [INFO] [stdout] | [INFO] [stdout] 602 | let args = vec!["--author=John Doe ".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["--author=John Doe ".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:613:16 [INFO] [stdout] | [INFO] [stdout] 613 | let args = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 614 | | "--author".to_string(), [INFO] [stdout] 615 | | "John Doe ".to_string(), [INFO] [stdout] 616 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 613 ~ let args = ["--author".to_string(), [INFO] [stdout] 614 ~ "John Doe ".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/commit_hooks_comprehensive.rs:631:16 [INFO] [stdout] | [INFO] [stdout] 631 | let args = vec!["-m".to_string(), "message".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-m".to_string(), "message".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `git_ai::git::repository::Repository` [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use git_ai::git::repository::Repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/observability_flush.rs:664:26 [INFO] [stdout] | [INFO] [stdout] 664 | fs::write(&log_path, &[0xFF, 0xFE, 0xFD, 0xFC]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[0xFF, 0xFE, 0xFD, 0xFC]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> tests/observability_flush.rs:682:10 [INFO] [stdout] | [INFO] [stdout] 682 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> tests/observability_flush.rs:719:34 [INFO] [stdout] | [INFO] [stdout] 719 | let result: Option = None [INFO] [stdout] | __________________________________^ [INFO] [stdout] 720 | | .or_else(|| None::) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 720 - .or_else(|| None::) [INFO] [stdout] 720 + .or(None::) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> tests/observability_flush.rs:747:19 [INFO] [stdout] | [INFO] [stdout] 747 | let api_key = runtime_key.or_else(|| build_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 747 - let api_key = runtime_key.or_else(|| build_key); [INFO] [stdout] 747 + let api_key = runtime_key.or(build_key); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or_else()` on `None` value [INFO] [stdout] --> tests/observability_flush.rs:751:16 [INFO] [stdout] | [INFO] [stdout] 751 | let host = None::.unwrap_or_else(|| "https://us.i.posthog.com".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] help: remove the `None` and `unwrap_or_else()` [INFO] [stdout] | [INFO] [stdout] 751 - let host = None::.unwrap_or_else(|| "https://us.i.posthog.com".to_string()); [INFO] [stdout] 751 + let host = "https://us.i.posthog.com".to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/observability_flush.rs:530:28 [INFO] [stdout] | [INFO] [stdout] 530 | let posthog_accepted = vec!["message"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: you can use an array directly: `["message"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::EventValues` [INFO] [stdout] --> src/metrics/types.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | use super::EventValues; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `METRICS_API_VERSION` [INFO] [stdout] --> src/observability/mod.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::metrics::{METRICS_API_VERSION, MetricEvent}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/jetbrains_download.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | / assert_eq!( [INFO] [stdout] 238 | | result.unwrap(), [INFO] [stdout] 239 | | false, [INFO] [stdout] 240 | | "Should return false for failed installation" [INFO] [stdout] 241 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 237 ~ assert!( [INFO] [stdout] 238 ~ !result.unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base_commit` [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let base_commit = repo.commit("base commit").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_commit` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 384 | let events = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 385 | | RewriteLogEvent::rebase_start(RebaseStartEvent::new_with_onto( [INFO] [stdout] 386 | | "abc123".to_string(), [INFO] [stdout] 387 | | false, [INFO] [stdout] ... | [INFO] [stdout] 396 | | )), [INFO] [stdout] 397 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 384 ~ let events = [RewriteLogEvent::rebase_start(RebaseStartEvent::new_with_onto( [INFO] [stdout] 385 + "abc123".to_string(), [INFO] [stdout] 386 + false, [INFO] [stdout] 387 + None, [INFO] [stdout] 388 + )), [INFO] [stdout] 389 + RewriteLogEvent::rebase_complete(RebaseCompleteEvent::new( [INFO] [stdout] 390 + "abc123".to_string(), [INFO] [stdout] 391 + "def456".to_string(), [INFO] [stdout] 392 + false, [INFO] [stdout] 393 + vec!["commit1".to_string()], [INFO] [stdout] 394 + vec!["commit2".to_string()], [INFO] [stdout] 395 ~ ))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/rebase_hooks_comprehensive.rs:416:18 [INFO] [stdout] | [INFO] [stdout] 416 | let events = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 417 | | RewriteLogEvent::rebase_start(RebaseStartEvent::new_with_onto( [INFO] [stdout] 418 | | "abc123".to_string(), [INFO] [stdout] 419 | | false, [INFO] [stdout] ... | [INFO] [stdout] 422 | | RewriteLogEvent::rebase_abort(RebaseAbortEvent::new("abc123".to_string())), [INFO] [stdout] 423 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 416 ~ let events = [RewriteLogEvent::rebase_start(RebaseStartEvent::new_with_onto( [INFO] [stdout] 417 + "abc123".to_string(), [INFO] [stdout] 418 + false, [INFO] [stdout] 419 + None, [INFO] [stdout] 420 + )), [INFO] [stdout] 421 ~ RewriteLogEvent::rebase_abort(RebaseAbortEvent::new("abc123".to_string()))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> tests/e2big_post_filter.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | format!("line1_0\nline2_0\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"line1_0\nline2_0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> tests/e2big_post_filter.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 426 | format!("line1_1\nline2_1\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"line1_1\nline2_1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cursor` is never read [INFO] [stdout] --> tests/share_tui_comprehensive.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | cursor -= 1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cursor` is never read [INFO] [stdout] --> tests/share_tui_comprehensive.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 123 | let mut cursor = 7; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/amend.rs:544:26 [INFO] [stdout] | [INFO] [stdout] 544 | for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 544 - for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] 544 + for prompt in original_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/amend.rs:568:26 [INFO] [stdout] | [INFO] [stdout] 568 | for (_id, prompt) in &amended_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 568 - for (_id, prompt) in &amended_log.metadata.prompts { [INFO] [stdout] 568 + for prompt in amended_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> tests/attribution_tracker_comprehensive.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// 10. Multi-file attribution scenarios [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | #[macro_use] [INFO] [stdout] 19 | mod repos; [INFO] [stdout] | --------- the comment documents this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Comprehensive tests for src/authorship/attribution_tracker.rs [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! This test module covers critical functionality in attribution_tracker.rs (2,573 LOC) [INFO] [stdout] 4 ~ //! which is the core diff-based attribution tracking module that underpins AI authorship tracking. [INFO] [stdout] 5 ~ //! [INFO] [stdout] 6 ~ //! Test coverage areas: [INFO] [stdout] 7 ~ //! 1. Basic line attribution (AI vs human edits) [INFO] [stdout] 8 ~ //! 2. Move detection across files and within files [INFO] [stdout] 9 ~ //! 3. Whitespace-only changes [INFO] [stdout] 10 ~ //! 4. Mixed AI/human edits on same lines [INFO] [stdout] 11 ~ //! 5. Large file performance [INFO] [stdout] 12 ~ //! 6. Unicode and special character handling [INFO] [stdout] 13 ~ //! 7. Diff algorithm edge cases [INFO] [stdout] 14 ~ //! 8. Character-level attribution tracking [INFO] [stdout] 15 ~ //! 9. Attribution preservation through renames [INFO] [stdout] 16 ~ //! 10. Multi-file attribution scenarios [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/cherry_pick.rs:619:26 [INFO] [stdout] | [INFO] [stdout] 619 | for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 619 - for (_id, prompt) in &original_log.metadata.prompts { [INFO] [stdout] 619 + for prompt in original_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> tests/cherry_pick.rs:640:26 [INFO] [stdout] | [INFO] [stdout] 640 | for (_id, prompt) in &new_log.metadata.prompts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 640 - for (_id, prompt) in &new_log.metadata.prompts { [INFO] [stdout] 640 + for prompt in new_log.metadata.prompts.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> tests/share_tui_comprehensive.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / if cursor > 0 { [INFO] [stdout] 61 | | cursor -= 1; [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____^ help: try: `cursor = cursor.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> tests/share_tui_comprehensive.rs:600:5 [INFO] [stdout] | [INFO] [stdout] 600 | assert!(true, "Control flow structure verified"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> tests/share_tui_comprehensive.rs:609:5 [INFO] [stdout] | [INFO] [stdout] 609 | / match picker_result { [INFO] [stdout] 610 | | Some(_) => panic!("Should be cancelled"), [INFO] [stdout] 611 | | None => {} // Expected - user cancelled [INFO] [stdout] 612 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(_) = picker_result { panic!("Should be cancelled") }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> tests/share_tui_comprehensive.rs:616:5 [INFO] [stdout] | [INFO] [stdout] 616 | / match config_result { [INFO] [stdout] 617 | | Some(_) => panic!("Should be cancelled"), [INFO] [stdout] 618 | | None => {} // Expected - goes back to picker [INFO] [stdout] 619 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(_) = config_result { panic!("Should be cancelled") }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/share_tui_comprehensive.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 347 | let constraints = vec![ [INFO] [stdout] | _______________________^ [INFO] [stdout] 348 | | Constraint::Length(3), // Header [INFO] [stdout] 349 | | Constraint::Length(5), // Title input [INFO] [stdout] 350 | | Constraint::Length(8), // Options [INFO] [stdout] 351 | | Constraint::Min(0), // Spacer [INFO] [stdout] 352 | | Constraint::Length(3), // Footer [INFO] [stdout] 353 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 347 ~ let constraints = [Constraint::Length(3), // Header [INFO] [stdout] 348 + Constraint::Length(5), // Title input [INFO] [stdout] 349 + Constraint::Length(8), // Options [INFO] [stdout] 350 + Constraint::Min(0), // Spacer [INFO] [stdout] 351 ~ Constraint::Length(3)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Ok` value [INFO] [stdout] --> tests/sync_authorship_types.rs:103:16 [INFO] [stdout] | [INFO] [stdout] 103 | assert_eq!(result.unwrap(), NotesExistence::Found); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Ok` and `unwrap()` [INFO] [stdout] --> tests/sync_authorship_types.rs:101:50 [INFO] [stdout] | [INFO] [stdout] 101 | let result: Result = Ok(NotesExistence::Found); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Ok` value [INFO] [stdout] --> tests/sync_authorship_types.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | assert_eq!(result.unwrap(), NotesExistence::NotFound); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Ok` and `unwrap()` [INFO] [stdout] --> tests/sync_authorship_types.rs:105:50 [INFO] [stdout] | [INFO] [stdout] 105 | let result: Result = Ok(NotesExistence::NotFound); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> tests/sync_authorship_types.rs:114:16 [INFO] [stdout] | [INFO] [stdout] 114 | assert_eq!(some_found.unwrap(), NotesExistence::Found); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] --> tests/sync_authorship_types.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | let some_found = Some(NotesExistence::Found); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap_or()` on `None` value [INFO] [stdout] --> tests/sync_authorship_types.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | let notes = maybe_notes.unwrap_or(NotesExistence::NotFound); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `None` and `unwrap_or()` [INFO] [stdout] --> tests/sync_authorship_types.rs:209:47 [INFO] [stdout] | [INFO] [stdout] 209 | let maybe_notes: Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | let results = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 123 | | NotesExistence::Found, [INFO] [stdout] 124 | | NotesExistence::NotFound, [INFO] [stdout] 125 | | NotesExistence::Found, [INFO] [stdout] 126 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 122 ~ let results = [NotesExistence::Found, [INFO] [stdout] 123 + NotesExistence::NotFound, [INFO] [stdout] 124 ~ NotesExistence::Found]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | let args1 = vec!["fetch", "origin"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["fetch", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | let args2 = vec!["fetch", "upstream", "main"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["fetch", "upstream", "main"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | let args3 = vec!["fetch", "--all"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["fetch", "--all"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | let args4 = vec!["fetch", "--tags", "origin"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["fetch", "--tags", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:360:17 [INFO] [stdout] | [INFO] [stdout] 360 | let args1 = vec!["push", "origin", "main"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["push", "origin", "main"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | let args2 = vec!["push", "upstream"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["push", "upstream"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/sync_authorship_types.rs:362:17 [INFO] [stdout] | [INFO] [stdout] 362 | let args3 = vec!["push", "--force", "origin"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["push", "--force", "origin"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `git_ai::git::repository::Repository` [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use git_ai::git::repository::Repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `repos::test_file::ExpectedLineExt` [INFO] [stdout] --> tests/continue_session.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use repos::test_file::ExpectedLineExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `repos::test_file::ExpectedLineExt` [INFO] [stdout] --> tests/search.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use repos::test_file::ExpectedLineExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> tests/search.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:666:9 [INFO] [stdout] | [INFO] [stdout] 666 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:712:9 [INFO] [stdout] | [INFO] [stdout] 712 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:763:9 [INFO] [stdout] | [INFO] [stdout] 763 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:814:9 [INFO] [stdout] | [INFO] [stdout] 814 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:846:9 [INFO] [stdout] | [INFO] [stdout] 846 | let mut repo = TestRepo::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit2` [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:856:9 [INFO] [stdout] | [INFO] [stdout] 856 | let commit2 = repo.commit("commit 2").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> tests/performance.rs:598:5 [INFO] [stdout] | [INFO] [stdout] 598 | file_sizes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 598 - file_sizes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 598 + file_sizes.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:559:21 [INFO] [stdout] | [INFO] [stdout] 559 | let pathspecs = vec!["file.txt".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["file.txt".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:575:21 [INFO] [stdout] | [INFO] [stdout] 575 | let pathspecs = vec!["dir/".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["dir/".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/checkout_hooks_comprehensive.rs:592:21 [INFO] [stdout] | [INFO] [stdout] 592 | let pathspecs = vec!["dir".to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["dir".to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/attribution_tracker_comprehensive.rs:1319:30 [INFO] [stdout] | [INFO] [stdout] 1319 | .update_attributions(&old_content, &new_content, &old_attrs, "current", 3000) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `old_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 742 | | if !parent.exists() { [INFO] [stdout] 743 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 | | } [INFO] [stdout] 745 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 741 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 742 ~ && !parent.exists() { [INFO] [stdout] 743 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 744 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:757:9 [INFO] [stdout] | [INFO] [stdout] 757 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 758 | | if !parent.exists() { [INFO] [stdout] 759 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 | | } [INFO] [stdout] 761 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 757 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 758 ~ && !parent.exists() { [INFO] [stdout] 759 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/repos/test_file.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | / if let Some(parent) = self.file_path.parent() { [INFO] [stdout] 784 | | if !parent.exists() { [INFO] [stdout] 785 | | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 | | } [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 783 ~ if let Some(parent) = self.file_path.parent() [INFO] [stdout] 784 ~ && !parent.exists() { [INFO] [stdout] 785 | fs::create_dir_all(parent).expect("failed to create parent directories"); [INFO] [stdout] 786 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/repos/test_repo.rs:289:21 [INFO] [stdout] | [INFO] [stdout] 289 | &default_branch, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `default_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/continue_session.rs:563:9 [INFO] [stdout] | [INFO] [stdout] 563 | / if let Some(messages) = prompt["messages"].as_array() { [INFO] [stdout] 564 | | if !messages.is_empty() { [INFO] [stdout] 565 | | let msg = &messages[0]; [INFO] [stdout] 566 | | assert!(msg.get("role").is_some(), "message should have role"); [INFO] [stdout] ... | [INFO] [stdout] 569 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 563 ~ if let Some(messages) = prompt["messages"].as_array() [INFO] [stdout] 564 ~ && !messages.is_empty() { [INFO] [stdout] 565 | let msg = &messages[0]; [INFO] [stdout] 566 | assert!(msg.get("role").is_some(), "message should have role"); [INFO] [stdout] 567 | assert!(msg.get("text").is_some(), "message should have text"); [INFO] [stdout] 568 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::EventValues` [INFO] [stdout] --> src/metrics/types.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | use super::EventValues; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repo` [INFO] [stdout] --> src/ci/ci_context.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | let repo = test_repo.gitai_repo(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_repo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repo` [INFO] [stdout] --> src/ci/ci_context.rs:472:13 [INFO] [stdout] | [INFO] [stdout] 472 | let repo = test_repo.gitai_repo(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_repo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit_a` [INFO] [stdout] --> src/git/refs.rs:728:13 [INFO] [stdout] | [INFO] [stdout] 728 | let commit_a = tmp_repo.get_head_commit_sha().expect("head A"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `commit_b` [INFO] [stdout] --> src/git/refs.rs:732:13 [INFO] [stdout] | [INFO] [stdout] 732 | let commit_b = tmp_repo.get_head_commit_sha().expect("head B"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commit_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `AGENT_USAGE_MIN_INTERVAL_SECS` is never used [INFO] [stdout] --> src/commands/checkpoint.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | const AGENT_USAGE_MIN_INTERVAL_SECS: u64 = 150; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/commands/blame.rs:1182:51 [INFO] [stdout] | [INFO] [stdout] 1182 | let mut authorship_logs: Vec = commit_authorship_cache [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 1183 | | .into_iter() [INFO] [stdout] 1184 | | .filter_map(|(_, log)| log) [INFO] [stdout] | |___________________________________^ help: try: `commit_authorship_cache.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/checkpoint_agent/agent_presets.rs:2584:17 [INFO] [stdout] | [INFO] [stdout] 2584 | / if s.starts_with("file://") { [INFO] [stdout] 2585 | | out.push(s.to_string()); [INFO] [stdout] 2586 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2583 ~ serde_json::Value::String(s) [INFO] [stdout] 2584 ~ if s.starts_with("file://") => { [INFO] [stdout] 2585 | out.push(s.to_string()); [INFO] [stdout] 2586 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:182:29 [INFO] [stdout] | [INFO] [stdout] 182 | / ... if config.title_cursor > 0 { [INFO] [stdout] 183 | | ... config.title.remove(config.title_cursor - 1); [INFO] [stdout] 184 | | ... config.title_cursor -= 1; [INFO] [stdout] 185 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 181 ~ KeyCode::Backspace [INFO] [stdout] 182 ~ if config.title_cursor > 0 => { [INFO] [stdout] 183 | config.title.remove(config.title_cursor - 1); [INFO] [stdout] 184 | config.title_cursor -= 1; [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | / ... if config.title_cursor > 0 { [INFO] [stdout] 189 | | ... config.title_cursor -= 1; [INFO] [stdout] 190 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ KeyCode::Left [INFO] [stdout] 188 ~ if config.title_cursor > 0 => { [INFO] [stdout] 189 | config.title_cursor -= 1; [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:193:29 [INFO] [stdout] | [INFO] [stdout] 193 | / ... if config.title_cursor < config.title.len() { [INFO] [stdout] 194 | | ... config.title_cursor += 1; [INFO] [stdout] 195 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 192 ~ KeyCode::Right [INFO] [stdout] 193 ~ if config.title_cursor < config.title.len() => { [INFO] [stdout] 194 | config.title_cursor += 1; [INFO] [stdout] 195 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:211:29 [INFO] [stdout] | [INFO] [stdout] 211 | / ... if config.focused_checkbox > 0 { [INFO] [stdout] 212 | | ... config.focused_checkbox -= 1; [INFO] [stdout] 213 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 209 ~ KeyCode::Up | KeyCode::Char('k') [INFO] [stdout] 210 | // Move focus up between checkboxes [INFO] [stdout] 211 ~ if config.focused_checkbox > 0 => { [INFO] [stdout] 212 | config.focused_checkbox -= 1; [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | / ... if config.focused_checkbox < 1 { [INFO] [stdout] 218 | | ... config.focused_checkbox += 1; [INFO] [stdout] 219 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ KeyCode::Down | KeyCode::Char('j') [INFO] [stdout] 216 | // Move focus down between checkboxes [INFO] [stdout] 217 ~ if config.focused_checkbox < 1 => { [INFO] [stdout] 218 | config.focused_checkbox += 1; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/commands/share_tui.rs:226:37 [INFO] [stdout] | [INFO] [stdout] 226 | / ... if config.can_share_commit { [INFO] [stdout] 227 | | ... config.share_all_in_commit = !config.share_all_in_commit; [INFO] [stdout] 228 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ 0 [INFO] [stdout] 225 | // Share all in commit - only toggle if can_share_commit [INFO] [stdout] 226 ~ if config.can_share_commit => { [INFO] [stdout] 227 | config.share_all_in_commit = !config.share_all_in_commit; [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/feature_flags.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | deserializable.rewrite_stash = Some(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `feature_flags::DeserializableFeatureFlags { rewrite_stash: Some(false), checkpoint_inter_commit_move: Some(true), auth_keyring: Some(true), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/feature_flags.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | let mut deserializable = DeserializableFeatureFlags::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/feature_flags.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | deserializable.rewrite_stash = Some(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `feature_flags::DeserializableFeatureFlags { rewrite_stash: Some(true), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/feature_flags.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | let mut deserializable = DeserializableFeatureFlags::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/feature_flags.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | deserializable.rewrite_stash = Some(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `feature_flags::DeserializableFeatureFlags { rewrite_stash: Some(false), checkpoint_inter_commit_move: Some(false), auth_keyring: Some(true), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/feature_flags.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut deserializable = DeserializableFeatureFlags::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/feature_flags.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | file_flags.rewrite_stash = Some(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `feature_flags::DeserializableFeatureFlags { rewrite_stash: Some(true), auth_keyring: Some(true), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/feature_flags.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let mut file_flags = DeserializableFeatureFlags::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/git/refs.rs:913:9 [INFO] [stdout] | [INFO] [stdout] 913 | / match results { [INFO] [stdout] 914 | | Ok(refs) => assert_eq!(refs.len(), 0), [INFO] [stdout] 915 | | Err(_) => {} // Also acceptable - git grep returns non-zero when no matches [INFO] [stdout] 916 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(refs) = results { assert_eq!(refs.len(), 0) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/git/refs.rs:931:9 [INFO] [stdout] | [INFO] [stdout] 931 | / match results { [INFO] [stdout] 932 | | Ok(refs) => assert_eq!(refs.len(), 0), [INFO] [stdout] 933 | | Err(_) => {} // Also acceptable - refs/notes/ai may not exist yet [INFO] [stdout] 934 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(refs) = results { assert_eq!(refs.len(), 0) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/git/refs.rs:1074:13 [INFO] [stdout] | [INFO] [stdout] 1074 | result.len() >= 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mdm/skills_installer.rs:424:17 [INFO] [stdout] | [INFO] [stdout] 424 | assert!(!link.symlink_metadata().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `link.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mdm/utils.rs:1084:35 [INFO] [stdout] | [INFO] [stdout] 1084 | fs::write(&settings_path, &initial).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `initial` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MetricEventId` which implements the `Copy` trait [INFO] [stdout] --> src/metrics/types.rs:268:19 [INFO] [stdout] | [INFO] [stdout] 268 | let id2 = id1.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `id1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commands/squash_authorship.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | let args = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 131 | | "main".to_string(), [INFO] [stdout] 132 | | "--dry-run".to_string(), [INFO] [stdout] 133 | | "abc123".to_string(), [INFO] [stdout] 134 | | "def456".to_string(), [INFO] [stdout] 135 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 130 ~ let args = ["main".to_string(), [INFO] [stdout] 131 + "--dry-run".to_string(), [INFO] [stdout] 132 + "abc123".to_string(), [INFO] [stdout] 133 ~ "def456".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 06s [INFO] running `Command { std: "docker" "inspect" "6eb9c87450e47fa2639e52bfb90d8dfc6ea47d5630d9fb7992fa9ed8bda3c0dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6eb9c87450e47fa2639e52bfb90d8dfc6ea47d5630d9fb7992fa9ed8bda3c0dd", kill_on_drop: false }` [INFO] [stdout] 6eb9c87450e47fa2639e52bfb90d8dfc6ea47d5630d9fb7992fa9ed8bda3c0dd