[INFO] cloning repository https://github.com/acikek/dzp-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/acikek/dzp-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facikek%2Fdzp-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facikek%2Fdzp-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 90323d6e4715a92373a904847065db07408f6137 [INFO] linting acikek/dzp-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Facikek%2Fdzp-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/acikek/dzp-rs [INFO] finished tweaking git repo https://github.com/acikek/dzp-rs [INFO] tweaked toml for git repo https://github.com/acikek/dzp-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/acikek/dzp-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/acikek/dzp-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded titlecase v1.1.0 [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded utf8parse v0.2.0 [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded openssl-probe v0.1.4 [INFO] [stderr] Downloaded lazer v0.3.1 [INFO] [stderr] Downloaded clipboard-win v4.2.2 [INFO] [stderr] Downloaded pkg-config v0.3.22 [INFO] [stderr] Downloaded str-buf v1.0.5 [INFO] [stderr] Downloaded fd-lock v3.0.0 [INFO] [stderr] Downloaded reduce v0.1.4 [INFO] [stderr] Downloaded serde_yaml v0.8.21 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded openssl-sys v0.9.71 [INFO] [stderr] Downloaded proc-macro2 v1.0.32 [INFO] [stderr] Downloaded error-code v2.3.0 [INFO] [stderr] Downloaded rustyline v9.0.0 [INFO] [stderr] Downloaded git2 v0.13.24 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded nix v0.22.2 [INFO] [stderr] Downloaded syn v1.0.81 [INFO] [stderr] Downloaded libssh2-sys v0.2.23 [INFO] [stderr] Downloaded libc v0.2.107 [INFO] [stderr] Downloaded license v1.1.9 [INFO] [stderr] Downloaded libz-sys v1.1.3 [INFO] [stderr] Downloaded libgit2-sys v0.12.25+1.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fd64ac9a30c4a991ac957064880d0277ebd7ff32ee3083607e2892822ebf28e [INFO] running `Command { std: "docker" "start" "-a" "6fd64ac9a30c4a991ac957064880d0277ebd7ff32ee3083607e2892822ebf28e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fd64ac9a30c4a991ac957064880d0277ebd7ff32ee3083607e2892822ebf28e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fd64ac9a30c4a991ac957064880d0277ebd7ff32ee3083607e2892822ebf28e", kill_on_drop: false }` [INFO] [stdout] 6fd64ac9a30c4a991ac957064880d0277ebd7ff32ee3083607e2892822ebf28e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee9631984b8a1b5e454c33033d9a45fa6571ccbdee5aa7be09ef20c013d105d6 [INFO] running `Command { std: "docker" "start" "-a" "ee9631984b8a1b5e454c33033d9a45fa6571ccbdee5aa7be09ef20c013d105d6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling lazer v0.3.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking fd-lock v3.0.0 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking nix v0.22.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking titlecase v1.1.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking reduce v0.1.4 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking license v1.1.9 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.71 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.12.25+1.3.0 [INFO] [stderr] Checking rustyline v9.0.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking git2 v0.13.24 [INFO] [stderr] Checking dzp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cache/scripts.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !scripts.iter().find(|(name, _)| name == script_name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `scripts.iter().find(|(name, _)| name == script_name).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/cache/scripts.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | let keys = file.1.keys().map(|s| s.clone()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `file.1.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/cache/scripts.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | / match from_str::>(&cache) { [INFO] [stdout] 111 | | Ok(data) => data, [INFO] [stdout] 112 | | Err(_) => BTreeMap::new() [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________^ help: replace it with: `from_str::>(&cache).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/config/styles.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/doc.rs:68:55 [INFO] [stdout] | [INFO] [stdout] 68 | .print_ln(&format!("{}{}", key, value.unwrap_or(String::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/doc.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | .print_ln(&format!("Uses: {}", self.uses.clone().unwrap_or(Vec::new()).join(", "))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/structs/project.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | Some(_) => return Ok(String::from(input)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/structs/project.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / match url { [INFO] [stdout] 217 | | Some(u) => println!("{}: {}", key, u), [INFO] [stdout] 218 | | None => () [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(u) = url { println!("{}: {}", key, u) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/project.rs:245:54 [INFO] [stdout] | [INFO] [stdout] 245 | ... .print_ln(&self.dependencies.clone().unwrap_or(Vec::new()).iter().map(|s| format!("- {}", s)).collect::>().join("... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/structs/script.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | let keys = contents.keys().map(|s| s.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `contents.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/subcmd/script.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / let _ = match app.clone().get_matches().subcommand() { [INFO] [stdout] 19 | | ("compile", Some(sub)) => subcmd::compile::compile(&sub), [INFO] [stdout] 20 | | ("new", Some(sub)) => subcmd::new::new(&sub), [INFO] [stdout] 21 | | ("project", Some(sub)) => subcmd::project::project(&sub), [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => { let _ = app.print_help(); } [INFO] [stdout] 25 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 18 - let _ = match app.clone().get_matches().subcommand() { [INFO] [stdout] 18 + match app.clone().get_matches().subcommand() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:19:60 [INFO] [stdout] | [INFO] [stdout] 19 | ("compile", Some(sub)) => subcmd::compile::compile(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:20:48 [INFO] [stdout] | [INFO] [stdout] 20 | ("new", Some(sub)) => subcmd::new::new(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:21:60 [INFO] [stdout] | [INFO] [stdout] 21 | ("project", Some(sub)) => subcmd::project::project(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | ("script", Some(sub)) => subcmd::script::script(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/structs/project.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | let sections = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 183 | | self.readme_header(), [INFO] [stdout] 184 | | Self::README_ABOUT.to_owned(), [INFO] [stdout] 185 | | self.readme_setup(), [INFO] [stdout] ... | [INFO] [stdout] 188 | | self.readme_license() [INFO] [stdout] 189 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 182 ~ let sections = [self.readme_header(), [INFO] [stdout] 183 + Self::README_ABOUT.to_owned(), [INFO] [stdout] 184 + self.readme_setup(), [INFO] [stdout] 185 + Self::README_EXAMPLE.to_owned(), [INFO] [stdout] 186 + self.readme_scripts(), [INFO] [stdout] 187 ~ self.readme_license()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cache/scripts.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !scripts.iter().find(|(name, _)| name == script_name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `scripts.iter().find(|(name, _)| name == script_name).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/cache/scripts.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | let keys = file.1.keys().map(|s| s.clone()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `file.1.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/cache/scripts.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | / match from_str::>(&cache) { [INFO] [stdout] 111 | | Ok(data) => data, [INFO] [stdout] 112 | | Err(_) => BTreeMap::new() [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________^ help: replace it with: `from_str::>(&cache).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/config/styles.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/doc.rs:68:55 [INFO] [stdout] | [INFO] [stdout] 68 | .print_ln(&format!("{}{}", key, value.unwrap_or(String::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/doc.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | .print_ln(&format!("Uses: {}", self.uses.clone().unwrap_or(Vec::new()).join(", "))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/structs/project.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | Some(_) => return Ok(String::from(input)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/structs/project.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / match url { [INFO] [stdout] 217 | | Some(u) => println!("{}: {}", key, u), [INFO] [stdout] 218 | | None => () [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(u) = url { println!("{}: {}", key, u) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/structs/project.rs:245:54 [INFO] [stdout] | [INFO] [stdout] 245 | ... .print_ln(&self.dependencies.clone().unwrap_or(Vec::new()).iter().map(|s| format!("- {}", s)).collect::>().join("... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/structs/script.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | let keys = contents.keys().map(|s| s.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `contents.keys().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/subcmd/script.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / let _ = match app.clone().get_matches().subcommand() { [INFO] [stdout] 19 | | ("compile", Some(sub)) => subcmd::compile::compile(&sub), [INFO] [stdout] 20 | | ("new", Some(sub)) => subcmd::new::new(&sub), [INFO] [stdout] 21 | | ("project", Some(sub)) => subcmd::project::project(&sub), [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => { let _ = app.print_help(); } [INFO] [stdout] 25 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 18 - let _ = match app.clone().get_matches().subcommand() { [INFO] [stdout] 18 + match app.clone().get_matches().subcommand() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:19:60 [INFO] [stdout] | [INFO] [stdout] 19 | ("compile", Some(sub)) => subcmd::compile::compile(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:20:48 [INFO] [stdout] | [INFO] [stdout] 20 | ("new", Some(sub)) => subcmd::new::new(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:21:60 [INFO] [stdout] | [INFO] [stdout] 21 | ("project", Some(sub)) => subcmd::project::project(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | ("script", Some(sub)) => subcmd::script::script(&sub), [INFO] [stdout] | ^^^^ help: change this to: `sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/structs/project.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | let sections = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 183 | | self.readme_header(), [INFO] [stdout] 184 | | Self::README_ABOUT.to_owned(), [INFO] [stdout] 185 | | self.readme_setup(), [INFO] [stdout] ... | [INFO] [stdout] 188 | | self.readme_license() [INFO] [stdout] 189 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 182 ~ let sections = [self.readme_header(), [INFO] [stdout] 183 + Self::README_ABOUT.to_owned(), [INFO] [stdout] 184 + self.readme_setup(), [INFO] [stdout] 185 + Self::README_EXAMPLE.to_owned(), [INFO] [stdout] 186 + self.readme_scripts(), [INFO] [stdout] 187 ~ self.readme_license()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.33s [INFO] running `Command { std: "docker" "inspect" "ee9631984b8a1b5e454c33033d9a45fa6571ccbdee5aa7be09ef20c013d105d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee9631984b8a1b5e454c33033d9a45fa6571ccbdee5aa7be09ef20c013d105d6", kill_on_drop: false }` [INFO] [stdout] ee9631984b8a1b5e454c33033d9a45fa6571ccbdee5aa7be09ef20c013d105d6