[INFO] cloning repository https://github.com/abtiwary/md-blog-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abtiwary/md-blog-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabtiwary%2Fmd-blog-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabtiwary%2Fmd-blog-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6bd195674765f93cf3bcc6a28a588ee6f7a0777d [INFO] linting abtiwary/md-blog-generator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabtiwary%2Fmd-blog-generator" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/abtiwary/md-blog-generator [INFO] finished tweaking git repo https://github.com/abtiwary/md-blog-generator [INFO] tweaked toml for git repo https://github.com/abtiwary/md-blog-generator written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/abtiwary/md-blog-generator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/abtiwary/md-blog-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded globwalk v0.8.1 [INFO] [stderr] Downloaded slug v0.1.5 [INFO] [stderr] Downloaded chrono-tz-build v0.2.1 [INFO] [stderr] Downloaded phf_codegen v0.11.2 [INFO] [stderr] Downloaded pest_generator v2.7.7 [INFO] [stderr] Downloaded pest_derive v2.7.7 [INFO] [stderr] Downloaded scraper v0.18.1 [INFO] [stderr] Downloaded ahash v0.8.10 [INFO] [stderr] Downloaded parse-zoneinfo v0.3.0 [INFO] [stderr] Downloaded ignore v0.4.22 [INFO] [stderr] Downloaded deunicode v1.4.3 [INFO] [stderr] Downloaded tera v1.19.1 [INFO] [stderr] Downloaded unic-segment v0.9.0 [INFO] [stderr] Downloaded pest_meta v2.7.7 [INFO] [stderr] Downloaded unic-ucd-segment v0.9.0 [INFO] [stderr] Downloaded chrono v0.4.34 [INFO] [stderr] Downloaded chrono-tz v0.8.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 993dcfc2c5f853f7bc2f84d0668fcb07568944d7d6de2a88328d4dcb1b266b1c [INFO] running `Command { std: "docker" "start" "-a" "993dcfc2c5f853f7bc2f84d0668fcb07568944d7d6de2a88328d4dcb1b266b1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "993dcfc2c5f853f7bc2f84d0668fcb07568944d7d6de2a88328d4dcb1b266b1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "993dcfc2c5f853f7bc2f84d0668fcb07568944d7d6de2a88328d4dcb1b266b1c", kill_on_drop: false }` [INFO] [stdout] 993dcfc2c5f853f7bc2f84d0668fcb07568944d7d6de2a88328d4dcb1b266b1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aba6294d2864426b329ce07da3f1d0eebe6f131a066062638128657708c4617 [INFO] running `Command { std: "docker" "start" "-a" "9aba6294d2864426b329ce07da3f1d0eebe6f131a066062638128657708c4617", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking lock_api v0.4.11 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling ahash v0.8.10 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking deunicode v1.4.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking unicase v2.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Compiling pest v2.7.7 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Compiling pest_meta v2.7.7 [INFO] [stderr] Compiling pest_generator v2.7.7 [INFO] [stderr] Compiling pest_derive v2.7.7 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tera v1.19.1 [INFO] [stderr] Checking scraper v0.18.1 [INFO] [stderr] Checking md-blog-gen v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !css_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `css_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if !markdown_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `markdown_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if !rendered_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rendered_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `css_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 74 | if !css_metadata.is_ok() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 75 | let e = css_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `markdown_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 83 | if !markdown_metadata.is_ok() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 84 | let e = markdown_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `rendered_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 92 | if !rendered_metadata.is_ok() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 93 | let e = rendered_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | format!("{}", &css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | format!("{}", &markdown_sources_dir), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&markdown_sources_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | format!("{}", &rendered_outputs_dir), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&rendered_outputs_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | format!("{}", &self.css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | format!("{}", &self.css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !css_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `css_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if !markdown_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `markdown_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/blog_gen/blog_generator.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if !rendered_metadata.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rendered_metadata.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `css_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 74 | if !css_metadata.is_ok() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 75 | let e = css_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `markdown_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 83 | if !markdown_metadata.is_ok() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 84 | let e = markdown_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `rendered_metadata` after checking its variant with `is_ok` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 92 | if !rendered_metadata.is_ok() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 93 | let e = rendered_metadata.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | markdown_files_sorted.sort_by(|a, b| a.created_time.cmp(&b.created_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - markdown_files_sorted.sort_by(|a, b| a.created_time.cmp(&b.created_time)); [INFO] [stdout] 175 + markdown_files_sorted.sort_by_key(|a| a.created_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | format!("{}", &css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | format!("{}", &markdown_sources_dir), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&markdown_sources_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | format!("{}", &rendered_outputs_dir), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&rendered_outputs_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | format!("{}", &self.css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/blog_gen/blog_generator.rs:241:52 [INFO] [stdout] | [INFO] [stdout] 241 | let f_write = f.unwrap().write_all(&rendered.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `rendered.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | format!("{}", &self.css_source_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.css_source_file).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/blog_gen/blog_generator.rs:280:42 [INFO] [stdout] | [INFO] [stdout] 280 | let _ = f.unwrap().write_all(&rendered.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `rendered.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blog_gen/html_template.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return index_page_template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return index_page_template; [INFO] [stdout] 65 + index_page_template [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blog_gen/html_template.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return html_template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return html_template; [INFO] [stdout] 90 + html_template [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/blog_gen/blog_generator.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | markdown_files_sorted.sort_by(|a, b| a.created_time.cmp(&b.created_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - markdown_files_sorted.sort_by(|a, b| a.created_time.cmp(&b.created_time)); [INFO] [stdout] 175 + markdown_files_sorted.sort_by_key(|a| a.created_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/blog_gen/blog_generator.rs:241:52 [INFO] [stdout] | [INFO] [stdout] 241 | let f_write = f.unwrap().write_all(&rendered.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `rendered.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/blog_gen/blog_generator.rs:280:42 [INFO] [stdout] | [INFO] [stdout] 280 | let _ = f.unwrap().write_all(&rendered.as_bytes()).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `rendered.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blog_gen/html_template.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return index_page_template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return index_page_template; [INFO] [stdout] 65 + index_page_template [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/blog_gen/html_template.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return html_template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return html_template; [INFO] [stdout] 90 + html_template [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.08s [INFO] running `Command { std: "docker" "inspect" "9aba6294d2864426b329ce07da3f1d0eebe6f131a066062638128657708c4617", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aba6294d2864426b329ce07da3f1d0eebe6f131a066062638128657708c4617", kill_on_drop: false }` [INFO] [stdout] 9aba6294d2864426b329ce07da3f1d0eebe6f131a066062638128657708c4617