[INFO] cloning repository https://github.com/abiolaogu/couchestor-ce [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abiolaogu/couchestor-ce" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabiolaogu%2Fcouchestor-ce", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabiolaogu%2Fcouchestor-ce'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b6ce24be6d4609d54bd79894755dbf9d641319a6 [INFO] linting abiolaogu/couchestor-ce against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabiolaogu%2Fcouchestor-ce" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 26% (11998/45546) Updating files: 27% (12298/45546) Updating files: 28% (12753/45546) Updating files: 29% (13209/45546) Updating files: 30% (13664/45546) Updating files: 31% (14120/45546) Updating files: 32% (14575/45546) Updating files: 33% (15031/45546) Updating files: 34% (15486/45546) Updating files: 35% (15942/45546) Updating files: 36% (16397/45546) Updating files: 37% (16853/45546) Updating files: 38% (17308/45546) Updating files: 39% (17763/45546) Updating files: 40% (18219/45546) Updating files: 41% (18674/45546) Updating files: 42% (19130/45546) Updating files: 43% (19585/45546) Updating files: 44% (20041/45546) Updating files: 45% (20496/45546) Updating files: 46% (20952/45546) Updating files: 47% (21407/45546) Updating files: 48% (21863/45546) Updating files: 49% (22318/45546) Updating files: 50% (22773/45546) Updating files: 51% (23229/45546) Updating files: 51% (23259/45546) Updating files: 52% (23684/45546) Updating files: 53% (24140/45546) Updating files: 54% (24595/45546) Updating files: 55% (25051/45546) Updating files: 56% (25506/45546) Updating files: 57% (25962/45546) Updating files: 58% (26417/45546) Updating files: 59% (26873/45546) Updating files: 60% (27328/45546) Updating files: 61% (27784/45546) Updating files: 62% (28239/45546) Updating files: 63% (28694/45546) Updating files: 64% (29150/45546) Updating files: 65% (29605/45546) Updating files: 66% (30061/45546) Updating files: 67% (30516/45546) Updating files: 68% (30972/45546) Updating files: 69% (31427/45546) Updating files: 70% (31883/45546) Updating files: 70% (32209/45546) Updating files: 71% (32338/45546) Updating files: 72% (32794/45546) Updating files: 73% (33249/45546) Updating files: 74% (33705/45546) Updating files: 75% (34160/45546) Updating files: 76% (34615/45546) Updating files: 77% (35071/45546) Updating files: 78% (35526/45546) Updating files: 79% (35982/45546) Updating files: 80% (36437/45546) Updating files: 81% (36893/45546) Updating files: 82% (37348/45546) Updating files: 83% (37804/45546) Updating files: 84% (38259/45546) Updating files: 85% (38715/45546) Updating files: 86% (39170/45546) Updating files: 87% (39626/45546) Updating files: 88% (40081/45546) Updating files: 89% (40536/45546) Updating files: 90% (40992/45546) Updating files: 91% (41447/45546) Updating files: 92% (41903/45546) Updating files: 93% (42358/45546) Updating files: 94% (42814/45546) Updating files: 95% (43269/45546) Updating files: 95% (43270/45546) Updating files: 96% (43725/45546) Updating files: 97% (44180/45546) Updating files: 98% (44636/45546) Updating files: 99% (45091/45546) Updating files: 100% (45546/45546) Updating files: 100% (45546/45546), done. [INFO] started tweaking git repo https://github.com/abiolaogu/couchestor-ce [INFO] finished tweaking git repo https://github.com/abiolaogu/couchestor-ce [INFO] tweaked toml for git repo https://github.com/abiolaogu/couchestor-ce written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/abiolaogu/couchestor-ce on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/abiolaogu/couchestor-ce already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded protobuf-support v3.7.2 [INFO] [stderr] Downloaded kube v0.99.0 [INFO] [stderr] Downloaded clap_lex v0.7.7 [INFO] [stderr] Downloaded hostname v0.4.2 [INFO] [stderr] Downloaded kube-derive v0.99.0 [INFO] [stderr] Downloaded hyper-http-proxy v1.1.0 [INFO] [stderr] Downloaded rustls-native-certs v0.7.3 [INFO] [stderr] Downloaded backon v1.6.0 [INFO] [stderr] Downloaded clap v4.5.56 [INFO] [stderr] Downloaded kube-core v0.99.0 [INFO] [stderr] Downloaded jsonptr v0.7.1 [INFO] [stderr] Downloaded kube-client v0.99.0 [INFO] [stderr] Downloaded pest v2.8.5 [INFO] [stderr] Downloaded kube-runtime v0.99.0 [INFO] [stderr] Downloaded clap_builder v4.5.56 [INFO] [stderr] Downloaded protobuf v3.7.2 [INFO] [stderr] Downloaded prometheus v0.14.0 [INFO] [stderr] Downloaded pest_meta v2.8.5 [INFO] [stderr] Downloaded webpki-roots v1.0.5 [INFO] [stderr] Downloaded pest_derive v2.8.5 [INFO] [stderr] Downloaded jsonpath-rust v0.7.5 [INFO] [stderr] Downloaded tempfile v3.24.0 [INFO] [stderr] Downloaded reed-solomon-erasure v6.0.0 [INFO] [stderr] Downloaded pest_generator v2.8.5 [INFO] [stderr] Downloaded json-patch v4.1.0 [INFO] [stderr] Downloaded k8s-openapi v0.24.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32908a0ae00e32734f4490bbfb28f080f3e5d55b3e901073d5edf0f6e790d7b3 [INFO] running `Command { std: "docker" "start" "-a" "32908a0ae00e32734f4490bbfb28f080f3e5d55b3e901073d5edf0f6e790d7b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32908a0ae00e32734f4490bbfb28f080f3e5d55b3e901073d5edf0f6e790d7b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32908a0ae00e32734f4490bbfb28f080f3e5d55b3e901073d5edf0f6e790d7b3", kill_on_drop: false }` [INFO] [stdout] 32908a0ae00e32734f4490bbfb28f080f3e5d55b3e901073d5edf0f6e790d7b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1233dcf5a26336fa973ff54797a94f66046c6e8a110cebd825fd7373ca38eb6f [INFO] running `Command { std: "docker" "start" "-a" "1233dcf5a26336fa973ff54797a94f66046c6e8a110cebd825fd7373ca38eb6f", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Compiling pest v2.8.5 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling k8s-openapi v0.24.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling pest_meta v2.8.5 [INFO] [stderr] Compiling enum-ordinalize v4.3.2 [INFO] [stderr] Checking jsonptr v0.7.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling protobuf v3.7.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking json-patch v4.1.0 [INFO] [stderr] Checking protobuf-support v3.7.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling educe v0.6.0 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Compiling prometheus v0.14.0 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Compiling pest_generator v2.8.5 [INFO] [stderr] Compiling reed-solomon-erasure v6.0.0 [INFO] [stderr] Checking clap_builder v4.5.56 [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking lru v0.7.8 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling pest_derive v2.8.5 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking jsonpath-rust v0.7.5 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling couchestor v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] warning: couchestor@0.1.0: Building without SPDK support. Enable with --features spdk [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling kube-derive v0.99.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking clap v4.5.56 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking backon v1.6.0 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking proptest v1.9.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking kube-core v0.99.0 [INFO] [stderr] Checking kube-client v0.99.0 [INFO] [stderr] Checking kube-runtime v0.99.0 [INFO] [stderr] Checking kube v0.99.0 [INFO] [stderr] Checking lz4 v1.28.1 [INFO] [stdout] warning: unused import: `PersistentVolumeStatus` [INFO] [stdout] --> src/controller/storage_policy.rs:590:49 [INFO] [stdout] | [INFO] [stdout] 590 | PersistentVolume, PersistentVolumeSpec, PersistentVolumeStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/controller/storage_policy.rs:1186:13 [INFO] [stdout] | [INFO] [stdout] 1186 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/controller/storage_policy.rs:532:15 [INFO] [stdout] | [INFO] [stdout] 532 | if let Ok(mut policy) = policies.get(policy_name).await { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/controller/storage_policy.rs:532:15 [INFO] [stdout] | [INFO] [stdout] 532 | if let Ok(mut policy) = policies.get(policy_name).await { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/crd/storage_policy.rs:309:5 [INFO] [stdout] | [INFO] [stdout] 309 | / pub fn new( [INFO] [stdout] 310 | | volume_name: String, [INFO] [stdout] 311 | | timestamp: DateTime, [INFO] [stdout] 312 | | from_tier: String, [INFO] [stdout] ... | [INFO] [stdout] 317 | | error: Option, [INFO] [stdout] 318 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hardware/discovery/nvme.rs:307:34 [INFO] [stdout] | [INFO] [stdout] 307 | if let Some(n_idx) = path[4..].find('n') { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hardware/discovery/nvme.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 305 | if path.starts_with("nvme") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 305 ~ if let Some() = path.strip_prefix("nvme") { [INFO] [stdout] 306 | // Skip "nvme" prefix, then find the next 'n' (namespace separator) [INFO] [stdout] 307 ~ if let Some(n_idx) = .find('n') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 146 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 146 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 166 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 166 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 190 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 190 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 190 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/controller/ec_policy.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/rustfs/cache/l3.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | .or_insert_with(DashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/rustfs/cache/compression.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CompressionAlgorithm { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | CompressionAlgorithm::Lz4 [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 28 + #[derive(Default)] [INFO] [stdout] 29 | pub enum CompressionAlgorithm { [INFO] [stdout] 30 | /// No compression [INFO] [stdout] 31 | None, [INFO] [stdout] 32 | /// LZ4 - fast compression [INFO] [stdout] 33 ~ #[default] [INFO] [stdout] 34 ~ Lz4, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/crd/storage_policy.rs:309:5 [INFO] [stdout] | [INFO] [stdout] 309 | / pub fn new( [INFO] [stdout] 310 | | volume_name: String, [INFO] [stdout] 311 | | timestamp: DateTime, [INFO] [stdout] 312 | | from_tier: String, [INFO] [stdout] ... | [INFO] [stdout] 317 | | error: Option, [INFO] [stdout] 318 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `degraded` [INFO] [stdout] --> tests/ec_integration.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | for i in 0..parity_shards { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 133 - for i in 0..parity_shards { [INFO] [stdout] 133 + for in degraded.iter_mut().take(parity_shards) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/integration_tests.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | assert!(manager.l1().len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `manager.l1().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/integration_tests.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(manager.l2().len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `manager.l2().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/integration_tests.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | config.auto_promotion = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `couchestor::rustfs::CacheConfig { auto_promotion: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/integration_tests.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional` [INFO] [stdout] --> src/ec/encoder.rs:572:22 [INFO] [stdout] | [INFO] [stdout] 572 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 572 - for i in 0..m { [INFO] [stdout] 572 + for in optional.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional_shards` [INFO] [stdout] --> src/ec/proptest.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..actual_erasures { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 110 - for i in 0..actual_erasures { [INFO] [stdout] 110 + for in optional_shards.iter_mut().take(actual_erasures) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `shards` [INFO] [stdout] --> src/ec/proptest.rs:218:18 [INFO] [stdout] | [INFO] [stdout] 218 | for i in 0..k { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 218 - for i in 0..k { [INFO] [stdout] 218 + for in shards.iter().take(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional_shards` [INFO] [stdout] --> src/ec/proptest.rs:370:18 [INFO] [stdout] | [INFO] [stdout] 370 | for i in 0..=m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 370 - for i in 0..=m { [INFO] [stdout] 370 + for in optional_shards.iter_mut().take(m + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hardware/discovery/nvme.rs:307:34 [INFO] [stdout] | [INFO] [stdout] 307 | if let Some(n_idx) = path[4..].find('n') { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hardware/discovery/nvme.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 305 | if path.starts_with("nvme") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 305 ~ if let Some() = path.strip_prefix("nvme") { [INFO] [stdout] 306 | // Skip "nvme" prefix, then find the next 'n' (namespace separator) [INFO] [stdout] 307 ~ if let Some(n_idx) = .find('n') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PersistentVolumeStatus` [INFO] [stdout] --> src/controller/storage_policy.rs:590:49 [INFO] [stdout] | [INFO] [stdout] 590 | PersistentVolume, PersistentVolumeSpec, PersistentVolumeStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/controller/storage_policy.rs:1186:13 [INFO] [stdout] | [INFO] [stdout] 1186 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MigrationState` which implements the `Copy` trait [INFO] [stdout] --> src/migrator/engine.rs:1024:22 [INFO] [stdout] | [INFO] [stdout] 1024 | let cloned = state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rustfs/cache/entry.rs:373:47 [INFO] [stdout] | [INFO] [stdout] 373 | let key = CacheKey::new("bucket", &format!("key-{}", i)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("key-{}", i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/rustfs/cache/l3.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | .or_insert_with(DashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/rustfs/cache/manager.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | config.write_through = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `rustfs::cache::manager::CacheConfig { write_through: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/rustfs/cache/manager.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 457 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/rustfs/cache/manager.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | config.auto_promotion = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `rustfs::cache::manager::CacheConfig { auto_promotion: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/rustfs/cache/manager.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/rustfs/cache/manager.rs:523:9 [INFO] [stdout] | [INFO] [stdout] 523 | config.auto_promotion = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `rustfs::cache::manager::CacheConfig { auto_promotion: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/rustfs/cache/manager.rs:522:9 [INFO] [stdout] | [INFO] [stdout] 522 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/rustfs/cache/manager.rs:677:9 [INFO] [stdout] | [INFO] [stdout] 677 | config.write_through = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `rustfs::cache::manager::CacheConfig { write_through: true, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/rustfs/cache/manager.rs:676:9 [INFO] [stdout] | [INFO] [stdout] 676 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/rustfs/cache/shard.rs:561:49 [INFO] [stdout] | [INFO] [stdout] 561 | map.insert(key.clone(), i as i32, 4); [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/rustfs/cache/compression.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | / impl Default for CompressionAlgorithm { [INFO] [stdout] 59 | | fn default() -> Self { [INFO] [stdout] 60 | | CompressionAlgorithm::Lz4 [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 28 + #[derive(Default)] [INFO] [stdout] 29 | pub enum CompressionAlgorithm { [INFO] [stdout] 30 | /// No compression [INFO] [stdout] 31 | None, [INFO] [stdout] 32 | /// LZ4 - fast compression [INFO] [stdout] 33 ~ #[default] [INFO] [stdout] 34 ~ Lz4, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/rustfs/monitoring/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/controller/storage_policy.rs:532:15 [INFO] [stdout] | [INFO] [stdout] 532 | if let Ok(mut policy) = policies.get(policy_name).await { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/controller/storage_policy.rs:532:15 [INFO] [stdout] | [INFO] [stdout] 532 | if let Ok(mut policy) = policies.get(policy_name).await { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/crd/storage_policy.rs:309:5 [INFO] [stdout] | [INFO] [stdout] 309 | / pub fn new( [INFO] [stdout] 310 | | volume_name: String, [INFO] [stdout] 311 | | timestamp: DateTime, [INFO] [stdout] 312 | | from_tier: String, [INFO] [stdout] ... | [INFO] [stdout] 317 | | error: Option, [INFO] [stdout] 318 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 146 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 146 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 166 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 166 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/adapters/reed_solomon.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 190 | .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 190 - .chain(encoded.parity_shards.into_iter()) [INFO] [stdout] 190 + .chain(encoded.parity_shards) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/controller/ec_policy.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/crd/storage_policy.rs:309:5 [INFO] [stdout] | [INFO] [stdout] 309 | / pub fn new( [INFO] [stdout] 310 | | volume_name: String, [INFO] [stdout] 311 | | timestamp: DateTime, [INFO] [stdout] 312 | | from_tier: String, [INFO] [stdout] ... | [INFO] [stdout] 317 | | error: Option, [INFO] [stdout] 318 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional` [INFO] [stdout] --> src/ec/encoder.rs:572:22 [INFO] [stdout] | [INFO] [stdout] 572 | for i in 0..m { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 572 - for i in 0..m { [INFO] [stdout] 572 + for in optional.iter_mut().take(m) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional_shards` [INFO] [stdout] --> src/ec/proptest.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..actual_erasures { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 110 - for i in 0..actual_erasures { [INFO] [stdout] 110 + for in optional_shards.iter_mut().take(actual_erasures) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `shards` [INFO] [stdout] --> src/ec/proptest.rs:218:18 [INFO] [stdout] | [INFO] [stdout] 218 | for i in 0..k { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 218 - for i in 0..k { [INFO] [stdout] 218 + for in shards.iter().take(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `optional_shards` [INFO] [stdout] --> src/ec/proptest.rs:370:18 [INFO] [stdout] | [INFO] [stdout] 370 | for i in 0..=m { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 370 - for i in 0..=m { [INFO] [stdout] 370 + for in optional_shards.iter_mut().take(m + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MigrationState` which implements the `Copy` trait [INFO] [stdout] --> src/migrator/engine.rs:1024:22 [INFO] [stdout] | [INFO] [stdout] 1024 | let cloned = state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `Command { std: "docker" "inspect" "1233dcf5a26336fa973ff54797a94f66046c6e8a110cebd825fd7373ca38eb6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1233dcf5a26336fa973ff54797a94f66046c6e8a110cebd825fd7373ca38eb6f", kill_on_drop: false }` [INFO] [stdout] 1233dcf5a26336fa973ff54797a94f66046c6e8a110cebd825fd7373ca38eb6f