[INFO] cloning repository https://github.com/abigailsdev/quarc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abigailsdev/quarc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabigailsdev%2Fquarc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabigailsdev%2Fquarc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 649116f73951da6c3ebcf6dd358198c4bcad9727 [INFO] linting abigailsdev/quarc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabigailsdev%2Fquarc" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/abigailsdev/quarc [INFO] finished tweaking git repo https://github.com/abigailsdev/quarc [INFO] tweaked toml for git repo https://github.com/abigailsdev/quarc written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/abigailsdev/quarc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/abigailsdev/quarc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded string_cache_codegen v0.4.4 [INFO] [stderr] Downloaded warc v0.3.2 [INFO] [stderr] Downloaded markup5ever v0.7.5 [INFO] [stderr] Downloaded string_cache v0.7.5 [INFO] [stderr] Downloaded string_cache_shared v0.3.0 [INFO] [stderr] Downloaded soup v0.5.1 [INFO] [stderr] Downloaded openssl-sys v0.9.101 [INFO] [stderr] Downloaded cc v1.0.89 [INFO] [stderr] Downloaded html5ever v0.22.5 [INFO] [stderr] Downloaded chrono v0.4.34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc97212da725485ceabb4fcf88ce026b55c2e0bdb42fbec3967500c297c3a79e [INFO] running `Command { std: "docker" "start" "-a" "cc97212da725485ceabb4fcf88ce026b55c2e0bdb42fbec3967500c297c3a79e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc97212da725485ceabb4fcf88ce026b55c2e0bdb42fbec3967500c297c3a79e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc97212da725485ceabb4fcf88ce026b55c2e0bdb42fbec3967500c297c3a79e", kill_on_drop: false }` [INFO] [stdout] cc97212da725485ceabb4fcf88ce026b55c2e0bdb42fbec3967500c297c3a79e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52ad34b284d0379fd630e549b20199f8a022bd7fdbd8e9441396023662ae8ac6 [INFO] running `Command { std: "docker" "start" "-a" "52ad34b284d0379fd630e549b20199f8a022bd7fdbd8e9441396023662ae8ac6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling cc v1.0.89 [INFO] [stderr] Compiling string_cache_shared v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling itoa v1.0.10 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling ryu v1.0.17 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking libflate_lz77 v1.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking libflate v1.4.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling string_cache_codegen v0.4.4 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling string_cache v0.7.5 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking warc v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling html5ever v0.22.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking soup v0.5.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.24 [INFO] [stderr] Checking quarc v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | let mut warc = WarcWriter::from_path("output.warc"); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Nothing` is never constructed [INFO] [stdout] --> src/main.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Nothing; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | if !raw_response.is_ok() { return Err(1); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if !body.is_ok() { return Err(3); } [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `body.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `headervalue` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 27 | if headervalue.is_ok() [INFO] [stdout] | ---------------------- help: try: `if let Ok() = headervalue` [INFO] [stdout] 28 | { [INFO] [stdout] 29 | mime = Some(headervalue.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok((body.unwrap().to_vec(), mime)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok((body.unwrap().to_vec(), mime)); [INFO] [stdout] 40 + Ok((body.unwrap().to_vec(), mime)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mime` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:56:55 [INFO] [stdout] | [INFO] [stdout] 55 | if mime.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = mime` [INFO] [stdout] 56 | warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dep_mime` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 102 | if dep_mime.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = dep_mime` [INFO] [stdout] 103 | dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] 104 | if dep_mime.unwrap().contains("text/css") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `warc` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 136 | if warc.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = warc` [INFO] [stdout] 137 | let mut nwarc = warc.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - println!("Failed to open WARC file."); [INFO] [stdout] 144 - return; [INFO] [stdout] 143 + println!("Failed to open WARC file."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | let _ = warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 52 - let _ = warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] 52 + warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | let soup = Soup::new(&body_text.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `body_text.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:68:57 [INFO] [stdout] | [INFO] [stdout] 68 | if link.get("rel").unwrap_or("".to_string()) == "me".to_string() { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `"me"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | if dep_body.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dep_body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | let _ = dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 99 - let _ = dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] 99 + dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | warc_head.set_header(WarcHeader::TargetURI, args[1].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 53 | let _ = warc_head.set_header(WarcHeader::TargetURI, args[1].to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | dep_warc_head.set_header(WarcHeader::TargetURI, url.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = dep_warc_head.set_header(WarcHeader::TargetURI, url.to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | nwarc.write(&record); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = nwarc.write(&record); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | nwarc.write(&rec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = nwarc.write(&rec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | let mut warc = WarcWriter::from_path("output.warc"); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Nothing` is never constructed [INFO] [stdout] --> src/main.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Nothing; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | if !raw_response.is_ok() { return Err(1); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `raw_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if !body.is_ok() { return Err(3); } [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `body.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `headervalue` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 27 | if headervalue.is_ok() [INFO] [stdout] | ---------------------- help: try: `if let Ok() = headervalue` [INFO] [stdout] 28 | { [INFO] [stdout] 29 | mime = Some(headervalue.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok((body.unwrap().to_vec(), mime)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok((body.unwrap().to_vec(), mime)); [INFO] [stdout] 40 + Ok((body.unwrap().to_vec(), mime)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mime` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:56:55 [INFO] [stdout] | [INFO] [stdout] 55 | if mime.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = mime` [INFO] [stdout] 56 | warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dep_mime` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 102 | if dep_mime.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = dep_mime` [INFO] [stdout] 103 | dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] 104 | if dep_mime.unwrap().contains("text/css") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `warc` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 136 | if warc.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = warc` [INFO] [stdout] 137 | let mut nwarc = warc.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - println!("Failed to open WARC file."); [INFO] [stdout] 144 - return; [INFO] [stdout] 143 + println!("Failed to open WARC file."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | let _ = warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 52 - let _ = warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] 52 + warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | let soup = Soup::new(&body_text.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `body_text.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:68:57 [INFO] [stdout] | [INFO] [stdout] 68 | if link.get("rel").unwrap_or("".to_string()) == "me".to_string() { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `"me"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | if dep_body.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dep_body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | let _ = dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 99 - let _ = dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] 99 + dep_warc_head.set_warc_type(RecordType::Resource); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | warc_head.set_header(WarcHeader::TargetURI, args[1].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 53 | let _ = warc_head.set_header(WarcHeader::TargetURI, args[1].to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = warc_head.set_header(WarcHeader::ContentType, mime.unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | dep_warc_head.set_header(WarcHeader::TargetURI, url.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = dep_warc_head.set_header(WarcHeader::TargetURI, url.to_string()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = dep_warc_head.set_header(WarcHeader::ContentType, dep_mime.clone().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | nwarc.write(&record); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = nwarc.write(&record); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | nwarc.write(&rec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = nwarc.write(&rec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.22s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.22.5 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 8` [INFO] running `Command { std: "docker" "inspect" "52ad34b284d0379fd630e549b20199f8a022bd7fdbd8e9441396023662ae8ac6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52ad34b284d0379fd630e549b20199f8a022bd7fdbd8e9441396023662ae8ac6", kill_on_drop: false }` [INFO] [stdout] 52ad34b284d0379fd630e549b20199f8a022bd7fdbd8e9441396023662ae8ac6