[INFO] cloning repository https://github.com/abc123me/fbgl-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abc123me/fbgl-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabc123me%2Ffbgl-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabc123me%2Ffbgl-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b095540e4687fd3e3a023d7438d46985426336d4 [INFO] linting abc123me/fbgl-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabc123me%2Ffbgl-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/abc123me/fbgl-rs [INFO] finished tweaking git repo https://github.com/abc123me/fbgl-rs [INFO] tweaked toml for git repo https://github.com/abc123me/fbgl-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/abc123me/fbgl-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/abc123me/fbgl-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 [INFO] [stderr] Adding lazy_static v1.5.0 [INFO] [stderr] Adding sdl2 v0.38.0 [INFO] [stderr] Adding sdl2-sys v0.38.0 [INFO] [stderr] Adding version-compare v0.1.1 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memmap v0.7.0 [INFO] [stderr] Downloaded zune-core v0.4.12 [INFO] [stderr] Downloaded bit_field v0.10.3 [INFO] [stderr] Downloaded arg_enum_proc_macro v0.3.4 [INFO] [stderr] Downloaded avif-serialize v0.8.8 [INFO] [stderr] Downloaded profiling v1.0.17 [INFO] [stderr] Downloaded pastey v0.1.1 [INFO] [stderr] Downloaded quick-error v2.0.1 [INFO] [stderr] Downloaded aligned v0.4.3 [INFO] [stderr] Downloaded zune-inflate v0.2.54 [INFO] [stderr] Downloaded core2 v0.4.0 [INFO] [stderr] Downloaded image-webp v0.2.4 [INFO] [stderr] Downloaded framebuffer v0.3.1 [INFO] [stderr] Downloaded cc v1.2.56 [INFO] [stderr] Downloaded png v0.18.1 [INFO] [stderr] Downloaded nom v8.0.0 [INFO] [stderr] Downloaded itertools v0.14.0 [INFO] [stderr] Downloaded moxcms v0.7.11 [INFO] [stderr] Downloaded sdl2 v0.38.0 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.12 [INFO] [stderr] Downloaded exr v1.74.0 [INFO] [stderr] Downloaded rand v0.9.2 [INFO] [stderr] Downloaded imgref v1.12.0 [INFO] [stderr] Downloaded image v0.25.9 [INFO] [stderr] Downloaded half v2.7.1 [INFO] [stderr] Downloaded zune-jpeg v0.5.12 [INFO] [stderr] Downloaded qoi v0.4.1 [INFO] [stderr] Downloaded bitstream-io v4.9.0 [INFO] [stderr] Downloaded zune-jpeg v0.4.21 [INFO] [stderr] Downloaded built v0.8.0 [INFO] [stderr] Downloaded rand_chacha v0.9.0 [INFO] [stderr] Downloaded rgb v0.8.53 [INFO] [stderr] Downloaded gif v0.14.1 [INFO] [stderr] Downloaded av1-grain v0.2.5 [INFO] [stderr] Downloaded av-scenechange v0.14.1 [INFO] [stderr] Downloaded new_debug_unreachable v1.0.6 [INFO] [stderr] Downloaded ravif v0.12.0 [INFO] [stderr] Downloaded rand_core v0.9.5 [INFO] [stderr] Downloaded simd_helpers v0.1.0 [INFO] [stderr] Downloaded aligned-vec v0.6.4 [INFO] [stderr] Downloaded v_frame v0.3.9 [INFO] [stderr] Downloaded fax v0.2.6 [INFO] [stderr] Downloaded weezl v0.1.12 [INFO] [stderr] Downloaded loop9 v0.1.5 [INFO] [stderr] Downloaded maybe-rayon v0.1.1 [INFO] [stderr] Downloaded noop_proc_macro v0.3.0 [INFO] [stderr] Downloaded profiling-procmacros v1.0.17 [INFO] [stderr] Downloaded equator-macro v0.4.2 [INFO] [stderr] Downloaded fax_derive v0.2.0 [INFO] [stderr] Downloaded zune-core v0.5.1 [INFO] [stderr] Downloaded lebe v0.5.3 [INFO] [stderr] Downloaded as-slice v0.2.1 [INFO] [stderr] Downloaded y4m v0.8.0 [INFO] [stderr] Downloaded interpolate_name v0.2.4 [INFO] [stderr] Downloaded equator v0.4.2 [INFO] [stderr] Downloaded pxfm v0.1.28 [INFO] [stderr] Downloaded tiff v0.10.3 [INFO] [stderr] Downloaded rav1e v0.8.1 [INFO] [stderr] Downloaded sdl2-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04977632e860b69c4bef7c87c050faa3a7b4e8b15fea672955e1976a8c884562 [INFO] running `Command { std: "docker" "start" "-a" "04977632e860b69c4bef7c87c050faa3a7b4e8b15fea672955e1976a8c884562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04977632e860b69c4bef7c87c050faa3a7b4e8b15fea672955e1976a8c884562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04977632e860b69c4bef7c87c050faa3a7b4e8b15fea672955e1976a8c884562", kill_on_drop: false }` [INFO] [stdout] 04977632e860b69c4bef7c87c050faa3a7b4e8b15fea672955e1976a8c884562 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e60a1814cdf2ac0d5796f01767e5ed0817cdedf85dea27855b0867781590df9 [INFO] running `Command { std: "docker" "start" "-a" "6e60a1814cdf2ac0d5796f01767e5ed0817cdedf85dea27855b0867781590df9", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling sdl2-sys v0.38.0 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Compiling sdl2 v0.38.0 [INFO] [stderr] Checking rgb v0.8.53 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking pxfm v0.1.28 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking framebuffer v0.3.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.40 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking fbgl v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/framebuffer.rs:61:4 [INFO] [stdout] | [INFO] [stdout] 61 | fb: fb, [INFO] [stdout] | ^^^^^^ help: replace it with: `fb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/framebuffer.rs:61:4 [INFO] [stdout] | [INFO] [stdout] 61 | fb: fb, [INFO] [stdout] | ^^^^^^ help: replace it with: `fb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/framebuffer.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 85 | let mut col: C = C::new(0, 0, 0); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/text.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/text.rs:18:39 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/text.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `txt` [INFO] [stdout] --> src/text.rs:18:55 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_txt` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opts` [INFO] [stdout] --> src/text.rs:18:68 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_opts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/image.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | fn draw_image_rgb(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/image.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | fn draw_image_rgb(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/image.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | fn draw_image_rgba(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/image.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 22 | fn draw_image_rgba(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dw2` [INFO] [stdout] --> src/lib.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | let dw2 = wh * wh; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dw2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/lib.rs:140:32 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:140:50 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:140:58 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/lib.rs:140:66 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/lib.rs:140:74 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn new(mut base_renderer: T) -> Self { [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lib.rs:207:7 [INFO] [stdout] | [INFO] [stdout] 207 | for i in 0..self.base.get_num_pixels() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn new(mut renderers: [T; N]) -> Self { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:255:7 [INFO] [stdout] | [INFO] [stdout] 255 | let mut out = MultiDisplayHorizontalRenderer:: { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u8` -> `*const u8`) [INFO] [stdout] --> src/framebuffer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | self.raw_diddy_framebuffer(x, y) as *const u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.raw_diddy_framebuffer(x, y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | fn set_pixels(&mut self, pixels: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 75 - fn set_pixels(&mut self, pixels: &Vec) { [INFO] [stdout] 75 + fn set_pixels(&mut self, pixels: &[Self::Color]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:260:3 [INFO] [stdout] | [INFO] [stdout] 255 | / let mut out = MultiDisplayHorizontalRenderer:: { [INFO] [stdout] 256 | | renderers, [INFO] [stdout] 257 | | base_w, [INFO] [stdout] 258 | | base_h, [INFO] [stdout] 259 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 260 | out [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 255 ~ [INFO] [stdout] 256 ~ MultiDisplayHorizontalRenderer:: { [INFO] [stdout] 257 ~ renderers, [INFO] [stdout] 258 ~ base_w, [INFO] [stdout] 259 ~ base_h, [INFO] [stdout] 260 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/framebuffer.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 85 | let mut col: C = C::new(0, 0, 0); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/text.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/text.rs:18:39 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/text.rs:18:47 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `txt` [INFO] [stdout] --> src/text.rs:18:55 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_txt` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opts` [INFO] [stdout] --> src/text.rs:18:68 [INFO] [stdout] | [INFO] [stdout] 18 | fn text(&mut self, col: Self::Color, x: u32, y: u32, txt: String, opts: TextRenderSettings) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_opts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/image.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | fn draw_image_rgb(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/image.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | fn draw_image_rgb(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/image.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | fn draw_image_rgba(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/image.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 22 | fn draw_image_rgba(&mut self, x: u32, y: u32, img: &impl GenericImageView>) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dw2` [INFO] [stdout] --> src/lib.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | let dw2 = wh * wh; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dw2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/lib.rs:140:32 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:140:50 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:140:58 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/lib.rs:140:66 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/lib.rs:140:74 [INFO] [stdout] | [INFO] [stdout] 140 | fn ellipse_outline(&mut self, col: Self::Color, x: u32, y: u32, w: u32, h: u32) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn new(mut base_renderer: T) -> Self { [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lib.rs:207:7 [INFO] [stdout] | [INFO] [stdout] 207 | for i in 0..self.base.get_num_pixels() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn new(mut renderers: [T; N]) -> Self { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:255:7 [INFO] [stdout] | [INFO] [stdout] 255 | let mut out = MultiDisplayHorizontalRenderer:: { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const u8` -> `*const u8`) [INFO] [stdout] --> src/framebuffer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | self.raw_diddy_framebuffer(x, y) as *const u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.raw_diddy_framebuffer(x, y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | fn set_pixels(&mut self, pixels: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 75 - fn set_pixels(&mut self, pixels: &Vec) { [INFO] [stdout] 75 + fn set_pixels(&mut self, pixels: &[Self::Color]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:260:3 [INFO] [stdout] | [INFO] [stdout] 255 | / let mut out = MultiDisplayHorizontalRenderer:: { [INFO] [stdout] 256 | | renderers, [INFO] [stdout] 257 | | base_w, [INFO] [stdout] 258 | | base_h, [INFO] [stdout] 259 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 260 | out [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 255 ~ [INFO] [stdout] 256 ~ MultiDisplayHorizontalRenderer:: { [INFO] [stdout] 257 ~ renderers, [INFO] [stdout] 258 ~ base_w, [INFO] [stdout] 259 ~ base_h, [INFO] [stdout] 260 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_fb_info` is never used [INFO] [stdout] --> src/main.rs:17:4 [INFO] [stdout] | [INFO] [stdout] 17 | fn print_fb_info(fb: &Framebuffer) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | if !gfx_mode.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `gfx_mode.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_fb_info` is never used [INFO] [stdout] --> src/main.rs:17:4 [INFO] [stdout] | [INFO] [stdout] 17 | fn print_fb_info(fb: &Framebuffer) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | if !gfx_mode.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `gfx_mode.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.63s [INFO] running `Command { std: "docker" "inspect" "6e60a1814cdf2ac0d5796f01767e5ed0817cdedf85dea27855b0867781590df9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e60a1814cdf2ac0d5796f01767e5ed0817cdedf85dea27855b0867781590df9", kill_on_drop: false }` [INFO] [stdout] 6e60a1814cdf2ac0d5796f01767e5ed0817cdedf85dea27855b0867781590df9