[INFO] cloning repository https://github.com/aayushmau5/meowui [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aayushmau5/meowui" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faayushmau5%2Fmeowui", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faayushmau5%2Fmeowui'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4908ee54ad774136fcf48e71b7b402ae214978fe [INFO] linting aayushmau5/meowui against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faayushmau5%2Fmeowui" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/aayushmau5/meowui [INFO] finished tweaking git repo https://github.com/aayushmau5/meowui [INFO] tweaked toml for git repo https://github.com/aayushmau5/meowui written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aayushmau5/meowui on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aayushmau5/meowui already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/liveview-native/phoenix-channels-client.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uniffi v0.28.3 [INFO] [stderr] Downloaded uniffi_meta v0.28.3 [INFO] [stderr] Downloaded uniffi_core v0.28.3 [INFO] [stderr] Downloaded uniffi_checksum_derive v0.28.3 [INFO] [stderr] Downloaded fs-err v2.11.0 [INFO] [stderr] Downloaded uniffi_macros v0.28.3 [INFO] [stderr] Downloaded file-size v1.0.3 [INFO] [stderr] Downloaded flexstr v0.9.2 [INFO] [stderr] Downloaded async-compat v0.2.4 [INFO] [stderr] Downloaded weedle2 v5.0.0 [INFO] [stderr] Downloaded data-encoding v2.7.0 [INFO] [stderr] Downloaded scroll_derive v0.12.0 [INFO] [stderr] Downloaded rusqlite v0.33.0 [INFO] [stderr] Downloaded uniffi_udl v0.28.3 [INFO] [stderr] Downloaded proc-status v0.1.1 [INFO] [stderr] Downloaded cli-log v2.1.0 [INFO] [stderr] Downloaded open v5.3.2 [INFO] [stderr] Downloaded atomic-take v1.1.0 [INFO] [stderr] Downloaded uniffi_testing v0.28.3 [INFO] [stderr] Downloaded uniffi_bindgen v0.28.3 [INFO] [stderr] Downloaded uuid v1.12.1 [INFO] [stderr] Downloaded goblin v0.8.2 [INFO] [stderr] Downloaded libsqlite3-sys v0.31.0 [INFO] [stderr] Downloaded openssl-src v300.4.1+3.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a4f46b9dfb3f5a4a2479f94949577ae98fdc662589a5b45775c9294cb5966cf [INFO] running `Command { std: "docker" "start" "-a" "9a4f46b9dfb3f5a4a2479f94949577ae98fdc662589a5b45775c9294cb5966cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a4f46b9dfb3f5a4a2479f94949577ae98fdc662589a5b45775c9294cb5966cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a4f46b9dfb3f5a4a2479f94949577ae98fdc662589a5b45775c9294cb5966cf", kill_on_drop: false }` [INFO] [stdout] 9a4f46b9dfb3f5a4a2479f94949577ae98fdc662589a5b45775c9294cb5966cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa9a46540fac1a58c544e13eaac63f67993fb6491da533cbd070b3ff4487aa76 [INFO] running `Command { std: "docker" "start" "-a" "fa9a46540fac1a58c544e13eaac63f67993fb6491da533cbd070b3ff4487aa76", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling cc v1.2.10 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling semver v1.0.25 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking data-encoding v2.7.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling openssl-src v300.4.1+3.4.0 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking atomic-take v1.1.0 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking file-size v1.0.3 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking open v5.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.12.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Compiling libsqlite3-sys v0.31.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling uniffi_checksum_derive v0.28.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling uniffi_meta v0.28.3 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking proc-status v0.1.1 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking async-compat v0.2.4 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking uniffi_core v0.28.3 [INFO] [stderr] Compiling bincode v1.3.3 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking cargo-platform v0.1.9 [INFO] [stderr] Checking flexstr v0.9.2 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking rusqlite v0.33.0 [INFO] [stderr] Compiling uniffi_macros v0.28.3 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking cli-log v2.1.0 [INFO] [stderr] Checking uniffi v0.28.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking phoenix_channels_client v0.9.1 (https://github.com/liveview-native/phoenix-channels-client.git#818fd0ca) [INFO] [stderr] Checking meowui v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/app/notes_screen.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / /// socket -> screen: `{"name": "notes", "payload": {"action": "get-workspaces", "data": [...]}}` [INFO] [stdout] 19 | | [INFO] [stdout] | |_^ [INFO] [stdout] 20 | pub struct NotesScreen { [INFO] [stdout] | ---------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `env::current_dir` [INFO] [stdout] --> src/app/projects_screen.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env::current_dir, path::Path}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rusqlite::Result as SqliteResult` [INFO] [stdout] --> src/app/projects_screen.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use rusqlite::Result as SqliteResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/app/notes_screen.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / /// socket -> screen: `{"name": "notes", "payload": {"action": "get-workspaces", "data": [...]}}` [INFO] [stdout] 19 | | [INFO] [stdout] | |_^ [INFO] [stdout] 20 | pub struct NotesScreen { [INFO] [stdout] | ---------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `env::current_dir` [INFO] [stdout] --> src/app/projects_screen.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env::current_dir, path::Path}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rusqlite::Result as SqliteResult` [INFO] [stdout] --> src/app/projects_screen.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use rusqlite::Result as SqliteResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cli_log::info` [INFO] [stdout] --> src/sqlite.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use cli_log::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cli_log::info` [INFO] [stdout] --> src/sqlite.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use cli_log::info; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/app/projects_screen.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct ProjectData { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 24 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProjectData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `execute_query` and `execute_query_with_params` are never used [INFO] [stdout] --> src/sqlite.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Sqlite { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn execute_query(&self, query: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn execute_query_with_params(&self, query: &str, params: impl Params) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/app/bin_screen/main.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 18 | / let bin_screen = Self { [INFO] [stdout] 19 | | bins, [INFO] [stdout] 20 | | list_state: ListState::default(), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 22 | bin_screen [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + bins, [INFO] [stdout] 21 + list_state: ListState::default(), [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app/bin_screen/show.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 65 | if !self.list_state.selected().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.list_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/bin_screen/show.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | format!("{}", self.bin.content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.bin.content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/bin_screen/show.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | format!("{}", self.bin.content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.bin.content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/app/projects_screen.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct ProjectData { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 24 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProjectData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `execute_query` and `execute_query_with_params` are never used [INFO] [stdout] --> src/sqlite.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Sqlite { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn execute_query(&self, query: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn execute_query_with_params(&self, query: &str, params: impl Params) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:162:48 [INFO] [stdout] | [INFO] [stdout] 160 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 161 | if let Screens::Main(main_screen) = &mut self.screen { [INFO] [stdout] 162 | main_screen.bins = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 169 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 170 | let data = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:185:36 [INFO] [stdout] | [INFO] [stdout] 184 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 185 | let data = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:200:35 [INFO] [stdout] | [INFO] [stdout] 199 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 200 | let bin = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/app/bin_screen/main.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 18 | / let bin_screen = Self { [INFO] [stdout] 19 | | bins, [INFO] [stdout] 20 | | list_state: ListState::default(), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 22 | bin_screen [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + bins, [INFO] [stdout] 21 + list_state: ListState::default(), [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / pub enum Screens { [INFO] [stdout] 37 | | Main(MainScreen), [INFO] [stdout] 38 | | Todos(TodosScreen), [INFO] [stdout] 39 | | Bin(BinScreen), [INFO] [stdout] | | -------------- the largest variant contains at least 1024 bytes [INFO] [stdout] 40 | | Notes(NotesScreen), [INFO] [stdout] 41 | | Projects(ProjectsScreen), [INFO] [stdout] | | ------------------------ the second-largest variant contains at least 176 bytes [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ the entire enum is at least 1024 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 39 - Bin(BinScreen), [INFO] [stdout] 39 + Bin(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app/bin_screen/show.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 65 | if !self.list_state.selected().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.list_state.selected().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/bin_screen/show.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | format!("{}", self.bin.content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.bin.content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app/bin_screen/show.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | format!("{}", self.bin.content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.bin.content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/phoenix.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | let _ = self.socket_tx.send(event.payload.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/sqlite.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | let conn = Connection::open(DB.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `DB` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/tui/expire_at_input_widget.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for TimeUnit { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::Minute [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 25 + #[derive(Default)] [INFO] [stdout] 26 | pub enum TimeUnit { [INFO] [stdout] 27 | Day, [INFO] [stdout] 28 ~ #[default] [INFO] [stdout] 29 ~ Minute, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:162:48 [INFO] [stdout] | [INFO] [stdout] 160 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 161 | if let Screens::Main(main_screen) = &mut self.screen { [INFO] [stdout] 162 | main_screen.bins = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 169 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 170 | let data = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:185:36 [INFO] [stdout] | [INFO] [stdout] 184 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 185 | let data = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/bin_screen.rs:200:35 [INFO] [stdout] | [INFO] [stdout] 199 | if data.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = data` [INFO] [stdout] 200 | let bin = data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui/expire_at_input_widget.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | / if c.is_ascii_digit() { [INFO] [stdout] 122 | | self.insert_char(c); [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ KeyCode::Char(c) [INFO] [stdout] 121 ~ if c.is_ascii_digit() => { [INFO] [stdout] 122 | self.insert_char(c); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tui/multiline_input_widget.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | let cursor_x = if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tui/multiline_input_widget.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | let cursor_y = if lines.len() == 0 { 0 } else { lines.len() - 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TUI` contains a capitalized acronym [INFO] [stdout] --> src/tui.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct TUI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tui` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/app.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / pub enum Screens { [INFO] [stdout] 37 | | Main(MainScreen), [INFO] [stdout] 38 | | Todos(TodosScreen), [INFO] [stdout] 39 | | Bin(BinScreen), [INFO] [stdout] | | -------------- the largest variant contains at least 1024 bytes [INFO] [stdout] 40 | | Notes(NotesScreen), [INFO] [stdout] 41 | | Projects(ProjectsScreen), [INFO] [stdout] | | ------------------------ the second-largest variant contains at least 176 bytes [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ the entire enum is at least 1024 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 39 - Bin(BinScreen), [INFO] [stdout] 39 + Bin(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/phoenix.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | let _ = self.socket_tx.send(event.payload.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/sqlite.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | let conn = Connection::open(DB.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `DB` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/tui/expire_at_input_widget.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for TimeUnit { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::Minute [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 25 + #[derive(Default)] [INFO] [stdout] 26 | pub enum TimeUnit { [INFO] [stdout] 27 | Day, [INFO] [stdout] 28 ~ #[default] [INFO] [stdout] 29 ~ Minute, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui/expire_at_input_widget.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | / if c.is_ascii_digit() { [INFO] [stdout] 122 | | self.insert_char(c); [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ KeyCode::Char(c) [INFO] [stdout] 121 ~ if c.is_ascii_digit() => { [INFO] [stdout] 122 | self.insert_char(c); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tui/multiline_input_widget.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | let cursor_x = if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tui/multiline_input_widget.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | let cursor_y = if lines.len() == 0 { 0 } else { lines.len() - 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TUI` contains a capitalized acronym [INFO] [stdout] --> src/tui.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct TUI { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tui` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 34s [INFO] running `Command { std: "docker" "inspect" "fa9a46540fac1a58c544e13eaac63f67993fb6491da533cbd070b3ff4487aa76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa9a46540fac1a58c544e13eaac63f67993fb6491da533cbd070b3ff4487aa76", kill_on_drop: false }` [INFO] [stdout] fa9a46540fac1a58c544e13eaac63f67993fb6491da533cbd070b3ff4487aa76