[INFO] cloning repository https://github.com/aarestad/vibe-tetris-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aarestad/vibe-tetris-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarestad%2Fvibe-tetris-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarestad%2Fvibe-tetris-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b3c11664716f4273c72e18e1d877d48608184232 [INFO] linting aarestad/vibe-tetris-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarestad%2Fvibe-tetris-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aarestad/vibe-tetris-rs [INFO] finished tweaking git repo https://github.com/aarestad/vibe-tetris-rs [INFO] tweaked toml for git repo https://github.com/aarestad/vibe-tetris-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aarestad/vibe-tetris-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aarestad/vibe-tetris-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia v0.5.5 [INFO] [stderr] Downloaded symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Downloaded symphonia-codec-pcm v0.5.5 [INFO] [stderr] Downloaded symphonia-bundle-flac v0.5.5 [INFO] [stderr] Downloaded symphonia-format-ogg v0.5.5 [INFO] [stderr] Downloaded time-core v0.1.7 [INFO] [stderr] Downloaded symphonia-format-riff v0.5.5 [INFO] [stderr] Downloaded rand_core v0.10.0-rc-3 [INFO] [stderr] Downloaded objc2-core-audio v0.3.2 [INFO] [stderr] Downloaded chacha20 v0.10.0-rc.6 [INFO] [stderr] Downloaded coreaudio-rs v0.13.0 [INFO] [stderr] Downloaded rodio v0.21.1 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Downloaded rand v0.10.0-rc.6 [INFO] [stderr] Downloaded cpal v0.16.0 [INFO] [stderr] Downloaded getrandom v0.4.0-rc.0 [INFO] [stderr] Downloaded symphonia-codec-aac v0.5.5 [INFO] [stderr] Downloaded time v0.3.45 [INFO] [stderr] Downloaded objc2-audio-toolbox v0.3.2 [INFO] [stderr] Downloaded objc2-core-audio-types v0.3.2 [INFO] [stderr] Downloaded symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Downloaded symphonia-core v0.5.5 [INFO] [stderr] Downloaded symphonia-metadata v0.5.5 [INFO] [stderr] Downloaded symphonia-utils-xiph v0.5.5 [INFO] [stderr] Downloaded extended v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 887a461fdbf283299538551c897d4c40e96ab7d7d62586cbd3a4ddbe542141cc [INFO] running `Command { std: "docker" "start" "-a" "887a461fdbf283299538551c897d4c40e96ab7d7d62586cbd3a4ddbe542141cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "887a461fdbf283299538551c897d4c40e96ab7d7d62586cbd3a4ddbe542141cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "887a461fdbf283299538551c897d4c40e96ab7d7d62586cbd3a4ddbe542141cc", kill_on_drop: false }` [INFO] [stdout] 887a461fdbf283299538551c897d4c40e96ab7d7d62586cbd3a4ddbe542141cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0aa328020916a9cf8ecdebd2978fce649b218bc8555dd03e9f3d6ce2ce754d2e [INFO] running `Command { std: "docker" "start" "-a" "0aa328020916a9cf8ecdebd2978fce649b218bc8555dd03e9f3d6ce2ce754d2e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Compiling getrandom v0.4.0-rc.0 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking rand_core v0.10.0-rc-3 [INFO] [stderr] Compiling cpal v0.16.0 [INFO] [stderr] Compiling zmij v1.0.14 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling tetris-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking chacha20 v0.10.0-rc.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.5 [INFO] [stderr] Checking symphonia-codec-aac v0.5.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.5 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Checking symphonia-format-riff v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand v0.10.0-rc.6 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.5 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Checking symphonia-format-ogg v0.5.5 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking rodio v0.21.1 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/game_state.rs:884:21 [INFO] [stdout] | [INFO] [stdout] 884 | let x = (0 + dx) as usize; [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_state.rs:1247:17 [INFO] [stdout] | [INFO] [stdout] 1247 | assert!(!state.current_piece.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.current_piece.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/input.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 76 | let handler = InputHandler::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 76 - let handler = InputHandler::default(); [INFO] [stdout] 76 + let handler = InputHandler; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Tetrimino` which implements the `Copy` trait [INFO] [stdout] --> src/tetrimino.rs:426:22 [INFO] [stdout] | [INFO] [stdout] 426 | let cloned = piece.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `ratatui::Terminal>` does not permit zero-initialization [INFO] [stdout] --> src/ui.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | terminal: unsafe { std::mem::zeroed() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `ratatui::backend::CrosstermBackend` must be non-null [INFO] [stdout] = note: because `std::io::Stdout` must be non-null [INFO] [stdout] = note: because references must be non-null [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_for_testing` is never used [INFO] [stdout] --> src/ui.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Renderer { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn new_for_testing() -> Self [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/game_state.rs:884:21 [INFO] [stdout] | [INFO] [stdout] 884 | let x = (0 + dx) as usize; [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_state.rs:1247:17 [INFO] [stdout] | [INFO] [stdout] 1247 | assert!(!state.current_piece.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.current_piece.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/input.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 76 | let handler = InputHandler::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 76 - let handler = InputHandler::default(); [INFO] [stdout] 76 + let handler = InputHandler; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Tetrimino` which implements the `Copy` trait [INFO] [stdout] --> src/tetrimino.rs:426:22 [INFO] [stdout] | [INFO] [stdout] 426 | let cloned = piece.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `piece` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `ratatui::Terminal>` does not permit zero-initialization [INFO] [stdout] --> src/ui.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | terminal: unsafe { std::mem::zeroed() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `ratatui::backend::CrosstermBackend` must be non-null [INFO] [stdout] = note: because `std::io::Stdout` must be non-null [INFO] [stdout] = note: because references must be non-null [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.53s [INFO] running `Command { std: "docker" "inspect" "0aa328020916a9cf8ecdebd2978fce649b218bc8555dd03e9f3d6ce2ce754d2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0aa328020916a9cf8ecdebd2978fce649b218bc8555dd03e9f3d6ce2ce754d2e", kill_on_drop: false }` [INFO] [stdout] 0aa328020916a9cf8ecdebd2978fce649b218bc8555dd03e9f3d6ce2ce754d2e