[INFO] cloning repository https://github.com/a11ywatch/htr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/a11ywatch/htr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fa11ywatch%2Fhtr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fa11ywatch%2Fhtr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce010e158c3f668946cb011cec5bc19e89996dd1 [INFO] linting a11ywatch/htr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fa11ywatch%2Fhtr" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/a11ywatch/htr [INFO] finished tweaking git repo https://github.com/a11ywatch/htr [INFO] tweaked toml for git repo https://github.com/a11ywatch/htr written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/a11ywatch/htr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/a11ywatch/htr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.82 [INFO] [stderr] Downloaded convert_case v0.5.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.82 [INFO] [stderr] Downloaded plotters-svg v0.3.2 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.82 [INFO] [stderr] Downloaded clap_derive v3.2.15 [INFO] [stderr] Downloaded serde_derive v1.0.140 [INFO] [stderr] Downloaded serde v1.0.140 [INFO] [stderr] Downloaded criterion v0.3.6 [INFO] [stderr] Downloaded wasm-bindgen v0.2.82 [INFO] [stderr] Downloaded plotters v0.3.2 [INFO] [stderr] Downloaded js-sys v0.3.59 [INFO] [stderr] Downloaded criterion-plot v0.4.5 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.82 [INFO] [stderr] Downloaded clap v3.2.16 [INFO] [stderr] Downloaded web-sys v0.3.59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b746164b32c8676cccec6925b7bfb58b0ab9a7c85c62297e29923e829295c842 [INFO] running `Command { std: "docker" "start" "-a" "b746164b32c8676cccec6925b7bfb58b0ab9a7c85c62297e29923e829295c842", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b746164b32c8676cccec6925b7bfb58b0ab9a7c85c62297e29923e829295c842", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b746164b32c8676cccec6925b7bfb58b0ab9a7c85c62297e29923e829295c842", kill_on_drop: false }` [INFO] [stdout] b746164b32c8676cccec6925b7bfb58b0ab9a7c85c62297e29923e829295c842 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d636d8da09f7e8fd46f27f3205155d66f4a8c6368919806a95a644ed661a8c91 [INFO] running `Command { std: "docker" "start" "-a" "d636d8da09f7e8fd46f27f3205155d66f4a8c6368919806a95a644ed661a8c91", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling serde v1.0.140 [INFO] [stderr] Checking convert_case v0.5.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking htr v0.5.27 (/opt/rustwide/workdir/htr) [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/transform.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] 5 + pub fn extract_html_props(context: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> htr/src/transform.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if !(!space_before_text || c != ',' && i + 1 != style_replacer.len()) { [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if (i + 1 == style_replacer.len() || c == ',') && space_before_text { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/transform.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn create_style_object(cc: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub fn create_style_object(cc: &str) -> String { [INFO] [stdout] 42 | let style_matcher = if cc.contains("style='") { [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let mut ctx = cc.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> htr/src/transform.rs:71:54 [INFO] [stdout] | [INFO] [stdout] 71 | style_replacer = style_replacer.replacen(&clp, &clp.to_case(Case::Camel), 1); [INFO] [stdout] | ^^^^ help: change this to: `clp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/utils.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | search_str: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - search_str: &String, [INFO] [stdout] 3 + search_str: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> htr/src/utils.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let end_idx = remaining.find(&end_str).unwrap_or(remaining.len()); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/lib.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] 63 + pub fn convert_to_react(ctx: &str, component_name: String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters-svg v0.3.2 [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] 103 + pub fn convert_children_react(ctx: &mut str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> htr/src/lib.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | if SELF_ENCLOSED_TAGS.contains(¤t_prop.trim_end().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_prop.trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking htr_examples v0.5.1 (/opt/rustwide/workdir/examples) [INFO] [stderr] Checking plotters v0.3.2 [INFO] [stderr] Checking htr-test v0.5.26 (/opt/rustwide/workdir/tests) [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> examples/example.rs:7:42 [INFO] [stdout] | [INFO] [stdout] 7 | let react_html = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> tests/src/lib.rs:7:42 [INFO] [stdout] | [INFO] [stdout] 7 | let react_html = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> tests/src/lib.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | let react_html = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> tests/src/lib.rs:22:42 [INFO] [stdout] | [INFO] [stdout] 22 | let react_html = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> tests/src/lib.rs:45:37 [INFO] [stdout] | [INFO] [stdout] 45 | let props = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> tests/src/lib.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | let props = convert_props_react(&html.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/transform.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn extract_html_props(context: &String) -> Vec { [INFO] [stdout] 5 + pub fn extract_html_props(context: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> htr/src/transform.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if !(!space_before_text || c != ',' && i + 1 != style_replacer.len()) { [INFO] [stdout] | [INFO] [stdout] 106 - if space_before_text && c == ',' || space_before_text && i + 1 == style_replacer.len() { [INFO] [stdout] 106 + if (i + 1 == style_replacer.len() || c == ',') && space_before_text { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/transform.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn create_style_object(cc: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub fn create_style_object(cc: &str) -> String { [INFO] [stdout] 42 | let style_matcher = if cc.contains("style='") { [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let mut ctx = cc.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> htr/src/transform.rs:71:54 [INFO] [stdout] | [INFO] [stdout] 71 | style_replacer = style_replacer.replacen(&clp, &clp.to_case(Case::Camel), 1); [INFO] [stdout] | ^^^^ help: change this to: `clp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/utils.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | search_str: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - search_str: &String, [INFO] [stdout] 3 + search_str: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> htr/src/utils.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let end_idx = remaining.find(&end_str).unwrap_or(remaining.len()); [INFO] [stdout] | ^^^^^^^^ help: change this to: `end_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/lib.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn convert_to_react(ctx: &String, component_name: String) -> String { [INFO] [stdout] 63 + pub fn convert_to_react(ctx: &str, component_name: String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> htr/src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - pub fn convert_children_react(ctx: &mut String) -> String { [INFO] [stdout] 103 + pub fn convert_children_react(ctx: &mut str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> htr/src/lib.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | if SELF_ENCLOSED_TAGS.contains(¤t_prop.trim_end().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_prop.trim_end()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking htr_cli v0.5.27 (/opt/rustwide/workdir/htr_cli) [INFO] [stderr] Checking benches v0.0.0 (/opt/rustwide/workdir/benches) [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> benches/transform.rs:14:39 [INFO] [stdout] | [INFO] [stdout] 14 | b.iter(|| convert_props_react(&html.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> benches/transform.rs:35:55 [INFO] [stdout] | [INFO] [stdout] 35 | black_box(convert_props_react(&html.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.18s [INFO] running `Command { std: "docker" "inspect" "d636d8da09f7e8fd46f27f3205155d66f4a8c6368919806a95a644ed661a8c91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d636d8da09f7e8fd46f27f3205155d66f4a8c6368919806a95a644ed661a8c91", kill_on_drop: false }` [INFO] [stdout] d636d8da09f7e8fd46f27f3205155d66f4a8c6368919806a95a644ed661a8c91