[INFO] cloning repository https://github.com/Zynh0722/factorio-ruins-patcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Zynh0722/factorio-ruins-patcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZynh0722%2Ffactorio-ruins-patcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZynh0722%2Ffactorio-ruins-patcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7e8ee80e0b37ee47d03642e9d768013fc0b309af [INFO] linting Zynh0722/factorio-ruins-patcher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZynh0722%2Ffactorio-ruins-patcher" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Zynh0722/factorio-ruins-patcher [INFO] finished tweaking git repo https://github.com/Zynh0722/factorio-ruins-patcher [INFO] tweaked toml for git repo https://github.com/Zynh0722/factorio-ruins-patcher written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Zynh0722/factorio-ruins-patcher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Zynh0722/factorio-ruins-patcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.166 [INFO] [stderr] Downloaded clap v4.3.10 [INFO] [stderr] Downloaded itoa v1.0.8 [INFO] [stderr] Downloaded is-terminal v0.4.8 [INFO] [stderr] Downloaded console v0.15.7 [INFO] [stderr] Downloaded ryu v1.0.14 [INFO] [stderr] Downloaded serde v1.0.166 [INFO] [stderr] Downloaded clap_derive v4.3.2 [INFO] [stderr] Downloaded clap_builder v4.3.10 [INFO] [stderr] Downloaded serde_json v1.0.100 [INFO] [stderr] Downloaded rustix v0.38.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 556a07db2a47df523f604fe50d55689f1994fdb04b9692761edfa727207be2e5 [INFO] running `Command { std: "docker" "start" "-a" "556a07db2a47df523f604fe50d55689f1994fdb04b9692761edfa727207be2e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "556a07db2a47df523f604fe50d55689f1994fdb04b9692761edfa727207be2e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "556a07db2a47df523f604fe50d55689f1994fdb04b9692761edfa727207be2e5", kill_on_drop: false }` [INFO] [stdout] 556a07db2a47df523f604fe50d55689f1994fdb04b9692761edfa727207be2e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d924f8281787aa5b3230a04fbad00eff795ce3b4f40bedc029eb2cb71c524557 [INFO] running `Command { std: "docker" "start" "-a" "d924f8281787aa5b3230a04fbad00eff795ce3b4f40bedc029eb2cb71c524557", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling serde v1.0.166 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling rustix v0.38.1 [INFO] [stderr] Compiling serde_json v1.0.100 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling itoa v1.0.8 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling ryu v1.0.14 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.10 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Compiling serde_derive v1.0.166 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking clap v4.3.10 [INFO] [stderr] Compiling factorio-ruins-patcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:30:51 [INFO] [stdout] | [INFO] [stdout] 30 | let file_path = Path::new("patches").join(&file_name); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patch/mod.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 25 | .flat_map(|path| File::open(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `File::open` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/patch/mod.rs:34:54 [INFO] [stdout] | [INFO] [stdout] 34 | .flat_map(|str| serde_json::from_str(*str)) [INFO] [stdout] | ^^^^ help: try: `str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | if !target.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `target.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/patch/mod.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 25 | .flat_map(|path| File::open(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `File::open` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/patch/mod.rs:34:54 [INFO] [stdout] | [INFO] [stdout] 34 | .flat_map(|str| serde_json::from_str(*str)) [INFO] [stdout] | ^^^^ help: try: `str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | if !target.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `target.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.80s [INFO] running `Command { std: "docker" "inspect" "d924f8281787aa5b3230a04fbad00eff795ce3b4f40bedc029eb2cb71c524557", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d924f8281787aa5b3230a04fbad00eff795ce3b4f40bedc029eb2cb71c524557", kill_on_drop: false }` [INFO] [stdout] d924f8281787aa5b3230a04fbad00eff795ce3b4f40bedc029eb2cb71c524557