[INFO] cloning repository https://github.com/ZoniBoy00/MotorStormRPC [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZoniBoy00/MotorStormRPC" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZoniBoy00%2FMotorStormRPC", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZoniBoy00%2FMotorStormRPC'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3925072861904c5c9c8fcc3433c3d724df11624c [INFO] linting ZoniBoy00/MotorStormRPC against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZoniBoy00%2FMotorStormRPC" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ZoniBoy00/MotorStormRPC [INFO] finished tweaking git repo https://github.com/ZoniBoy00/MotorStormRPC [INFO] tweaked toml for git repo https://github.com/ZoniBoy00/MotorStormRPC written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ZoniBoy00/MotorStormRPC on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ZoniBoy00/MotorStormRPC already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.10 [INFO] [stderr] Downloaded discord-rich-presence v0.2.5 [INFO] [stderr] Downloaded ratatui v0.26.3 [INFO] [stderr] Downloaded libc v0.2.179 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e8065f56bd05cc48ace757a1ce927ef855ee333d4bdc6bbd0ae258faff729fe [INFO] running `Command { std: "docker" "start" "-a" "3e8065f56bd05cc48ace757a1ce927ef855ee333d4bdc6bbd0ae258faff729fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e8065f56bd05cc48ace757a1ce927ef855ee333d4bdc6bbd0ae258faff729fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e8065f56bd05cc48ace757a1ce927ef855ee333d4bdc6bbd0ae258faff729fe", kill_on_drop: false }` [INFO] [stdout] 3e8065f56bd05cc48ace757a1ce927ef855ee333d4bdc6bbd0ae258faff729fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8db46f917ed818fee87ccc41a5e83de4561724292b210ea4949a433e744fa0ea [INFO] running `Command { std: "docker" "start" "-a" "8db46f917ed818fee87ccc41a5e83de4561724292b210ea4949a433e744fa0ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling proc-macro2 v1.0.104 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling zmij v1.0.10 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling winres v0.1.12 [INFO] [stderr] Compiling MotorStormRPC v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking discord-rich-presence v0.2.5 [INFO] [stdout] warning: unused import: `GAME_WINDOW_TITLES` [INFO] [stdout] --> src/modules/process.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::modules::config::{GAME_WINDOW_TITLES, PROCESS_NAMES}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GAME_WINDOW_TITLES` [INFO] [stdout] --> src/modules/process.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::modules::config::{GAME_WINDOW_TITLES, PROCESS_NAMES}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null_mut` [INFO] [stdout] --> src/modules/admin.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ptr::null_mut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null_mut` [INFO] [stdout] --> src/modules/admin.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ptr::null_mut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/process.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut found_game = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/process.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut matched_title = None; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/modules/process.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | for (pid, process) in self.sys.processes() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/process.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut found_game = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/process.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut matched_title = None; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pid` [INFO] [stdout] --> src/modules/process.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | for (pid, process) in self.sys.processes() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/modules/window.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn set_console_title(title: &str) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GAME_WINDOW_TITLES` is never used [INFO] [stdout] --> src/modules/config.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub const GAME_WINDOW_TITLES: &[&str] = &[ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/utils.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 61 | } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if !(!state.game_running || found_rpcs3 && found_game) { [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if !found_rpcs3 && state.game_running || state.game_running && !found_game { [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if (!found_game || !found_rpcs3) && state.game_running { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/modules/utils.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | if let Ok(_) = discord.connect() { [INFO] [stdout] | -------^^^^^-------------------- help: try: `if discord.connect().is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 39 | let res = run_tui(app_state, running.clone()); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 40 | [INFO] [stdout] 41 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 39 ~ [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ run_tui(app_state, running.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(_) = modules::admin::run_as_admin() { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if modules::admin::run_as_admin().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/modules/window.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn set_console_title(title: &str) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GAME_WINDOW_TITLES` is never used [INFO] [stdout] --> src/modules/config.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub const GAME_WINDOW_TITLES: &[&str] = &[ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/utils.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 61 | } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if !(!state.game_running || found_rpcs3 && found_game) { [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if !found_rpcs3 && state.game_running || state.game_running && !found_game { [INFO] [stdout] | [INFO] [stdout] 61 - } else if (!found_rpcs3 && state.game_running) || (!found_game && state.game_running && found_rpcs3) { [INFO] [stdout] 61 + } else if (!found_game || !found_rpcs3) && state.game_running { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/modules/utils.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | if let Ok(_) = discord.connect() { [INFO] [stdout] | -------^^^^^-------------------- help: try: `if discord.connect().is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 39 | let res = run_tui(app_state, running.clone()); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 40 | [INFO] [stdout] 41 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 39 ~ [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ run_tui(app_state, running.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(_) = modules::admin::run_as_admin() { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if modules::admin::run_as_admin().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.13s [INFO] running `Command { std: "docker" "inspect" "8db46f917ed818fee87ccc41a5e83de4561724292b210ea4949a433e744fa0ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8db46f917ed818fee87ccc41a5e83de4561724292b210ea4949a433e744fa0ea", kill_on_drop: false }` [INFO] [stdout] 8db46f917ed818fee87ccc41a5e83de4561724292b210ea4949a433e744fa0ea