[INFO] cloning repository https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhukDmitryOlegovich%2Fcompiler-labs-lab4", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhukDmitryOlegovich%2Fcompiler-labs-lab4'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 516c59b4fc1d99501f6409ee3ae3272b0cf24fc1 [INFO] linting ZhukDmitryOlegovich/compiler-labs-lab4 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhukDmitryOlegovich%2Fcompiler-labs-lab4" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 [INFO] finished tweaking git repo https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 [INFO] tweaked toml for git repo https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ZhukDmitryOlegovich/compiler-labs-lab4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32e21d63a35e3c995b2b3ea71f582b28710660520606e2a14739c38c73161911 [INFO] running `Command { std: "docker" "start" "-a" "32e21d63a35e3c995b2b3ea71f582b28710660520606e2a14739c38c73161911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32e21d63a35e3c995b2b3ea71f582b28710660520606e2a14739c38c73161911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32e21d63a35e3c995b2b3ea71f582b28710660520606e2a14739c38c73161911", kill_on_drop: false }` [INFO] [stdout] 32e21d63a35e3c995b2b3ea71f582b28710660520606e2a14739c38c73161911 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ffcb1d0fa297ac8c2cb20d42753c7149a07736fe748d6b0b84a3d492a420774 [INFO] running `Command { std: "docker" "start" "-a" "2ffcb1d0fa297ac8c2cb20d42753c7149a07736fe748d6b0b84a3d492a420774", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking lab4 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the `x @ _` pattern can be written as just `x` [INFO] [stdout] --> main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | x @ _ => x, [INFO] [stdout] | ^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `x @ _` pattern can be written as just `x` [INFO] [stdout] --> main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | x @ _ => x, [INFO] [stdout] | ^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> main.rs:153:39 [INFO] [stdout] | [INFO] [stdout] 153 | Some(x) if x.is_alphabetic() || x.is_digit(10) => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> main.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | TokenType::Spaces(_) if !env::var("NEED_SPACES").is_ok() => self.next(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("NEED_SPACES").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> main.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | } else if !env::var("SKIP_EOF").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("SKIP_EOF").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> main.rs:153:39 [INFO] [stdout] | [INFO] [stdout] 153 | Some(x) if x.is_alphabetic() || x.is_digit(10) => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> main.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | TokenType::Spaces(_) if !env::var("NEED_SPACES").is_ok() => self.next(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("NEED_SPACES").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> main.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | } else if !env::var("SKIP_EOF").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("SKIP_EOF").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> main.rs:258:46 [INFO] [stdout] | [INFO] [stdout] 258 | TokenType::Key(num) => ("KEY".yellow(), format!("{}", num).yellow()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `num.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> main.rs:258:46 [INFO] [stdout] | [INFO] [stdout] 258 | TokenType::Key(num) => ("KEY".yellow(), format!("{}", num).yellow()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `num.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `Command { std: "docker" "inspect" "2ffcb1d0fa297ac8c2cb20d42753c7149a07736fe748d6b0b84a3d492a420774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ffcb1d0fa297ac8c2cb20d42753c7149a07736fe748d6b0b84a3d492a420774", kill_on_drop: false }` [INFO] [stdout] 2ffcb1d0fa297ac8c2cb20d42753c7149a07736fe748d6b0b84a3d492a420774