[INFO] cloning repository https://github.com/YouSafe/gda-testing [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YouSafe/gda-testing" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouSafe%2Fgda-testing", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouSafe%2Fgda-testing'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c70385c7d46568311dc9c7aad8f9328ffacccca3 [INFO] linting YouSafe/gda-testing against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouSafe%2Fgda-testing" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/YouSafe/gda-testing [INFO] finished tweaking git repo https://github.com/YouSafe/gda-testing [INFO] tweaked toml for git repo https://github.com/YouSafe/gda-testing written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/YouSafe/gda-testing on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/YouSafe/gda-testing already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded winsplit v0.1.0 [INFO] [stderr] Downloaded petgraph-gen v0.2.0 [INFO] [stderr] Downloaded numeric-sort v0.1.4 [INFO] [stderr] Downloaded ctrlc v3.4.6 [INFO] [stderr] Downloaded clap v4.5.36 [INFO] [stderr] Downloaded handlebars v4.5.0 [INFO] [stderr] Downloaded clap_builder v4.5.36 [INFO] [stderr] Downloaded smol v2.0.2 [INFO] [stderr] Downloaded charming v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 083745bc66550efd7474e3bc79c375f6d9022008961ed9785f60dd7609a6720c [INFO] running `Command { std: "docker" "start" "-a" "083745bc66550efd7474e3bc79c375f6d9022008961ed9785f60dd7609a6720c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "083745bc66550efd7474e3bc79c375f6d9022008961ed9785f60dd7609a6720c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "083745bc66550efd7474e3bc79c375f6d9022008961ed9785f60dd7609a6720c", kill_on_drop: false }` [INFO] [stdout] 083745bc66550efd7474e3bc79c375f6d9022008961ed9785f60dd7609a6720c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8441fba04ed3bfe73dc39776da6aa3d070ab69bb4832cbd9d8edc191541996f [INFO] running `Command { std: "docker" "start" "-a" "a8441fba04ed3bfe73dc39776da6aa3d070ab69bb4832cbd9d8edc191541996f", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking indexmap v2.8.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking clap_builder v4.5.36 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling pest v2.8.0 [INFO] [stderr] Checking petgraph v0.7.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pest_meta v2.8.0 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking clap v4.5.36 [INFO] [stderr] Checking numeric-sort v0.1.4 [INFO] [stderr] Checking petgraph-gen v0.2.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking winsplit v0.1.0 [INFO] [stderr] Checking ctrlc v3.4.6 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Compiling pest_generator v2.8.0 [INFO] [stderr] Compiling pest_derive v2.8.0 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking smol v2.0.2 [INFO] [stderr] Checking handlebars v4.5.0 [INFO] [stderr] Checking charming v0.4.0 [INFO] [stderr] Checking gda_testing v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> src/cli.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Args, Parser, Subcommand, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> src/cli.rs:2:38 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Args, Parser, Subcommand, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/comparer/compare_mode.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 54 | nodes: (0..graph.node_count()) [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | .into_iter() [INFO] [stdout] | |________________________________^ help: consider removing `.into_iter()`: `(0..graph.node_count())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/comparer/compare_mode.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graph.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return input_edges == output_edges; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return input_edges == output_edges; [INFO] [stdout] 222 + input_edges == output_edges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graph.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | return ((n - a) * (y - m)).cmp(&((m - b) * (x - n))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 240 - return ((n - a) * (y - m)).cmp(&((m - b) * (x - n))); [INFO] [stdout] 240 + ((n - a) * (y - m)).cmp(&((m - b) * (x - n))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:66:61 [INFO] [stdout] | [INFO] [stdout] 66 | .skip_while(|(_, (_, name))| !name.contains(&skip_to)) [INFO] [stdout] | ^^^^^^^^ help: change this to: `skip_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:148:31 [INFO] [stdout] | [INFO] [stdout] 148 | path.push(&team_name.trim_start_matches('/')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `team_name.trim_start_matches('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 149 | path.push(&graph_name.trim_start_matches('/')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `graph_name.trim_start_matches('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/leaderboard/plots.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|max_per_edge| (graph_ids[&v.graph] as usize, max_per_edge)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph_ids[&v.graph]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/leaderboard/stats.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(self.0.flush()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 54 - Ok(self.0.flush()?) [INFO] [stdout] 54 + self.0.flush() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/optimizer_protocol.rs:34:36 [INFO] [stdout] | [INFO] [stdout] 34 | let command = shlex::split(&command).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimizer_protocol.rs:41:43 [INFO] [stdout] | [INFO] [stdout] 41 | .args(command[1..].iter().map(|v| std::ffi::OsStr::new(v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `std::ffi::OsStr::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn redirect_stderr(&mut self) -> impl Future> + Send + use<> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn write_graph(&mut self, graph: &Graph) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn write_graph_bytes(&mut self, graph: &[u8]) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn write_graph_bytes(&mut self, graph: &[u8]) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] = note: `#[warn(clippy::manual_async_fn)]` on by default [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 109 ~ pub async fn write_graph_bytes(&mut self, graph: &[u8]) -> io::Result<()> { [INFO] [stdout] 110 + self.stdin.write_all(&graph).await?; [INFO] [stdout] 111 + self.stdin.write_all(b"\n").await?; [INFO] [stdout] 112 + self.stdin.flush().await?; [INFO] [stdout] 113 + Ok(()) [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/optimizer_protocol.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | self.stdin.write_all(&graph).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `graph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_response(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/optimizer_protocol.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn read_start(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn read_start(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 160 ~ pub async fn read_start(&mut self) -> io::Result { [INFO] [stdout] 161 + match self.read_response().await? { [INFO] [stdout] 162 + OptimizerResponse::Start { name } => Ok(name), [INFO] [stdout] 163 + response => Err(io::Error::new( [INFO] [stdout] 164 + io::ErrorKind::InvalidData, [INFO] [stdout] 165 + format!("expected start, but got {:?}", response), [INFO] [stdout] 166 + )), [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn read_graph(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn read_graph(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 173 ~ pub async fn read_graph(&mut self) -> io::Result { [INFO] [stdout] 174 + match self.read_response().await? { [INFO] [stdout] 175 + OptimizerResponse::Graph { graph } => Ok(graph), [INFO] [stdout] 176 + response => Err(io::Error::new( [INFO] [stdout] 177 + io::ErrorKind::InvalidData, [INFO] [stdout] 178 + format!("expected graph, but got {:?}", response), [INFO] [stdout] 179 + )), [INFO] [stdout] 180 + } [INFO] [stdout] 181 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_graph_request(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_graph_request(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 186 ~ pub async fn read_graph_request(&mut self) -> io::Result<()> { [INFO] [stdout] 187 + match self.read_response().await? { [INFO] [stdout] 188 + OptimizerResponse::GraphRequest => Ok(()), [INFO] [stdout] 189 + response => Err(io::Error::new( [INFO] [stdout] 190 + io::ErrorKind::InvalidData, [INFO] [stdout] 191 + format!("expected graph request, but got {:?}", response), [INFO] [stdout] 192 + )), [INFO] [stdout] 193 + } [INFO] [stdout] 194 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/optimizer_protocol.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | Some(&text[pattern.len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/optimizer_protocol.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | if text.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 201 ~ if let Some() = text.strip_prefix(pattern) { [INFO] [stdout] 202 ~ Some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | while !ctrl_c.recv().await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ctrl_c.recv().await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/comparer/compare_mode.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 54 | nodes: (0..graph.node_count()) [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | .into_iter() [INFO] [stdout] | |________________________________^ help: consider removing `.into_iter()`: `(0..graph.node_count())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/comparer/compare_mode.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graph.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return input_edges == output_edges; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return input_edges == output_edges; [INFO] [stdout] 222 + input_edges == output_edges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graph.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | return ((n - a) * (y - m)).cmp(&((m - b) * (x - n))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 240 - return ((n - a) * (y - m)).cmp(&((m - b) * (x - n))); [INFO] [stdout] 240 + ((n - a) * (y - m)).cmp(&((m - b) * (x - n))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:66:61 [INFO] [stdout] | [INFO] [stdout] 66 | .skip_while(|(_, (_, name))| !name.contains(&skip_to)) [INFO] [stdout] | ^^^^^^^^ help: change this to: `skip_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:148:31 [INFO] [stdout] | [INFO] [stdout] 148 | path.push(&team_name.trim_start_matches('/')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `team_name.trim_start_matches('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/graphs_runner.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 149 | path.push(&graph_name.trim_start_matches('/')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `graph_name.trim_start_matches('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/leaderboard/plots.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|max_per_edge| (graph_ids[&v.graph] as usize, max_per_edge)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph_ids[&v.graph]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/leaderboard/stats.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(self.0.flush()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 54 - Ok(self.0.flush()?) [INFO] [stdout] 54 + self.0.flush() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/optimizer_protocol.rs:34:36 [INFO] [stdout] | [INFO] [stdout] 34 | let command = shlex::split(&command).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/optimizer_protocol.rs:41:43 [INFO] [stdout] | [INFO] [stdout] 41 | .args(command[1..].iter().map(|v| std::ffi::OsStr::new(v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `std::ffi::OsStr::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn redirect_stderr(&mut self) -> impl Future> + Send + use<> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] = note: `#[warn(clippy::double_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn write_graph(&mut self, graph: &Graph) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn write_graph_bytes(&mut self, graph: &[u8]) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn write_graph_bytes(&mut self, graph: &[u8]) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] = note: `#[warn(clippy::manual_async_fn)]` on by default [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 109 ~ pub async fn write_graph_bytes(&mut self, graph: &[u8]) -> io::Result<()> { [INFO] [stdout] 110 + self.stdin.write_all(&graph).await?; [INFO] [stdout] 111 + self.stdin.write_all(b"\n").await?; [INFO] [stdout] 112 + self.stdin.flush().await?; [INFO] [stdout] 113 + Ok(()) [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/optimizer_protocol.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | self.stdin.write_all(&graph).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `graph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_response(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/optimizer_protocol.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn read_start(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn read_start(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 160 ~ pub async fn read_start(&mut self) -> io::Result { [INFO] [stdout] 161 + match self.read_response().await? { [INFO] [stdout] 162 + OptimizerResponse::Start { name } => Ok(name), [INFO] [stdout] 163 + response => Err(io::Error::new( [INFO] [stdout] 164 + io::ErrorKind::InvalidData, [INFO] [stdout] 165 + format!("expected start, but got {:?}", response), [INFO] [stdout] 166 + )), [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn read_graph(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn read_graph(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 173 ~ pub async fn read_graph(&mut self) -> io::Result { [INFO] [stdout] 174 + match self.read_response().await? { [INFO] [stdout] 175 + OptimizerResponse::Graph { graph } => Ok(graph), [INFO] [stdout] 176 + response => Err(io::Error::new( [INFO] [stdout] 177 + io::ErrorKind::InvalidData, [INFO] [stdout] 178 + format!("expected graph, but got {:?}", response), [INFO] [stdout] 179 + )), [INFO] [stdout] 180 + } [INFO] [stdout] 181 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]` [INFO] [stdout] --> src/optimizer_protocol.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_graph_request(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: either add some descriptive message or remove the attribute [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function can be simplified using the `async fn` syntax [INFO] [stdout] --> src/optimizer_protocol.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn read_graph_request(&mut self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_async_fn [INFO] [stdout] help: make the function `async` and return the output of the future directly [INFO] [stdout] | [INFO] [stdout] 186 ~ pub async fn read_graph_request(&mut self) -> io::Result<()> { [INFO] [stdout] 187 + match self.read_response().await? { [INFO] [stdout] 188 + OptimizerResponse::GraphRequest => Ok(()), [INFO] [stdout] 189 + response => Err(io::Error::new( [INFO] [stdout] 190 + io::ErrorKind::InvalidData, [INFO] [stdout] 191 + format!("expected graph request, but got {:?}", response), [INFO] [stdout] 192 + )), [INFO] [stdout] 193 + } [INFO] [stdout] 194 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/optimizer_protocol.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | Some(&text[pattern.len()..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/optimizer_protocol.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | if text.starts_with(pattern) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 201 ~ if let Some() = text.strip_prefix(pattern) { [INFO] [stdout] 202 ~ Some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 73 | while !ctrl_c.recv().await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ctrl_c.recv().await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.13s [INFO] running `Command { std: "docker" "inspect" "a8441fba04ed3bfe73dc39776da6aa3d070ab69bb4832cbd9d8edc191541996f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8441fba04ed3bfe73dc39776da6aa3d070ab69bb4832cbd9d8edc191541996f", kill_on_drop: false }` [INFO] [stdout] a8441fba04ed3bfe73dc39776da6aa3d070ab69bb4832cbd9d8edc191541996f