[INFO] cloning repository https://github.com/Xyloz7/aoc-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Xyloz7/aoc-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXyloz7%2Faoc-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXyloz7%2Faoc-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d002a4053a4f69f756fca313f4b640f5235c8174 [INFO] linting Xyloz7/aoc-2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXyloz7%2Faoc-2023" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Xyloz7/aoc-2023 [INFO] finished tweaking git repo https://github.com/Xyloz7/aoc-2023 [INFO] tweaked toml for git repo https://github.com/Xyloz7/aoc-2023 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Xyloz7/aoc-2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Xyloz7/aoc-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.10.1 [INFO] [stderr] Downloaded rustix v0.38.26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6989b5a465ca8bf80801064e6d2825712272579575f2b2bb21f381b093cd4448 [INFO] running `Command { std: "docker" "start" "-a" "6989b5a465ca8bf80801064e6d2825712272579575f2b2bb21f381b093cd4448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6989b5a465ca8bf80801064e6d2825712272579575f2b2bb21f381b093cd4448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6989b5a465ca8bf80801064e6d2825712272579575f2b2bb21f381b093cd4448", kill_on_drop: false }` [INFO] [stdout] 6989b5a465ca8bf80801064e6d2825712272579575f2b2bb21f381b093cd4448 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 273fe45d41a8742059527b690ab650b4f532fcc296e10e11686c4799d495f5cc [INFO] running `Command { std: "docker" "start" "-a" "273fe45d41a8742059527b690ab650b4f532fcc296e10e11686c4799d495f5cc", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking aoc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/days/daythree.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn is_valid(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 118 - fn is_valid(self: &Self) -> bool { [INFO] [stdout] 118 + fn is_valid(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/days/daythree.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 121 | fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 121 - fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] 121 + fn ratio(&self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/days/daythree.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn is_valid(self: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 118 - fn is_valid(self: &Self) -> bool { [INFO] [stdout] 118 + fn is_valid(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/days/daythree.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 121 | fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 121 - fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] 121 + fn ratio(&self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/days/dayfour.rs:74:56 [INFO] [stdout] | [INFO] [stdout] 74 | card_count.entry(key).and_modify(|x| *x += 1 * copies); [INFO] [stdout] | ^^^^^^^^^^ help: consider reducing it to: `copies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/days/dayone.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | let last_ = digits.last().unwrap_or(first_); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - let last_ = digits.last().unwrap_or(first_); [INFO] [stdout] 6 + let last_ = digits.next_back().unwrap_or(first_); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/daythree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if character.is_digit(10) && !making_number { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/daythree.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if character.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/daythree.rs:92:48 [INFO] [stdout] | [INFO] [stdout] 92 | if !character.is_alphanumeric() && !(character == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/days/daythree.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | / co_ord_to_part_map [INFO] [stdout] 99 | | .get(&p) [INFO] [stdout] 100 | | .and_then(|x| Some(indices_to_sum.insert(*x))); [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ co_ord_to_part_map [INFO] [stdout] 99 ~ .get(&p).map(|x| indices_to_sum.insert(*x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/daythree.rs:121:42 [INFO] [stdout] | [INFO] [stdout] 121 | fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] 121 + fn ratio(self: &Self, index_to_part: &[Part]) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/days/daythree.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | / co_ord_to_part_map [INFO] [stdout] 164 | | .get(&p) [INFO] [stdout] 165 | | .and_then(|x| Some(current_gear.adjacent_part_indices.insert(*x))); [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ co_ord_to_part_map [INFO] [stdout] 164 ~ .get(&p).map(|x| current_gear.adjacent_part_indices.insert(*x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/days/dayfour.rs:74:56 [INFO] [stdout] | [INFO] [stdout] 74 | card_count.entry(key).and_modify(|x| *x += 1 * copies); [INFO] [stdout] | ^^^^^^^^^^ help: consider reducing it to: `copies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/days/dayone.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | let last_ = digits.last().unwrap_or(first_); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - let last_ = digits.last().unwrap_or(first_); [INFO] [stdout] 6 + let last_ = digits.next_back().unwrap_or(first_); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/daythree.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if character.is_digit(10) && !making_number { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/daythree.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if character.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/daythree.rs:92:48 [INFO] [stdout] | [INFO] [stdout] 92 | if !character.is_alphanumeric() && !(character == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/days/daythree.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | / co_ord_to_part_map [INFO] [stdout] 99 | | .get(&p) [INFO] [stdout] 100 | | .and_then(|x| Some(indices_to_sum.insert(*x))); [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ co_ord_to_part_map [INFO] [stdout] 99 ~ .get(&p).map(|x| indices_to_sum.insert(*x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/daythree.rs:121:42 [INFO] [stdout] | [INFO] [stdout] 121 | fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - fn ratio(self: &Self, index_to_part: &Vec) -> u32 { [INFO] [stdout] 121 + fn ratio(self: &Self, index_to_part: &[Part]) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/days/daythree.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | / co_ord_to_part_map [INFO] [stdout] 164 | | .get(&p) [INFO] [stdout] 165 | | .and_then(|x| Some(current_gear.adjacent_part_indices.insert(*x))); [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ co_ord_to_part_map [INFO] [stdout] 164 ~ .get(&p).map(|x| current_gear.adjacent_part_indices.insert(*x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.96s [INFO] running `Command { std: "docker" "inspect" "273fe45d41a8742059527b690ab650b4f532fcc296e10e11686c4799d495f5cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "273fe45d41a8742059527b690ab650b4f532fcc296e10e11686c4799d495f5cc", kill_on_drop: false }` [INFO] [stdout] 273fe45d41a8742059527b690ab650b4f532fcc296e10e11686c4799d495f5cc