[INFO] cloning repository https://github.com/XRayAdams/loremgenerator-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/XRayAdams/loremgenerator-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXRayAdams%2Floremgenerator-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXRayAdams%2Floremgenerator-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 912e3fb16ea2af11c6246b9ba6bbbd2aea9d4e2c [INFO] linting XRayAdams/loremgenerator-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXRayAdams%2Floremgenerator-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/XRayAdams/loremgenerator-rs [INFO] finished tweaking git repo https://github.com/XRayAdams/loremgenerator-rs [INFO] tweaked toml for git repo https://github.com/XRayAdams/loremgenerator-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/XRayAdams/loremgenerator-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/XRayAdams/loremgenerator-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tracker-macros v0.2.2 [INFO] [stderr] Downloaded tracker v0.2.2 [INFO] [stderr] Downloaded itoa v1.0.16 [INFO] [stderr] Downloaded relm4-css v0.10.1 [INFO] [stderr] Downloaded relm4-macros v0.10.1 [INFO] [stderr] Downloaded temp-dir v0.1.16 [INFO] [stderr] Downloaded graphene-sys v0.21.5 [INFO] [stderr] Downloaded relm4-components v0.10.1 [INFO] [stderr] Downloaded locale_config v0.3.0 [INFO] [stderr] Downloaded libadwaita-sys v0.8.1 [INFO] [stderr] Downloaded target-lexicon v0.13.3 [INFO] [stderr] Downloaded pango-sys v0.21.5 [INFO] [stderr] Downloaded cairo-rs v0.21.5 [INFO] [stderr] Downloaded clap v4.5.56 [INFO] [stderr] Downloaded gdk4 v0.10.3 [INFO] [stderr] Downloaded clap_builder v4.5.56 [INFO] [stderr] Downloaded glib-sys v0.21.5 [INFO] [stderr] Downloaded gio-sys v0.21.5 [INFO] [stderr] Downloaded gtk4-sys v0.10.3 [INFO] [stderr] Downloaded gdk4-sys v0.10.3 [INFO] [stderr] Downloaded gio v0.21.5 [INFO] [stderr] Downloaded libadwaita v0.8.1 [INFO] [stderr] Downloaded glib-macros v0.21.5 [INFO] [stderr] Downloaded serde_json v1.0.147 [INFO] [stderr] Downloaded toml v0.9.10+spec-1.1.0 [INFO] [stderr] Downloaded relm4 v0.10.1 [INFO] [stderr] Downloaded flume v0.12.0 [INFO] [stderr] Downloaded gsk4-sys v0.10.3 [INFO] [stderr] Downloaded glib v0.21.5 [INFO] [stderr] Downloaded cfg-expr v0.20.5 [INFO] [stderr] Downloaded pango v0.21.5 [INFO] [stderr] Downloaded gsk4 v0.10.3 [INFO] [stderr] Downloaded gettext-rs v0.7.7 [INFO] [stderr] Downloaded gdk-pixbuf v0.21.5 [INFO] [stderr] Downloaded graphene-rs v0.21.5 [INFO] [stderr] Downloaded gtk4-macros v0.10.3 [INFO] [stderr] Downloaded gobject-sys v0.21.5 [INFO] [stderr] Downloaded system-deps v7.0.7 [INFO] [stderr] Downloaded objc-foundation v0.1.1 [INFO] [stderr] Downloaded cairo-sys-rs v0.21.5 [INFO] [stderr] Downloaded gtk4 v0.10.3 [INFO] [stderr] Downloaded gdk-pixbuf-sys v0.21.5 [INFO] [stderr] Downloaded zmij v0.1.7 [INFO] [stderr] Downloaded gettext-sys v0.26.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5885d86d1f054f841a2e93fad94b7882f711f38eb49eb7241265e1b28458ef2a [INFO] running `Command { std: "docker" "start" "-a" "5885d86d1f054f841a2e93fad94b7882f711f38eb49eb7241265e1b28458ef2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5885d86d1f054f841a2e93fad94b7882f711f38eb49eb7241265e1b28458ef2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5885d86d1f054f841a2e93fad94b7882f711f38eb49eb7241265e1b28458ef2a", kill_on_drop: false }` [INFO] [stdout] 5885d86d1f054f841a2e93fad94b7882f711f38eb49eb7241265e1b28458ef2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58ba845e5ce572d08f24f2ce1c184c8f838f3602a3168e983ff020c1e2015ef2 [INFO] running `Command { std: "docker" "start" "-a" "58ba845e5ce572d08f24f2ce1c184c8f838f3602a3168e983ff020c1e2015ef2", kill_on_drop: false }` [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling target-lexicon v0.13.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling serde_spanned v1.0.4 [INFO] [stderr] Compiling version-compare v0.2.1 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling equivalent v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Compiling cfg-expr v0.20.5 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Compiling relm4-css v0.10.1 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling temp-dir v0.1.16 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling toml v0.9.10+spec-1.1.0 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling system-deps v7.0.7 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking flume v0.12.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling gettext-sys v0.26.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Compiling serde_json v1.0.147 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling glib-sys v0.21.5 [INFO] [stderr] Compiling gobject-sys v0.21.5 [INFO] [stderr] Compiling gio-sys v0.21.5 [INFO] [stderr] Compiling cairo-sys-rs v0.21.5 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.21.5 [INFO] [stderr] Compiling pango-sys v0.21.5 [INFO] [stderr] Compiling gdk4-sys v0.10.3 [INFO] [stderr] Compiling graphene-sys v0.21.5 [INFO] [stderr] Compiling gsk4-sys v0.10.3 [INFO] [stderr] Compiling gtk4-sys v0.10.3 [INFO] [stderr] Compiling libadwaita-sys v0.8.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fragile v2.0.1 [INFO] [stderr] Checking clap_builder v4.5.56 [INFO] [stderr] Compiling loremgenerator v2.4.9+45 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> build.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / for entry in entries { [INFO] [stdout] 52 | | if let Ok(entry) = entry { [INFO] [stdout] 53 | | let path = entry.path(); [INFO] [stdout] 54 | | if path.extension().and_then(|s| s.to_str()) == Some("po") { [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> build.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Ok(entry) = entry { [INFO] [stdout] 53 | | let path = entry.path(); [INFO] [stdout] 54 | | if path.extension().and_then(|s| s.to_str()) == Some("po") { [INFO] [stdout] 55 | | if let Some(lang) = path.file_stem().and_then(|s| s.to_str()) { [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ for entry in entries.flatten() { [INFO] [stdout] 52 + let path = entry.path(); [INFO] [stdout] 53 + if path.extension().and_then(|s| s.to_str()) == Some("po") { [INFO] [stdout] 54 + if let Some(lang) = path.file_stem().and_then(|s| s.to_str()) { [INFO] [stdout] 55 + // Skip the template file [INFO] [stdout] 56 + if lang.ends_with(".pot") || lang == "loremgenerator" { [INFO] [stdout] 57 + continue; [INFO] [stdout] 58 + } [INFO] [stdout] 59 + [INFO] [stdout] 60 + compile_po_file(&path, lang, dest_path); [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> build.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | / if path.extension().and_then(|s| s.to_str()) == Some("po") { [INFO] [stdout] 55 | | if let Some(lang) = path.file_stem().and_then(|s| s.to_str()) { [INFO] [stdout] 56 | | // Skip the template file [INFO] [stdout] 57 | | if lang.ends_with(".pot") || lang == "loremgenerator" { [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if path.extension().and_then(|s| s.to_str()) == Some("po") [INFO] [stdout] 55 ~ && let Some(lang) = path.file_stem().and_then(|s| s.to_str()) { [INFO] [stdout] 56 | // Skip the template file [INFO] [stdout] ... [INFO] [stdout] 61 | compile_po_file(&path, lang, dest_path); [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking zmij v0.1.7 [INFO] [stderr] Checking itoa v1.0.16 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling glib-macros v0.21.5 [INFO] [stderr] Compiling gtk4-macros v0.10.3 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tracker-macros v0.2.2 [INFO] [stderr] Compiling relm4-macros v0.10.1 [INFO] [stderr] Checking locale_config v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tracker v0.2.2 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking gettext-rs v0.7.7 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking clap v4.5.56 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking glib v0.21.5 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking gio v0.21.5 [INFO] [stderr] Checking cairo-rs v0.21.5 [INFO] [stderr] Checking graphene-rs v0.21.5 [INFO] [stderr] Checking pango v0.21.5 [INFO] [stderr] Checking gdk-pixbuf v0.21.5 [INFO] [stderr] Checking gdk4 v0.10.3 [INFO] [stderr] Checking gsk4 v0.10.3 [INFO] [stderr] Checking gtk4 v0.10.3 [INFO] [stderr] Checking libadwaita v0.8.1 [INFO] [stderr] Checking relm4 v0.10.1 [INFO] [stderr] Checking relm4-components v0.10.1 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers/generator.rs:19:46 [INFO] [stdout] | [INFO] [stdout] 19 | let word = if i2 == 0 && (!start_with_lorem || (start_with_lorem && (i > 0 || (i == 0 && j > 0)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!start_with_lorem || i > 0 || i == 0 && j > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helpers/actions.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | .application_name(&gettext("Lorem Ipsum Generator")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gettext("Lorem Ipsum Generator")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/i18n.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / if let Ok(exe_path) = std::env::current_exe() { [INFO] [stdout] 39 | | if let Some(exe_dir) = exe_path.parent() { [INFO] [stdout] 40 | | let dev_locale = exe_dir.join("locale"); [INFO] [stdout] 41 | | if dev_locale.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 38 ~ if let Ok(exe_path) = std::env::current_exe() [INFO] [stdout] 39 ~ && let Some(exe_dir) = exe_path.parent() { [INFO] [stdout] 40 | let dev_locale = exe_dir.join("locale"); [INFO] [stdout] ... [INFO] [stdout] 43 | } [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / if let Ok(content) = fs::read_to_string(path) { [INFO] [stdout] 90 | | if let Ok(settings) = serde_json::from_str::(&content) { [INFO] [stdout] 91 | | return settings; [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Ok(content) = fs::read_to_string(path) [INFO] [stdout] 90 ~ && let Ok(settings) = serde_json::from_str::(&content) { [INFO] [stdout] 91 | return settings; [INFO] [stdout] 92 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:185:37 [INFO] [stdout] | [INFO] [stdout] 185 | ... let _ = sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 185 - let _ = sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] 185 + sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers/generator.rs:19:46 [INFO] [stdout] | [INFO] [stdout] 19 | let word = if i2 == 0 && (!start_with_lorem || (start_with_lorem && (i > 0 || (i == 0 && j > 0)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!start_with_lorem || i > 0 || i == 0 && j > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helpers/actions.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | .application_name(&gettext("Lorem Ipsum Generator")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gettext("Lorem Ipsum Generator")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/i18n.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / if let Ok(exe_path) = std::env::current_exe() { [INFO] [stdout] 39 | | if let Some(exe_dir) = exe_path.parent() { [INFO] [stdout] 40 | | let dev_locale = exe_dir.join("locale"); [INFO] [stdout] 41 | | if dev_locale.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 38 ~ if let Ok(exe_path) = std::env::current_exe() [INFO] [stdout] 39 ~ && let Some(exe_dir) = exe_path.parent() { [INFO] [stdout] 40 | let dev_locale = exe_dir.join("locale"); [INFO] [stdout] ... [INFO] [stdout] 43 | } [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / if let Ok(content) = fs::read_to_string(path) { [INFO] [stdout] 90 | | if let Ok(settings) = serde_json::from_str::(&content) { [INFO] [stdout] 91 | | return settings; [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Ok(content) = fs::read_to_string(path) [INFO] [stdout] 90 ~ && let Ok(settings) = serde_json::from_str::(&content) { [INFO] [stdout] 91 | return settings; [INFO] [stdout] 92 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:185:37 [INFO] [stdout] | [INFO] [stdout] 185 | ... let _ = sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 185 - let _ = sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] 185 + sender.input(Messages::ToggleStartWithLorem(state)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 58s [INFO] running `Command { std: "docker" "inspect" "58ba845e5ce572d08f24f2ce1c184c8f838f3602a3168e983ff020c1e2015ef2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58ba845e5ce572d08f24f2ce1c184c8f838f3602a3168e983ff020c1e2015ef2", kill_on_drop: false }` [INFO] [stdout] 58ba845e5ce572d08f24f2ce1c184c8f838f3602a3168e983ff020c1e2015ef2