[INFO] cloning repository https://github.com/Winsalot/hecs_test_simulation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Winsalot/hecs_test_simulation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWinsalot%2Fhecs_test_simulation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWinsalot%2Fhecs_test_simulation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 472470628e1392b583593d496d9f9115c6dfe72d [INFO] linting Winsalot/hecs_test_simulation against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWinsalot%2Fhecs_test_simulation" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Winsalot/hecs_test_simulation [INFO] finished tweaking git repo https://github.com/Winsalot/hecs_test_simulation [INFO] tweaked toml for git repo https://github.com/Winsalot/hecs_test_simulation written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Winsalot/hecs_test_simulation on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Winsalot/hecs_test_simulation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hecs v0.2.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5c36d3adc7267192817df824446844f1c6ef763b1537ba31c2cb8289bc402da [INFO] running `Command { std: "docker" "start" "-a" "e5c36d3adc7267192817df824446844f1c6ef763b1537ba31c2cb8289bc402da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5c36d3adc7267192817df824446844f1c6ef763b1537ba31c2cb8289bc402da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5c36d3adc7267192817df824446844f1c6ef763b1537ba31c2cb8289bc402da", kill_on_drop: false }` [INFO] [stdout] e5c36d3adc7267192817df824446844f1c6ef763b1537ba31c2cb8289bc402da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd3c66689f1be153c82a861cf8d21d696bb1921c3a618ce235634b1c936a6f5e [INFO] running `Command { std: "docker" "start" "-a" "fd3c66689f1be153c82a861cf8d21d696bb1921c3a618ce235634b1c936a6f5e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Compiling hashbrown v0.7.2 [INFO] [stderr] Checking hecs v0.2.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking hecs_test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `spawn_enitites` is never used [INFO] [stdout] --> src/main.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn spawn_enitites(world: &mut World, n: usize){ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | return dx + dy [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return dx + dy [INFO] [stdout] 47 + dx + dy [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | if !closest_id.is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `closest_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:146:4 [INFO] [stdout] | [INFO] [stdout] 146 | hp1.hp = hp1.hp - dmg0.dmg; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hp1.hp -= dmg0.dmg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `to_remove` [INFO] [stdout] --> src/main.rs:166:11 [INFO] [stdout] | [INFO] [stdout] 166 | for i in 0..to_remove.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 166 - for i in 0..to_remove.len(){ [INFO] [stdout] 166 + for in &to_remove{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `spawn_enitites` is never used [INFO] [stdout] --> src/main.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn spawn_enitites(world: &mut World, n: usize){ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | return dx + dy [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return dx + dy [INFO] [stdout] 47 + dx + dy [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | if !closest_id.is_some(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `closest_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:146:4 [INFO] [stdout] | [INFO] [stdout] 146 | hp1.hp = hp1.hp - dmg0.dmg; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hp1.hp -= dmg0.dmg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `to_remove` [INFO] [stdout] --> src/main.rs:166:11 [INFO] [stdout] | [INFO] [stdout] 166 | for i in 0..to_remove.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 166 - for i in 0..to_remove.len(){ [INFO] [stdout] 166 + for in &to_remove{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.98s [INFO] running `Command { std: "docker" "inspect" "fd3c66689f1be153c82a861cf8d21d696bb1921c3a618ce235634b1c936a6f5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd3c66689f1be153c82a861cf8d21d696bb1921c3a618ce235634b1c936a6f5e", kill_on_drop: false }` [INFO] [stdout] fd3c66689f1be153c82a861cf8d21d696bb1921c3a618ce235634b1c936a6f5e