[INFO] cloning repository https://github.com/Willmo3/walc-model
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Willmo3/walc-model" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillmo3%2Fwalc-model", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillmo3%2Fwalc-model'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 27f3102ff739e016b6558f2c2c93a796edf75966
[INFO] linting Willmo3/walc-model against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillmo3%2Fwalc-model" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Willmo3/walc-model
[INFO] finished tweaking git repo https://github.com/Willmo3/walc-model
[INFO] tweaked toml for git repo https://github.com/Willmo3/walc-model written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Willmo3/walc-model on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Willmo3/walc-model already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a6e149a1b97c0ddbb8ca97b52e15dfaabbf5c8a51a9b8f2e3c079a730f7c1e8c
[INFO] running `Command { std: "docker" "start" "-a" "a6e149a1b97c0ddbb8ca97b52e15dfaabbf5c8a51a9b8f2e3c079a730f7c1e8c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a6e149a1b97c0ddbb8ca97b52e15dfaabbf5c8a51a9b8f2e3c079a730f7c1e8c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a6e149a1b97c0ddbb8ca97b52e15dfaabbf5c8a51a9b8f2e3c079a730f7c1e8c", kill_on_drop: false }`
[INFO] [stdout] a6e149a1b97c0ddbb8ca97b52e15dfaabbf5c8a51a9b8f2e3c079a730f7c1e8c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a8d8edff2b6b4a12785016101cb174b74c79b021127cbbefa7152de020f096fe
[INFO] running `Command { std: "docker" "start" "-a" "a8d8edff2b6b4a12785016101cb174b74c79b021127cbbefa7152de020f096fe", kill_on_drop: false }`
[INFO] [stderr]    Compiling syn v2.0.55
[INFO] [stderr]    Compiling serde_derive v1.0.197
[INFO] [stderr]     Checking serde v1.0.197
[INFO] [stderr]     Checking walc_model v0.5.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `DIVIDE` and `PUSH`
[INFO] [stdout]   --> src/vm/interpreter.rs:23:53
[INFO] [stdout]    |
[INFO] [stdout] 23 |     use crate::bytecode::opcode::Opcode::{VARWRITE, DIVIDE, MULTIPLY, PUSH, SUBTRACT, IDENTIFIER};
[INFO] [stdout]    |                                                     ^^^^^^            ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `IMM_LEN` is never used
[INFO] [stdout]  --> src/vm/interpreter.rs:4:7
[INFO] [stdout]   |
[INFO] [stdout] 4 | const IMM_LEN: usize = 8;
[INFO] [stdout]   |       ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `parent` is never read
[INFO] [stdout]  --> src/vm/scope_binding.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub(crate) struct Binding {
[INFO] [stdout]   |                   ------- field in this struct
[INFO] [stdout] 6 |     parent: Option<Box<Binding>>,
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_bind` is never used
[INFO] [stdout]   --> src/vm/scope_binding.rs:21:19
[INFO] [stdout]    |
[INFO] [stdout] 17 | impl Binding {
[INFO] [stdout]    | ------------ method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 21 |     pub(crate) fn get_bind(&self, binding_name: &str) -> Option<&f64> {
[INFO] [stdout]    |                   ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PUSH` contains a capitalized acronym
[INFO] [stdout]  --> src/bytecode/opcode.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     PUSH,
[INFO] [stdout]   |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `ADD` contains a capitalized acronym
[INFO] [stdout]  --> src/bytecode/opcode.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     ADD,
[INFO] [stdout]   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Add`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `SUBTRACT` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     SUBTRACT,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Subtract`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `MULTIPLY` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     MULTIPLY,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Multiply`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     DIVIDE,
[INFO] [stdout]    |     ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EXP` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     EXP,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Exp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     IDENTIFIER,
[INFO] [stdout]    |     ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `VARWRITE` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     VARWRITE,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Varwrite`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]   --> src/lib.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     pub mod ast;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]    = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `lexemes`
[INFO] [stdout]    --> src/frontend/parser.rs:322:13
[INFO] [stdout]     |
[INFO] [stdout] 322 |         let lexemes = lex(no_equals).unwrap();
[INFO] [stdout]     |             ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_lexemes`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `IMM_LEN` is never used
[INFO] [stdout]  --> src/vm/interpreter.rs:4:7
[INFO] [stdout]   |
[INFO] [stdout] 4 | const IMM_LEN: usize = 8;
[INFO] [stdout]   |       ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `parent` is never read
[INFO] [stdout]  --> src/vm/scope_binding.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub(crate) struct Binding {
[INFO] [stdout]   |                   ------- field in this struct
[INFO] [stdout] 6 |     parent: Option<Box<Binding>>,
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_bind` is never used
[INFO] [stdout]   --> src/vm/scope_binding.rs:21:19
[INFO] [stdout]    |
[INFO] [stdout] 17 | impl Binding {
[INFO] [stdout]    | ------------ method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 21 |     pub(crate) fn get_bind(&self, binding_name: &str) -> Option<&f64> {
[INFO] [stdout]    |                   ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PUSH` contains a capitalized acronym
[INFO] [stdout]  --> src/bytecode/opcode.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     PUSH,
[INFO] [stdout]   |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `ADD` contains a capitalized acronym
[INFO] [stdout]  --> src/bytecode/opcode.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     ADD,
[INFO] [stdout]   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Add`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `SUBTRACT` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     SUBTRACT,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Subtract`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `MULTIPLY` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     MULTIPLY,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Multiply`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     DIVIDE,
[INFO] [stdout]    |     ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EXP` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     EXP,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Exp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     IDENTIFIER,
[INFO] [stdout]    |     ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/ast/ast.rs:30:55
[INFO] [stdout]    |
[INFO] [stdout] 30 |     pub fn postorder_traverse<Visitor: FnMut(&ASTNode) -> ()>(&self, visit_fn: &mut Visitor) {
[INFO] [stdout]    |                                                       ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `VARWRITE` contains a capitalized acronym
[INFO] [stdout]   --> src/bytecode/opcode.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     VARWRITE,
[INFO] [stdout]    |     ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Varwrite`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/ast/ast.rs:45:18
[INFO] [stdout]    |
[INFO] [stdout] 45 |         visit_fn(&self);
[INFO] [stdout]    |                  ^^^^^ help: change this to: `self`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> src/frontend/lexer.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/frontend/lexer.rs:141:26
[INFO] [stdout]     |
[INFO] [stdout] 141 |         if chars.len() > u8::max_value() as usize {
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 141 -         if chars.len() > u8::max_value() as usize {
[INFO] [stdout] 141 +         if chars.len() > u8::MAX as usize {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/frontend/parser.rs:11:13
[INFO] [stdout]    |
[INFO] [stdout] 11 |     assert!(lexemes.len() > 0);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexemes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/frontend/parser.rs:91:16
[INFO] [stdout]    |
[INFO] [stdout] 91 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^ help: try: `left.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/frontend/parser.rs:91:34
[INFO] [stdout]    |
[INFO] [stdout] 91 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^^ help: try: `right.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/frontend/parser.rs:132:16
[INFO] [stdout]     |
[INFO] [stdout] 132 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^ help: try: `left.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/frontend/parser.rs:132:34
[INFO] [stdout]     |
[INFO] [stdout] 132 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^ help: try: `right.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]   --> src/lib.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     pub mod ast;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]    = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:36:38
[INFO] [stdout]    |
[INFO] [stdout] 36 |         Err(lex_error) => return Err(String::from(lex_error)),
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `lex_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:40:46
[INFO] [stdout]    |
[INFO] [stdout] 40 |         Some(Err(parse_error)) => return Err(String::from(parse_error)),
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `parse_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:46:35
[INFO] [stdout]    |
[INFO] [stdout] 46 |         Err(runtime_error) => Err(String::from(runtime_error))
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `runtime_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/ast/ast.rs:30:55
[INFO] [stdout]    |
[INFO] [stdout] 30 |     pub fn postorder_traverse<Visitor: FnMut(&ASTNode) -> ()>(&self, visit_fn: &mut Visitor) {
[INFO] [stdout]    |                                                       ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/ast/ast.rs:45:18
[INFO] [stdout]    |
[INFO] [stdout] 45 |         visit_fn(&self);
[INFO] [stdout]    |                  ^^^^^ help: change this to: `self`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> src/frontend/lexer.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/frontend/lexer.rs:141:26
[INFO] [stdout]     |
[INFO] [stdout] 141 |         if chars.len() > u8::max_value() as usize {
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 141 -         if chars.len() > u8::max_value() as usize {
[INFO] [stdout] 141 +         if chars.len() > u8::MAX as usize {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/frontend/parser.rs:11:13
[INFO] [stdout]    |
[INFO] [stdout] 11 |     assert!(lexemes.len() > 0);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexemes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/frontend/parser.rs:91:16
[INFO] [stdout]    |
[INFO] [stdout] 91 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^ help: try: `left.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/frontend/parser.rs:91:34
[INFO] [stdout]    |
[INFO] [stdout] 91 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^^ help: try: `right.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/frontend/parser.rs:132:16
[INFO] [stdout]     |
[INFO] [stdout] 132 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^ help: try: `left.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/frontend/parser.rs:132:34
[INFO] [stdout]     |
[INFO] [stdout] 132 |             if !left.is_err() && !right.is_err() {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^ help: try: `right.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:36:38
[INFO] [stdout]    |
[INFO] [stdout] 36 |         Err(lex_error) => return Err(String::from(lex_error)),
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `lex_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:40:46
[INFO] [stdout]    |
[INFO] [stdout] 40 |         Some(Err(parse_error)) => return Err(String::from(parse_error)),
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `parse_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/lib.rs:46:35
[INFO] [stdout]    |
[INFO] [stdout] 46 |         Err(runtime_error) => Err(String::from(runtime_error))
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `runtime_error`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.80s
[INFO] running `Command { std: "docker" "inspect" "a8d8edff2b6b4a12785016101cb174b74c79b021127cbbefa7152de020f096fe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a8d8edff2b6b4a12785016101cb174b74c79b021127cbbefa7152de020f096fe", kill_on_drop: false }`
[INFO] [stdout] a8d8edff2b6b4a12785016101cb174b74c79b021127cbbefa7152de020f096fe