[INFO] cloning repository https://github.com/WillFrancois/Tiny-Toml [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WillFrancois/Tiny-Toml" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillFrancois%2FTiny-Toml", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillFrancois%2FTiny-Toml'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0a5e102750eb6eba502b01179dd1d60201f0099e [INFO] linting WillFrancois/Tiny-Toml against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWillFrancois%2FTiny-Toml" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/WillFrancois/Tiny-Toml [INFO] finished tweaking git repo https://github.com/WillFrancois/Tiny-Toml [INFO] tweaked toml for git repo https://github.com/WillFrancois/Tiny-Toml written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/WillFrancois/Tiny-Toml on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/WillFrancois/Tiny-Toml already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9531639dfa660e92a9b8627ca2a352a5ece2d40034be5fc270123a6a8a683cd1 [INFO] running `Command { std: "docker" "start" "-a" "9531639dfa660e92a9b8627ca2a352a5ece2d40034be5fc270123a6a8a683cd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9531639dfa660e92a9b8627ca2a352a5ece2d40034be5fc270123a6a8a683cd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9531639dfa660e92a9b8627ca2a352a5ece2d40034be5fc270123a6a8a683cd1", kill_on_drop: false }` [INFO] [stdout] 9531639dfa660e92a9b8627ca2a352a5ece2d40034be5fc270123a6a8a683cd1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fd7faf73152350c4ca173bee44dccc34ae064ea8309c9fd74a83babecb23393 [INFO] running `Command { std: "docker" "start" "-a" "2fd7faf73152350c4ca173bee44dccc34ae064ea8309c9fd74a83babecb23393", kill_on_drop: false }` [INFO] [stderr] Checking toml_parse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `RefMut` [INFO] [stdout] --> src/grammar.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cell::{RefCell, RefMut}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | tag: tag, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | location: location, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | content: content, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RefMut` [INFO] [stdout] --> src/grammar.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cell::{RefCell, RefMut}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | tag: tag, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | location: location, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lexer.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | content: content, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `check_buffer` is never read [INFO] [stdout] --> src/lexer.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | check_buffer = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return GrammarNode { [INFO] [stdout] 15 | | valid_token_types: vec![], [INFO] [stdout] 16 | | neighbors: vec![], [INFO] [stdout] 17 | | side_effect: Box::new(|_| return true), [INFO] [stdout] 18 | | end_node: false, [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ GrammarNode { [INFO] [stdout] 15 + valid_token_types: vec![], [INFO] [stdout] 16 + neighbors: vec![], [INFO] [stdout] 17 + side_effect: Box::new(|_| return true), [INFO] [stdout] 18 + end_node: false, [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | side_effect: Box::new(|_| return true), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - side_effect: Box::new(|_| return true), [INFO] [stdout] 17 + side_effect: Box::new(|_| true), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/grammar.rs:22:77 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn add_valid_token_types(&mut self, token_types: Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self.valid_token_types.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self.valid_token_types.clone(); [INFO] [stdout] 27 + self.valid_token_types.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammars/comment.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | && !r.is_none() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `r.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammars/comment.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return false; [INFO] [stdout] 74 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `r.1` after checking its variant with `is_some` [INFO] [stdout] --> src/grammars/kv_pairing.rs:228:60 [INFO] [stdout] | [INFO] [stdout] 222 | if r.1.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = r.1` [INFO] [stdout] ... [INFO] [stdout] 228 | let next_pos = current_node.borrow().neighbors[r.1.unwrap().0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammars/kv_pairing.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return false; [INFO] [stdout] 254 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grammars/kv_pairing.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | / if let ref mut s = STACK { [INFO] [stdout] 196 | | if s.len() > 0 { [INFO] [stdout] 197 | | return false; [INFO] [stdout] 198 | | } [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 195 ~ if let ref mut s = STACK [INFO] [stdout] 196 ~ && s.len() > 0 { [INFO] [stdout] 197 | return false; [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammars/kv_pairing.rs:196:20 [INFO] [stdout] | [INFO] [stdout] 196 | if s.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grammars/kv_pairing.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | / if let ref mut s = STACK { [INFO] [stdout] 207 | | if s.len() > 0 { [INFO] [stdout] 208 | | return false; [INFO] [stdout] 209 | | } [INFO] [stdout] 210 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 206 ~ if let ref mut s = STACK [INFO] [stdout] 207 ~ && s.len() > 0 { [INFO] [stdout] 208 | return false; [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammars/kv_pairing.rs:207:20 [INFO] [stdout] | [INFO] [stdout] 207 | if s.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOMLTOKENTYPE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum TOMLTOKENTYPE { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Tomltokentype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLITERAL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | SLITERAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Sliteral` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBOOL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | SBOOL, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Sbool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | CDOT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCOMMENT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | CCOMMENT, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ccomment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CEQUALS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | CEQUALS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cequals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CWHITESPACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CWHITESPACE, [INFO] [stdout] | ^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cwhitespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CNEWLINE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | CNEWLINE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cnewline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CSINGLEQUOTE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | CSINGLEQUOTE, [INFO] [stdout] | ^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Csinglequote` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLEQUOTE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | CDOUBLEQUOTE, [INFO] [stdout] | ^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoublequote` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLESTARTBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | CDOUBLESTARTBRACKET, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoublestartbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLEENDBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | CDOUBLEENDBRACKET, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoubleendbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOVALUE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | NOVALUE, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Novalue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / return Token { [INFO] [stdout] 27 | | tag: tag, [INFO] [stdout] 28 | | location: location, [INFO] [stdout] 29 | | content: content, [INFO] [stdout] 30 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ Token { [INFO] [stdout] 27 + tag: tag, [INFO] [stdout] 28 + location: location, [INFO] [stdout] 29 + content: content, [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return self.tag; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return self.tag; [INFO] [stdout] 51 + self.tag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return self.location; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.location; [INFO] [stdout] 55 + self.location [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return &self.content; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return &self.content; [INFO] [stdout] 59 + &self.content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/lexer.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | fn clean_whitespace_tokens(tokens: &mut Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tokens` [INFO] [stdout] --> src/lexer.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | for i in 0..tokens.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for i in 0..tokens.len() { [INFO] [stdout] 66 + for in &mut tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 236 - return ret; [INFO] [stdout] 236 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn tokenize(file_contents: &mut String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 ~ pub fn tokenize(file_contents: &mut str) -> Vec { [INFO] [stdout] 81 | let mut ret: Vec = vec![]; [INFO] [stdout] 82 ~ let mut char_vec = file_contents.to_owned().chars().collect::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:87:11 [INFO] [stdout] | [INFO] [stdout] 87 | while char_vec.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!char_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '#' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '=' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x09 as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | || *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x20 as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x0a as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | || *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x0d as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '"' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 139 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '\'' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 148 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '[' [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:170:20 [INFO] [stdout] | [INFO] [stdout] 170 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == ']' [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '\\' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:220:32 [INFO] [stdout] | [INFO] [stdout] 220 | if check_buffer > 0 && buffer.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if tokens.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `check_buffer` is never read [INFO] [stdout] --> src/lexer.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | check_buffer = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return GrammarNode { [INFO] [stdout] 15 | | valid_token_types: vec![], [INFO] [stdout] 16 | | neighbors: vec![], [INFO] [stdout] 17 | | side_effect: Box::new(|_| return true), [INFO] [stdout] 18 | | end_node: false, [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ GrammarNode { [INFO] [stdout] 15 + valid_token_types: vec![], [INFO] [stdout] 16 + neighbors: vec![], [INFO] [stdout] 17 + side_effect: Box::new(|_| return true), [INFO] [stdout] 18 + end_node: false, [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | side_effect: Box::new(|_| return true), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - side_effect: Box::new(|_| return true), [INFO] [stdout] 17 + side_effect: Box::new(|_| true), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/grammar.rs:22:77 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn add_valid_token_types(&mut self, token_types: Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self.valid_token_types.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self.valid_token_types.clone(); [INFO] [stdout] 27 + self.valid_token_types.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammars/comment.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | && !r.is_none() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `r.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammars/comment.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return false; [INFO] [stdout] 74 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `r.1` after checking its variant with `is_some` [INFO] [stdout] --> src/grammars/kv_pairing.rs:228:60 [INFO] [stdout] | [INFO] [stdout] 222 | if r.1.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = r.1` [INFO] [stdout] ... [INFO] [stdout] 228 | let next_pos = current_node.borrow().neighbors[r.1.unwrap().0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammars/kv_pairing.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return false; [INFO] [stdout] 254 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grammars/kv_pairing.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | / if let ref mut s = STACK { [INFO] [stdout] 196 | | if s.len() > 0 { [INFO] [stdout] 197 | | return false; [INFO] [stdout] 198 | | } [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 195 ~ if let ref mut s = STACK [INFO] [stdout] 196 ~ && s.len() > 0 { [INFO] [stdout] 197 | return false; [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammars/kv_pairing.rs:196:20 [INFO] [stdout] | [INFO] [stdout] 196 | if s.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/grammars/kv_pairing.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | / if let ref mut s = STACK { [INFO] [stdout] 207 | | if s.len() > 0 { [INFO] [stdout] 208 | | return false; [INFO] [stdout] 209 | | } [INFO] [stdout] 210 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 206 ~ if let ref mut s = STACK [INFO] [stdout] 207 ~ && s.len() > 0 { [INFO] [stdout] 208 | return false; [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammars/kv_pairing.rs:207:20 [INFO] [stdout] | [INFO] [stdout] 207 | if s.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOMLTOKENTYPE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum TOMLTOKENTYPE { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Tomltokentype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLITERAL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | SLITERAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Sliteral` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBOOL` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | SBOOL, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Sbool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | CDOT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCOMMENT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | CCOMMENT, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ccomment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CEQUALS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | CEQUALS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cequals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CWHITESPACE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CWHITESPACE, [INFO] [stdout] | ^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cwhitespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CNEWLINE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | CNEWLINE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cnewline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CSINGLEQUOTE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | CSINGLEQUOTE, [INFO] [stdout] | ^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Csinglequote` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLEQUOTE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | CDOUBLEQUOTE, [INFO] [stdout] | ^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoublequote` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLESTARTBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | CDOUBLESTARTBRACKET, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoublestartbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CDOUBLEENDBRACKET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | CDOUBLEENDBRACKET, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cdoubleendbracket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOVALUE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | NOVALUE, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Novalue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / return Token { [INFO] [stdout] 27 | | tag: tag, [INFO] [stdout] 28 | | location: location, [INFO] [stdout] 29 | | content: content, [INFO] [stdout] 30 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ Token { [INFO] [stdout] 27 + tag: tag, [INFO] [stdout] 28 + location: location, [INFO] [stdout] 29 + content: content, [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return self.tag; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return self.tag; [INFO] [stdout] 51 + self.tag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return self.location; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return self.location; [INFO] [stdout] 55 + self.location [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return &self.content; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return &self.content; [INFO] [stdout] 59 + &self.content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/lexer.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | fn clean_whitespace_tokens(tokens: &mut Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tokens` [INFO] [stdout] --> src/lexer.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | for i in 0..tokens.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for i in 0..tokens.len() { [INFO] [stdout] 66 + for in &mut tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 236 - return ret; [INFO] [stdout] 236 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn tokenize(file_contents: &mut String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 ~ pub fn tokenize(file_contents: &mut str) -> Vec { [INFO] [stdout] 81 | let mut ret: Vec = vec![]; [INFO] [stdout] 82 ~ let mut char_vec = file_contents.to_owned().chars().collect::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:87:11 [INFO] [stdout] | [INFO] [stdout] 87 | while char_vec.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!char_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '#' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '=' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x09 as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | || *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x20 as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x0a as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | || *char_vec.get(0).unwrap_or(&(0x00 as char)) == 0x0d as char [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '"' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 139 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '\'' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 148 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '[' [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:170:20 [INFO] [stdout] | [INFO] [stdout] 170 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == ']' [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | char_vec.get(0).unwrap_or(&(0x00 as char)).to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `char_vec.get(0)` [INFO] [stdout] --> src/lexer.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | } else if *char_vec.get(0).unwrap_or(&(0x00 as char)) == '\\' { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `char_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:220:32 [INFO] [stdout] | [INFO] [stdout] 220 | if check_buffer > 0 && buffer.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if tokens.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `Command { std: "docker" "inspect" "2fd7faf73152350c4ca173bee44dccc34ae064ea8309c9fd74a83babecb23393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fd7faf73152350c4ca173bee44dccc34ae064ea8309c9fd74a83babecb23393", kill_on_drop: false }` [INFO] [stdout] 2fd7faf73152350c4ca173bee44dccc34ae064ea8309c9fd74a83babecb23393