[INFO] cloning repository https://github.com/Weasy666/rocket_airlock [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Weasy666/rocket_airlock" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWeasy666%2Frocket_airlock", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWeasy666%2Frocket_airlock'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f92630c607a85f780b15b2b06ddda4ed2a7d00f [INFO] linting Weasy666/rocket_airlock against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWeasy666%2Frocket_airlock" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Weasy666/rocket_airlock [INFO] finished tweaking git repo https://github.com/Weasy666/rocket_airlock [INFO] tweaked toml for git repo https://github.com/Weasy666/rocket_airlock written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Weasy666/rocket_airlock on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 294 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding openidconnect v2.5.1 (available: v4.0.1) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded openidconnect v2.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c37e0077a287bccc3f368f6b8d385f5e71dc5d63b538a7663e84edab2257fe13 [INFO] running `Command { std: "docker" "start" "-a" "c37e0077a287bccc3f368f6b8d385f5e71dc5d63b538a7663e84edab2257fe13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c37e0077a287bccc3f368f6b8d385f5e71dc5d63b538a7663e84edab2257fe13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c37e0077a287bccc3f368f6b8d385f5e71dc5d63b538a7663e84edab2257fe13", kill_on_drop: false }` [INFO] [stdout] c37e0077a287bccc3f368f6b8d385f5e71dc5d63b538a7663e84edab2257fe13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 183f94c73fa99926f0b5720c24ccbe9c181279eb79bc23b577d4a3044dbd16b3 [INFO] running `Command { std: "docker" "start" "-a" "183f94c73fa99926f0b5720c24ccbe9c181279eb79bc23b577d4a3044dbd16b3", kill_on_drop: false }` [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling futures-sink v0.3.32 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling futures-task v0.3.32 [INFO] [stderr] Compiling deranged v0.5.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling futures-channel v0.3.32 [INFO] [stderr] Compiling socket2 v0.6.3 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling bitflags v2.11.0 [INFO] [stderr] Compiling time v0.3.47 [INFO] [stderr] Compiling devise_core v0.4.2 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling futures-io v0.3.32 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking pear v0.2.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Compiling futures v0.3.32 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling devise_codegen v0.4.2 [INFO] [stderr] Checking uncased v0.9.10 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling devise v0.4.2 [INFO] [stderr] Compiling hyper v0.14.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling rocket v0.5.1 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking multer v3.1.0 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking ubyte v0.10.4 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling rocket_http v0.5.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking figment v0.10.19 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Compiling rocket_codegen v0.5.1 [INFO] [stderr] Checking oauth2 v4.4.2 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking openidconnect v2.5.1 [INFO] [stderr] Checking rocket_airlock v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking simple v0.2.2 (/opt/rustwide/workdir/examples/simple) [INFO] [stderr] Checking openid_connect v0.2.2 (/opt/rustwide/workdir/examples/openid_connect) [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | impl<'h> OidcHatch<'static> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:123:6 [INFO] [stdout] | [INFO] [stdout] 123 | impl<'h> Hatch for OidcHatch<'static> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:186:64 [INFO] [stdout] | [INFO] [stdout] 186 | fn to_absolute_url<'h>(url: &str, address: &str, port: u16) -> Result, figment::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 208 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `rocket::figment::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | if !code.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `code.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 270 | if !state.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `state.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 273 | if !session_state.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `session_state.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:283:43 [INFO] [stdout] | [INFO] [stdout] 283 | Some(stored_state) if stored_state.value().to_string() == state => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stored_state.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | impl<'h> OidcHatch<'static> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:123:6 [INFO] [stdout] | [INFO] [stdout] 123 | impl<'h> Hatch for OidcHatch<'static> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:186:64 [INFO] [stdout] | [INFO] [stdout] 186 | fn to_absolute_url<'h>(url: &str, address: &str, port: u16) -> Result, figment::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 208 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `rocket::figment::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | if !code.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `code.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 270 | if !state.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `state.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 273 | if !session_state.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `session_state.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> examples/openid_connect/src/hatch.rs:283:43 [INFO] [stdout] | [INFO] [stdout] 283 | Some(stored_state) if stored_state.value().to_string() == state => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stored_state.value()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] running `Command { std: "docker" "inspect" "183f94c73fa99926f0b5720c24ccbe9c181279eb79bc23b577d4a3044dbd16b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "183f94c73fa99926f0b5720c24ccbe9c181279eb79bc23b577d4a3044dbd16b3", kill_on_drop: false }` [INFO] [stdout] 183f94c73fa99926f0b5720c24ccbe9c181279eb79bc23b577d4a3044dbd16b3