[INFO] cloning repository https://github.com/Vrchester67/roblox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Vrchester67/roblox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVrchester67%2Froblox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVrchester67%2Froblox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c4260f3ac6f967fe380aec2867e2eff84660709 [INFO] linting Vrchester67/roblox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVrchester67%2Froblox" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Vrchester67/roblox [INFO] finished tweaking git repo https://github.com/Vrchester67/roblox [INFO] tweaked toml for git repo https://github.com/Vrchester67/roblox written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Vrchester67/roblox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Vrchester67/roblox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded semver v1.0.19 [INFO] [stderr] Downloaded roblox_install v1.0.0 [INFO] [stderr] Downloaded errno v0.3.4 [INFO] [stderr] Downloaded tracy-client v0.13.2 [INFO] [stderr] Downloaded opener v0.5.2 [INFO] [stderr] Downloaded jod-thread v0.1.2 [INFO] [stderr] Downloaded globset v0.4.13 [INFO] [stderr] Downloaded pest_meta v2.7.4 [INFO] [stderr] Downloaded similar v2.2.1 [INFO] [stderr] Downloaded rbx_reflection_database v0.2.10+roblox-607 [INFO] [stderr] Downloaded rbx_binary v0.7.4 [INFO] [stderr] Downloaded pest v2.7.4 [INFO] [stderr] Downloaded rbx_xml v0.13.3 [INFO] [stderr] Downloaded pest_derive v2.7.4 [INFO] [stderr] Downloaded tracy-client v0.16.3 [INFO] [stderr] Downloaded sharded-slab v0.1.6 [INFO] [stderr] Downloaded pest_generator v2.7.4 [INFO] [stderr] Downloaded regex v1.9.6 [INFO] [stderr] Downloaded tracy-client-sys v0.21.2 [INFO] [stderr] Downloaded tracy-client-sys v0.17.1 [INFO] [stderr] Downloaded fs-err v2.9.0 [INFO] [stderr] Downloaded rbx_types v1.8.0 [INFO] [stderr] Downloaded rbx_reflection v4.5.0 [INFO] [stderr] Downloaded rustix v0.38.20 [INFO] [stderr] Downloaded rbx_dom_weak v2.7.0 [INFO] [stderr] Downloaded snax v0.2.0 [INFO] [stderr] Downloaded ritz v0.1.0 [INFO] [stderr] Downloaded ritz_impl v0.1.0 [INFO] [stderr] Downloaded insta v1.33.0 [INFO] [stderr] Downloaded linux-raw-sys v0.4.8 [INFO] [stderr] Downloaded openssl-src v300.1.5+3.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81e72366dbd1850dd0b5e9b120bfd39b9315a45c9be48f2ea29ad6240d3d3fb3 [INFO] running `Command { std: "docker" "start" "-a" "81e72366dbd1850dd0b5e9b120bfd39b9315a45c9be48f2ea29ad6240d3d3fb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81e72366dbd1850dd0b5e9b120bfd39b9315a45c9be48f2ea29ad6240d3d3fb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81e72366dbd1850dd0b5e9b120bfd39b9315a45c9be48f2ea29ad6240d3d3fb3", kill_on_drop: false }` [INFO] [stdout] 81e72366dbd1850dd0b5e9b120bfd39b9315a45c9be48f2ea29ad6240d3d3fb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 82d69175bd6908b25bf3d64afe1bcafe93ea463760911c7da9488e5c2e996b4c [INFO] running `Command { std: "docker" "start" "-a" "82d69175bd6908b25bf3d64afe1bcafe93ea463760911c7da9488e5c2e996b4c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking slab v0.4.9 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling semver v1.0.19 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking futures-core v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling fs-err v2.9.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling iovec v0.1.4 [INFO] [stderr] Compiling net2 v0.2.39 [INFO] [stderr] Compiling inotify-sys v0.1.5 [INFO] [stderr] Compiling filetime v0.2.22 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling inotify v0.7.1 [INFO] [stderr] Checking futures-channel v0.3.28 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling mio v0.6.23 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling snax v0.2.0 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Compiling ritz_impl v0.1.0 [INFO] [stderr] Checking indexmap v1.9.3 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking futures-task v0.3.28 [INFO] [stderr] Compiling openssl-src v300.1.5+3.1.3 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Compiling mio-extras v2.0.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling notify v4.0.17 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Checking memoffset v0.9.0 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking ritz v0.1.0 [INFO] [stderr] Checking opener v0.5.2 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Checking jod-thread v0.1.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling profiling-procmacros v1.0.11 [INFO] [stderr] Checking profiling v1.0.11 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking futures-util v0.3.28 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking thiserror v1.0.49 [INFO] [stderr] Checking pest v2.7.4 [INFO] [stderr] Checking roblox_install v1.0.0 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Checking rbx_types v1.8.0 [INFO] [stderr] Checking rmp-serde v1.1.2 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking memofs v0.2.0 (/opt/rustwide/workdir/crates/memofs) [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 232 | | io::ErrorKind::Other, [INFO] [stdout] 233 | | format!( [INFO] [stdout] 234 | | "path {} was a directory, but must be a file", [INFO] [stdout] 235 | | path.display() [INFO] [stdout] 236 | | ), [INFO] [stdout] 237 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 ~ Err(io::Error::other( [INFO] [stdout] 232 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 242 | | io::ErrorKind::Other, [INFO] [stdout] 243 | | format!( [INFO] [stdout] 244 | | "path {} was a file, but must be a directory", [INFO] [stdout] 245 | | path.display() [INFO] [stdout] 246 | | ), [INFO] [stdout] 247 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 ~ Err(io::Error::other( [INFO] [stdout] 242 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 19 | | io::ErrorKind::Other, [INFO] [stdout] 20 | | "NoopBackend doesn't do anything", [INFO] [stdout] 21 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err(io::Error::other( [INFO] [stdout] 19 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "NoopBackend doesn't do anything", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ Err(io::Error::other( [INFO] [stdout] 26 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | io::ErrorKind::Other, [INFO] [stdout] 34 | | "NoopBackend doesn't do anything", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(io::Error::other( [INFO] [stdout] 33 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 40 | | io::ErrorKind::Other, [INFO] [stdout] 41 | | "NoopBackend doesn't do anything", [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 ~ Err(io::Error::other( [INFO] [stdout] 40 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 47 | | io::ErrorKind::Other, [INFO] [stdout] 48 | | "NoopBackend doesn't do anything", [INFO] [stdout] 49 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 ~ Err(io::Error::other( [INFO] [stdout] 47 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 54 | | io::ErrorKind::Other, [INFO] [stdout] 55 | | "NoopBackend doesn't do anything", [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 ~ Err(io::Error::other( [INFO] [stdout] 54 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 65 | | io::ErrorKind::Other, [INFO] [stdout] 66 | | "NoopBackend doesn't do anything", [INFO] [stdout] 67 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 ~ Err(io::Error::other( [INFO] [stdout] 65 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | io::ErrorKind::Other, [INFO] [stdout] 73 | | "NoopBackend doesn't do anything", [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 ~ Err(io::Error::other( [INFO] [stdout] 72 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 112 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 112 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 120 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 120 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Checking insta v1.33.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 232 | | io::ErrorKind::Other, [INFO] [stdout] 233 | | format!( [INFO] [stdout] 234 | | "path {} was a directory, but must be a file", [INFO] [stdout] 235 | | path.display() [INFO] [stdout] 236 | | ), [INFO] [stdout] 237 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 ~ Err(io::Error::other( [INFO] [stdout] 232 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 242 | | io::ErrorKind::Other, [INFO] [stdout] 243 | | format!( [INFO] [stdout] 244 | | "path {} was a file, but must be a directory", [INFO] [stdout] 245 | | path.display() [INFO] [stdout] 246 | | ), [INFO] [stdout] 247 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 ~ Err(io::Error::other( [INFO] [stdout] 242 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 19 | | io::ErrorKind::Other, [INFO] [stdout] 20 | | "NoopBackend doesn't do anything", [INFO] [stdout] 21 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err(io::Error::other( [INFO] [stdout] 19 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "NoopBackend doesn't do anything", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ Err(io::Error::other( [INFO] [stdout] 26 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | io::ErrorKind::Other, [INFO] [stdout] 34 | | "NoopBackend doesn't do anything", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(io::Error::other( [INFO] [stdout] 33 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 40 | | io::ErrorKind::Other, [INFO] [stdout] 41 | | "NoopBackend doesn't do anything", [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 ~ Err(io::Error::other( [INFO] [stdout] 40 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 47 | | io::ErrorKind::Other, [INFO] [stdout] 48 | | "NoopBackend doesn't do anything", [INFO] [stdout] 49 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 ~ Err(io::Error::other( [INFO] [stdout] 47 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 54 | | io::ErrorKind::Other, [INFO] [stdout] 55 | | "NoopBackend doesn't do anything", [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 ~ Err(io::Error::other( [INFO] [stdout] 54 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 65 | | io::ErrorKind::Other, [INFO] [stdout] 66 | | "NoopBackend doesn't do anything", [INFO] [stdout] 67 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 ~ Err(io::Error::other( [INFO] [stdout] 65 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | io::ErrorKind::Other, [INFO] [stdout] 73 | | "NoopBackend doesn't do anything", [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 ~ Err(io::Error::other( [INFO] [stdout] 72 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 112 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 112 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 120 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 120 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rojo-insta-ext v0.1.0 (/opt/rustwide/workdir/crates/rojo-insta-ext) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RedactionMap` [INFO] [stdout] --> crates/rojo-insta-ext/src/redaction_map.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | ids: HashMap::new(), [INFO] [stdout] 17 | | last_id: 0, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for RedactionMap { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RedactionMap` [INFO] [stdout] --> crates/rojo-insta-ext/src/redaction_map.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | ids: HashMap::new(), [INFO] [stdout] 17 | | last_id: 0, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for RedactionMap { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 232 | | io::ErrorKind::Other, [INFO] [stdout] 233 | | format!( [INFO] [stdout] 234 | | "path {} was a directory, but must be a file", [INFO] [stdout] 235 | | path.display() [INFO] [stdout] 236 | | ), [INFO] [stdout] 237 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 ~ Err(io::Error::other( [INFO] [stdout] 232 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 242 | | io::ErrorKind::Other, [INFO] [stdout] 243 | | format!( [INFO] [stdout] 244 | | "path {} was a file, but must be a directory", [INFO] [stdout] 245 | | path.display() [INFO] [stdout] 246 | | ), [INFO] [stdout] 247 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 ~ Err(io::Error::other( [INFO] [stdout] 242 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 19 | | io::ErrorKind::Other, [INFO] [stdout] 20 | | "NoopBackend doesn't do anything", [INFO] [stdout] 21 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err(io::Error::other( [INFO] [stdout] 19 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "NoopBackend doesn't do anything", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ Err(io::Error::other( [INFO] [stdout] 26 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | io::ErrorKind::Other, [INFO] [stdout] 34 | | "NoopBackend doesn't do anything", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(io::Error::other( [INFO] [stdout] 33 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 40 | | io::ErrorKind::Other, [INFO] [stdout] 41 | | "NoopBackend doesn't do anything", [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 ~ Err(io::Error::other( [INFO] [stdout] 40 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 47 | | io::ErrorKind::Other, [INFO] [stdout] 48 | | "NoopBackend doesn't do anything", [INFO] [stdout] 49 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 ~ Err(io::Error::other( [INFO] [stdout] 47 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 54 | | io::ErrorKind::Other, [INFO] [stdout] 55 | | "NoopBackend doesn't do anything", [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 ~ Err(io::Error::other( [INFO] [stdout] 54 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 65 | | io::ErrorKind::Other, [INFO] [stdout] 66 | | "NoopBackend doesn't do anything", [INFO] [stdout] 67 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 ~ Err(io::Error::other( [INFO] [stdout] 65 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | io::ErrorKind::Other, [INFO] [stdout] 73 | | "NoopBackend doesn't do anything", [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 ~ Err(io::Error::other( [INFO] [stdout] 72 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 112 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 112 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 120 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 120 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rbx_reflection v4.5.0 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 232 | | io::ErrorKind::Other, [INFO] [stdout] 233 | | format!( [INFO] [stdout] 234 | | "path {} was a directory, but must be a file", [INFO] [stdout] 235 | | path.display() [INFO] [stdout] 236 | | ), [INFO] [stdout] 237 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 ~ Err(io::Error::other( [INFO] [stdout] 232 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/in_memory_fs.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 242 | | io::ErrorKind::Other, [INFO] [stdout] 243 | | format!( [INFO] [stdout] 244 | | "path {} was a file, but must be a directory", [INFO] [stdout] 245 | | path.display() [INFO] [stdout] 246 | | ), [INFO] [stdout] 247 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 ~ Err(io::Error::other( [INFO] [stdout] 242 ~ format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 19 | | io::ErrorKind::Other, [INFO] [stdout] 20 | | "NoopBackend doesn't do anything", [INFO] [stdout] 21 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 ~ Err(io::Error::other( [INFO] [stdout] 19 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "NoopBackend doesn't do anything", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ Err(io::Error::other( [INFO] [stdout] 26 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | io::ErrorKind::Other, [INFO] [stdout] 34 | | "NoopBackend doesn't do anything", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(io::Error::other( [INFO] [stdout] 33 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 40 | | io::ErrorKind::Other, [INFO] [stdout] 41 | | "NoopBackend doesn't do anything", [INFO] [stdout] 42 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 39 ~ Err(io::Error::other( [INFO] [stdout] 40 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 47 | | io::ErrorKind::Other, [INFO] [stdout] 48 | | "NoopBackend doesn't do anything", [INFO] [stdout] 49 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 ~ Err(io::Error::other( [INFO] [stdout] 47 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 54 | | io::ErrorKind::Other, [INFO] [stdout] 55 | | "NoopBackend doesn't do anything", [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 ~ Err(io::Error::other( [INFO] [stdout] 54 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 65 | | io::ErrorKind::Other, [INFO] [stdout] 66 | | "NoopBackend doesn't do anything", [INFO] [stdout] 67 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 ~ Err(io::Error::other( [INFO] [stdout] 65 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/noop_backend.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | io::ErrorKind::Other, [INFO] [stdout] 73 | | "NoopBackend doesn't do anything", [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 71 ~ Err(io::Error::other( [INFO] [stdout] 72 ~ "NoopBackend doesn't do anything", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rbx_dom_weak v2.7.0 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 112 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 112 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/memofs/src/std_backend.rs:120:30 [INFO] [stdout] | [INFO] [stdout] 120 | .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 120 - .map_err(|inner| io::Error::new(io::ErrorKind::Other, inner)) [INFO] [stdout] 120 + .map_err(|inner| io::Error::other(inner)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling embed-resource v1.8.0 [INFO] [stderr] Checking rbx_reflection_database v0.2.10+roblox-607 [INFO] [stderr] Checking rbx_xml v0.13.3 [INFO] [stderr] Compiling rojo v7.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RedactionMap` [INFO] [stdout] --> crates/rojo-insta-ext/src/redaction_map.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | ids: HashMap::new(), [INFO] [stdout] 17 | | last_id: 0, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for RedactionMap { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Checking rbx_binary v0.7.4 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/multimap.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn get(&self, k: &Q) -> &[V] [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 25 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/multimap.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn get(&self, k: &Q) -> &[V] [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 25 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/multimap.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn get(&self, k: &Q) -> &[V] [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 25 | Q: Hash + Eq, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/snapshot/patch_compute.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | snapshot_id: snapshot_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/snapshot/patch_compute.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 291 | snapshot_id: snapshot_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `UploadKind` is never used [INFO] [stdout] --> src/cli/upload.rs:97:6 [INFO] [stdout] | [INFO] [stdout] 97 | enum UploadKind { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DisplayLua` is never constructed [INFO] [stdout] --> src/lua_ast.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | struct DisplayLua(T); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/change_processor.rs:139:52 [INFO] [stdout] | [INFO] [stdout] 139 | let ids = tree.get_ids_at_path(¤t_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `current_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/snapshot/metadata.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | / pub enum InstigatingSource { [INFO] [stdout] 208 | | Path(#[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf), [INFO] [stdout] | | ------------------------------------------------------------------------------ the second-largest variant contains at least 24 bytes [INFO] [stdout] 209 | |/ ProjectNode( [INFO] [stdout] 210 | || #[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf, [INFO] [stdout] 211 | || String, [INFO] [stdout] 212 | || ProjectNode, [INFO] [stdout] 213 | || Option, [INFO] [stdout] 214 | || ), [INFO] [stdout] | ||_____- the largest variant contains at least 256 bytes [INFO] [stdout] 215 | | } [INFO] [stdout] | |__^ the entire enum is at least 256 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 212 - ProjectNode, [INFO] [stdout] 212 + Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/snapshot_middleware/csv.rs:135:51 [INFO] [stdout] | [INFO] [stdout] 135 | for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 135 - for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] 135 + for (header, value) in headers.iter().zip(&*record) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `UploadKind` is never used [INFO] [stdout] --> src/cli/upload.rs:97:6 [INFO] [stdout] | [INFO] [stdout] 97 | enum UploadKind { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DisplayLua` is never constructed [INFO] [stdout] --> src/lua_ast.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | struct DisplayLua(T); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/change_processor.rs:139:52 [INFO] [stdout] | [INFO] [stdout] 139 | let ids = tree.get_ids_at_path(¤t_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `current_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `UploadKind` is never used [INFO] [stdout] --> src/cli/upload.rs:97:6 [INFO] [stdout] | [INFO] [stdout] 97 | enum UploadKind { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/snapshot/metadata.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | / pub enum InstigatingSource { [INFO] [stdout] 208 | | Path(#[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf), [INFO] [stdout] | | ------------------------------------------------------------------------------ the second-largest variant contains at least 24 bytes [INFO] [stdout] 209 | |/ ProjectNode( [INFO] [stdout] 210 | || #[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf, [INFO] [stdout] 211 | || String, [INFO] [stdout] 212 | || ProjectNode, [INFO] [stdout] 213 | || Option, [INFO] [stdout] 214 | || ), [INFO] [stdout] | ||_____- the largest variant contains at least 256 bytes [INFO] [stdout] 215 | | } [INFO] [stdout] | |__^ the entire enum is at least 256 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 212 - ProjectNode, [INFO] [stdout] 212 + Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/change_processor.rs:139:52 [INFO] [stdout] | [INFO] [stdout] 139 | let ids = tree.get_ids_at_path(¤t_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `current_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/snapshot_middleware/csv.rs:135:51 [INFO] [stdout] | [INFO] [stdout] 135 | for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 135 - for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] 135 + for (header, value) in headers.iter().zip(&*record) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/snapshot/metadata.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | / pub enum InstigatingSource { [INFO] [stdout] 208 | | Path(#[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf), [INFO] [stdout] | | ------------------------------------------------------------------------------ the second-largest variant contains at least 24 bytes [INFO] [stdout] 209 | |/ ProjectNode( [INFO] [stdout] 210 | || #[serde(serialize_with = "path_serializer::serialize_absolute")] PathBuf, [INFO] [stdout] 211 | || String, [INFO] [stdout] 212 | || ProjectNode, [INFO] [stdout] 213 | || Option, [INFO] [stdout] 214 | || ), [INFO] [stdout] | ||_____- the largest variant contains at least 256 bytes [INFO] [stdout] 215 | | } [INFO] [stdout] | |__^ the entire enum is at least 256 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 212 - ProjectNode, [INFO] [stdout] 212 + Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/snapshot_middleware/csv.rs:135:51 [INFO] [stdout] | [INFO] [stdout] 135 | for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 135 - for (header, value) in headers.iter().zip(record.into_iter()) { [INFO] [stdout] 135 + for (header, value) in headers.iter().zip(&*record) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_csv` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/csv.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 187 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 187 - &mut vfs, [INFO] [stdout] 187 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_csv` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/csv.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 219 - &mut vfs, [INFO] [stdout] 219 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_dir` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/dir.rs:123:55 [INFO] [stdout] | [INFO] [stdout] 123 | snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 123 - snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] 123 + snapshot_dir(&InstanceContext::default(), &vfs, Path::new("/foo")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_dir` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/dir.rs:144:55 [INFO] [stdout] | [INFO] [stdout] 144 | snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 144 - snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] 144 + snapshot_dir(&InstanceContext::default(), &vfs, Path::new("/foo")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_json` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/json.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 108 - &mut vfs, [INFO] [stdout] 108 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 135 - &mut vfs, [INFO] [stdout] 135 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 158 - &mut vfs, [INFO] [stdout] 158 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 181 - &mut vfs, [INFO] [stdout] 181 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 204 - &mut vfs, [INFO] [stdout] 204 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 227 - &mut vfs, [INFO] [stdout] 227 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 250 - &mut vfs, [INFO] [stdout] 250 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 279 - &mut vfs, [INFO] [stdout] 279 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 313 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 313 - &mut vfs, [INFO] [stdout] 313 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:347:13 [INFO] [stdout] | [INFO] [stdout] 347 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 347 - &mut vfs, [INFO] [stdout] 347 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:381:13 [INFO] [stdout] | [INFO] [stdout] 381 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 381 - &mut vfs, [INFO] [stdout] 381 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 415 - &mut vfs, [INFO] [stdout] 415 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:451:13 [INFO] [stdout] | [INFO] [stdout] 451 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 451 - &mut vfs, [INFO] [stdout] 451 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_lua` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/lua.rs:487:13 [INFO] [stdout] | [INFO] [stdout] 487 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 487 - &mut vfs, [INFO] [stdout] 487 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:360:59 [INFO] [stdout] | [INFO] [stdout] 360 | snapshot_project(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 360 - snapshot_project(&InstanceContext::default(), &mut vfs, Path::new("/foo")) [INFO] [stdout] 360 + snapshot_project(&InstanceContext::default(), &vfs, Path::new("/foo")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 391 - &mut vfs, [INFO] [stdout] 391 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:429:13 [INFO] [stdout] | [INFO] [stdout] 429 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 429 - &mut vfs, [INFO] [stdout] 429 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:465:13 [INFO] [stdout] | [INFO] [stdout] 465 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 465 - &mut vfs, [INFO] [stdout] 465 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 502 - &mut vfs, [INFO] [stdout] 502 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 536 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 536 - &mut vfs, [INFO] [stdout] 536 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:577:13 [INFO] [stdout] | [INFO] [stdout] 577 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 577 - &mut vfs, [INFO] [stdout] 577 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 622 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 622 - &mut vfs, [INFO] [stdout] 622 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_project` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/project.rs:672:13 [INFO] [stdout] | [INFO] [stdout] 672 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 672 - &mut vfs, [INFO] [stdout] 672 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_rbxm` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/rbxm.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 61 - &mut vfs, [INFO] [stdout] 61 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_rbxmx` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/rbxmx.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 73 - &mut vfs, [INFO] [stdout] 73 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_toml` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/toml.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 115 - &mut vfs, [INFO] [stdout] 115 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `snapshot_txt` doesn't need a mutable reference [INFO] [stdout] --> src/snapshot_middleware/txt.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | &mut vfs, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 63 - &mut vfs, [INFO] [stdout] 63 + &vfs, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 69 | pub fn get_instance(&self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/snapshot/tree.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_instance_mut(&mut self, id: Ref) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/rojo_test/serve_util.rs:90:19 [INFO] [stdout] | [INFO] [stdout] 90 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 91 | | "serve", [INFO] [stdout] 92 | | project_path.to_str().unwrap(), [INFO] [stdout] 93 | | "--port", [INFO] [stdout] 94 | | port_string.as_str(), [INFO] [stdout] 95 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 ~ .args([ [INFO] [stdout] 91 + "serve", [INFO] [stdout] 92 + project_path.to_str().unwrap(), [INFO] [stdout] 93 + "--port", [INFO] [stdout] 94 + port_string.as_str(), [INFO] [stdout] 95 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests/build.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 76 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 77 | | "build", [INFO] [stdout] 78 | | input_path.to_str().unwrap(), [INFO] [stdout] 79 | | "-o", [INFO] [stdout] 80 | | output_path.to_str().unwrap(), [INFO] [stdout] 81 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 ~ .args([ [INFO] [stdout] 77 + "build", [INFO] [stdout] 78 + input_path.to_str().unwrap(), [INFO] [stdout] 79 + "-o", [INFO] [stdout] 80 + output_path.to_str().unwrap(), [INFO] [stdout] 81 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> tests/rojo_test/serve_util.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn get_api_read(&self, id: Ref) -> Result { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 153 | pub fn get_api_read(&self, id: Ref) -> Result, reqwest::Error> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 39s [INFO] running `Command { std: "docker" "inspect" "82d69175bd6908b25bf3d64afe1bcafe93ea463760911c7da9488e5c2e996b4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82d69175bd6908b25bf3d64afe1bcafe93ea463760911c7da9488e5c2e996b4c", kill_on_drop: false }` [INFO] [stdout] 82d69175bd6908b25bf3d64afe1bcafe93ea463760911c7da9488e5c2e996b4c