[INFO] cloning repository https://github.com/VitalikMk/search_files
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VitalikMk/search_files" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVitalikMk%2Fsearch_files", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVitalikMk%2Fsearch_files'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 5f13d9cd8a0a332cd2e914da4305a9ac806b8b9e
[INFO] linting VitalikMk/search_files against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVitalikMk%2Fsearch_files" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/VitalikMk/search_files
[INFO] finished tweaking git repo https://github.com/VitalikMk/search_files
[INFO] tweaked toml for git repo https://github.com/VitalikMk/search_files written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/VitalikMk/search_files on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/VitalikMk/search_files already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 614adcf1528d4a3ee6f43f89f44e926691fc5943f5f52678eb91d2f8a9176600
[INFO] running `Command { std: "docker" "start" "-a" "614adcf1528d4a3ee6f43f89f44e926691fc5943f5f52678eb91d2f8a9176600", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "614adcf1528d4a3ee6f43f89f44e926691fc5943f5f52678eb91d2f8a9176600", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "614adcf1528d4a3ee6f43f89f44e926691fc5943f5f52678eb91d2f8a9176600", kill_on_drop: false }`
[INFO] [stdout] 614adcf1528d4a3ee6f43f89f44e926691fc5943f5f52678eb91d2f8a9176600
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8046bf98f1b75af96dceeba12ea5d18ecca5a2aa40909b4c975b3052d8c7b9df
[INFO] running `Command { std: "docker" "start" "-a" "8046bf98f1b75af96dceeba12ea5d18ecca5a2aa40909b4c975b3052d8c7b9df", kill_on_drop: false }`
[INFO] [stderr]     Checking search_files v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/main.rs:60:13
[INFO] [stdout]    |
[INFO] [stdout] 60 |             print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout]    = note: `#[warn(clippy::print_with_newline)]` on by default
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 60 -             print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout] 60 +             println!(" - {} MB", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:97:20
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout] 97 +                 if !(!is_no_extensions && !extensions.contains(&file_extension)) {
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout] 97 +                 if is_no_extensions || extensions.contains(&file_extension) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:76:5
[INFO] [stdout]     |
[INFO] [stdout]  76 | /     for entry in files {
[INFO] [stdout]  77 | |         if let Ok(entry) = entry {
[INFO] [stdout]  78 | |             let path = entry.path();
[INFO] [stdout]  79 | |             let file_name = convert_os_str(path.file_stem());
[INFO] [stdout] ...   |
[INFO] [stdout] 103 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:77:9
[INFO] [stdout]     |
[INFO] [stdout]  77 | /         if let Ok(entry) = entry {
[INFO] [stdout]  78 | |             let path = entry.path();
[INFO] [stdout]  79 | |             let file_name = convert_os_str(path.file_stem());
[INFO] [stdout]  80 | |             let file_extension = convert_os_str(path.extension());
[INFO] [stdout] ...   |
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  76 ~     for entry in files.flatten() {
[INFO] [stdout]  77 +         let path = entry.path();
[INFO] [stdout]  78 +         let file_name = convert_os_str(path.file_stem());
[INFO] [stdout]  79 +         let file_extension = convert_os_str(path.extension());
[INFO] [stdout]  80 + 
[INFO] [stdout]  81 +         if path.is_dir() {
[INFO] [stdout]  82 +             if is_no_extensions && file_name.contains(filename) {
[INFO] [stdout]  83 +                 file_found(&path, now, results_count);
[INFO] [stdout]  84 +             }
[INFO] [stdout]  85 + 
[INFO] [stdout]  86 +             search_files (
[INFO] [stdout]  87 +                 path.to_str().unwrap_or_default(),
[INFO] [stdout]  88 +                 filename,
[INFO] [stdout]  89 +                 extensions,
[INFO] [stdout]  90 +                 now,
[INFO] [stdout]  91 +                 results_count
[INFO] [stdout]  92 +             );
[INFO] [stdout]  93 +         } else if is_empty_filename && extensions.contains(&file_extension) {
[INFO] [stdout]  94 +             file_found(&path, now, results_count);
[INFO] [stdout]  95 +         } else if path.is_file() && file_name.contains(filename) {
[INFO] [stdout]  96 +             if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]  97 +                 file_found(&path, now, results_count);
[INFO] [stdout]  98 +             }
[INFO] [stdout]  99 +         }
[INFO] [stdout] 100 + 
[INFO] [stdout] 101 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:96:20
[INFO] [stdout]     |
[INFO] [stdout]  96 |               } else if path.is_file() && file_name.contains(filename) {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout]  97 | |                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]  98 | |                     file_found(&path, now, results_count);
[INFO] [stdout]  99 | |                 }
[INFO] [stdout] 100 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  96 ~             } else if path.is_file() && file_name.contains(filename)
[INFO] [stdout]  97 ~                 && ((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions) {
[INFO] [stdout]  98 |                     file_found(&path, now, results_count);
[INFO] [stdout]  99 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s
[INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline
[INFO] [stdout]   --> src/main.rs:60:13
[INFO] [stdout]    |
[INFO] [stdout] 60 |             print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stdout]    = note: `#[warn(clippy::print_with_newline)]` on by default
[INFO] [stdout] help: use `println!` instead
[INFO] [stdout]    |
[INFO] [stdout] 60 -             print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout] 60 +             println!(" - {} MB", metadata.len() as f64 / FILE_SIZE_BASE);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:97:20
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout] 97 +                 if !(!is_no_extensions && !extensions.contains(&file_extension)) {
[INFO] [stdout]    |
[INFO] [stdout] 97 -                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout] 97 +                 if is_no_extensions || extensions.contains(&file_extension) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:76:5
[INFO] [stdout]     |
[INFO] [stdout]  76 | /     for entry in files {
[INFO] [stdout]  77 | |         if let Ok(entry) = entry {
[INFO] [stdout]  78 | |             let path = entry.path();
[INFO] [stdout]  79 | |             let file_name = convert_os_str(path.file_stem());
[INFO] [stdout] ...   |
[INFO] [stdout] 103 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:77:9
[INFO] [stdout]     |
[INFO] [stdout]  77 | /         if let Ok(entry) = entry {
[INFO] [stdout]  78 | |             let path = entry.path();
[INFO] [stdout]  79 | |             let file_name = convert_os_str(path.file_stem());
[INFO] [stdout]  80 | |             let file_extension = convert_os_str(path.extension());
[INFO] [stdout] ...   |
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  76 ~     for entry in files.flatten() {
[INFO] [stdout]  77 +         let path = entry.path();
[INFO] [stdout]  78 +         let file_name = convert_os_str(path.file_stem());
[INFO] [stdout]  79 +         let file_extension = convert_os_str(path.extension());
[INFO] [stdout]  80 + 
[INFO] [stdout]  81 +         if path.is_dir() {
[INFO] [stdout]  82 +             if is_no_extensions && file_name.contains(filename) {
[INFO] [stdout]  83 +                 file_found(&path, now, results_count);
[INFO] [stdout]  84 +             }
[INFO] [stdout]  85 + 
[INFO] [stdout]  86 +             search_files (
[INFO] [stdout]  87 +                 path.to_str().unwrap_or_default(),
[INFO] [stdout]  88 +                 filename,
[INFO] [stdout]  89 +                 extensions,
[INFO] [stdout]  90 +                 now,
[INFO] [stdout]  91 +                 results_count
[INFO] [stdout]  92 +             );
[INFO] [stdout]  93 +         } else if is_empty_filename && extensions.contains(&file_extension) {
[INFO] [stdout]  94 +             file_found(&path, now, results_count);
[INFO] [stdout]  95 +         } else if path.is_file() && file_name.contains(filename) {
[INFO] [stdout]  96 +             if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]  97 +                 file_found(&path, now, results_count);
[INFO] [stdout]  98 +             }
[INFO] [stdout]  99 +         }
[INFO] [stdout] 100 + 
[INFO] [stdout] 101 +     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:96:20
[INFO] [stdout]     |
[INFO] [stdout]  96 |               } else if path.is_file() && file_name.contains(filename) {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout]  97 | |                 if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions {
[INFO] [stdout]  98 | |                     file_found(&path, now, results_count);
[INFO] [stdout]  99 | |                 }
[INFO] [stdout] 100 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  96 ~             } else if path.is_file() && file_name.contains(filename)
[INFO] [stdout]  97 ~                 && ((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions) {
[INFO] [stdout]  98 |                     file_found(&path, now, results_count);
[INFO] [stdout]  99 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "8046bf98f1b75af96dceeba12ea5d18ecca5a2aa40909b4c975b3052d8c7b9df", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8046bf98f1b75af96dceeba12ea5d18ecca5a2aa40909b4c975b3052d8c7b9df", kill_on_drop: false }`
[INFO] [stdout] 8046bf98f1b75af96dceeba12ea5d18ecca5a2aa40909b4c975b3052d8c7b9df